Re: [PATCH v3 2/3] dt-bindings: display: convert samsung, s6e8aa0 to DT Schema

2020-07-09 Thread Rob Herring
On Sat, 04 Jul 2020 12:28:05 +0200, Sam Ravnborg wrote:
> v2:
>   - Add missing types (Rob)
>   - Fix example to specify panel@0 (Rob)
> 
> Signed-off-by: Sam Ravnborg 
> Cc: Rob Herring 
> Cc: Andrzej Hajda 
> Cc: Thierry Reding 
> Cc: Sam Ravnborg 
> ---
>  .../display/panel/samsung,s6e8aa0.txt |  56 --
>  .../display/panel/samsung,s6e8aa0.yaml| 100 ++
>  2 files changed, 100 insertions(+), 56 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> 

Reviewed-by: Rob Herring 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH v3 2/3] dt-bindings: display: convert samsung, s6e8aa0 to DT Schema

2020-07-04 Thread Sam Ravnborg
v2:
  - Add missing types (Rob)
  - Fix example to specify panel@0 (Rob)

Signed-off-by: Sam Ravnborg 
Cc: Rob Herring 
Cc: Andrzej Hajda 
Cc: Thierry Reding 
Cc: Sam Ravnborg 
---
 .../display/panel/samsung,s6e8aa0.txt |  56 --
 .../display/panel/samsung,s6e8aa0.yaml| 100 ++
 2 files changed, 100 insertions(+), 56 deletions(-)
 delete mode 100644 
Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt
 create mode 100644 
Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml

diff --git 
a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt 
b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt
deleted file mode 100644
index 9e766c5f86da..
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt
+++ /dev/null
@@ -1,56 +0,0 @@
-Samsung S6E8AA0 AMOLED LCD 5.3 inch panel
-
-Required properties:
-  - compatible: "samsung,s6e8aa0"
-  - reg: the virtual channel number of a DSI peripheral
-  - vdd3-supply: core voltage supply
-  - vci-supply: voltage supply for analog circuits
-  - reset-gpios: a GPIO spec for the reset pin
-  - display-timings: timings for the connected panel as described by [1]
-
-Optional properties:
-  - power-on-delay: delay after turning regulators on [ms]
-  - reset-delay: delay after reset sequence [ms]
-  - init-delay: delay after initialization sequence [ms]
-  - panel-width-mm: physical panel width [mm]
-  - panel-height-mm: physical panel height [mm]
-  - flip-horizontal: boolean to flip image horizontally
-  - flip-vertical: boolean to flip image vertically
-
-The device node can contain one 'port' child node with one child
-'endpoint' node, according to the bindings defined in [2]. This
-node should describe panel's video bus.
-
-[1]: Documentation/devicetree/bindings/display/panel/display-timing.txt
-[2]: Documentation/devicetree/bindings/media/video-interfaces.txt
-
-Example:
-
-   panel {
-   compatible = "samsung,s6e8aa0";
-   reg = <0>;
-   vdd3-supply = <_reg>;
-   vci-supply = <_reg>;
-   reset-gpios = < 5 0>;
-   power-on-delay= <50>;
-   reset-delay = <100>;
-   init-delay = <100>;
-   panel-width-mm = <58>;
-   panel-height-mm = <103>;
-   flip-horizontal;
-   flip-vertical;
-
-   display-timings {
-   timing0: timing-0 {
-   clock-frequency = <57153600>;
-   hactive = <720>;
-   vactive = <1280>;
-   hfront-porch = <5>;
-   hback-porch = <5>;
-   hsync-len = <5>;
-   vfront-porch = <13>;
-   vback-porch = <1>;
-   vsync-len = <2>;
-   };
-   };
-   };
diff --git 
a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml 
b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
new file mode 100644
index ..f155074726d2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,s6e8aa0.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung S6E8AA0 AMOLED LCD 5.3 inch panel
+
+maintainers:
+  - Andrzej Hajda 
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+const: samsung,s6e8aa0
+
+  reg: true
+  reset-gpios: true
+  display-timings: true
+
+  vdd3-supply:
+description: core voltage supply
+
+  vci-supply:
+description: voltage supply for analog circuits
+ 
+  power-on-delay:
+description: delay after turning regulators on [ms]
+$ref: /schemas/types.yaml#/definitions/uint32
+
+  reset-delay:
+description: delay after reset sequence [ms]
+$ref: /schemas/types.yaml#/definitions/uint32
+
+  init-delay:
+description: delay after initialization sequence [ms]
+
+  panel-width-mm:
+description: physical panel width [mm]
+
+  panel-height-mm:
+description: physical panel height [mm]
+
+  flip-horizontal:
+description: boolean to flip image horizontally
+type: boolean
+
+  flip-vertical:
+description: boolean to flip image vertically
+type: boolean
+
+required:
+  - compatible
+  - reg
+  - vdd3-supply 
+  - vci-supply
+  - reset-gpios
+  - display-timings
+
+additionalProperties: false
+
+examples:
+  - |
+dsi {
+#address-cells = <1>;
+#size-cells = <0>;
+
+panel@0 {
+compatible = "samsung,s6e8aa0";
+reg = <0>;
+vdd3-supply = <_reg>;
+vci-supply = <_reg>;
+reset-gpios = < 5 0>;
+power-on-delay= <50>;
+