RE: [PATCH v3 4/4] drm: rcar-du: Add RZ/G2L DU Support
Hi All, Gentle ping. Are we happy with this patch? I need to post next version based on some additions in the latest HW manual. Before that, if there is any feedback I can incorporate the same. Please let me know. Cheers, Biju > Subject: [PATCH v3 4/4] drm: rcar-du: Add RZ/G2L DU Support > > The LCD controller is composed of Frame Compression Processor (FCPVD), > Video Signal Processor (VSPD), and Display Unit (DU). > > It has DPI/DSI interfaces and supports a maximum resolution of 1080p > along with 2 RPFs to support blending of two picture layers and > raster operations (ROPs). > > The DU part is similar to RCar like DU is connected to VSPD, so most of > the framework related functionality is based on RCar DU. > > Signed-off-by: Biju Das > --- > v3: > * New patch after removing all the indirections and by adding >new DRM driver. > --- > drivers/gpu/drm/rcar-du/Kconfig | 16 +- > drivers/gpu/drm/rcar-du/Makefile | 9 + > drivers/gpu/drm/rcar-du/rzg2l_du_crtc.c | 745 ++ > drivers/gpu/drm/rcar-du/rzg2l_du_crtc.h | 104 +++ > drivers/gpu/drm/rcar-du/rzg2l_du_drv.c | 192 + > drivers/gpu/drm/rcar-du/rzg2l_du_drv.h | 102 +++ > drivers/gpu/drm/rcar-du/rzg2l_du_encoder.c | 113 +++ > drivers/gpu/drm/rcar-du/rzg2l_du_encoder.h | 29 + > drivers/gpu/drm/rcar-du/rzg2l_du_group.h | 32 + > drivers/gpu/drm/rcar-du/rzg2l_du_kms.c | 782 +++ > drivers/gpu/drm/rcar-du/rzg2l_du_kms.h | 43 + > drivers/gpu/drm/rcar-du/rzg2l_du_regs.h | 64 ++ > drivers/gpu/drm/rcar-du/rzg2l_du_vsp.c | 420 ++ > drivers/gpu/drm/rcar-du/rzg2l_du_vsp.h | 93 +++ > drivers/gpu/drm/rcar-du/rzg2l_du_writeback.c | 247 ++ > drivers/gpu/drm/rcar-du/rzg2l_du_writeback.h | 42 + > 16 files changed, 3032 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_crtc.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_crtc.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_drv.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_drv.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_encoder.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_encoder.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_group.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_kms.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_kms.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_regs.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_vsp.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_vsp.h > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_writeback.c > create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_writeback.h > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar- > du/Kconfig > index 3e59c7c213f5..5fb00e8dc2e7 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -11,6 +11,19 @@ config DRM_RCAR_DU > Choose this option if you have an R-Car chipset. > If M is selected the module will be called rcar-du-drm. > > +config DRM_RZG2L_DU > + tristate "DRM Support for RZ/G2L DU" > + depends on DRM && OF > + depends on ARM || ARM64 > + depends on ARCH_RENESAS || COMPILE_TEST > + select DRM_KMS_HELPER > + select DRM_GEM_CMA_HELPER > + select VIDEOMODE_HELPERS > + help > + Choose this option if you have an RZ/G2L chipset. > + If M is selected the module will be called rzg2l-du-drm. > + > + > config DRM_RCAR_USE_CMM > bool "R-Car DU Color Management Module (CMM) Support" > depends on DRM_RCAR_DU > @@ -62,8 +75,9 @@ config DRM_RZG2L_MIPI_DSI > config DRM_RCAR_VSP > bool "R-Car DU VSP Compositor Support" if ARM > default y if ARM64 > - depends on DRM_RCAR_DU > + depends on DRM_RCAR_DU || DRM_RZG2L_DU > depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && > DRM_RCAR_DU=m) > + depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && > DRM_RZG2L_DU=m) > help > Enable support to expose the R-Car VSP Compositor as KMS planes. > > diff --git a/drivers/gpu/drm/rcar-du/Makefile b/drivers/gpu/drm/rcar- > du/Makefile > index 14a3fa88cc0b..460ff9aeba6c 100644 > --- a/drivers/gpu/drm/rcar-du/Makefile > +++ b/drivers/gpu/drm/rcar-du/Makefile > @@ -6,15 +6,24 @@ rcar-du-drm-y := rcar_du_crtc.o \ >rcar_du_kms.o \ >rcar_du_plane.o \ > > +rzg2l-du-drm-y := rzg2l_du_crtc.o \ > + rzg2l_du_drv.o \ > + rzg2l_du_encoder.o \ > + rzg
[PATCH v3 4/4] drm: rcar-du: Add RZ/G2L DU Support
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support blending of two picture layers and raster operations (ROPs). The DU part is similar to RCar like DU is connected to VSPD, so most of the framework related functionality is based on RCar DU. Signed-off-by: Biju Das --- v3: * New patch after removing all the indirections and by adding new DRM driver. --- drivers/gpu/drm/rcar-du/Kconfig | 16 +- drivers/gpu/drm/rcar-du/Makefile | 9 + drivers/gpu/drm/rcar-du/rzg2l_du_crtc.c | 745 ++ drivers/gpu/drm/rcar-du/rzg2l_du_crtc.h | 104 +++ drivers/gpu/drm/rcar-du/rzg2l_du_drv.c | 192 + drivers/gpu/drm/rcar-du/rzg2l_du_drv.h | 102 +++ drivers/gpu/drm/rcar-du/rzg2l_du_encoder.c | 113 +++ drivers/gpu/drm/rcar-du/rzg2l_du_encoder.h | 29 + drivers/gpu/drm/rcar-du/rzg2l_du_group.h | 32 + drivers/gpu/drm/rcar-du/rzg2l_du_kms.c | 782 +++ drivers/gpu/drm/rcar-du/rzg2l_du_kms.h | 43 + drivers/gpu/drm/rcar-du/rzg2l_du_regs.h | 64 ++ drivers/gpu/drm/rcar-du/rzg2l_du_vsp.c | 420 ++ drivers/gpu/drm/rcar-du/rzg2l_du_vsp.h | 93 +++ drivers/gpu/drm/rcar-du/rzg2l_du_writeback.c | 247 ++ drivers/gpu/drm/rcar-du/rzg2l_du_writeback.h | 42 + 16 files changed, 3032 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_crtc.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_crtc.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_drv.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_drv.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_encoder.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_encoder.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_group.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_kms.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_kms.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_regs.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_vsp.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_vsp.h create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_writeback.c create mode 100644 drivers/gpu/drm/rcar-du/rzg2l_du_writeback.h diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 3e59c7c213f5..5fb00e8dc2e7 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -11,6 +11,19 @@ config DRM_RCAR_DU Choose this option if you have an R-Car chipset. If M is selected the module will be called rcar-du-drm. +config DRM_RZG2L_DU + tristate "DRM Support for RZ/G2L DU" + depends on DRM && OF + depends on ARM || ARM64 + depends on ARCH_RENESAS || COMPILE_TEST + select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER + select VIDEOMODE_HELPERS + help + Choose this option if you have an RZ/G2L chipset. + If M is selected the module will be called rzg2l-du-drm. + + config DRM_RCAR_USE_CMM bool "R-Car DU Color Management Module (CMM) Support" depends on DRM_RCAR_DU @@ -62,8 +75,9 @@ config DRM_RZG2L_MIPI_DSI config DRM_RCAR_VSP bool "R-Car DU VSP Compositor Support" if ARM default y if ARM64 - depends on DRM_RCAR_DU + depends on DRM_RCAR_DU || DRM_RZG2L_DU depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && DRM_RCAR_DU=m) + depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && DRM_RZG2L_DU=m) help Enable support to expose the R-Car VSP Compositor as KMS planes. diff --git a/drivers/gpu/drm/rcar-du/Makefile b/drivers/gpu/drm/rcar-du/Makefile index 14a3fa88cc0b..460ff9aeba6c 100644 --- a/drivers/gpu/drm/rcar-du/Makefile +++ b/drivers/gpu/drm/rcar-du/Makefile @@ -6,15 +6,24 @@ rcar-du-drm-y := rcar_du_crtc.o \ rcar_du_kms.o \ rcar_du_plane.o \ +rzg2l-du-drm-y := rzg2l_du_crtc.o \ + rzg2l_du_drv.o \ + rzg2l_du_encoder.o \ + rzg2l_du_kms.o \ + rcar-du-drm-$(CONFIG_DRM_RCAR_VSP) += rcar_du_vsp.o rcar-du-drm-$(CONFIG_DRM_RCAR_WRITEBACK) += rcar_du_writeback.o +rzg2l-du-drm-$(CONFIG_DRM_RCAR_VSP)+= rzg2l_du_vsp.o +rzg2l-du-drm-$(CONFIG_DRM_RCAR_WRITEBACK) += rzg2l_du_writeback.o + obj-$(CONFIG_DRM_RCAR_CMM) += rcar_cmm.o obj-$(CONFIG_DRM_RCAR_DU) += rcar-du-drm.o obj-$(CONFIG_DRM_RCAR_DW_HDMI) += rcar_dw_hdmi.o obj-$(CONFIG_DRM_RCAR_LVDS)+= rcar_lvds.o obj-$(CONFIG_DRM_RCAR_MIPI_DSI)+= rcar_mipi_dsi.o +obj-$(CONFIG_DRM_RZG2L_DU) += rzg2l-du-drm.o obj-$(CONFIG_DRM_RZG2L_MIPI_DSI) += rzg2l_mipi_dsi.o # 'remote-endpoint' is fixed up at run-time diff --git a/drivers/gpu/drm/rcar-du/rzg2l_du_crtc.c
