Re: [PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback

[Hsin-Yi Wang]

On Mon, Jun 6, 2022 at 10:27 PM Doug Anderson  wrote:
>
> Hi,
>
> On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang  wrote:
> >
> > To return the orientation property to drm/kms driver.
> >
> > Signed-off-by: Hsin-Yi Wang 
> > Reviewed-by: Hans de Goede 
> > ---
> > v2->v3: add comments for notice.
> > ---
> >  drivers/gpu/drm/panel/panel-lvds.c | 14 ++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-lvds.c 
> > b/drivers/gpu/drm/panel/panel-lvds.c
> > index 27a1c9923b09..239527409b00 100644
> > --- a/drivers/gpu/drm/panel/panel-lvds.c
> > +++ b/drivers/gpu/drm/panel/panel-lvds.c
> > @@ -102,15 +102,29 @@ static int panel_lvds_get_modes(struct drm_panel 
> > *panel,
> > connector->display_info.bus_flags = lvds->data_mirror
> >   ? DRM_BUS_FLAG_DATA_LSB_TO_MSB
> >   : DRM_BUS_FLAG_DATA_MSB_TO_LSB;
>
> Can you rebase your patch and send again? There's a context conflict
> with the above line because your tree is lacking commit 83c784e70036
> ("drm/panel: lvds: Use bus_flags from DT panel-timing property")
>
Rebased in v4.

> In any case:
>
> Reviewed-by: Douglas Anderson 

Re: [PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback

[Doug Anderson]

Hi,

On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang  wrote:
>
> To return the orientation property to drm/kms driver.
>
> Signed-off-by: Hsin-Yi Wang 
> Reviewed-by: Hans de Goede 
> ---
> v2->v3: add comments for notice.
> ---
>  drivers/gpu/drm/panel/panel-lvds.c | 14 ++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c 
> b/drivers/gpu/drm/panel/panel-lvds.c
> index 27a1c9923b09..239527409b00 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -102,15 +102,29 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
> connector->display_info.bus_flags = lvds->data_mirror
>   ? DRM_BUS_FLAG_DATA_LSB_TO_MSB
>   : DRM_BUS_FLAG_DATA_MSB_TO_LSB;

Can you rebase your patch and send again? There's a context conflict
with the above line because your tree is lacking commit 83c784e70036
("drm/panel: lvds: Use bus_flags from DT panel-timing property")

In any case:

Reviewed-by: Douglas Anderson 

[PATCH v3 4/8] drm/panel: lvds: Implement .get_orientation callback

[Hsin-Yi Wang]

To return the orientation property to drm/kms driver.

Signed-off-by: Hsin-Yi Wang 
Reviewed-by: Hans de Goede 
---
v2->v3: add comments for notice.
---
 drivers/gpu/drm/panel/panel-lvds.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-lvds.c 
b/drivers/gpu/drm/panel/panel-lvds.c
index 27a1c9923b09..239527409b00 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -102,15 +102,29 @@ static int panel_lvds_get_modes(struct drm_panel *panel,
connector->display_info.bus_flags = lvds->data_mirror
  ? DRM_BUS_FLAG_DATA_LSB_TO_MSB
  : DRM_BUS_FLAG_DATA_MSB_TO_LSB;
+   /*
+* drm drivers are expected to call drm_panel_get_orientation() to get
+* panel's orientation then drm_connector_set_panel_orientation() to
+* set the property before drm_dev_register(). Otherwise there will be
+* a WARN_ON if orientation is set after drm is registered.
+*/
drm_connector_set_panel_orientation(connector, lvds->orientation);
 
return 1;
 }
 
+static enum drm_panel_orientation panel_lvds_get_orientation,(struct drm_panel 
*panel)
+{
+   struct panel_lvds *lvds = to_panel_lvds(panel);
+
+   return lvds->orientation;
+}
+
 static const struct drm_panel_funcs panel_lvds_funcs = {
.unprepare = panel_lvds_unprepare,
.prepare = panel_lvds_prepare,
.get_modes = panel_lvds_get_modes,
+   .get_orientation = panel_lvds_get_orientation,
 };
 
 static int panel_lvds_parse_dt(struct panel_lvds *lvds)
-- 
2.36.1.255.ge46751e96f-goog