Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
On Tue, Apr 24, 2018 at 3:32 AM, Türk, Jan wrote:
>> -Ursprüngliche Nachricht-
>> Von: Shawn Guo Gesendet: Montag, 23. April 2018 10:45
>> Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
>>
>> On Fri, Apr 20, 2018 at 02:50:52PM +0200, jan.tu...@emtrion.com wrote:
>> > From: Jan Tuerk
>> >
>> > This patch adds support for the emtrion GmbH emCON-MX6 modules.
>> > They are available with imx.6 Solo, Dual-Lite, Dual and Quad equipped
>> > with Memory from 512MB to 2GB (configured by U-Boot).
>> >
>> > Our default developer-Kit ships with the Avari baseboard and the EDT
>> > ETM0700G0BDH6 Display (imx6[q|dl]-emcon-avari).
>> >
>> > The devicetree is split into the common part providing all module
>> > components and the basic support for all SoC versions
>> > (imx6qdl-emcon.dtsi) and parts which are i.mx6 S|DL and D|Q relevant.
>> > Finally the support for the avari baseboard in the developer-kit
>> > configuration is provided by the emcon-avari dts files.
>> >
>> > Signed-off-by: Jan Tuerk
>> > ---
>> > Documentation/devicetree/bindings/arm/emtrion.txt | 13 +
>>
>> It's better to have a separate patch for bindings doc, which needs to be
>> acknowledged by DT maintainers.
>
> I can change that, but nobody complained in the first 2 revisions of the
> patch.
Well, sometimes I forget to mention what is step 1 in
Documentation/devicetree/bindings/submitting-patches.txt.
> Also I though having the documentation is required for merging new bindings?
Yes, so binding patches come first (step 3).
>> > arch/arm/boot/dts/Makefile| 2 +
>> > arch/arm/boot/dts/imx6dl-emcon-avari.dts | 224 ++
>> > arch/arm/boot/dts/imx6dl-emcon.dtsi | 27 +
>> > arch/arm/boot/dts/imx6q-emcon-avari.dts | 224 ++
>> > arch/arm/boot/dts/imx6q-emcon.dtsi| 27 +
>> > arch/arm/boot/dts/imx6qdl-emcon.dtsi | 838
>> ++
>> > 7 files changed, 1355 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/arm/emtrion.txt
>> > create mode 100644 arch/arm/boot/dts/imx6dl-emcon-avari.dts
>> > create mode 100644 arch/arm/boot/dts/imx6dl-emcon.dtsi
>> > create mode 100644 arch/arm/boot/dts/imx6q-emcon-avari.dts
>> > create mode 100644 arch/arm/boot/dts/imx6q-emcon.dtsi
>> > create mode 100644 arch/arm/boot/dts/imx6qdl-emcon.dtsi
[...]
>> > + };
>> > +
>> > + boardID: pca8754a@3a {
>>
>> Please find a more generic node name for it.
>
> you mean boardID@3a?
No. "gpio@3a" as it is a gpio controller.
> This chip identifies the baseboard type for the bootloader.
>
>>
>> > + compatible = "nxp,pca8574";
>> > + reg = <0x3a>;
>> > + gpio-controller;
>> > + #gpio-cells = <1>;
>> > + };
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
AW: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
> -Ursprüngliche Nachricht-
> Von: Shawn Guo Gesendet: Montag, 23. April 2018 10:45
> Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
>
> On Fri, Apr 20, 2018 at 02:50:52PM +0200, jan.tu...@emtrion.com wrote:
> > From: Jan Tuerk
> >
> > This patch adds support for the emtrion GmbH emCON-MX6 modules.
> > They are available with imx.6 Solo, Dual-Lite, Dual and Quad equipped
> > with Memory from 512MB to 2GB (configured by U-Boot).
> >
> > Our default developer-Kit ships with the Avari baseboard and the EDT
> > ETM0700G0BDH6 Display (imx6[q|dl]-emcon-avari).
> >
> > The devicetree is split into the common part providing all module
> > components and the basic support for all SoC versions
> > (imx6qdl-emcon.dtsi) and parts which are i.mx6 S|DL and D|Q relevant.
> > Finally the support for the avari baseboard in the developer-kit
> > configuration is provided by the emcon-avari dts files.
> >
> > Signed-off-by: Jan Tuerk
> > ---
> > Documentation/devicetree/bindings/arm/emtrion.txt | 13 +
>
> It's better to have a separate patch for bindings doc, which needs to be
> acknowledged by DT maintainers.
I can change that, but nobody complained in the first 2 revisions of the patch.
Also I though having the documentation is required for merging new bindings?
>
> > arch/arm/boot/dts/Makefile| 2 +
> > arch/arm/boot/dts/imx6dl-emcon-avari.dts | 224 ++
> > arch/arm/boot/dts/imx6dl-emcon.dtsi | 27 +
> > arch/arm/boot/dts/imx6q-emcon-avari.dts | 224 ++
> > arch/arm/boot/dts/imx6q-emcon.dtsi| 27 +
> > arch/arm/boot/dts/imx6qdl-emcon.dtsi | 838
> ++
> > 7 files changed, 1355 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/emtrion.txt
> > create mode 100644 arch/arm/boot/dts/imx6dl-emcon-avari.dts
> > create mode 100644 arch/arm/boot/dts/imx6dl-emcon.dtsi
> > create mode 100644 arch/arm/boot/dts/imx6q-emcon-avari.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-emcon.dtsi
> > create mode 100644 arch/arm/boot/dts/imx6qdl-emcon.dtsi
> >
> > diff --git a/Documentation/devicetree/bindings/arm/emtrion.txt
> > b/Documentation/devicetree/bindings/arm/emtrion.txt
> > new file mode 100644
> > index ..3ff6c6c2034d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/emtrion.txt
> > @@ -0,0 +1,13 @@
> > +Emtrion Devicetree Bindings
> > +===
> > +
> > +emCON Series:
[..]
> > index ..2344fb9498e3
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-emcon-avari.dts
> > @@ -0,0 +1,224 @@
> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> > +/* Copyright (C) 2018 emtrion GmbH
> > + * Author: Jan Tuerk*/
>
> /*
> * Copyright ...
> */
Ack
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-emcon.dtsi"
> > +#include "imx6dl-emcon.dtsi" /*Include camera2 pinmux*/
>
> /* bla bla */
>
> > +
> > +/ {
> > + model = "emtrion SoM emCON-MX6 Solo/Dual-Lite Avari";
> > + compatible = "emtrion,emcon-mx6-avari", "fsl,imx6dl";
> > +
> > + aliases {
> > + mmc0 = &usdhc3;
> > + mmc2 = &usdhc1;
> > + mmc1 = &usdhc2;
> > + mmc3 = &usdhc4;
> > + };
> > +
> > + chosen {
> > + stdout-path = <&uart1>;
> > + };
> > +
> > + memory {
>
> The unit-address is missing.
Ack
>
> > + reg = <0x1000 0x4000>;
> > + };
> > +
> > + supplies {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> DT maintainers do not like this fake container node. Please put the
> fixed regulator nodes directly under root with a unique name like below.
Ok I'll change this
>
> reg_xxx: regulator-xxx {
> ...
> };
>
> > +
> > + wallplug5p0: supply@0 {
> > + compatible = "regulator-fixed";
> > + reg = <0>;
> > + regulator-name = "WALL-PLUG";
> > + regulator-min-microvolt = <500>;
> > + regulator-max-microvolt = <500>;
> > + regulator-always-on;
&
Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
On Fri, Apr 20, 2018 at 02:50:52PM +0200, jan.tu...@emtrion.com wrote:
> From: Jan Tuerk
>
> This patch adds support for the emtrion GmbH emCON-MX6 modules.
> They are available with imx.6 Solo, Dual-Lite, Dual and Quad
> equipped with Memory from 512MB to 2GB (configured by U-Boot).
>
> Our default developer-Kit ships with the Avari baseboard and the
> EDT ETM0700G0BDH6 Display (imx6[q|dl]-emcon-avari).
>
> The devicetree is split into the common part providing all module
> components and the basic support for all SoC versions
> (imx6qdl-emcon.dtsi) and parts which are i.mx6 S|DL and D|Q relevant.
> Finally the support for the avari baseboard in the developer-kit
> configuration is provided by the emcon-avari dts files.
>
> Signed-off-by: Jan Tuerk
> ---
> Documentation/devicetree/bindings/arm/emtrion.txt | 13 +
It's better to have a separate patch for bindings doc, which needs to be
acknowledged by DT maintainers.
> arch/arm/boot/dts/Makefile| 2 +
> arch/arm/boot/dts/imx6dl-emcon-avari.dts | 224 ++
> arch/arm/boot/dts/imx6dl-emcon.dtsi | 27 +
> arch/arm/boot/dts/imx6q-emcon-avari.dts | 224 ++
> arch/arm/boot/dts/imx6q-emcon.dtsi| 27 +
> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 838
> ++
> 7 files changed, 1355 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/emtrion.txt
> create mode 100644 arch/arm/boot/dts/imx6dl-emcon-avari.dts
> create mode 100644 arch/arm/boot/dts/imx6dl-emcon.dtsi
> create mode 100644 arch/arm/boot/dts/imx6q-emcon-avari.dts
> create mode 100644 arch/arm/boot/dts/imx6q-emcon.dtsi
> create mode 100644 arch/arm/boot/dts/imx6qdl-emcon.dtsi
>
> diff --git a/Documentation/devicetree/bindings/arm/emtrion.txt
> b/Documentation/devicetree/bindings/arm/emtrion.txt
> new file mode 100644
> index ..3ff6c6c2034d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/emtrion.txt
> @@ -0,0 +1,13 @@
> +Emtrion Devicetree Bindings
> +===
> +
> +emCON Series:
> +-
> +
> +Required root node properties
> + - compatible:
> + - "emtrion,emcon-mx6", "fsl,imx6q", "fsl,imx6dl"; : emCON-MX6 Generic
> SoM
> + - "emtrion,emcon-mx6", "fsl,imx6q"; : emCON-MX6D or
> emCON-MX6Q SoM
> + - "emtrion,emcon-mx6-avari", "fsl,imx6q"; : emCON-MX6D or
> emCON-MX6Q SoM on Avari Base
> + - "emtrion,emcon-mx6", "fsl,imx6dl";: emCON-MX6S or
> emCON-MX6DL SoM
> + - "emtrion,emcon-mx6-avari", "fsl,imx6dl"; : emCON-MX6S or
> emCON-MX6DL SoM on Avari Base
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7e2424957809..05b930da3fda 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -381,6 +381,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6dl-cubox-i-emmc-som-v15.dtb \
> imx6dl-cubox-i-som-v15.dtb \
> imx6dl-dfi-fs700-m60.dtb \
> + imx6dl-emcon-avari.dtb \
> imx6dl-gw51xx.dtb \
> imx6dl-gw52xx.dtb \
> imx6dl-gw53xx.dtb \
> @@ -442,6 +443,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6q-display5-tianma-tm070-1280x768.dtb \
> imx6q-dmo-edmqmx6.dtb \
> imx6q-dms-ba16.dtb \
> + imx6q-emcon-avari.dtb \
> imx6q-evi.dtb \
> imx6q-gk802.dtb \
> imx6q-gw51xx.dtb \
> diff --git a/arch/arm/boot/dts/imx6dl-emcon-avari.dts
> b/arch/arm/boot/dts/imx6dl-emcon-avari.dts
> new file mode 100644
> index ..2344fb9498e3
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-emcon-avari.dts
> @@ -0,0 +1,224 @@
> +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> +/* Copyright (C) 2018 emtrion GmbH
> + * Author: Jan Tuerk
> + */
/*
* Copyright ...
*/
> +
> +/dts-v1/;
> +#include "imx6dl.dtsi"
> +#include "imx6qdl-emcon.dtsi"
> +#include "imx6dl-emcon.dtsi" /*Include camera2 pinmux*/
/* bla bla */
> +
> +/ {
> + model = "emtrion SoM emCON-MX6 Solo/Dual-Lite Avari";
> + compatible = "emtrion,emcon-mx6-avari", "fsl,imx6dl";
> +
> + aliases {
> + mmc0 = &usdhc3;
> + mmc2 = &usdhc1;
> + mmc1 = &usdhc2;
> + mmc3 = &usdhc4;
> + };
> +
> + chosen {
> + stdout-path = <&uart1>;
> + };
> +
> + memory {
The unit-address is missing.
> + reg = <0x1000 0x4000>;
> + };
> +
> + supplies {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
DT maintainers do not like this fake container node. Please put the
fixed regulator nodes directly under root with a unique name like below.
reg_xxx: regulator-xxx {
...
};
> +
> + wallplug5p0: supply@0 {
> + compatible = "regulator-fixed";
> + reg = <0>;
> + regulator-name = "WALL-PLUG";
> + regulator-min-microvolt
[PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series
From: Jan Tuerk
This patch adds support for the emtrion GmbH emCON-MX6 modules.
They are available with imx.6 Solo, Dual-Lite, Dual and Quad
equipped with Memory from 512MB to 2GB (configured by U-Boot).
Our default developer-Kit ships with the Avari baseboard and the
EDT ETM0700G0BDH6 Display (imx6[q|dl]-emcon-avari).
The devicetree is split into the common part providing all module
components and the basic support for all SoC versions
(imx6qdl-emcon.dtsi) and parts which are i.mx6 S|DL and D|Q relevant.
Finally the support for the avari baseboard in the developer-kit
configuration is provided by the emcon-avari dts files.
Signed-off-by: Jan Tuerk
---
Documentation/devicetree/bindings/arm/emtrion.txt | 13 +
arch/arm/boot/dts/Makefile| 2 +
arch/arm/boot/dts/imx6dl-emcon-avari.dts | 224 ++
arch/arm/boot/dts/imx6dl-emcon.dtsi | 27 +
arch/arm/boot/dts/imx6q-emcon-avari.dts | 224 ++
arch/arm/boot/dts/imx6q-emcon.dtsi| 27 +
arch/arm/boot/dts/imx6qdl-emcon.dtsi | 838 ++
7 files changed, 1355 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/emtrion.txt
create mode 100644 arch/arm/boot/dts/imx6dl-emcon-avari.dts
create mode 100644 arch/arm/boot/dts/imx6dl-emcon.dtsi
create mode 100644 arch/arm/boot/dts/imx6q-emcon-avari.dts
create mode 100644 arch/arm/boot/dts/imx6q-emcon.dtsi
create mode 100644 arch/arm/boot/dts/imx6qdl-emcon.dtsi
diff --git a/Documentation/devicetree/bindings/arm/emtrion.txt
b/Documentation/devicetree/bindings/arm/emtrion.txt
new file mode 100644
index ..3ff6c6c2034d
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/emtrion.txt
@@ -0,0 +1,13 @@
+Emtrion Devicetree Bindings
+===
+
+emCON Series:
+-
+
+Required root node properties
+ - compatible:
+ - "emtrion,emcon-mx6", "fsl,imx6q", "fsl,imx6dl"; : emCON-MX6 Generic
SoM
+ - "emtrion,emcon-mx6", "fsl,imx6q"; : emCON-MX6D or
emCON-MX6Q SoM
+ - "emtrion,emcon-mx6-avari", "fsl,imx6q"; : emCON-MX6D or
emCON-MX6Q SoM on Avari Base
+ - "emtrion,emcon-mx6", "fsl,imx6dl";: emCON-MX6S or
emCON-MX6DL SoM
+ - "emtrion,emcon-mx6-avari", "fsl,imx6dl"; : emCON-MX6S or
emCON-MX6DL SoM on Avari Base
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7e2424957809..05b930da3fda 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -381,6 +381,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6dl-cubox-i-emmc-som-v15.dtb \
imx6dl-cubox-i-som-v15.dtb \
imx6dl-dfi-fs700-m60.dtb \
+ imx6dl-emcon-avari.dtb \
imx6dl-gw51xx.dtb \
imx6dl-gw52xx.dtb \
imx6dl-gw53xx.dtb \
@@ -442,6 +443,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-display5-tianma-tm070-1280x768.dtb \
imx6q-dmo-edmqmx6.dtb \
imx6q-dms-ba16.dtb \
+ imx6q-emcon-avari.dtb \
imx6q-evi.dtb \
imx6q-gk802.dtb \
imx6q-gw51xx.dtb \
diff --git a/arch/arm/boot/dts/imx6dl-emcon-avari.dts
b/arch/arm/boot/dts/imx6dl-emcon-avari.dts
new file mode 100644
index ..2344fb9498e3
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-emcon-avari.dts
@@ -0,0 +1,224 @@
+// SPDX-License-Identifier: (GPL-2.0 or MIT)
+/* Copyright (C) 2018 emtrion GmbH
+ * Author: Jan Tuerk
+ */
+
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-emcon.dtsi"
+#include "imx6dl-emcon.dtsi" /*Include camera2 pinmux*/
+
+/ {
+ model = "emtrion SoM emCON-MX6 Solo/Dual-Lite Avari";
+ compatible = "emtrion,emcon-mx6-avari", "fsl,imx6dl";
+
+ aliases {
+ mmc0 = &usdhc3;
+ mmc2 = &usdhc1;
+ mmc1 = &usdhc2;
+ mmc3 = &usdhc4;
+ };
+
+ chosen {
+ stdout-path = <&uart1>;
+ };
+
+ memory {
+ reg = <0x1000 0x4000>;
+ };
+
+ supplies {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wallplug5p0: supply@0 {
+ compatible = "regulator-fixed";
+ reg = <0>;
+ regulator-name = "WALL-PLUG";
+ regulator-min-microvolt = <500>;
+ regulator-max-microvolt = <500>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ base3p3: supply@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ vin-supply = <&wallplug5p0>;
+ regulator-name = "3V3-avari";
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-always-on;
+ regulator-boot-
