Re: [PATCH v4 1/3] dt-bindings: panel: Add the Ilitek ILI9881c panel documentation

2018-05-11 Thread Linus Walleij 
On Fri, May 4, 2018 at 5:23 PM, Maxime Ripard  wrote:

> The LHR050H41 from BananaPi is a 1280x700 4-lanes DSI panel based on the
> ILI9881c from Ilitek.
>
> Acked-by: Rob Herring 
> Signed-off-by: Maxime Ripard 
(...)

Bah, now I see this:

> +  - power-gpios: a GPIO phandle for the power pin

That should probably be a fixed regulator backed by a GPIO
instead. Especially if you know which voltage it has. So
one more layer of abstraction, sorry.

Yours,
Linus Walleij
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 1/3] dt-bindings: panel: Add the Ilitek ILI9881c panel documentation

2018-05-11 Thread Linus Walleij 
On Fri, May 4, 2018 at 5:23 PM, Maxime Ripard  wrote:
> The LHR050H41 from BananaPi is a 1280x700 4-lanes DSI panel based on the
> ILI9881c from Ilitek.
>
> Acked-by: Rob Herring 
> Signed-off-by: Maxime Ripard 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 1/3] dt-bindings: panel: Add the Ilitek ILI9881c panel documentation

2018-05-04 Thread Maxime Ripard 
The LHR050H41 from BananaPi is a 1280x700 4-lanes DSI panel based on the
ILI9881c from Ilitek.

Acked-by: Rob Herring 
Signed-off-by: Maxime Ripard 
---
 Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt | 20 

 1 file changed, 20 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt

diff --git 
a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt 
b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt
new file mode 100644
index ..df05e8bb4851
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt
@@ -0,0 +1,20 @@
+Ilitek ILI9881c based MIPI-DSI panels
+
+Required properties:
+  - compatible: must be "ilitek,ili9881c" and one of:
+* "bananapi,lhr050h41"
+  - reg: DSI virtual channel used by that screen
+  - power-gpios: a GPIO phandle for the power pin
+  - reset-gpios: a GPIO phandle for the reset pin
+
+Optional properties:
+  - backlight: phandle to the backlight used
+
+Example:
+panel@0 {
+   compatible = "bananapi,lhr050h41", "ilitek,ili9881c";
+   reg = <0>;
+   power-gpios = <&pio 1 7 GPIO_ACTIVE_HIGH>; /* PB07 */
+   reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
+   backlight = <&pwm_bl>;
+};
-- 
git-series 0.9.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel