[PATCH v4 3/3] drm/panel: add support for Innolux TV123WAM panel

[Sandeep Panda]

Innolux TV123WAM is a 12.3" eDP display panel with
2160x1440 resolution, which can be supported by simple
panel driver.

Changes in v1:
 - Make use of simple panel driver instead of creating
   a new driver for this panel (Sean Paul).
 - Combine dt-binding and driver changes into one patch
   as done by other existing panel support changes.

Signed-off-by: Sandeep Panda 
---
 .../bindings/display/panel/innolux,tv123wam.txt|  7 ++
 drivers/gpu/drm/panel/panel-simple.c   | 27 ++
 2 files changed, 34 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt

diff --git 
a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt 
b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
new file mode 100644
index 000..c12e714
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
@@ -0,0 +1,7 @@
+Innolux TV123WAM 12.3 inch eDP 2K display panel
+
+Required properties:
+- compatible: should be "innolux,tv123wam"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 234af81..52bbcfb 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1939,6 +1939,30 @@ static void panel_simple_shutdown(struct device *dev)
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct drm_display_mode innolux_tv123wam_mode = {
+   .clock = 206016,
+   .hdisplay = 2160,
+   .hsync_start = 2160 + 48,
+   .hsync_end = 2160 + 48 + 32,
+   .htotal = 2160 + 48 + 32 + 80,
+   .vdisplay = 1440,
+   .vsync_start = 1440 + 3,
+   .vsync_end = 1440 + 3 + 10,
+   .vtotal = 1440 + 3 + 10 + 27,
+   .vrefresh = 60,
+   .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc innolux_tv123wam = {
+   .modes = _tv123wam_mode,
+   .num_modes = 1,
+   .bpc = 8,
+   .size = {
+   .width = 259,
+   .height = 173,
+   },
+};
+
 static const struct of_device_id platform_of_match[] = {
{
.compatible = "ampire,am-480272h3tmqw-t01h",
@@ -2142,6 +2166,9 @@ static void panel_simple_shutdown(struct device *dev)
.compatible = "winstar,wf35ltiacd",
.data = _wf35ltiacd,
}, {
+   .compatible = "innolux,tv123wam",
+   .data = _tv123wam,
+   }, {
/* sentinel */
}
 };
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 3/3] drm/panel: add support for Innolux TV123WAM panel

[Rob Herring]

On Fri, Apr 27, 2018 at 03:09:42PM +0530, Sandeep Panda wrote:
> Innolux TV123WAM is a 12.3" eDP display panel with
> 2160x1440 resolution, which can be supported by simple
> panel driver.
> 
> Changes in v1:
>  - Make use of simple panel driver instead of creating
>a new driver for this panel (Sean Paul).
>  - Combine dt-binding and driver changes into one patch
>as done by other existing panel support changes.

While allowed, having them separate is preferred.

> 
> Signed-off-by: Sandeep Panda 
> ---
>  .../bindings/display/panel/innolux,tv123wam.txt|  7 ++
>  drivers/gpu/drm/panel/panel-simple.c   | 27 
> ++
>  2 files changed, 34 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt 
> b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> new file mode 100644
> index 000..c12e714
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt
> @@ -0,0 +1,7 @@
> +Innolux TV123WAM 12.3 inch eDP 2K display panel
> +
> +Required properties:
> +- compatible: should be "innolux,tv123wam"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.

You need to state exactly what properties from this apply.

Rob
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel