Re: [PATCH v5 0/3] Support 64 bpp half float formats
On Fri, 2019-02-08 at 13:49 -0800, Kevin Strasser wrote: > This series defines new formats and adds implementation to the i915 driver. > Since posting v1 I have removed the pixel normalize property, as it's not > needed > for basic functionality. Also, I have been working on adding support to > userspace, but we can't land any patches until drm_fourcc.h has been updated > here. Series is: Reviewed-by: Adam Jackson - ajax ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH v5 0/3] Support 64 bpp half float formats
Maarten Lankhorst wrote:
> Op 13-02-2019 om 16:53 schreef Ville Syrjälä:
> > On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote:
> >> This series defines new formats and adds implementation to the i915 driver.
> >> Since posting v1 I have removed the pixel normalize property, as it's not
> >> needed
> >> for basic functionality. Also, I have been working on adding support to
> >> userspace, but we can't land any patches until drm_fourcc.h has been
> >> updated
> >> here.
> >>
> >> I have submitted a series to Mesa to make use of the RGBA ordered formats:
> >> https://patchwork.freedesktop.org/series/54759/
> >>
> >> My igt branch is reworked to drop usage of pixel normalize and includes use
> >> of f16c intrinsics to speed up conversion:
> >> https://gitlab.freedesktop.org/strassek/igt-gpu-tools/commits/fp16
> > Was that posted to the ml? I can't seem to find it.
> >
> > Anyways, a quick look at the web thing tells me this predates
> > Maarten's cairo float stuff. I believe that has now landed so you
> > should probably switch to using that instead of rendering at 8bpc.
>
> Yes, it's now in upstream igt. :)
>
> RGB96F is just a float[3] = { r, g, b }; RGBA128F is the same with the alpha
> channel at the end,
>
> should be possible to convert to half float with the right changes to the
> conversion function.
I've updated my branch to use the new float formats. Here is a link to the
relevant commit:
https://gitlab.freedesktop.org/strassek/igt-gpu-tools/commit/11d14a37859e9dfd43755feb631e4b530d666392
Thanks,
Kevin
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v5 0/3] Support 64 bpp half float formats
Op 13-02-2019 om 16:53 schreef Ville Syrjälä:
> On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote:
>> This series defines new formats and adds implementation to the i915 driver.
>> Since posting v1 I have removed the pixel normalize property, as it's not
>> needed
>> for basic functionality. Also, I have been working on adding support to
>> userspace, but we can't land any patches until drm_fourcc.h has been updated
>> here.
>>
>> I have submitted a series to Mesa to make use of the RGBA ordered formats:
>> https://patchwork.freedesktop.org/series/54759/
>>
>> My igt branch is reworked to drop usage of pixel normalize and includes use
>> of f16c intrinsics to speed up conversion:
>> https://gitlab.freedesktop.org/strassek/igt-gpu-tools/commits/fp16
> Was that posted to the ml? I can't seem to find it.
>
> Anyways, a quick look at the web thing tells me this predates
> Maarten's cairo float stuff. I believe that has now landed so you
> should probably switch to using that instead of rendering at 8bpc.
Yes, it's now in upstream igt. :)
RGB96F is just a float[3] = { r, g, b }; RGBA128F is the same with the alpha
channel at the end,
should be possible to convert to half float with the right changes to the
conversion function.
~Maarten
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v5 0/3] Support 64 bpp half float formats
On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: > This series defines new formats and adds implementation to the i915 driver. > Since posting v1 I have removed the pixel normalize property, as it's not > needed > for basic functionality. Also, I have been working on adding support to > userspace, but we can't land any patches until drm_fourcc.h has been updated > here. > > I have submitted a series to Mesa to make use of the RGBA ordered formats: > https://patchwork.freedesktop.org/series/54759/ > > My igt branch is reworked to drop usage of pixel normalize and includes use > of f16c intrinsics to speed up conversion: > https://gitlab.freedesktop.org/strassek/igt-gpu-tools/commits/fp16 Was that posted to the ml? I can't seem to find it. Anyways, a quick look at the web thing tells me this predates Maarten's cairo float stuff. I believe that has now landed so you should probably switch to using that instead of rendering at 8bpc. > > I also have a libdrm branch with fp16 coverage added to modetest: > https://gitlab.freedesktop.org/strassek/drm/commits/fp16 > > To serve as a smoke test of the whole stack I have a modified version of > kmscube: > https://gitlab.freedesktop.org/strassek/kmscube/commits/fp16 > > Kevin Strasser (3): > drm/fourcc: Add 64 bpp half float formats > drm/i915: Refactor icl_is_hdr_plane > drm/i915/icl: Implement half float formats > > drivers/gpu/drm/drm_fourcc.c | 4 ++ > drivers/gpu/drm/i915/intel_atomic.c | 3 +- > drivers/gpu/drm/i915/intel_display.c | 29 +- > drivers/gpu/drm/i915/intel_drv.h | 7 ++-- > drivers/gpu/drm/i915/intel_sprite.c | 73 > +++- > include/uapi/drm/drm_fourcc.h| 11 ++ > 6 files changed, 112 insertions(+), 15 deletions(-) > > -- > 2.7.4 -- Ville Syrjälä Intel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v5 0/3] Support 64 bpp half float formats
This series defines new formats and adds implementation to the i915 driver. Since posting v1 I have removed the pixel normalize property, as it's not needed for basic functionality. Also, I have been working on adding support to userspace, but we can't land any patches until drm_fourcc.h has been updated here. I have submitted a series to Mesa to make use of the RGBA ordered formats: https://patchwork.freedesktop.org/series/54759/ My igt branch is reworked to drop usage of pixel normalize and includes use of f16c intrinsics to speed up conversion: https://gitlab.freedesktop.org/strassek/igt-gpu-tools/commits/fp16 I also have a libdrm branch with fp16 coverage added to modetest: https://gitlab.freedesktop.org/strassek/drm/commits/fp16 To serve as a smoke test of the whole stack I have a modified version of kmscube: https://gitlab.freedesktop.org/strassek/kmscube/commits/fp16 Kevin Strasser (3): drm/fourcc: Add 64 bpp half float formats drm/i915: Refactor icl_is_hdr_plane drm/i915/icl: Implement half float formats drivers/gpu/drm/drm_fourcc.c | 4 ++ drivers/gpu/drm/i915/intel_atomic.c | 3 +- drivers/gpu/drm/i915/intel_display.c | 29 +- drivers/gpu/drm/i915/intel_drv.h | 7 ++-- drivers/gpu/drm/i915/intel_sprite.c | 73 +++- include/uapi/drm/drm_fourcc.h| 11 ++ 6 files changed, 112 insertions(+), 15 deletions(-) -- 2.7.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
