Re: [PATCH v5 06/18] kbuild: enable building KUnit
On Tue, Jun 25, 2019 at 03:41:29PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain wrote: > > > > On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > > > diff --git a/Kconfig b/Kconfig > > > index 48a80beab6853..10428501edb78 100644 > > > --- a/Kconfig > > > +++ b/Kconfig > > > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > > > source "lib/Kconfig" > > > > > > source "lib/Kconfig.debug" > > > + > > > +source "kunit/Kconfig" > > > > This patch would break compilation as kunit/Kconfig is not introduced. This > > would would also break bisectability on this commit. This change should > > either be folded in to the next patch, or just be a separate patch after > > the next one. > > Maybe my brain isn't working right now, but I am pretty darn sure that > I introduce kunit/Kconfig in the very first patch of this series. > Quoting from the change summary from the first commit: Indeed, my mistake, thanks! Luis
Re: [PATCH v5 06/18] kbuild: enable building KUnit
On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain wrote: > > On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > > diff --git a/Kconfig b/Kconfig > > index 48a80beab6853..10428501edb78 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > > source "lib/Kconfig" > > > > source "lib/Kconfig.debug" > > + > > +source "kunit/Kconfig" > > This patch would break compilation as kunit/Kconfig is not introduced. This > would would also break bisectability on this commit. This change should > either be folded in to the next patch, or just be a separate patch after > the next one. Maybe my brain isn't working right now, but I am pretty darn sure that I introduce kunit/Kconfig in the very first patch of this series. Quoting from the change summary from the first commit: > include/kunit/test.h | 161 + > kunit/Kconfig| 17 > kunit/Makefile | 1 + > kunit/test.c | 210 +++ > 4 files changed, 389 insertions(+) > create mode 100644 include/kunit/test.h > create mode 100644 kunit/Kconfig I am not crazy, right? > create mode 100644 kunit/Makefile > create mode 100644 kunit/test.c ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v5 06/18] kbuild: enable building KUnit
On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > diff --git a/Kconfig b/Kconfig > index 48a80beab6853..10428501edb78 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > + > +source "kunit/Kconfig" This patch would break compilation as kunit/Kconfig is not introduced. This would would also break bisectability on this commit. This change should either be folded in to the next patch, or just be a separate patch after the next one. Luis ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v5 06/18] kbuild: enable building KUnit
KUnit is a new unit testing framework for the kernel and when used is built into the kernel as a part of it. Add KUnit to the root Kconfig and Makefile to allow it to be actually built. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Kconfig | 2 ++ Makefile | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Kconfig b/Kconfig index 48a80beab6853..10428501edb78 100644 --- a/Kconfig +++ b/Kconfig @@ -30,3 +30,5 @@ source "crypto/Kconfig" source "lib/Kconfig" source "lib/Kconfig.debug" + +source "kunit/Kconfig" diff --git a/Makefile b/Makefile index b81e172612507..4b544a8eebee4 100644 --- a/Makefile +++ b/Makefile @@ -991,7 +991,7 @@ endif PHONY += prepare0 ifeq ($(KBUILD_EXTMOD),) -core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/ vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ $(core-y) $(core-m) $(drivers-y) $(drivers-m) \ -- 2.22.0.410.gd8fdbe21b5-goog