Re: [PATCH v5 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-06-26 Thread Daniel Vetter
On Sun, Jun 26, 2022 at 10:56:15AM +0200, Helge Deller wrote:
> Use the fbcon_info_from_console() wrapper which was added to kernel
> v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for 
> console->fb_info lookup").
> 
> Signed-off-by: Helge Deller 

Reviewed-by: Daniel Vetter 

> ---
>  drivers/video/fbdev/core/fbcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/core/fbcon.c 
> b/drivers/video/fbdev/core/fbcon.c
> index 69c7261ac334..2ab7515ac842 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2751,7 +2751,7 @@ int fbcon_modechange_possible(struct fb_info *info, 
> struct fb_var_screeninfo *va
>   /* prevent setting a screen size which is smaller than font size */
>   for (i = first_fb_vc; i <= last_fb_vc; i++) {
>   vc = vc_cons[i].d;
> - if (!vc || registered_fb[con2fb_map[i]] != info)
> + if (!vc || fbcon_info_from_console(i) != info)
>   continue;
> 
>   if (vc->vc_font.width  > FBCON_SWAP(var->rotate, var->xres, 
> var->yres) ||
> --
> 2.35.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


[PATCH v5 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-06-26 Thread Helge Deller
Use the fbcon_info_from_console() wrapper which was added to kernel
v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info 
lookup").

Signed-off-by: Helge Deller 
---
 drivers/video/fbdev/core/fbcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 69c7261ac334..2ab7515ac842 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -2751,7 +2751,7 @@ int fbcon_modechange_possible(struct fb_info *info, 
struct fb_var_screeninfo *va
/* prevent setting a screen size which is smaller than font size */
for (i = first_fb_vc; i <= last_fb_vc; i++) {
vc = vc_cons[i].d;
-   if (!vc || registered_fb[con2fb_map[i]] != info)
+   if (!vc || fbcon_info_from_console(i) != info)
continue;

if (vc->vc_font.width  > FBCON_SWAP(var->rotate, var->xres, 
var->yres) ||
--
2.35.3