Re: [Nouveau] [PATCH v5 5/5] nouveau_hwmon: Change permissions to numeric
2017-05-02 7:07 GMT+02:00 Martin Peres: > On 26/04/17 19:46, Oscar Salvador wrote: >> This patch replaces the symbolic permissions with the numeric ones, >> and adds me to the authors too. >> >> Signed-off-by: Oscar Salvador > > >> --- >> drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++--- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c >> b/drivers/gpu/drm/nouveau/nouveau_hwmon.c >> index 9142779..45b5c85 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c >> @@ -1,5 +1,6 @@ >> /* >> - * Copyright 2010 Red Hat Inc. >> + * Copyright 2010 Red Hat Inc. (Ben Skeggs) > > Please drop this change. > >> + * Copyright 2017 Oscar Salvador >> * >> * Permission is hereby granted, free of charge, to any person obtaining a >> * copy of this software and associated documentation files (the >> "Software"), >> @@ -19,7 +20,6 @@ >> * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> * OTHER DEALINGS IN THE SOFTWARE. >> * >> - * Authors: Ben Skeggs > > You can't remove people as being the author of something. Just add > yourself if you care about this (I did not care to add my name when I > wrote in this file, because the git history makes more sense nowadays. > > Otherwise, I have no strong opinions on this patch. I guess the numeric > representation is easier to read, so I will give you my R-b for this and > let others decide what to do: > copyright holder != Author though. So yeah, he isn't allowed to change that. > Reviewed-by: Martin Peres > >> */ >> >> #ifdef CONFIG_ACPI >> @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, >> { >> return snprintf(buf, PAGE_SIZE, "%d\n", 100); >> } >> -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, >> +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, >> nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); >> >> static ssize_t >> @@ -88,7 +88,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp(struct device *d, >> >> return count; >> } >> -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, S_IRUGO | S_IWUSR, >> +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, 0644, >> nouveau_hwmon_temp1_auto_point1_temp, >> nouveau_hwmon_set_temp1_auto_point1_temp, 0); >> >> @@ -121,7 +121,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp_hyst(struct >> device *d, >> >> return count; >> } >> -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, S_IRUGO | S_IWUSR, >> +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, 0644, >> nouveau_hwmon_temp1_auto_point1_temp_hyst, >> nouveau_hwmon_set_temp1_auto_point1_temp_hyst, 0); >> >> @@ -255,7 +255,7 @@ nouveau_hwmon_set_pwm1_min(struct device *d, struct >> device_attribute *a, >> return count; >> } >> >> -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, >> +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, >> nouveau_hwmon_get_pwm1_min, >> nouveau_hwmon_set_pwm1_min, 0); >> >> @@ -295,7 +295,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct >> device_attribute *a, >> return count; >> } >> >> -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, >> +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, >> nouveau_hwmon_get_pwm1_max, >> nouveau_hwmon_set_pwm1_max, 0); >> >> > > ___ > Nouveau mailing list > nouv...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Nouveau] [PATCH v5 5/5] nouveau_hwmon: Change permissions to numeric
On 26/04/17 19:46, Oscar Salvador wrote: > This patch replaces the symbolic permissions with the numeric ones, > and adds me to the authors too. > > Signed-off-by: Oscar Salvador> --- > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > index 9142779..45b5c85 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > @@ -1,5 +1,6 @@ > /* > - * Copyright 2010 Red Hat Inc. > + * Copyright 2010 Red Hat Inc. (Ben Skeggs) Please drop this change. > + * Copyright 2017 Oscar Salvador > * > * Permission is hereby granted, free of charge, to any person obtaining a > * copy of this software and associated documentation files (the "Software"), > @@ -19,7 +20,6 @@ > * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > * OTHER DEALINGS IN THE SOFTWARE. > * > - * Authors: Ben Skeggs You can't remove people as being the author of something. Just add yourself if you care about this (I did not care to add my name when I wrote in this file, because the git history makes more sense nowadays. Otherwise, I have no strong opinions on this patch. I guess the numeric representation is easier to read, so I will give you my R-b for this and let others decide what to do: Reviewed-by: Martin Peres > */ > > #ifdef CONFIG_ACPI > @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, > { > return snprintf(buf, PAGE_SIZE, "%d\n", 100); > } > -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, > +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, > nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); > > static ssize_t > @@ -88,7 +88,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp(struct device *d, > > return count; > } > -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, 0644, > nouveau_hwmon_temp1_auto_point1_temp, > nouveau_hwmon_set_temp1_auto_point1_temp, 0); > > @@ -121,7 +121,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp_hyst(struct > device *d, > > return count; > } > -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, 0644, > nouveau_hwmon_temp1_auto_point1_temp_hyst, > nouveau_hwmon_set_temp1_auto_point1_temp_hyst, 0); > > @@ -255,7 +255,7 @@ nouveau_hwmon_set_pwm1_min(struct device *d, struct > device_attribute *a, > return count; > } > > -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, > nouveau_hwmon_get_pwm1_min, > nouveau_hwmon_set_pwm1_min, 0); > > @@ -295,7 +295,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct > device_attribute *a, > return count; > } > > -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, > nouveau_hwmon_get_pwm1_max, > nouveau_hwmon_set_pwm1_max, 0); > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v5 5/5] nouveau_hwmon: Change permissions to numeric
This patch replaces the symbolic permissions with the numeric ones, and adds me to the authors too. Signed-off-by: Oscar Salvador--- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index 9142779..45b5c85 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -1,5 +1,6 @@ /* - * Copyright 2010 Red Hat Inc. + * Copyright 2010 Red Hat Inc. (Ben Skeggs) + * Copyright 2017 Oscar Salvador * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"), @@ -19,7 +20,6 @@ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. * - * Authors: Ben Skeggs */ #ifdef CONFIG_ACPI @@ -56,7 +56,7 @@ nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, { return snprintf(buf, PAGE_SIZE, "%d\n", 100); } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, S_IRUGO, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); static ssize_t @@ -88,7 +88,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp(struct device *d, return count; } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp, 0644, nouveau_hwmon_temp1_auto_point1_temp, nouveau_hwmon_set_temp1_auto_point1_temp, 0); @@ -121,7 +121,7 @@ nouveau_hwmon_set_temp1_auto_point1_temp_hyst(struct device *d, return count; } -static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(temp1_auto_point1_temp_hyst, 0644, nouveau_hwmon_temp1_auto_point1_temp_hyst, nouveau_hwmon_set_temp1_auto_point1_temp_hyst, 0); @@ -255,7 +255,7 @@ nouveau_hwmon_set_pwm1_min(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, nouveau_hwmon_get_pwm1_min, nouveau_hwmon_set_pwm1_min, 0); @@ -295,7 +295,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, nouveau_hwmon_get_pwm1_max, nouveau_hwmon_set_pwm1_max, 0); -- 2.1.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel