Re: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits
On 5/27/2024 1:56 PM, Animesh Manna wrote: From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 906949ca3cee..3317ff88ed59 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -232,6 +232,8 @@ #define DP_RECEIVER_ALPM_CAP 0x02e /* eDP 1.4 */ # define DP_ALPM_CAP (1 << 0) +# define DP_ALPM_PM_STATE_2A_SUPPORT (1 << 1) /* eDP 1.5 */ +# define DP_ALPM_AUX_LESS_CAP (1 << 2) /* eDP 1.5 */ This bit seems to be derived from DP 2.1. As per eDP1.5: Only bits [1 and 0] are eDP-specific. The register’s other bits are defined in DP Standard. In any case, patch looks good to me. Reviewed-by: Ankit Nautiyal Regards, Ankit #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CAP 0x02f /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_CAP(1 << 0) @@ -683,7 +685,8 @@ #define DP_RECEIVER_ALPM_CONFIG 0x116 /* eDP 1.4 */ # define DP_ALPM_ENABLE (1 << 0) -# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) +# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) /* eDP 1.5 */ +# define DP_ALPM_MODE_AUX_LESS (1 << 2) /* eDP 1.5 */ #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF 0x117 /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_ENABLE (1 << 0)
Re: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits
On Tue, May 28, 2024 at 10:04:06AM GMT, Manna, Animesh wrote: > + drm-core maintainer > > Hi, > > Could you please have a look and ack this patch. > Received r-b from Jouni on 0th patch for the whole patch series. Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature
RE: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits
+ drm-core maintainer Hi, Could you please have a look and ack this patch. Received r-b from Jouni on 0th patch for the whole patch series. Regards, Animesh > -Original Message- > From: Intel-gfx On Behalf Of > Animesh Manna > Sent: Monday, May 27, 2024 1:57 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Hogander, Jouni > ; Murthy, Arun R > Subject: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related > bits > > From: Jouni Högander > > eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and > DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. > > Signed-off-by: Jouni Högander > --- > include/drm/display/drm_dp.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h > index 906949ca3cee..3317ff88ed59 100644 > --- a/include/drm/display/drm_dp.h > +++ b/include/drm/display/drm_dp.h > @@ -232,6 +232,8 @@ > > #define DP_RECEIVER_ALPM_CAP 0x02e /* eDP 1.4 */ > # define DP_ALPM_CAP (1 << 0) > +# define DP_ALPM_PM_STATE_2A_SUPPORT (1 << 1) /* eDP 1.5 */ > +# define DP_ALPM_AUX_LESS_CAP(1 << 2) /* eDP 1.5 */ > > #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CAP 0x02f /* eDP 1.4 */ > # define DP_AUX_FRAME_SYNC_CAP (1 << 0) > @@ -683,7 +685,8 @@ > > #define DP_RECEIVER_ALPM_CONFIG 0x116 /* eDP 1.4 */ > # define DP_ALPM_ENABLE (1 << 0) > -# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) > +# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) /* eDP 1.5 */ > +# define DP_ALPM_MODE_AUX_LESS (1 << 2) /* eDP 1.5 */ > > #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF 0x117 /* eDP 1.4 */ > # define DP_AUX_FRAME_SYNC_ENABLE(1 << 0) > -- > 2.29.0
[PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits
From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 906949ca3cee..3317ff88ed59 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -232,6 +232,8 @@ #define DP_RECEIVER_ALPM_CAP 0x02e /* eDP 1.4 */ # define DP_ALPM_CAP (1 << 0) +# define DP_ALPM_PM_STATE_2A_SUPPORT (1 << 1) /* eDP 1.5 */ +# define DP_ALPM_AUX_LESS_CAP (1 << 2) /* eDP 1.5 */ #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CAP 0x02f /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_CAP (1 << 0) @@ -683,7 +685,8 @@ #define DP_RECEIVER_ALPM_CONFIG0x116 /* eDP 1.4 */ # define DP_ALPM_ENABLE(1 << 0) -# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) +# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE (1 << 1) /* eDP 1.5 */ +# define DP_ALPM_MODE_AUX_LESS (1 << 2) /* eDP 1.5 */ #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF 0x117 /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_ENABLE (1 << 0) -- 2.29.0
