[PATCHv2 2/2] i915: do not leak module ref counter
Always put_filesystem() in i915_gemfs_init(). Signed-off-by: Sergey Senozhatsky --- - v2: rebased (i915 does not remount gemfs anymore) drivers/gpu/drm/i915/gem/i915_gemfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c index 5e6e8c91ab38..0a398e1e45fc 100644 --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c @@ -30,6 +30,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) */ gemfs = kern_mount(type); + put_filesystem(type); if (IS_ERR(gemfs)) return PTR_ERR(gemfs); -- 2.23.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCHv2 2/2] i915: do not leak module ref counter
On Tue, Aug 20, 2019 at 12:13:59PM +0900, Sergey Senozhatsky wrote: > Always put_filesystem() in i915_gemfs_init(). > > Signed-off-by: Sergey Senozhatsky > --- > - v2: rebased (i915 does not remount gemfs anymore) Which means it real doesn't need its mount anyore, and thus can use plain old shmem_file_setup and doesn't need to mess with file system types at all. Assuming we find a legitimate rason for why a driver should be able to create a kernel mount or a file system type where it doesn't have access to the struct file_system_type an API that mount by file system name and thus hides the get_fs_type and put_filesystem would be a much better API than adding this random export.
