[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-30 Thread Jean-Jacques Hiblot
Hi Tim,

On 04/24/2014 02:46 PM, Tim Niemeyer wrote:
> 
> Hi Boris
> 
> Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON:
>> Hi Tim,
>>
>> On 23/04/2014 17:36, Tim Niemeyer wrote:
>>> Hi Jean-Jacques,
>>>
>>> Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
 Hi,

 this patch serie implements a simple DRM driver for the ATMEL High end LCD
 controller found in the SAMA5 familly. It's based on the tilcdc driver.
 It uses the cma_helper for memory and fbdev stuff.
 Your comments are welcome !
>>> I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
>>> framebuffer device on the sama5d31-ek. Seems to work.
>>>
 Supported features:
 * the base layer (the main framebuffer)
>>> Tested to show a little tux png, but it's appearing only after 
>>> 'echo 0 > /sys/devices/ahb.1/apb.2/f003.hlcdc/graphics/fb0/rotate'
>>> is there missing some initializing?
>>
>> Could you try to apply this http://code.bulix.org/f01kvh-86117 ?
> I can't see any difference with that.
> 
> I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the
> display stays with a small atmel logo and u-Boot version information. If
> i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel
> start and fbv just works as expected.
> 
I've been able to reproduce the problem. After some digging, I found
that trigerring a hotplug event with drm_kms_helper_hotplug_event() to
trigger a detection of the connectors at the end of atmel_hlcdc_load()
solves the issue. I don't know if this is a proper way to fix it though.


> Best Regards,
> Tim
> 
>> Best Regards,
>>
>> Boris
>>
>>>
 * a simple panel
 * a backlight driver
>>> Tested to set brightness to 0, 20 and 255. Works.
>>>
>>> Thanks for your work.
>>>
>>> Best Regards
>>> Tim
>>>
 * structure to 'easily' add other connectors (it comes from the tilcdc)

 On the todo list:
 * support overlays as drm_planes
 * support for the hardware cursor
 * support for the SiI9022 HDMI connector (present on sama5d36ek)


 Jean-Jacques Hiblot (3):
   atmel: drm: added drm driver for the atmel hlcd controller
   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
   atmel: dt: Add supports for the lcdc support on the sama5d36ek

  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
  drivers/gpu/drm/Kconfig|   2 +
  drivers/gpu/drm/Makefile   |   1 +
  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
 +
  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 
 +++
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
  15 files changed, 3042 insertions(+), 1 deletion(-)
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h

 --
 1.9.1


 ___
 linux-arm-kernel mailing list
 linux-arm-kernel at lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>>
> 
> 


[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-24 Thread Jean-Jacques Hiblot
Hi Tim,

I'll look a this issue soon. It looks like the scanout is not started in
your test case.
Thanks for reporting this.

JJ

On 04/24/2014 02:46 PM, Tim Niemeyer wrote:
> 
> Hi Boris
> 
> Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON:
>> Hi Tim,
>>
>> On 23/04/2014 17:36, Tim Niemeyer wrote:
>>> Hi Jean-Jacques,
>>>
>>> Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
 Hi,

 this patch serie implements a simple DRM driver for the ATMEL High end LCD
 controller found in the SAMA5 familly. It's based on the tilcdc driver.
 It uses the cma_helper for memory and fbdev stuff.
 Your comments are welcome !
>>> I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
>>> framebuffer device on the sama5d31-ek. Seems to work.
>>>
 Supported features:
 * the base layer (the main framebuffer)
>>> Tested to show a little tux png, but it's appearing only after 
>>> 'echo 0 > /sys/devices/ahb.1/apb.2/f003.hlcdc/graphics/fb0/rotate'
>>> is there missing some initializing?
>>
>> Could you try to apply this http://code.bulix.org/f01kvh-86117 ?
> I can't see any difference with that.
> 
> I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the
> display stays with a small atmel logo and u-Boot version information. If
> i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel
> start and fbv just works as expected.
> 
> Best Regards,
> Tim
> 
>> Best Regards,
>>
>> Boris
>>
>>>
 * a simple panel
 * a backlight driver
>>> Tested to set brightness to 0, 20 and 255. Works.
>>>
>>> Thanks for your work.
>>>
>>> Best Regards
>>> Tim
>>>
 * structure to 'easily' add other connectors (it comes from the tilcdc)

 On the todo list:
 * support overlays as drm_planes
 * support for the hardware cursor
 * support for the SiI9022 HDMI connector (present on sama5d36ek)


 Jean-Jacques Hiblot (3):
   atmel: drm: added drm driver for the atmel hlcd controller
   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
   atmel: dt: Add supports for the lcdc support on the sama5d36ek

  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
  drivers/gpu/drm/Kconfig|   2 +
  drivers/gpu/drm/Makefile   |   1 +
  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
 +
  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 
 +++
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
  15 files changed, 3042 insertions(+), 1 deletion(-)
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h

 --
 1.9.1


 ___
 linux-arm-kernel mailing list
 linux-arm-kernel at lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>>
> 
> 


[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-24 Thread Tim Niemeyer
Hi Boris

Am Donnerstag, den 24.04.2014, 14:14 +0200 schrieb Boris BREZILLON:
> Hi Tim,
> 
> On 23/04/2014 17:36, Tim Niemeyer wrote:
> > Hi Jean-Jacques,
> >
> > Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
> >> Hi,
> >>
> >> this patch serie implements a simple DRM driver for the ATMEL High end LCD
> >> controller found in the SAMA5 familly. It's based on the tilcdc driver.
> >> It uses the cma_helper for memory and fbdev stuff.
> >> Your comments are welcome !
> > I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
> > framebuffer device on the sama5d31-ek. Seems to work.
> >
> >> Supported features:
> >> * the base layer (the main framebuffer)
> > Tested to show a little tux png, but it's appearing only after 
> > 'echo 0 > /sys/devices/ahb.1/apb.2/f003.hlcdc/graphics/fb0/rotate'
> > is there missing some initializing?
> 
> Could you try to apply this http://code.bulix.org/f01kvh-86117 ?
I can't see any difference with that.

I used fbv to display the tux. With CONFIG_FRAMEBUFFER_CONSOLE=n the
display stays with a small atmel logo and u-Boot version information. If
i set CONFIG_FRAMEBUFFER_CONSOLE=y, the display is black after kernel
start and fbv just works as expected.

Best Regards,
Tim

> Best Regards,
> 
> Boris
> 
> >
> >> * a simple panel
> >> * a backlight driver
> > Tested to set brightness to 0, 20 and 255. Works.
> >
> > Thanks for your work.
> >
> > Best Regards
> > Tim
> >
> >> * structure to 'easily' add other connectors (it comes from the tilcdc)
> >>
> >> On the todo list:
> >> * support overlays as drm_planes
> >> * support for the hardware cursor
> >> * support for the SiI9022 HDMI connector (present on sama5d36ek)
> >>
> >>
> >> Jean-Jacques Hiblot (3):
> >>   atmel: drm: added drm driver for the atmel hlcd controller
> >>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
> >>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
> >>
> >>  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
> >>  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
> >>  drivers/gpu/drm/Kconfig|   2 +
> >>  drivers/gpu/drm/Makefile   |   1 +
> >>  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
> >>  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
> >> +
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
> >>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 
> >> +++
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
> >>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
> >>  15 files changed, 3042 insertions(+), 1 deletion(-)
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
> >>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
> >>
> >> --
> >> 1.9.1
> >>
> >>
> >> ___
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel at lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
> 




[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-24 Thread Boris BREZILLON
Hi Tim,

On 23/04/2014 17:36, Tim Niemeyer wrote:
> Hi Jean-Jacques,
>
> Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
>> Hi,
>>
>> this patch serie implements a simple DRM driver for the ATMEL High end LCD
>> controller found in the SAMA5 familly. It's based on the tilcdc driver.
>> It uses the cma_helper for memory and fbdev stuff.
>> Your comments are welcome !
> I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
> framebuffer device on the sama5d31-ek. Seems to work.
>
>> Supported features:
>> * the base layer (the main framebuffer)
> Tested to show a little tux png, but it's appearing only after 
> 'echo 0 > /sys/devices/ahb.1/apb.2/f003.hlcdc/graphics/fb0/rotate'
> is there missing some initializing?

Could you try to apply this http://code.bulix.org/f01kvh-86117 ?

Best Regards,

Boris

>
>> * a simple panel
>> * a backlight driver
> Tested to set brightness to 0, 20 and 255. Works.
>
> Thanks for your work.
>
> Best Regards
> Tim
>
>> * structure to 'easily' add other connectors (it comes from the tilcdc)
>>
>> On the todo list:
>> * support overlays as drm_planes
>> * support for the hardware cursor
>> * support for the SiI9022 HDMI connector (present on sama5d36ek)
>>
>>
>> Jean-Jacques Hiblot (3):
>>   atmel: drm: added drm driver for the atmel hlcd controller
>>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
>>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
>>
>>  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
>>  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
>>  drivers/gpu/drm/Kconfig|   2 +
>>  drivers/gpu/drm/Makefile   |   1 +
>>  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
>>  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
>> +
>>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
>>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
>>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
>>  15 files changed, 3042 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
>>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
>>
>> --
>> 1.9.1
>>
>>
>> ___
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-23 Thread Tim Niemeyer
Hi Jean-Jacques,

Am Freitag, den 18.04.2014, 11:45 +0200 schrieb Jean-Jacques Hiblot:
> Hi,
> 
> this patch serie implements a simple DRM driver for the ATMEL High end LCD
> controller found in the SAMA5 familly. It's based on the tilcdc driver.
> It uses the cma_helper for memory and fbdev stuff.
> Your comments are welcome !
I applied your and Robert's patches on a 3.15-rc2 kernel and tried the
framebuffer device on the sama5d31-ek. Seems to work.

> Supported features:
> * the base layer (the main framebuffer)
Tested to show a little tux png, but it's appearing only after 
'echo 0 > /sys/devices/ahb.1/apb.2/f003.hlcdc/graphics/fb0/rotate'
is there missing some initializing?

> * a simple panel
> * a backlight driver
Tested to set brightness to 0, 20 and 255. Works.

Thanks for your work.

Best Regards
Tim

> * structure to 'easily' add other connectors (it comes from the tilcdc)
> 
> On the todo list:
> * support overlays as drm_planes
> * support for the hardware cursor
> * support for the SiI9022 HDMI connector (present on sama5d36ek)
> 
> 
> Jean-Jacques Hiblot (3):
>   atmel: drm: added drm driver for the atmel hlcd controller
>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
> 
>  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
>  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
>  drivers/gpu/drm/Kconfig|   2 +
>  drivers/gpu/drm/Makefile   |   1 +
>  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
>  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
> +
>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
>  15 files changed, 3042 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
> 
> --
> 1.9.1
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-18 Thread Boris BREZILLON
Hi JJ,

On 18/04/2014 11:45, Jean-Jacques Hiblot wrote:
> Hi,
>
> this patch serie implements a simple DRM driver for the ATMEL High end LCD
> controller found in the SAMA5 familly. It's based on the tilcdc driver.
> It uses the cma_helper for memory and fbdev stuff.
> Your comments are welcome !

Thanks for you work.

As I already told you, I started to work on a DRM/KMS driver for the
hlcdc too, and I'd be pleased to help you on this driver (either by
adding the missing stuff, debugging or reworking some parts).

Regarding the code itself, I only had a quick look, but I'll try to
review it next week. Anyway, I might not be the best person to give
advice on a DRM/KMS driver :-).

BTW, I tried to boot a kernel with your driver (statically compiled),
and it hangs (see http://pastebin.com/H24KpVHb). But I didn't have time
for further debugging.

Best Regards,

Boris
>
>
> Supported features:
> * the base layer (the main framebuffer)
> * a simple panel
> * a backlight driver
> * structure to 'easily' add other connectors (it comes from the tilcdc)
>
> On the todo list:
> * support overlays as drm_planes
> * support for the hardware cursor
> * support for the SiI9022 HDMI connector (present on sama5d36ek)
>
>
> Jean-Jacques Hiblot (3):
>   atmel: drm: added drm driver for the atmel hlcd controller
>   atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
>   atmel: dt: Add supports for the lcdc support on the sama5d36ek
>
>  arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
>  arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
>  drivers/gpu/drm/Kconfig|   2 +
>  drivers/gpu/drm/Makefile   |   1 +
>  drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
>  drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 
> +
>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
>  .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
>  drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
>  15 files changed, 3042 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
>  create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h
>
> --
> 1.9.1
>

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



[RFC 0/3] DRM driver for the ATMEL High end LCD controller

2014-04-18 Thread Jean-Jacques Hiblot
Hi,

this patch serie implements a simple DRM driver for the ATMEL High end LCD
controller found in the SAMA5 familly. It's based on the tilcdc driver.
It uses the cma_helper for memory and fbdev stuff.
Your comments are welcome !


Supported features:
* the base layer (the main framebuffer)
* a simple panel
* a backlight driver
* structure to 'easily' add other connectors (it comes from the tilcdc)

On the todo list:
* support overlays as drm_planes
* support for the hardware cursor
* support for the SiI9022 HDMI connector (present on sama5d36ek)


Jean-Jacques Hiblot (3):
  atmel: drm: added drm driver for the atmel hlcd controller
  atmel: drm: dt: Added DT entry for the atmel hlcdc found in the sama5
  atmel: dt: Add supports for the lcdc support on the sama5d36ek

 arch/arm/boot/dts/sama5d36ek.dts   |  27 +-
 arch/arm/boot/dts/sama5d3_lcd.dtsi |  11 +
 drivers/gpu/drm/Kconfig|   2 +
 drivers/gpu/drm/Makefile   |   1 +
 drivers/gpu/drm/atmel_hlcdc/Kconfig|  13 +
 drivers/gpu/drm/atmel_hlcdc/Makefile   |  12 +
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h  | 771 +
 .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c|  92 +++
 .../gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h|  25 +
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c | 702 +++
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c  | 586 
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h  | 124 
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h  | 190 +
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c| 459 
 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h|  28 +
 15 files changed, 3042 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/Kconfig
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/Makefile
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc.h
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.c
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_backlight.h
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_crtc.c
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.c
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_drv.h
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_ovl.h
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.c
 create mode 100644 drivers/gpu/drm/atmel_hlcdc/atmel_hlcdc_panel.h

--
1.9.1