Re: [RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove

2024-05-06 Thread Linus Walleij 
On Fri, May 3, 2024 at 11:38 PM Douglas Anderson  wrote:

> It's the responsibility of a correctly written DRM modeset driver to
> call drm_atomic_helper_shutdown() at shutdown time and that should be
> disabling / unpreparing the panel if needed. Panel drivers shouldn't
> be calling these functions themselves.
>
> A recent effort was made to fix as many DRM modeset drivers as
> possible [1] [2] [3] and most drivers are fixed now.
>
> A grep through mainline for compatible strings used by this driver
> indicates that it is used by TI OMAP boards. The TI OMAP driver
> appears to be correctly calling drm_atomic_helper_shutdown() so we can
> remove the calls.
>
> [1] https://lore.kernel.org/r/20230901234015.566018-1-diand...@chromium.org
> [2] https://lore.kernel.org/r/20230901234202.566951-1-diand...@chromium.org
> [3] https://lore.kernel.org/r/20230921192749.1542462-1-diand...@chromium.org
>
> Cc: Laurent Pinchart 
> Cc: Sebastian Reichel 
> Signed-off-by: Douglas Anderson 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij

Re: [RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove

2024-05-06 Thread Linus Walleij 
On Fri, May 3, 2024 at 11:38 PM Douglas Anderson  wrote:

> It's the responsibility of a correctly written DRM modeset driver to
> call drm_atomic_helper_shutdown() at shutdown time and that should be
> disabling / unpreparing the panel if needed. Panel drivers shouldn't
> be calling these functions themselves.
>
> A recent effort was made to fix as many DRM modeset drivers as
> possible [1] [2] [3] and most drivers are fixed now.
>
> A grep through mainline for compatible strings used by this driver
> indicates that it is used by TI OMAP boards. The TI OMAP driver
> appears to be correctly calling drm_atomic_helper_shutdown() so we can
> remove the calls.
>
> [1] https://lore.kernel.org/r/20230901234015.566018-1-diand...@chromium.org
> [2] https://lore.kernel.org/r/20230901234202.566951-1-diand...@chromium.org
> [3] https://lore.kernel.org/r/20230921192749.1542462-1-diand...@chromium.org
>
> Cc: Laurent Pinchart 
> Cc: Sebastian Reichel 
> Signed-off-by: Douglas Anderson

[RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove

2024-05-03 Thread Douglas Anderson 
It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by TI OMAP boards. The TI OMAP driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-diand...@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-diand...@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-diand...@chromium.org

Cc: Laurent Pinchart 
Cc: Sebastian Reichel 
Signed-off-by: Douglas Anderson 
---

Changes in v2:
- Split removal of prepared/enabled from handling of remove/shutdown.

 drivers/gpu/drm/panel/panel-sony-acx565akm.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c 
b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
index a9a545a56404..73ba93ff00fe 100644
--- a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
+++ b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
@@ -652,9 +652,6 @@ static void acx565akm_remove(struct spi_device *spi)
 
if (lcd->has_bc)
acx565akm_backlight_cleanup(lcd);
-
-   drm_panel_disable(>panel);
-   drm_panel_unprepare(>panel);
 }
 
 static const struct of_device_id acx565akm_of_match[] = {
-- 
2.45.0.rc1.225.g2a3ae87e7f-goog