Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
On Tue, Nov 12, 2019 at 01:10:13PM +0100, Torsten Duwe wrote: > On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote: > > Hi Thorsten, > > > > On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote: > > > > > >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field > > > 'bridge' has incomplete type > > > struct drm_bridge bridge; > > >^~ > > >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field > > > 'link' has incomplete type > > > struct drm_dp_link link; > > > ^~~~ > > > > It looks like you didn't compile your driver after rebasing. > > FWIW I compiled and ran the rebased series, based on 5.4-rc6 + 025910db8. > Who needs stable in-kernel interfaces anyway :-/ So that's what you did? Yet you were saying that this was tested on top of drm-misc-next and linux-next... > > The first error here is pretty trivial (missing drm_bridge.h include), > > but the second one is there becaus the DP link helpers you rely on > > have been removed. > > > > Can you send a patch to fix this? Otherwise, we can just revert the > > offending patch. > > https://patchwork.freedesktop.org/series/68031/ passed me by unnoticed; > I wonder why I Cc'ed Thierry on every single patch? A simple heads-up would > have sufficed. > > Now that I have that series, I'm confident I can update the anx6345 driver > accordingly. Thanks Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
Hi Thorsten, On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote: > tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > head: 6aa192698089b450b06d609355fc9c82c07856d2 > commit: 6aa192698089b450b06d609355fc9c82c07856d2 [5/5] drm/bridge: Add > Analogix anx6345 support > config: i386-randconfig-h004-201945 (attached as .config) > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 > reproduce: > git checkout 6aa192698089b450b06d609355fc9c82c07856d2 > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field > 'bridge' has incomplete type > struct drm_bridge bridge; >^~ >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field > 'link' has incomplete type > struct drm_dp_link link; > ^~~~ It looks like you didn't compile your driver after rebasing. The first error here is pretty trivial (missing drm_bridge.h include), but the second one is there becaus the DP link helpers you rely on have been removed. Can you send a patch to fix this? Otherwise, we can just revert the offending patch. Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote: > Hi Thorsten, > > On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote: > > > >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field > > 'bridge' has incomplete type > > struct drm_bridge bridge; > >^~ > >drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field > > 'link' has incomplete type > > struct drm_dp_link link; > > ^~~~ > > It looks like you didn't compile your driver after rebasing. FWIW I compiled and ran the rebased series, based on 5.4-rc6 + 025910db8. Who needs stable in-kernel interfaces anyway :-/ > The first error here is pretty trivial (missing drm_bridge.h include), > but the second one is there becaus the DP link helpers you rely on > have been removed. > > Can you send a patch to fix this? Otherwise, we can just revert the > offending patch. https://patchwork.freedesktop.org/series/68031/ passed me by unnoticed; I wonder why I Cc'ed Thierry on every single patch? A simple heads-up would have sufficed. Now that I have that series, I'm confident I can update the anx6345 driver accordingly. Stay tuned... Torsten ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
