Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits
On Fri, Jun 21, 2019 at 2:51 AM Jagan Teki wrote: > > On Tue, Jun 18, 2019 at 8:15 PM Chen-Yu Tsai wrote: > > > > On Tue, Jun 18, 2019 at 8:11 PM Jagan Teki > > wrote: > > > > > > On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > > > > > > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki > > > > wrote: > > > > > > > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > > > > wrote: > > > > > > > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > > > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > > > > > wrote: > > > > > > > > > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > > > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > > > > > > > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki > > > > > > > > > > > > wrote: > > > > > > > > > > > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan > > > > > > > > > > > > > > Teki wrote: > > > > > > > > > > > > > > > According to "DRM kernel-internal display mode > > > > > > > > > > > > > > > structure" in > > > > > > > > > > > > > > > include/drm/drm_modes.h the current driver is > > > > > > > > > > > > > > > trying to include > > > > > > > > > > > > > > > sync timings along with front porch value while > > > > > > > > > > > > > > > checking and > > > > > > > > > > > > > > > computing drq set bits in non-burst mode. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > mode->hsync_end - mode->hdisplay => horizontal > > > > > > > > > > > > > > > front porch + sync > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > With adding additional sync timings, the dsi > > > > > > > > > > > > > > > controller leads to > > > > > > > > > > > > > > > wrong drq set bits for "bananapi,s070wv20-ct16" > > > > > > > > > > > > > > > panel which indeed > > > > > > > > > > > > > > > trigger panel flip_done timed out as: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at > > > > > > > > > > > > > > > drivers/gpu/drm/drm_atomic_helper.c:1429 > > > > > > > > > > > > > > > drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > > > > > > > > Modules linked in: > > > > > > > > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > > > > > > > > > > > > > > > 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > > > > > > > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > > > > > > > > [] (unwind_backtrace) from > > > > > > > > > > > > > > > [] (show_stack+0x10/0x14) > > > > > > > > > > > > > > > [] (show_stack) from [] > > > > > > > > > > > > > > > (dump_stack+0x84/0x98) > > > > > > > > > > > > > > > [] (dump_stack) from [] > > > > > > > > > > > > > > > (__warn+0xfc/0x114) > > > > > > > > > > > > > > > [] (__warn) from [] > > > > > > > > > > > > > > > (warn_slowpath_fmt+0x44/0x68) > > > > > > > > > > > > > > > [] (warn_slowpath_fmt) from > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1) from > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) > > > > > > > > > > > > > > > from [] (commit_tail+0x40/0x6c) > > > > > > > > > > > > > > > [] (commit_tail) from [] > > > > > > > > > > > > > > > (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > > > > > > > > [] (drm_atomic_helper_commit) from > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > > > > > > > > [] (restore_fbdev_mode_atomic) from > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked) from > > > > > > > > > > > > > > > [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > > > > > > > > [] (drm_fb_helper_set_par) from > > > > > > > > > > > > > > > [] (fbcon_init+0x560/0x5ac) > > > > > > > > > > > > > > > [] (fbcon_init) from [] > > > > > > > > > > > > > > > (visual_init+0xbc/0x104) > > > > > > > > > > > > > > > [] (visual_init) from [] > > > > > > > > > > > > > > > (do_bind_con_driver+0x1b0/0x390) > > > > > > > > > > > > > > > [] (do_bind_con_driver) f
Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits
On Tue, Jun 18, 2019 at 8:15 PM Chen-Yu Tsai wrote: > > On Tue, Jun 18, 2019 at 8:11 PM Jagan Teki wrote: > > > > On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > > > > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki > > > wrote: > > > > > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > > > wrote: > > > > > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > > > > wrote: > > > > > > > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > > > > > > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki > > > > > > > > > > > wrote: > > > > > > > > > > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > According to "DRM kernel-internal display mode > > > > > > > > > > > > > > structure" in > > > > > > > > > > > > > > include/drm/drm_modes.h the current driver is > > > > > > > > > > > > > > trying to include > > > > > > > > > > > > > > sync timings along with front porch value while > > > > > > > > > > > > > > checking and > > > > > > > > > > > > > > computing drq set bits in non-burst mode. > > > > > > > > > > > > > > > > > > > > > > > > > > > > mode->hsync_end - mode->hdisplay => horizontal > > > > > > > > > > > > > > front porch + sync > > > > > > > > > > > > > > > > > > > > > > > > > > > > With adding additional sync timings, the dsi > > > > > > > > > > > > > > controller leads to > > > > > > > > > > > > > > wrong drq set bits for "bananapi,s070wv20-ct16" > > > > > > > > > > > > > > panel which indeed > > > > > > > > > > > > > > trigger panel flip_done timed out as: > > > > > > > > > > > > > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at > > > > > > > > > > > > > > drivers/gpu/drm/drm_atomic_helper.c:1429 > > > > > > > > > > > > > > drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > > > > > > > Modules linked in: > > > > > > > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > > > > > > > > > > > > > > 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > > > > > > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > > > > > > > [] (unwind_backtrace) from [] > > > > > > > > > > > > > > (show_stack+0x10/0x14) > > > > > > > > > > > > > > [] (show_stack) from [] > > > > > > > > > > > > > > (dump_stack+0x84/0x98) > > > > > > > > > > > > > > [] (dump_stack) from [] > > > > > > > > > > > > > > (__warn+0xfc/0x114) > > > > > > > > > > > > > > [] (__warn) from [] > > > > > > > > > > > > > > (warn_slowpath_fmt+0x44/0x68) > > > > > > > > > > > > > > [] (warn_slowpath_fmt) from [] > > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1) from > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) > > > > > > > > > > > > > > from [] (commit_tail+0x40/0x6c) > > > > > > > > > > > > > > [] (commit_tail) from [] > > > > > > > > > > > > > > (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > > > > > > > [] (drm_atomic_helper_commit) from > > > > > > > > > > > > > > [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > > > > > > > [] (restore_fbdev_mode_atomic) from > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > > > > > > > [] > > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked) from > > > > > > > > > > > > > > [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > > > > > > > [] (drm_fb_helper_set_par) from > > > > > > > > > > > > > > [] (fbcon_init+0x560/0x5ac) > > > > > > > > > > > > > > [] (fbcon_init) from [] > > > > > > > > > > > > > > (visual_init+0xbc/0x104) > > > > > > > > > > > > > > [] (visual_init) from [] > > > > > > > > > > > > > > (do_bind_con_driver+0x1b0/0x390) > > > > > > > > > > > > > > [] (do_bind_con_driver) from > > > > > > > > > > > > > > [] (do_take_over_console+0x13c/0x1c4) > > > > > > > > > > > > > > [] (do_take_over_console) from > > > > > > > > > > > > > > [] (do_fbcon_takeover+0x74/0xcc) > > > > > > > > > > > > > > [] (do_fbcon_takeover) from [] > > > > > > > > > > > > > > (notifier_call_cha
Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits
On Tue, Jun 18, 2019 at 8:11 PM Jagan Teki wrote: > > On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki > > wrote: > > > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > > wrote: > > > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > > > wrote: > > > > > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > > > > > wrote: > > > > > > > > > > > > > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > > > > > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > > > > > > > > > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki > > > > > > > > > > > > wrote: > > > > > > > > > > > > > According to "DRM kernel-internal display mode > > > > > > > > > > > > > structure" in > > > > > > > > > > > > > include/drm/drm_modes.h the current driver is trying > > > > > > > > > > > > > to include > > > > > > > > > > > > > sync timings along with front porch value while > > > > > > > > > > > > > checking and > > > > > > > > > > > > > computing drq set bits in non-burst mode. > > > > > > > > > > > > > > > > > > > > > > > > > > mode->hsync_end - mode->hdisplay => horizontal front > > > > > > > > > > > > > porch + sync > > > > > > > > > > > > > > > > > > > > > > > > > > With adding additional sync timings, the dsi > > > > > > > > > > > > > controller leads to > > > > > > > > > > > > > wrong drq set bits for "bananapi,s070wv20-ct16" panel > > > > > > > > > > > > > which indeed > > > > > > > > > > > > > trigger panel flip_done timed out as: > > > > > > > > > > > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at > > > > > > > > > > > > > drivers/gpu/drm/drm_atomic_helper.c:1429 > > > > > > > > > > > > > drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > > > > > > Modules linked in: > > > > > > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > > > > > > > > > > > > > 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > > > > > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > > > > > > [] (unwind_backtrace) from [] > > > > > > > > > > > > > (show_stack+0x10/0x14) > > > > > > > > > > > > > [] (show_stack) from [] > > > > > > > > > > > > > (dump_stack+0x84/0x98) > > > > > > > > > > > > > [] (dump_stack) from [] > > > > > > > > > > > > > (__warn+0xfc/0x114) > > > > > > > > > > > > > [] (__warn) from [] > > > > > > > > > > > > > (warn_slowpath_fmt+0x44/0x68) > > > > > > > > > > > > > [] (warn_slowpath_fmt) from [] > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > > > > > > [] > > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1) from > > > > > > > > > > > > > [] > > > > > > > > > > > > > (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) > > > > > > > > > > > > > from [] (commit_tail+0x40/0x6c) > > > > > > > > > > > > > [] (commit_tail) from [] > > > > > > > > > > > > > (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > > > > > > [] (drm_atomic_helper_commit) from > > > > > > > > > > > > > [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > > > > > > [] (restore_fbdev_mode_atomic) from > > > > > > > > > > > > > [] > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > > > > > > [] > > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked) from > > > > > > > > > > > > > [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > > > > > > [] (drm_fb_helper_set_par) from > > > > > > > > > > > > > [] (fbcon_init+0x560/0x5ac) > > > > > > > > > > > > > [] (fbcon_init) from [] > > > > > > > > > > > > > (visual_init+0xbc/0x104) > > > > > > > > > > > > > [] (visual_init) from [] > > > > > > > > > > > > > (do_bind_con_driver+0x1b0/0x390) > > > > > > > > > > > > > [] (do_bind_con_driver) from [] > > > > > > > > > > > > > (do_take_over_console+0x13c/0x1c4) > > > > > > > > > > > > > [] (do_take_over_console) from > > > > > > > > > > > > > [] (do_fbcon_takeover+0x74/0xcc) > > > > > > > > > > > > > [] (do_fbcon_takeover) from [] > > > > > > > > > > > > > (notifier_call_chain+0x44/0x84) > > > > > > > > > > > > > [] (notifier_call_chain) from [] > > > > > > > > > > > > > (__blocking_notifier_call_chain+0x48/0x60) > > > > > > > > > > > > > [] (__blocking_notifier_call_chain) from > > > > > > > > > > > > > [] (blocking_notifier_c
Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits
On Tue, Jun 18, 2019 at 5:13 PM Chen-Yu Tsai wrote: > > On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki wrote: > > > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > > wrote: > > > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > > wrote: > > > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > > > > wrote: > > > > > > > > > > > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > > > > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > > > > > > > > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki > > > > > > > > > > > wrote: > > > > > > > > > > > > According to "DRM kernel-internal display mode > > > > > > > > > > > > structure" in > > > > > > > > > > > > include/drm/drm_modes.h the current driver is trying to > > > > > > > > > > > > include > > > > > > > > > > > > sync timings along with front porch value while > > > > > > > > > > > > checking and > > > > > > > > > > > > computing drq set bits in non-burst mode. > > > > > > > > > > > > > > > > > > > > > > > > mode->hsync_end - mode->hdisplay => horizontal front > > > > > > > > > > > > porch + sync > > > > > > > > > > > > > > > > > > > > > > > > With adding additional sync timings, the dsi controller > > > > > > > > > > > > leads to > > > > > > > > > > > > wrong drq set bits for "bananapi,s070wv20-ct16" panel > > > > > > > > > > > > which indeed > > > > > > > > > > > > trigger panel flip_done timed out as: > > > > > > > > > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at > > > > > > > > > > > > drivers/gpu/drm/drm_atomic_helper.c:1429 > > > > > > > > > > > > drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > > > > > Modules linked in: > > > > > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > > > > > > > > > > > > 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > > > > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > > > > > [] (unwind_backtrace) from [] > > > > > > > > > > > > (show_stack+0x10/0x14) > > > > > > > > > > > > [] (show_stack) from [] > > > > > > > > > > > > (dump_stack+0x84/0x98) > > > > > > > > > > > > [] (dump_stack) from [] > > > > > > > > > > > > (__warn+0xfc/0x114) > > > > > > > > > > > > [] (__warn) from [] > > > > > > > > > > > > (warn_slowpath_fmt+0x44/0x68) > > > > > > > > > > > > [] (warn_slowpath_fmt) from [] > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > > > > > [] > > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1) from > > > > > > > > > > > > [] > > > > > > > > > > > > (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) from > > > > > > > > > > > > [] (commit_tail+0x40/0x6c) > > > > > > > > > > > > [] (commit_tail) from [] > > > > > > > > > > > > (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > > > > > [] (drm_atomic_helper_commit) from > > > > > > > > > > > > [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > > > > > [] (restore_fbdev_mode_atomic) from > > > > > > > > > > > > [] > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > > > > > [] > > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked) from > > > > > > > > > > > > [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > > > > > [] (drm_fb_helper_set_par) from [] > > > > > > > > > > > > (fbcon_init+0x560/0x5ac) > > > > > > > > > > > > [] (fbcon_init) from [] > > > > > > > > > > > > (visual_init+0xbc/0x104) > > > > > > > > > > > > [] (visual_init) from [] > > > > > > > > > > > > (do_bind_con_driver+0x1b0/0x390) > > > > > > > > > > > > [] (do_bind_con_driver) from [] > > > > > > > > > > > > (do_take_over_console+0x13c/0x1c4) > > > > > > > > > > > > [] (do_take_over_console) from [] > > > > > > > > > > > > (do_fbcon_takeover+0x74/0xcc) > > > > > > > > > > > > [] (do_fbcon_takeover) from [] > > > > > > > > > > > > (notifier_call_chain+0x44/0x84) > > > > > > > > > > > > [] (notifier_call_chain) from [] > > > > > > > > > > > > (__blocking_notifier_call_chain+0x48/0x60) > > > > > > > > > > > > [] (__blocking_notifier_call_chain) from > > > > > > > > > > > > [] (blocking_notifier_call_chain+0x18/0x20) > > > > > > > > > > > > [] (blocking_notifier_call_chain) from > > > > > > > > > > > > [] (register_framebuffer+0x1e0/0x2f8) > > > > > > > > > > > > [] (register_framebuffer) from [] > > > > > > > > > > > > (__drm_fb_he
Re: [linux-sunxi] Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits
On Tue, Jun 18, 2019 at 6:51 PM Jagan Teki wrote: > > On Fri, Jun 14, 2019 at 8:15 PM Maxime Ripard > wrote: > > > > On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > > > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > > > wrote: > > > > > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > > > wrote: > > > > > > > > > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > > > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > > > > > wrote: > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > > > > > > > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki wrote: > > > > > > > > > > > According to "DRM kernel-internal display mode structure" > > > > > > > > > > > in > > > > > > > > > > > include/drm/drm_modes.h the current driver is trying to > > > > > > > > > > > include > > > > > > > > > > > sync timings along with front porch value while checking > > > > > > > > > > > and > > > > > > > > > > > computing drq set bits in non-burst mode. > > > > > > > > > > > > > > > > > > > > > > mode->hsync_end - mode->hdisplay => horizontal front > > > > > > > > > > > porch + sync > > > > > > > > > > > > > > > > > > > > > > With adding additional sync timings, the dsi controller > > > > > > > > > > > leads to > > > > > > > > > > > wrong drq set bits for "bananapi,s070wv20-ct16" panel > > > > > > > > > > > which indeed > > > > > > > > > > > trigger panel flip_done timed out as: > > > > > > > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at > > > > > > > > > > > drivers/gpu/drm/drm_atomic_helper.c:1429 > > > > > > > > > > > drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > > > > Modules linked in: > > > > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted > > > > > > > > > > > 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > > > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > > > > [] (unwind_backtrace) from [] > > > > > > > > > > > (show_stack+0x10/0x14) > > > > > > > > > > > [] (show_stack) from [] > > > > > > > > > > > (dump_stack+0x84/0x98) > > > > > > > > > > > [] (dump_stack) from [] > > > > > > > > > > > (__warn+0xfc/0x114) > > > > > > > > > > > [] (__warn) from [] > > > > > > > > > > > (warn_slowpath_fmt+0x44/0x68) > > > > > > > > > > > [] (warn_slowpath_fmt) from [] > > > > > > > > > > > (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) > > > > > > > > > > > from [] > > > > > > > > > > > (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) from > > > > > > > > > > > [] (commit_tail+0x40/0x6c) > > > > > > > > > > > [] (commit_tail) from [] > > > > > > > > > > > (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > > > > [] (drm_atomic_helper_commit) from > > > > > > > > > > > [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > > > > [] (restore_fbdev_mode_atomic) from > > > > > > > > > > > [] > > > > > > > > > > > (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > > > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) > > > > > > > > > > > from [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > > > > [] (drm_fb_helper_set_par) from [] > > > > > > > > > > > (fbcon_init+0x560/0x5ac) > > > > > > > > > > > [] (fbcon_init) from [] > > > > > > > > > > > (visual_init+0xbc/0x104) > > > > > > > > > > > [] (visual_init) from [] > > > > > > > > > > > (do_bind_con_driver+0x1b0/0x390) > > > > > > > > > > > [] (do_bind_con_driver) from [] > > > > > > > > > > > (do_take_over_console+0x13c/0x1c4) > > > > > > > > > > > [] (do_take_over_console) from [] > > > > > > > > > > > (do_fbcon_takeover+0x74/0xcc) > > > > > > > > > > > [] (do_fbcon_takeover) from [] > > > > > > > > > > > (notifier_call_chain+0x44/0x84) > > > > > > > > > > > [] (notifier_call_chain) from [] > > > > > > > > > > > (__blocking_notifier_call_chain+0x48/0x60) > > > > > > > > > > > [] (__blocking_notifier_call_chain) from > > > > > > > > > > > [] (blocking_notifier_call_chain+0x18/0x20) > > > > > > > > > > > [] (blocking_notifier_call_chain) from > > > > > > > > > > > [] (register_framebuffer+0x1e0/0x2f8) > > > > > > > > > > > [] (register_framebuffer) from [] > > > > > > > > > > > (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > > > > > > > > [] (__drm_fb_helper_initial_config_and_unlock) > > > > > > > > > > > from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > > > > > > > > [] (drm_fbdev_client_hotplug) from > > > > > > > > > > > [] (drm_fbdev_generic_setup+0x88/0x118) > > > >
