Re: [patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
On Sat, Sep 28, 2013 at 6:17 AM, Dan Carpenter wrote: > The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". > > Signed-off-by: Dan Carpenter > Acked-by: Maarten Lankhorst > --- > Somehow this wasn't applied when I sent it earlier. Sorry about this slipping through the cracks. It's in my tree now, so it'll make it to Dave at some point. Thanks, Ben. > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > b/drivers/gpu/drm/nouveau/nouveau_drm.c > index c95decf..e11f8e4 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) > struct nouveau_drm *drm = nouveau_drm(dev); > struct nouveau_disp *pdisp = nouveau_disp(drm->device); > > - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) > + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) > return -EIO; > WARN_ON_ONCE(drm->vblank[head].func); > drm->vblank[head].func = nouveau_drm_vblank_handler; > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". Signed-off-by: Dan Carpenter Acked-by: Maarten Lankhorst --- Somehow this wasn't applied when I sent it earlier. diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index c95decf..e11f8e4 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) struct nouveau_drm *drm = nouveau_drm(dev); struct nouveau_disp *pdisp = nouveau_disp(drm->device); - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) return -EIO; WARN_ON_ONCE(drm->vblank[head].func); drm->vblank[head].func = nouveau_drm_vblank_handler; ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
On Wed, Apr 03, 2013 at 01:33:09PM +0200, Maarten Lankhorst wrote: > Op 03-04-13 10:05, Dan Carpenter schreef: > > The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". > > > > Signed-off-by: Dan Carpenter > Acked-by: Maarten Lankhorst We still need this patch in linux-next. regards, dan carpenter
Re: [patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
On Wed, Apr 03, 2013 at 01:33:09PM +0200, Maarten Lankhorst wrote: > Op 03-04-13 10:05, Dan Carpenter schreef: > > The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". > > > > Signed-off-by: Dan Carpenter > Acked-by: Maarten Lankhorst We still need this patch in linux-next. regards, dan carpenter ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
Op 03-04-13 10:05, Dan Carpenter schreef: > The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". > > Signed-off-by: Dan Carpenter Acked-by: Maarten Lankhorst > --- > This was introduced in git://git.freedesktop.org/git/nouveau/linux-2.6 > drm-nouveau-fixes-3.9 > It hadn't hit linux-next yet yesterday. > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > b/drivers/gpu/drm/nouveau/nouveau_drm.c > index c95decf..e11f8e4 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) > struct nouveau_drm *drm = nouveau_drm(dev); > struct nouveau_disp *pdisp = nouveau_disp(drm->device); > > - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) > + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) > return -EIO; > WARN_ON_ONCE(drm->vblank[head].func); > drm->vblank[head].func = nouveau_drm_vblank_handler; >
[patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". Signed-off-by: Dan Carpenter --- This was introduced in git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-fixes-3.9 It hadn't hit linux-next yet yesterday. diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index c95decf..e11f8e4 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) struct nouveau_drm *drm = nouveau_drm(dev); struct nouveau_disp *pdisp = nouveau_disp(drm->device); - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) return -EIO; WARN_ON_ONCE(drm->vblank[head].func); drm->vblank[head].func = nouveau_drm_vblank_handler;
Re: [patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
Op 03-04-13 10:05, Dan Carpenter schreef: > The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". > > Signed-off-by: Dan Carpenter Acked-by: Maarten Lankhorst > --- > This was introduced in git://git.freedesktop.org/git/nouveau/linux-2.6 > drm-nouveau-fixes-3.9 > It hadn't hit linux-next yet yesterday. > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > b/drivers/gpu/drm/nouveau/nouveau_drm.c > index c95decf..e11f8e4 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) > struct nouveau_drm *drm = nouveau_drm(dev); > struct nouveau_disp *pdisp = nouveau_disp(drm->device); > > - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) > + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) > return -EIO; > WARN_ON_ONCE(drm->vblank[head].func); > drm->vblank[head].func = nouveau_drm_vblank_handler; > ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[patch] drm/nouveau: off by one in nouveau_drm_vblank_enable()
The test here should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()". Signed-off-by: Dan Carpenter --- This was introduced in git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-fixes-3.9 It hadn't hit linux-next yet yesterday. diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index c95decf..e11f8e4 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -86,7 +86,7 @@ nouveau_drm_vblank_enable(struct drm_device *dev, int head) struct nouveau_drm *drm = nouveau_drm(dev); struct nouveau_disp *pdisp = nouveau_disp(drm->device); - if (WARN_ON_ONCE(head > ARRAY_SIZE(drm->vblank))) + if (WARN_ON_ONCE(head >= ARRAY_SIZE(drm->vblank))) return -EIO; WARN_ON_ONCE(drm->vblank[head].func); drm->vblank[head].func = nouveau_drm_vblank_handler; ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
