[patch] drm/rockchip: inno_hdmi: fix an error code
On 2016å¹´04æ21æ¥ 22:03, Dan Carpenter wrote: > On Fri, Feb 26, 2016 at 02:26:23PM +0800, Yakir Yang wrote: >> Dan, >> >> On 02/26/2016 05:30 AM, Dan Carpenter wrote: >>> We were accidentally returning PTR_ERR(NULL) which means success when we >>> wanted to return a negative error code. >>> >>> Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') >>> Signed-off-by: Dan Carpenter >> Reviewed-by: Yakir Yang > We still need to apply this. > > regards, > dan carpenter > > > > Oh, Sorry, Miss this patch. Applied to my drm-fixes. Thanks. -- ï¼ark Yao
[patch] drm/rockchip: inno_hdmi: fix an error code
On Fri, Feb 26, 2016 at 02:26:23PM +0800, Yakir Yang wrote: > Dan, > > On 02/26/2016 05:30 AM, Dan Carpenter wrote: > >We were accidentally returning PTR_ERR(NULL) which means success when we > >wanted to return a negative error code. > > > >Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') > >Signed-off-by: Dan Carpenter > Reviewed-by: Yakir Yang We still need to apply this. regards, dan carpenter
[patch] drm/rockchip: inno_hdmi: fix an error code
Dan, On 02/26/2016 05:30 AM, Dan Carpenter wrote: > We were accidentally returning PTR_ERR(NULL) which means success when we > wanted to return a negative error code. > > Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') > Signed-off-by: Dan Carpenter Reviewed-by: Yakir Yang Thanks, - Yakir > diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c > b/drivers/gpu/drm/rockchip/inno_hdmi.c > index 10d62ff..f252441 100644 > --- a/drivers/gpu/drm/rockchip/inno_hdmi.c > +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c > @@ -855,8 +855,9 @@ static int inno_hdmi_bind(struct device *dev, struct > device *master, > > hdmi->ddc = inno_hdmi_i2c_adapter(hdmi); > if (IS_ERR(hdmi->ddc)) { > + ret = PTR_ERR(hdmi->ddc); > hdmi->ddc = NULL; > - return PTR_ERR(hdmi->ddc); > + return ret; > } > > /* > > >
[patch] drm/rockchip: inno_hdmi: fix an error code
We were accidentally returning PTR_ERR(NULL) which means success when we wanted to return a negative error code. Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 10d62ff..f252441 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -855,8 +855,9 @@ static int inno_hdmi_bind(struct device *dev, struct device *master, hdmi->ddc = inno_hdmi_i2c_adapter(hdmi); if (IS_ERR(hdmi->ddc)) { + ret = PTR_ERR(hdmi->ddc); hdmi->ddc = NULL; - return PTR_ERR(hdmi->ddc); + return ret; } /*