Re: [patch] drm/udl: unlock before returning in udl_gem_mmap()

2012-05-25 Thread Dan Carpenter 
On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote:
 If we hit an error here, then we should unlock and unreference obj
 before returning.
 

This is still present in linux-next.

regards,
dan carpenter

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
 
 diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
 index 852642d..6de6130 100644
 --- a/drivers/gpu/drm/udl/udl_gem.c
 +++ b/drivers/gpu/drm/udl/udl_gem.c
 @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device 
 *dev,
  
   ret = udl_gem_get_pages(gobj, GFP_KERNEL);
   if (ret)
 - return ret;
 + goto out;
   if (!gobj-base.map_list.map) {
   ret = drm_gem_create_mmap_offset(obj);
   if (ret)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[patch] drm/udl: unlock before returning in udl_gem_mmap()

2012-05-24 Thread Dan Carpenter 
On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote:
> If we hit an error here, then we should unlock and unreference obj
> before returning.
> 

This is still present in linux-next.

regards,
dan carpenter

> Signed-off-by: Dan Carpenter 
> 
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index 852642d..6de6130 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device 
> *dev,
>  
>   ret = udl_gem_get_pages(gobj, GFP_KERNEL);
>   if (ret)
> - return ret;
> + goto out;
>   if (!gobj->base.map_list.map) {
>   ret = drm_gem_create_mmap_offset(obj);
>   if (ret)

[patch] drm/udl: unlock before returning in udl_gem_mmap()

2012-03-22 Thread Dan Carpenter 
If we hit an error here, then we should unlock and unreference obj
before returning.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index 852642d..6de6130 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device 
*dev,

ret = udl_gem_get_pages(gobj, GFP_KERNEL);
if (ret)
-   return ret;
+   goto out;
if (!gobj->base.map_list.map) {
ret = drm_gem_create_mmap_offset(obj);
if (ret)

[patch] drm/udl: unlock before returning in udl_gem_mmap()

2012-03-22 Thread Dan Carpenter 
If we hit an error here, then we should unlock and unreference obj
before returning.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index 852642d..6de6130 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device 
*dev,
 
ret = udl_gem_get_pages(gobj, GFP_KERNEL);
if (ret)
-   return ret;
+   goto out;
if (!gobj-base.map_list.map) {
ret = drm_gem_create_mmap_offset(obj);
if (ret)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel