Re: [v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
On Fri, 6 Mar 2020 17:06:00 +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem(MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > --- > .../bindings/display/msm/dpu-sc7180.yaml | 269 +++ > .../bindings/display/msm/dpu-sdm845.yaml | 265 +++ > .../bindings/display/msm/dsi-sc7180.yaml | 369 > + > .../bindings/display/msm/dsi-sdm845.yaml | 369 > + > 4 files changed, 1272 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-sdm845.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Documentation/devicetree/bindings/display/msm/dpu-sc7180.example.dts:17:10: fatal error: dt-bindings/clock/qcom,dispcc-sc7180.h: No such file or directory #include ^~~~ compilation terminated. scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/display/msm/dpu-sc7180.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/display/msm/dpu-sc7180.example.dt.yaml] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1250230 Please check and re-submit. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
Hi Krishna. Thanks for these bindings files. On Fri, Mar 06, 2020 at 05:06:00PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem(MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > --- > .../bindings/display/msm/dpu-sc7180.yaml | 269 +++ > .../bindings/display/msm/dpu-sdm845.yaml | 265 +++ > .../bindings/display/msm/dsi-sc7180.yaml | 369 > + > .../bindings/display/msm/dsi-sdm845.yaml | 369 > + > 4 files changed, 1272 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-sdm845.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > new file mode 100644 > index 000..3d1d9b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > @@ -0,0 +1,269 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Description of Qualcomm Display Dpu dt properties. Try to be cossistent in capitilization of Dpu versus DPU > + > +maintainers: > + - Krishna Manikandan > + > +description: | > + Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates > + sub-blocks like DPU display controller, DSI and DP interfaces etc. Device > tree > + bindings of MDSS and DPU are mentioned for SC7180 target. Bindings should use an indent of two spaces. This is what is used in the example schema and the de-facto standard. One space indent makes it very hard to follow the indent. For examples the indent varies. From 2 spaces to 8 spaces. I often use 4 spaces as 2 spaces is not enough when it spans several lines. But there is nothing fixed there. > + > +properties: > + "mdss": > + type: object > + description: | > + Node containing MDSS that encapsulated sub-blocks like DPU, DSI and DP > + interfaces. > + > + properties: > + compatible: > +items: > + - const: qcom,sc7180-mdss > + reg: > +description: | > + Physical base address and length of controller's registers. Add empty line between properties (empty line before reg:). > + > + reg-names: > +description: | > + Names for different register regions defined above. The required region > + is mentioned below. > +items: > + - const: mdss > + > + power-domains: > +description: | > + A power domain consumer specifier according to > + Documentation/devicetree/bindings/power/power_domain.txt. Should this be power-domain.yaml? > + > + clocks: > +description: | > + List of clock specifiers for clocks needed by the device. Do not use "|" unless required. Fine to have text on same line as description: . Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
MSM Mobile Display Subsytem(MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for the device tree bindings for the same. Signed-off-by: Krishna Manikandan --- .../bindings/display/msm/dpu-sc7180.yaml | 269 +++ .../bindings/display/msm/dpu-sdm845.yaml | 265 +++ .../bindings/display/msm/dsi-sc7180.yaml | 369 + .../bindings/display/msm/dsi-sdm845.yaml | 369 + 4 files changed, 1272 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sc7180.yaml create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sdm845.yaml diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml new file mode 100644 index 000..3d1d9b8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml @@ -0,0 +1,269 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Description of Qualcomm Display Dpu dt properties. + +maintainers: + - Krishna Manikandan + +description: | + Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates + sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree + bindings of MDSS and DPU are mentioned for SC7180 target. + +properties: + "mdss": + type: object + description: | + Node containing MDSS that encapsulated sub-blocks like DPU, DSI and DP + interfaces. + + properties: + compatible: +items: + - const: qcom,sc7180-mdss + reg: +description: | + Physical base address and length of controller's registers. + + reg-names: +description: | + Names for different register regions defined above. The required region + is mentioned below. +items: + - const: mdss + + power-domains: +description: | + A power domain consumer specifier according to + Documentation/devicetree/bindings/power/power_domain.txt. + + clocks: +description: | + List of clock specifiers for clocks needed by the device. + + clock-names: +description: | + Device clock names in the same order as mentioned in clocks property. + The required clocks are mentioned below. +items: + - const: iface + - const: bus + - const: ahb + - const: core + + interrupts: +description: | + Interrupt signal from MDSS. + + interrupt-controller: +description: | + Identifies the node as an interrupt controller. + + "#interrupt-cells": +description: | + Specifies the number of cells needed to encode an interrupt source. +const: 1 + + iommus: +description: | + Phandle of iommu device node. + + "#address-cells": +description: | + Indicate how many cells (32 bits values) are needed to form the base + address part in the reg property. + + "#size-cells": +description: | + Indicate how many cells (32 bits values) are needed to specify the size + part in the reg property. + + ranges: +description: | + Parent bus address space is the same as the child bus address space. + + interconnects : +description: | + Interconnect path specifier for MDSS according to + Documentation/devicetree/bindings/interconnect/interconnect.txt. Should be + 2 paths corresponding to 2 AXI ports. + + interconnect-names: +description: | + MDSS will have 2 port names to differentiate between the + 2 interconnect paths defined with interconnect specifier. + + properties: +description: | + Optional properties for MDSS. + + assigned-clocks: + description: | + List of clock specifiers for clocks needing rate assignment. + + assigned-clock-rates: + description: | + List of clock frequencies sorted in the same order as the assigned-clocks + property. + + "mdp": +type: object +description: | + Node containing the properties of DPU. +properties: + compatible: + items: + - const: qcom,sc7180-dpu + + reg: + description: | + Physical base address and length of controller's registers. + + reg-names: + description: | + Register region names. The following regions are required. + items: +- const: mdp +- const: vbif + + clocks: + description: | + List of clock specifiers for clocks needed by the device. + + clock-names: + description: | + Device clock names, must be in same order as clocks property. + The following clocks are required. "bus" is an optional property + in sc7180 due to architecture change. +
