[PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Checking up on this patch from a few months back that I'd like to get
included..  Acked by Daniel Vetter[1] and Reviewed by Jani Nikula[2].
 However ajax has not yet provided comments.  Is this SOL without feedback
from ajax?

[1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html
[2] http://lists.freedesktop.org/archives/dri-devel/2013-April/036829.html


On Mon, Mar 25, 2013 at 5:58 PM, Dylan Semler wrote:

> Changes in this version
>  * rename do_force_quirk_modes() -> do_force_quirk_mode()
>  * use list_for_each_entry() instead of list_for_each_entry_safe() in
>do_force_quirk_mode()
>  * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
>appropriate
>  * remove unused quirks argument from add_force_quirk_modes()
>  * fixes to allow cases of forcing multiple modes
>  * adjusted comments to adhere closer to style guides
>
> Changes in version 3
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
>
> Changes in version 2
>  * none
>
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
>
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
>
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list described above to be
> checked.
>
> The second patch adds the offending monitor to the quirk lists.
>
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+
>
>  drivers/gpu/drm/drm_edid.c | 89
> ++
>  1 file changed, 89 insertions(+)
>
> --
> 1.7.11.7
>
>
-- next part --
An HTML attachment was scrubbed...
URL: 

Re: [PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Checking up on this patch from a few months back that I'd like to get
included..  Acked by Daniel Vetter[1] and Reviewed by Jani Nikula[2].
 However ajax has not yet provided comments.  Is this SOL without feedback
from ajax?

[1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html
[2] http://lists.freedesktop.org/archives/dri-devel/2013-April/036829.html


On Mon, Mar 25, 2013 at 5:58 PM, Dylan Semler wrote:

> Changes in this version
>  * rename do_force_quirk_modes() -> do_force_quirk_mode()
>  * use list_for_each_entry() instead of list_for_each_entry_safe() in
>do_force_quirk_mode()
>  * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
>appropriate
>  * remove unused quirks argument from add_force_quirk_modes()
>  * fixes to allow cases of forcing multiple modes
>  * adjusted comments to adhere closer to style guides
>
> Changes in version 3
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
>
> Changes in version 2
>  * none
>
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
>
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
>
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list described above to be
> checked.
>
> The second patch adds the offending monitor to the quirk lists.
>
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+
>
>  drivers/gpu/drm/drm_edid.c | 89
> ++
>  1 file changed, 89 insertions(+)
>
> --
> 1.7.11.7
>
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Jani Nikula]

On Wed, 03 Apr 2013, Dylan Semler  wrote:
> Version 3 was Acked by Daniel Vetter[1].  Any chance ajax can give his
> comments?
>
> [1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html

FWIW,

Reviewed-by: Jani Nikula 

Re: [PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Jani Nikula]

On Wed, 03 Apr 2013, Dylan Semler  wrote:
> Version 3 was Acked by Daniel Vetter[1].  Any chance ajax can give his
> comments?
>
> [1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html

FWIW,

Reviewed-by: Jani Nikula 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Mon, Mar 25, 2013 at 5:58 PM, Dylan Semler 
wrote:
>
> Changes in this version
>  * rename do_force_quirk_modes() -> do_force_quirk_mode()
>  * use list_for_each_entry() instead of list_for_each_entry_safe() in
>do_force_quirk_mode()
>  * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
>appropriate
>  * remove unused quirks argument from add_force_quirk_modes()
>  * fixes to allow cases of forcing multiple modes
>  * adjusted comments to adhere closer to style guides
>
> Changes in version 3
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
>
> Changes in version 2
>  * none
>
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
>
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
>
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list described above to be
> checked.
>
> The second patch adds the offending monitor to the quirk lists.
>
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+
>
>  drivers/gpu/drm/drm_edid.c | 89
++
>  1 file changed, 89 insertions(+)
>
> --
> 1.7.11.7
>

Version 3 was Acked by Daniel Vetter[1].  Any chance ajax can give his
comments?

[1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html
-- next part --
An HTML attachment was scrubbed...
URL: 

Re: [PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Mon, Mar 25, 2013 at 5:58 PM, Dylan Semler 
wrote:
>
> Changes in this version
>  * rename do_force_quirk_modes() -> do_force_quirk_mode()
>  * use list_for_each_entry() instead of list_for_each_entry_safe() in
>do_force_quirk_mode()
>  * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
>appropriate
>  * remove unused quirks argument from add_force_quirk_modes()
>  * fixes to allow cases of forcing multiple modes
>  * adjusted comments to adhere closer to style guides
>
> Changes in version 3
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
>
> Changes in version 2
>  * none
>
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
>
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
>
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list described above to be
> checked.
>
> The second patch adds the offending monitor to the quirk lists.
>
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+
>
>  drivers/gpu/drm/drm_edid.c | 89
++
>  1 file changed, 89 insertions(+)
>
> --
> 1.7.11.7
>

Version 3 was Acked by Daniel Vetter[1].  Any chance ajax can give his
comments?

[1] http://lists.freedesktop.org/archives/dri-devel/2013-March/036457.html
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * rename do_force_quirk_modes() -> do_force_quirk_mode()
 * use list_for_each_entry() instead of list_for_each_entry_safe() in
   do_force_quirk_mode()
 * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
   appropriate
 * remove unused quirks argument from add_force_quirk_modes()
 * fixes to allow cases of forcing multiple modes
 * adjusted comments to adhere closer to style guides

Changes in version 3
 * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
 * Adds bool to specify reduced blanking to edid_quirk_force_mode
 * Removes preferred bit from all other modes

Changes in version 2
 * none

There is at least one monitor that doesn't report its native resolution
in its EDID block.  This enhancement extends the EDID quirk logic to
make monitors like this "just work".

The first patch in this series sets up a new quirk list where monitors'
correct width, height, refresh rate, and reduced blanking parameters are
specified.  When a matching monitor is attached the full mode is
calculated with drm_cvt_mode() and added to the connector.  The
DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
other modes.

The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
This bit needs to be set for the new quirk list described above to be
checked.

The second patch adds the offending monitor to the quirk lists.

Dylan Semler (2):
  drm: Enhance EDID quirks to explicitly set a mode
  drm: Add EDID force quirk for MMT Monitor2Go HD+

 drivers/gpu/drm/drm_edid.c | 89 ++
 1 file changed, 89 insertions(+)

-- 
1.7.11.7

[PATCH v4 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * rename do_force_quirk_modes() -> do_force_quirk_mode()
 * use list_for_each_entry() instead of list_for_each_entry_safe() in
   do_force_quirk_mode()
 * remove num_modes from do_force_quirk_mode(), just return 1 or 0 as
   appropriate
 * remove unused quirks argument from add_force_quirk_modes()
 * fixes to allow cases of forcing multiple modes
 * adjusted comments to adhere closer to style guides

Changes in version 3
 * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
 * Adds bool to specify reduced blanking to edid_quirk_force_mode
 * Removes preferred bit from all other modes

Changes in version 2
 * none

There is at least one monitor that doesn't report its native resolution
in its EDID block.  This enhancement extends the EDID quirk logic to
make monitors like this "just work".

The first patch in this series sets up a new quirk list where monitors'
correct width, height, refresh rate, and reduced blanking parameters are
specified.  When a matching monitor is attached the full mode is
calculated with drm_cvt_mode() and added to the connector.  The
DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
other modes.

The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
This bit needs to be set for the new quirk list described above to be
checked.

The second patch adds the offending monitor to the quirk lists.

Dylan Semler (2):
  drm: Enhance EDID quirks to explicitly set a mode
  drm: Add EDID force quirk for MMT Monitor2Go HD+

 drivers/gpu/drm/drm_edid.c | 89 ++
 1 file changed, 89 insertions(+)

-- 
1.7.11.7

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 07:08:05PM -0400, Dylan Semler wrote:
> Changes in this version
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
> 
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
> 
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
> 
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list discribed above to be
> checked.
> 
> The second patch adds the offending monitor to the quirk lists.
> 
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+

Ah, missed this resend of your patches. Looks good to me, but I guess Dave
want's to have Ajax's ack, too. Anyway for the series:

Acked-by: Daniel Vetter 

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[PATCH v2 0/2] Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 09:48:49AM -0400, Dylan Semler wrote:
> Changes in this version
>  * Fix missing commit messages in patch emails

Seems to be still missing. Also I kinda liked Alex' idea of adding a
gtf/gtf2/cdt flag for the detailed timing generation algorithm.
-Daniel

> 
> These patches offer a fix for a monitor that doesn't report its native
> resolution in its EDID.  The idea is setup a new quirk list with width, 
> height,
> and refresh rates for each monitor that needs this quirk.  If a monitor is
> attached that matches one in this list, the full modeline is calculated with
> drm_gtf_mode, the DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is 
> added
> to the connector.
> 
> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit 
> needs
> to be set for the new quirk list discribed above to be checked.
> 
> Dylan Semler (2):
>   Enhances EDID quirks to allow for specifying and preferring a mode
> not reported in the EDID block.
>   Adds EDID force mode quirk for MMT Monitor2Go HD+.
> 
>  drivers/gpu/drm/drm_edid.c | 77 
> ++
>  1 file changed, 77 insertions(+)
> 
> -- 
> 1.7.11.7
> 
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 07:08:05PM -0400, Dylan Semler wrote:
> Changes in this version
>  * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
>  * Adds bool to specify reduced blanking to edid_quirk_force_mode
>  * Removes preferred bit from all other modes
> 
> There is at least one monitor that doesn't report its native resolution
> in its EDID block.  This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
> 
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified.  When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector.  The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
> 
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list discribed above to be
> checked.
> 
> The second patch adds the offending monitor to the quirk lists.
> 
> Dylan Semler (2):
>   drm: Enhance EDID quirks to explicitly set a mode
>   drm: Add EDID force quirk for MMT Monitor2Go HD+

Ah, missed this resend of your patches. Looks good to me, but I guess Dave
want's to have Ajax's ack, too. Anyway for the series:

Acked-by: Daniel Vetter 

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/2] Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 09:48:49AM -0400, Dylan Semler wrote:
> Changes in this version
>  * Fix missing commit messages in patch emails

Seems to be still missing. Also I kinda liked Alex' idea of adding a
gtf/gtf2/cdt flag for the detailed timing generation algorithm.
-Daniel

> 
> These patches offer a fix for a monitor that doesn't report its native
> resolution in its EDID.  The idea is setup a new quirk list with width, 
> height,
> and refresh rates for each monitor that needs this quirk.  If a monitor is
> attached that matches one in this list, the full modeline is calculated with
> drm_gtf_mode, the DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is 
> added
> to the connector.
> 
> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit 
> needs
> to be set for the new quirk list discribed above to be checked.
> 
> Dylan Semler (2):
>   Enhances EDID quirks to allow for specifying and preferring a mode
> not reported in the EDID block.
>   Adds EDID force mode quirk for MMT Monitor2Go HD+.
> 
>  drivers/gpu/drm/drm_edid.c | 77 
> ++
>  1 file changed, 77 insertions(+)
> 
> -- 
> 1.7.11.7
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
 * Adds bool to specify reduced blanking to edid_quirk_force_mode
 * Removes preferred bit from all other modes

There is at least one monitor that doesn't report its native resolution
in its EDID block.  This enhancement extends the EDID quirk logic to
make monitors like this "just work".

The first patch in this series sets up a new quirk list where monitors'
correct width, height, refresh rate, and reduced blanking parameters are
specified.  When a matching monitor is attached the full mode is
calculated with drm_cvt_mode() and added to the connector.  The
DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
other modes.

The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
This bit needs to be set for the new quirk list discribed above to be
checked.

The second patch adds the offending monitor to the quirk lists.

Dylan Semler (2):
  drm: Enhance EDID quirks to explicitly set a mode
  drm: Add EDID force quirk for MMT Monitor2Go HD+

 drivers/gpu/drm/drm_edid.c | 83 ++
 1 file changed, 83 insertions(+)

-- 
1.7.11.7

[PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
 * Adds bool to specify reduced blanking to edid_quirk_force_mode
 * Removes preferred bit from all other modes

There is at least one monitor that doesn't report its native resolution
in its EDID block.  This enhancement extends the EDID quirk logic to
make monitors like this "just work".

The first patch in this series sets up a new quirk list where monitors'
correct width, height, refresh rate, and reduced blanking parameters are
specified.  When a matching monitor is attached the full mode is
calculated with drm_cvt_mode() and added to the connector.  The
DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
other modes.

The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
This bit needs to be set for the new quirk list discribed above to be
checked.

The second patch adds the offending monitor to the quirk lists.

Dylan Semler (2):
  drm: Enhance EDID quirks to explicitly set a mode
  drm: Add EDID force quirk for MMT Monitor2Go HD+

 drivers/gpu/drm/drm_edid.c | 83 ++
 1 file changed, 83 insertions(+)

-- 
1.7.11.7

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 3:02 PM, Dylan Semler  wrote:
> On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher  
> wrote:
>>
>> On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler 
>> wrote:
>> > Oops.  I neglected to preface this with my motivation:  I have a new
>> > monitor that doesn't report its native resolution in its EDID block.  It
>> > seemed to me this calls for an EDID quirk, but the current quirk
>> > infrastructure doesn't allow explicitly creating new modes.  So I set
>> > out
>> > to make a simple enhancement to allow specifying a new mode and then
>> > setting it as preferred.
>> >
>>
>> That's odd.  Maybe it's actually in an extension block or something like
>> that?
>
> Yeah, I agree.  According to edid-decode /sys/class/drm/card0-HDMI-A-1/edid
> there's one extension block, but none of those modes are the native
> resolution
> either.

Hm, we only recently added support for E-EDID (i.e. more than 1
extension block). Have you checked whether latest kernels fare better?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 10:41 AM, Daniel Vetter  wrote:
>
> On Fri, Mar 22, 2013 at 3:02 PM, Dylan Semler 
wrote:
> > On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher 
> > wrote:
> >>
> >> That's odd.  Maybe it's actually in an extension block or something
like
> >> that?
> >
> > Yeah, I agree.  According to edid-decode
/sys/class/drm/card0-HDMI-A-1/edid
> > there's one extension block, but none of those modes are the native
> > resolution either.
>
> Hm, we only recently added support for E-EDID (i.e. more than 1 extension
> block). Have you checked whether latest kernels fare better?

I just tried booting with 3.9rc3 and my distro's latest package of
xorg-utils;
I get the same results.
-- next part --
An HTML attachment was scrubbed...
URL: 

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher  wrote:
>
> On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler 
wrote:
> > Oops.  I neglected to preface this with my motivation:  I have a new
> > monitor that doesn't report its native resolution in its EDID block.  It
> > seemed to me this calls for an EDID quirk, but the current quirk
> > infrastructure doesn't allow explicitly creating new modes.  So I set
out
> > to make a simple enhancement to allow specifying a new mode and then
> > setting it as preferred.
> >
>
> That's odd.  Maybe it's actually in an extension block or something like
> that?

Yeah, I agree.  According to edid-decode /sys/class/drm/card0-HDMI-A-1/edid
there's one extension block, but none of those modes are the native
resolution
either.
-- next part --
An HTML attachment was scrubbed...
URL: 

Enhance EDID quirks to allow forcing a mode

[Alex Deucher]

On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler  wrote:
> Oops.  I neglected to preface this with my motivation:  I have a new monitor
> that doesn't report its native resolution in its EDID block.  It seemed to
> me
> this calls for an EDID quirk, but the current quirk infrastructure doesn't
> allow explicitly creating new modes.  So I set out to make a simple
> enhancement
> to allow specifying a new mode and then setting it as preferred.
>

That's odd.  Maybe it's actually in an extension block or something like that?

>
>
> On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler 
> wrote:
>>
>> The idea is setup a new quirk list with width, height, and refresh rates
>> for
>> each monitor that needs this quirk.  If a monitor is attached that matches
>> one
>> in this list, the full modeline is calculated with drm_gtf_mode, the
>> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
>> connector.
>>
>> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
>> needs
>> to be set for the new quirk list discribed above to be checked.
>>
>> The first patch enhances the quirk logic as described above.  The second
>> one
>> adds my new monitor to the quirk lists.
>
>
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

[PATCH v2 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * Fix missing commit messages in patch emails

These patches offer a fix for a monitor that doesn't report its native
resolution in its EDID.  The idea is setup a new quirk list with width, height,
and refresh rates for each monitor that needs this quirk.  If a monitor is
attached that matches one in this list, the full modeline is calculated with
drm_gtf_mode, the DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added
to the connector.

The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit needs
to be set for the new quirk list discribed above to be checked.

Dylan Semler (2):
  Enhances EDID quirks to allow for specifying and preferring a mode
not reported in the EDID block.
  Adds EDID force mode quirk for MMT Monitor2Go HD+.

 drivers/gpu/drm/drm_edid.c | 77 ++
 1 file changed, 77 insertions(+)

-- 
1.7.11.7

Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Thu, Mar 21, 2013 at 10:42 PM, Dylan Semler  
wrote:
> Oops.  I neglected to preface this with my motivation:  I have a new monitor
> that doesn't report its native resolution in its EDID block.  It seemed to
> me
> this calls for an EDID quirk, but the current quirk infrastructure doesn't
> allow explicitly creating new modes.  So I set out to make a simple
> enhancement
> to allow specifying a new mode and then setting it as preferred.
>
>
>
> On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler 
> wrote:
>>
>> The idea is setup a new quirk list with width, height, and refresh rates
>> for
>> each monitor that needs this quirk.  If a monitor is attached that matches
>> one
>> in this list, the full modeline is calculated with drm_gtf_mode, the
>> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
>> connector.
>>
>> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
>> needs
>> to be set for the new quirk list discribed above to be checked.
>>
>> The first patch enhances the quirk logic as described above.  The second
>> one
>> adds my new monitor to the quirk lists.

I think it'd be good to shovel these text blocks into the (currently
rather empty) commit messages of the patches. Since when reading old
commits with e.g. git blame that's what people will read.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 4:48 AM, Daniel Vetter  wrote:
>
> I think it'd be good to shovel these text blocks into the (currently
rather
> empty) commit messages of the patches. Since when reading old commits with
> e.g. git blame that's what people will read.

Yeah, I just noticed that.  For some reason my git format-patch didn't place
the commit messages above the signoff.  Here comes v2.
-- next part --
An HTML attachment was scrubbed...
URL: 

Re: Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 10:41 AM, Daniel Vetter  wrote:
>
> On Fri, Mar 22, 2013 at 3:02 PM, Dylan Semler 
wrote:
> > On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher 
> > wrote:
> >>
> >> That's odd.  Maybe it's actually in an extension block or something
like
> >> that?
> >
> > Yeah, I agree.  According to edid-decode
/sys/class/drm/card0-HDMI-A-1/edid
> > there's one extension block, but none of those modes are the native
> > resolution either.
>
> Hm, we only recently added support for E-EDID (i.e. more than 1 extension
> block). Have you checked whether latest kernels fare better?

I just tried booting with 3.9rc3 and my distro's latest package of
xorg-utils;
I get the same results.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Fri, Mar 22, 2013 at 3:02 PM, Dylan Semler  wrote:
> On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher  wrote:
>>
>> On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler 
>> wrote:
>> > Oops.  I neglected to preface this with my motivation:  I have a new
>> > monitor that doesn't report its native resolution in its EDID block.  It
>> > seemed to me this calls for an EDID quirk, but the current quirk
>> > infrastructure doesn't allow explicitly creating new modes.  So I set
>> > out
>> > to make a simple enhancement to allow specifying a new mode and then
>> > setting it as preferred.
>> >
>>
>> That's odd.  Maybe it's actually in an extension block or something like
>> that?
>
> Yeah, I agree.  According to edid-decode /sys/class/drm/card0-HDMI-A-1/edid
> there's one extension block, but none of those modes are the native
> resolution
> either.

Hm, we only recently added support for E-EDID (i.e. more than 1
extension block). Have you checked whether latest kernels fare better?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 9:50 AM, Alex Deucher  wrote:
>
> On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler 
wrote:
> > Oops.  I neglected to preface this with my motivation:  I have a new
> > monitor that doesn't report its native resolution in its EDID block.  It
> > seemed to me this calls for an EDID quirk, but the current quirk
> > infrastructure doesn't allow explicitly creating new modes.  So I set
out
> > to make a simple enhancement to allow specifying a new mode and then
> > setting it as preferred.
> >
>
> That's odd.  Maybe it's actually in an extension block or something like
> that?

Yeah, I agree.  According to edid-decode /sys/class/drm/card0-HDMI-A-1/edid
there's one extension block, but none of those modes are the native
resolution
either.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 0/2] Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Changes in this version
 * Fix missing commit messages in patch emails

These patches offer a fix for a monitor that doesn't report its native
resolution in its EDID.  The idea is setup a new quirk list with width, height,
and refresh rates for each monitor that needs this quirk.  If a monitor is
attached that matches one in this list, the full modeline is calculated with
drm_gtf_mode, the DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added
to the connector.

The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit needs
to be set for the new quirk list discribed above to be checked.

Dylan Semler (2):
  Enhances EDID quirks to allow for specifying and preferring a mode
not reported in the EDID block.
  Adds EDID force mode quirk for MMT Monitor2Go HD+.

 drivers/gpu/drm/drm_edid.c | 77 ++
 1 file changed, 77 insertions(+)

-- 
1.7.11.7

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Enhance EDID quirks to allow forcing a mode

[Alex Deucher]

On Thu, Mar 21, 2013 at 5:42 PM, Dylan Semler  wrote:
> Oops.  I neglected to preface this with my motivation:  I have a new monitor
> that doesn't report its native resolution in its EDID block.  It seemed to
> me
> this calls for an EDID quirk, but the current quirk infrastructure doesn't
> allow explicitly creating new modes.  So I set out to make a simple
> enhancement
> to allow specifying a new mode and then setting it as preferred.
>

That's odd.  Maybe it's actually in an extension block or something like that?

>
>
> On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler 
> wrote:
>>
>> The idea is setup a new quirk list with width, height, and refresh rates
>> for
>> each monitor that needs this quirk.  If a monitor is attached that matches
>> one
>> in this list, the full modeline is calculated with drm_gtf_mode, the
>> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
>> connector.
>>
>> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
>> needs
>> to be set for the new quirk list discribed above to be checked.
>>
>> The first patch enhances the quirk logic as described above.  The second
>> one
>> adds my new monitor to the quirk lists.
>
>
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

On Fri, Mar 22, 2013 at 4:48 AM, Daniel Vetter  wrote:
>
> I think it'd be good to shovel these text blocks into the (currently
rather
> empty) commit messages of the patches. Since when reading old commits with
> e.g. git blame that's what people will read.

Yeah, I just noticed that.  For some reason my git format-patch didn't place
the commit messages above the signoff.  Here comes v2.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Enhance EDID quirks to allow forcing a mode

[Daniel Vetter]

On Thu, Mar 21, 2013 at 10:42 PM, Dylan Semler  wrote:
> Oops.  I neglected to preface this with my motivation:  I have a new monitor
> that doesn't report its native resolution in its EDID block.  It seemed to
> me
> this calls for an EDID quirk, but the current quirk infrastructure doesn't
> allow explicitly creating new modes.  So I set out to make a simple
> enhancement
> to allow specifying a new mode and then setting it as preferred.
>
>
>
> On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler 
> wrote:
>>
>> The idea is setup a new quirk list with width, height, and refresh rates
>> for
>> each monitor that needs this quirk.  If a monitor is attached that matches
>> one
>> in this list, the full modeline is calculated with drm_gtf_mode, the
>> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
>> connector.
>>
>> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
>> needs
>> to be set for the new quirk list discribed above to be checked.
>>
>> The first patch enhances the quirk logic as described above.  The second
>> one
>> adds my new monitor to the quirk lists.

I think it'd be good to shovel these text blocks into the (currently
rather empty) commit messages of the patches. Since when reading old
commits with e.g. git blame that's what people will read.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Oops.  I neglected to preface this with my motivation:  I have a new
monitor
that doesn't report its native resolution in its EDID block.  It seemed to
me
this calls for an EDID quirk, but the current quirk infrastructure doesn't
allow explicitly creating new modes.  So I set out to make a simple
enhancement
to allow specifying a new mode and then setting it as preferred.



On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler wrote:

> The idea is setup a new quirk list with width, height, and refresh rates
> for
> each monitor that needs this quirk.  If a monitor is attached that matches
> one
> in this list, the full modeline is calculated with drm_gtf_mode, the
> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
> connector.
>
> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
> needs
> to be set for the new quirk list discribed above to be checked.
>
> The first patch enhances the quirk logic as described above.  The second
> one
> adds my new monitor to the quirk lists.
>
-- next part --
An HTML attachment was scrubbed...
URL: 

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

The idea is setup a new quirk list with width, height, and refresh rates for
each monitor that needs this quirk.  If a monitor is attached that matches one
in this list, the full modeline is calculated with drm_gtf_mode, the
DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the connector.

The patch also creates a new quirk bit:??EDID_QUIRK_FORCE_MODE. ?This bit needs
to be set for the new quirk list discribed above to be checked.

The first patch enhances the quirk logic as described above. ?The second one
adds my new monitor to the quirk lists.

Re: Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

Oops.  I neglected to preface this with my motivation:  I have a new
monitor
that doesn't report its native resolution in its EDID block.  It seemed to
me
this calls for an EDID quirk, but the current quirk infrastructure doesn't
allow explicitly creating new modes.  So I set out to make a simple
enhancement
to allow specifying a new mode and then setting it as preferred.



On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler wrote:

> The idea is setup a new quirk list with width, height, and refresh rates
> for
> each monitor that needs this quirk.  If a monitor is attached that matches
> one
> in this list, the full modeline is calculated with drm_gtf_mode, the
> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
> connector.
>
> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
> needs
> to be set for the new quirk list discribed above to be checked.
>
> The first patch enhances the quirk logic as described above.  The second
> one
> adds my new monitor to the quirk lists.
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Enhance EDID quirks to allow forcing a mode

[Dylan Semler]

The idea is setup a new quirk list with width, height, and refresh rates for
each monitor that needs this quirk.  If a monitor is attached that matches one
in this list, the full modeline is calculated with drm_gtf_mode, the
DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the connector.

The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit needs
to be set for the new quirk list discribed above to be checked.

The first patch enhances the quirk logic as described above.  The second one
adds my new monitor to the quirk lists.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel