Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi
Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
> from Negtive to Positive
>
> Signed-off-by: KuoHsiang Chou
I've merged this patch. Thanks!
Best regards
Thomas
> ---
> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_tables.h
> b/drivers/gpu/drm/ast/ast_tables.h
> index 8414e543f260..51efc5b4a55c 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] =
> {
>
> static const struct ast_vbios_enhtable res_1920x1080[] = {
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> AST2500PreCatchCRT), 60, 1, 0x38 },
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> AST2500PreCatchCRT), 0xFF, 1, 0x38 },
> };
>
> --
> 2.18.4
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi
Am 06.11.20 um 01:31 schrieb Kuo-Hsiang Chou:
> To Sir
>
> Yes, I ran scripts/checkpatch.pl and cleared 3 errors about tailing spaces.
>
> OK, would you please give me the mail-address of Daniel?
It's
> And will be removed from CC.
Thanks!
> Because I ran get_maintainers.pl and got the result of " The current
> directory does not appear to be a linux kernel source tree. "
Strange, that sounds like a problem in your setup. Go to the actual
directory where you checkout out the Linux source code; where the
MAINTAINERS file is located. From there use
scripts/get_maintainers.pl
That should work.
Best regards
Thomas
> So, I got the information from MAINTAINERS by keyword of "/drm/ast", likes as:
> DRM DRIVER FOR AST SERVER GRAPHICS CHIPS
> M:Dave Airlie
> R:Thomas Zimmermann
> L:dri-devel@lists.freedesktop.org
> S:Supported
> T:git git://anongit.freedesktop.org/drm/drm-misc
> F:drivers/gpu/drm/ast/
>
> Thanks and Have a good day,
> Kuo-Hsiang Chou
>
> -Original Message-
> From: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
> Sent: Thursday, November 05, 2020 8:09 PM
> To: Kuo-Hsiang Chou ;
> dri-devel@lists.freedesktop.org
> Cc: e...@suse.com; Tommy Huang ; Jenmin Yuan
> ; airl...@redhat.com; Arc Sung
>
> Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
>
> Hi,
>
> please follow the advise we're giving you. Had you run scripts/checkpatch.pl
> on the patch file it would have told you
>
> <<<
> ERROR: patch seems to be corrupt (line wrapped?)
> #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
>
>
> ERROR: DOS line endings
> #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
> +|^M$
>
> ERROR: DOS line endings
> #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
> +|^M$
>
> total: 3 errors, 0 warnings, 19 lines checked
>>>>
>
> As said before, the mail e...@suse.de is still not relevant any longer.
> But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?
>
> Best regards
> Thomas
>
> Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
>> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
>> from Negtive to Positive
>>
>> Signed-off-by: KuoHsiang Chou
>> ---
>> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_tables.h
>> b/drivers/gpu/drm/ast/ast_tables.h
>> index 8414e543f260..51efc5b4a55c 100644
>> --- a/drivers/gpu/drm/ast/ast_tables.h
>> +++ b/drivers/gpu/drm/ast/ast_tables.h
>> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable
>> res_1600x900[] = {
>>
>> static const struct ast_vbios_enhtable res_1920x1080[] = {
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
>> +|
>>AST2500PreCatchCRT), 60, 1, 0x38 },
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
>> +|
>>AST2500PreCatchCRT), 0xFF, 1, 0x38 }, };
>>
>> --
>> 2.18.4
>>
>> ___
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_0x680DC11D530B7A23.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
To Sir,
Is the mail-address of "daniel.vet...@intel.com" correct for Daniel?
Because, got the message of " The current directory does not appear to be a
linux kernel source tree. " after running get_maintainers.pl
So, find Daniel out by gitk /drivers/gpu/drm/ast
Have a good day,
Kuo-Hsiang Chou
-Original Message-
From: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
Sent: Thursday, November 05, 2020 8:22 PM
To: Kuo-Hsiang Chou ;
dri-devel@lists.freedesktop.org
Cc: Jenmin Yuan ; e...@suse.com; Tommy Huang
; Arc Sung ;
airl...@redhat.com
Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi
Am 05.11.20 um 13:08 schrieb Thomas Zimmermann:
> Hi,
>
> please follow the advise we're giving you. Had you run
> scripts/checkpatch.pl on the patch file it would have told you
>
> <<<
> ERROR: patch seems to be corrupt (line wrapped?)
> #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
>
>
> ERROR: DOS line endings
> #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode |
> +NewModeInfo |^M$
>
> ERROR: DOS line endings
> #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode |
> +NewModeInfo |^M$
>
> total: 3 errors, 0 warnings, 19 lines checked
>>>>
>
This might not be your fault but the result of my mail client.
> As said before, the mail e...@suse.de is still not relevant any longer.
> But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?
This still applies.
Best regards
Thomas
>
> Best regards
> Thomas
>
> Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
>> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
>> from Negtive to Positive
>>
>> Signed-off-by: KuoHsiang Chou
>> ---
>> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_tables.h
>> b/drivers/gpu/drm/ast/ast_tables.h
>> index 8414e543f260..51efc5b4a55c 100644
>> --- a/drivers/gpu/drm/ast/ast_tables.h
>> +++ b/drivers/gpu/drm/ast/ast_tables.h
>> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable
>> res_1600x900[] = {
>>
>> static const struct ast_vbios_enhtable res_1920x1080[] = {
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode |
>> +NewModeInfo |
>>AST2500PreCatchCRT), 60, 1, 0x38 },
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode |
>> +NewModeInfo |
>>AST2500PreCatchCRT), 0xFF, 1, 0x38 }, };
>>
>> --
>> 2.18.4
>>
>> ___
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
To Sir
Yes, I ran scripts/checkpatch.pl and cleared 3 errors about tailing spaces.
OK, would you please give me the mail-address of Daniel? And
will be removed from CC.
Because I ran get_maintainers.pl and got the result of " The current directory
does not appear to be a linux kernel source tree. "
So, I got the information from MAINTAINERS by keyword of "/drm/ast", likes as:
DRM DRIVER FOR AST SERVER GRAPHICS CHIPS
M: Dave Airlie
R: Thomas Zimmermann
L: dri-devel@lists.freedesktop.org
S: Supported
T: git git://anongit.freedesktop.org/drm/drm-misc
F: drivers/gpu/drm/ast/
Thanks and Have a good day,
Kuo-Hsiang Chou
-Original Message-
From: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
Sent: Thursday, November 05, 2020 8:09 PM
To: Kuo-Hsiang Chou ;
dri-devel@lists.freedesktop.org
Cc: e...@suse.com; Tommy Huang ; Jenmin Yuan
; airl...@redhat.com; Arc Sung
Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi,
please follow the advise we're giving you. Had you run scripts/checkpatch.pl on
the patch file it would have told you
<<<
ERROR: patch seems to be corrupt (line wrapped?)
#102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
ERROR: DOS line endings
#106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
+|^M$
ERROR: DOS line endings
#110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
+|^M$
total: 3 errors, 0 warnings, 19 lines checked
>>>
As said before, the mail e...@suse.de is still not relevant any longer.
But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?
Best regards
Thomas
Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
> from Negtive to Positive
>
> Signed-off-by: KuoHsiang Chou
> ---
> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_tables.h
> b/drivers/gpu/drm/ast/ast_tables.h
> index 8414e543f260..51efc5b4a55c 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable
> res_1600x900[] = {
>
> static const struct ast_vbios_enhtable res_1920x1080[] = {
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
> +|
> AST2500PreCatchCRT), 60, 1, 0x38 },
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo
> +|
> AST2500PreCatchCRT), 0xFF, 1, 0x38 }, };
>
> --
> 2.18.4
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi
Am 05.11.20 um 13:08 schrieb Thomas Zimmermann:
> Hi,
>
> please follow the advise we're giving you. Had you run
> scripts/checkpatch.pl on the patch file it would have told you
>
> <<<
> ERROR: patch seems to be corrupt (line wrapped?)
> #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
>
>
> ERROR: DOS line endings
> #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$
>
> ERROR: DOS line endings
> #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$
>
> total: 3 errors, 0 warnings, 19 lines checked
>
This might not be your fault but the result of my mail client.
> As said before, the mail e...@suse.de is still not relevant any longer.
> But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?
This still applies.
Best regards
Thomas
>
> Best regards
> Thomas
>
> Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
>> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
>> from Negtive to Positive
>>
>> Signed-off-by: KuoHsiang Chou
>> ---
>> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_tables.h
>> b/drivers/gpu/drm/ast/ast_tables.h
>> index 8414e543f260..51efc5b4a55c 100644
>> --- a/drivers/gpu/drm/ast/ast_tables.h
>> +++ b/drivers/gpu/drm/ast/ast_tables.h
>> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[]
>> = {
>>
>> static const struct ast_vbios_enhtable res_1920x1080[] = {
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>>AST2500PreCatchCRT), 60, 1, 0x38 },
>> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
>> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>>AST2500PreCatchCRT), 0xFF, 1, 0x38 },
>> };
>>
>> --
>> 2.18.4
>>
>> ___
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_0x680DC11D530B7A23.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Hi,
please follow the advise we're giving you. Had you run
scripts/checkpatch.pl on the patch file it would have told you
<<<
ERROR: patch seems to be corrupt (line wrapped?)
#102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
ERROR: DOS line endings
#106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$
ERROR: DOS line endings
#110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$
total: 3 errors, 0 warnings, 19 lines checked
>>>
As said before, the mail e...@suse.de is still not relevant any longer.
But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?
Best regards
Thomas
Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
> from Negtive to Positive
>
> Signed-off-by: KuoHsiang Chou
> ---
> drivers/gpu/drm/ast/ast_tables.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_tables.h
> b/drivers/gpu/drm/ast/ast_tables.h
> index 8414e543f260..51efc5b4a55c 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] =
> {
>
> static const struct ast_vbios_enhtable res_1920x1080[] = {
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> AST2500PreCatchCRT), 60, 1, 0x38 },
> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> AST2500PreCatchCRT), 0xFF, 1, 0x38 },
> };
>
> --
> 2.18.4
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
OpenPGP_0x680DC11D530B7A23.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
