Hi Tomi,
> -Original Message-
> From: Tomi Valkeinen
> Sent: Wednesday, September 16, 2020 5:48 PM
> To: Swapnil Kashinath Jakhade ; airl...@linux.ie;
> dan...@ffwll.ch; laurent.pinch...@ideasonboard.com; robh...@kernel.org;
> a.ha...@samsung.com; narmstr...@baylibre.com; jo...@kwiboo.se;
> jernej.skra...@siol.net; dri-devel@lists.freedesktop.org;
> devicet...@vger.kernel.org; linux-ker...@vger.kernel.org
> Cc: Milind Parab ; Yuti Suresh Amonkar
> ; jsa...@ti.com; nsek...@ti.com;
> prane...@ti.com; nikhil...@ti.com
> Subject: Re: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence
> MHDP8546 bridge bindings
>
> EXTERNAL MAIL
>
>
> Hi Swapnil, Yuti,
>
> On 14/09/2020 15:48, Swapnil Jakhade wrote:
> > From: Yuti Amonkar
> >
> > Document the bindings used for the Cadence MHDP8546 DPI/DP bridge in
> > yaml format.
> >
> > Signed-off-by: Yuti Amonkar
> > Signed-off-by: Swapnil Jakhade
> > Reviewed-by: Rob Herring
> > Reviewed-by: Laurent Pinchart
> > ---
> > .../display/bridge/cdns,mhdp8546.yaml | 154 ++
> > 1 file changed, 154 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> I was testing this on J7 EVM, and looking at the dts files and DT bindings. To
> get rid of the warnings from dtbs_check, I made the following changes.
>
> I think the interrupt one is clear. The driver needs the interrupt, but it was
> not defined in the yaml file.
>
> For phy-names, we had that in the out-of-tree dts file, so I added it here.
> The
> driver just looks for the PHY via index, but I guess we should require it.
>
> The power-domain is not needed by the driver, but if I'm not mistaken, has
> to be defined here.
>
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> index a21a4bfe15cf..c5f5781c1ed6 100644
> ---
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> +++
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yam
> +++ l
> @@ -46,6 +46,16 @@ properties:
> description:
>phandle to the DisplayPort PHY.
>
> + phy-names:
> +items:
> + - const: dpphy
> +
> + power-domains:
> +maxItems: 1
> +
> + interrupts:
> +maxItems: 1
> +
>ports:
> type: object
> description:
> @@ -114,6 +124,8 @@ required:
>- reg
>- reg-names
>- phys
> + - phy-names
> + - interrupts
>- ports
>
Okay. We will update the bindings as per above suggestions. Thanks for your
inputs.
Thanks & regards,
Swapnil
> additionalProperties: false
>
> Tomi
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
