RE: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
HI Rob, ... > Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C > ... > > + > > + mps,overvoltage-protection-microvolt: > > +description: Overvoltage protection (13.5V, 24V or 35.5V). If missing, > > the > > + hardware default of 35.5V is used. > > default: 3550 > > instead of prose saying the same thing. > > With that, > > Reviewed-by: Rob Herring Ok, right, I'll fix it in my next version. I prefer to wait a few days before sending the next version, to wait if there are other comments on the device driver file as well. Just a question about the procedure: in my next version, I have to add the sentence: "Reviewed-by: Rob Herring " in my commit or it will be added again by you? Thanks for your help, Flavio
RE: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
Hi Conor,
...
> On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote:
> > The Monolithic Power (MPS) MP3309C is a WLED step-up converter,
> > featuring a programmable switching frequency to optimize efficiency.
> > The brightness can be controlled either by I2C commands (called "analog"
> > mode) or by a PWM input signal (PWM mode).
> > This driver supports both modes.
> >
> > For device driver details, please refer to:
> > - drivers/video/backlight/mp3309c_bl.c
> >
> > The datasheet is available at:
> > - https://www.monolithicpower.com/en/mp3309c.html
> >
> > Signed-off-by: Flavio Suligoi
> > ---
> >
> > v2:
> > - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0,
> >switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms,
> >reset-on-length-ms)
> > - add common.yaml#
> > - remove already included properties (default-brightness,
> > max-brightness)
> > - substitute three boolean properties, used for the overvoltage-protection
> >values, with a single enum property
> > - remove some conditional definitions
> > - remove the 2nd example
> > v1:
> > - first version
> >
> > .../bindings/leds/backlight/mps,mp3309c.yaml | 73
> > +++
> > 1 file changed, 73 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > new file mode 100644
> > index ..99ccdba2c08f
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yam
> > +++ l
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/mps,mp3309c.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MPS MP3309C backlight
> > +
> > +maintainers:
> > + - Flavio Suligoi
...
> > + mps,overvoltage-protection-microvolt:
> > +description: Overvoltage protection (13.5V, 24V or 35.5V). If missing,
> > the
> > + hardware default of 35.5V is used.
> > +enum: [ 1350, 2400, 3550 ]
> You can add "default: 3550" and drop the free form default as text in the
> description.
Ok, thanks.
>
> Cheers,
> Conor.
>
> > +
> > + mps,no-sync-mode:
> > +description: disable synchronous rectification mode
> > +type: boolean
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - max-brightness
> > + - default-brightness
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > +i2c {
> > +#address-cells = <1>;
> > +#size-cells = <0>;
> > +
> > +/* Backlight with PWM control */
> > +backlight_pwm: backlight@17 {
> > +compatible = "mps,mp3309c-backlight";
>
> As the bot pointed out, the compatible doesn't contain "backlight".
Right, fixed!
Thanks and regards,
Flavio
Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote:
> The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a
> programmable switching frequency to optimize efficiency.
> The brightness can be controlled either by I2C commands (called "analog"
> mode) or by a PWM input signal (PWM mode).
> This driver supports both modes.
>
> For device driver details, please refer to:
> - drivers/video/backlight/mp3309c_bl.c
>
> The datasheet is available at:
> - https://www.monolithicpower.com/en/mp3309c.html
>
> Signed-off-by: Flavio Suligoi
> ---
>
> v2:
> - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0,
>switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms,
>reset-on-length-ms)
> - add common.yaml#
> - remove already included properties (default-brightness, max-brightness)
> - substitute three boolean properties, used for the overvoltage-protection
>values, with a single enum property
> - remove some conditional definitions
> - remove the 2nd example
> v1:
> - first version
>
> .../bindings/leds/backlight/mps,mp3309c.yaml | 73 +++
> 1 file changed, 73 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> new file mode 100644
> index ..99ccdba2c08f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/mps,mp3309c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MPS MP3309C backlight
> +
> +maintainers:
> + - Flavio Suligoi
> +
> +description: |
> + The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a
> + programmable switching frequency to optimize efficiency.
> + It supports two different dimming modes:
> +
> + - analog mode, via I2C commands (default)
> + - PWM controlled mode.
> +
> + The datasheet is available at:
> + https://www.monolithicpower.com/en/mp3309c.html
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> +const: mps,mp3309c
> +
> + reg:
> +maxItems: 1
> +
> + pwms:
> +description: if present, the backlight is controlled in PWM mode.
> +maxItems: 1
> +
> + enable-gpios:
> +description: GPIO used to enable the backlight in "analog-i2c" dimming
> mode.
> +maxItems: 1
> +
> + mps,overvoltage-protection-microvolt:
> +description: Overvoltage protection (13.5V, 24V or 35.5V). If missing,
> the
> + hardware default of 35.5V is used.
default: 3550
instead of prose saying the same thing.
With that,
Reviewed-by: Rob Herring
> +enum: [ 1350, 2400, 3550 ]
> +
> + mps,no-sync-mode:
> +description: disable synchronous rectification mode
> +type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - max-brightness
> + - default-brightness
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> +i2c {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +/* Backlight with PWM control */
> +backlight_pwm: backlight@17 {
> +compatible = "mps,mp3309c-backlight";
> +reg = <0x17>;
> +pwms = <&pwm1 0 333 0>; /* 300 Hz --> (1/f) * 1*10^9 */
> +max-brightness = <100>;
> +default-brightness = <80>;
> +overvoltage-protection-microvolt = <2400>;
> +};
> +};
> --
> 2.34.1
>
Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
Yo,
On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote:
> The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a
> programmable switching frequency to optimize efficiency.
> The brightness can be controlled either by I2C commands (called "analog"
> mode) or by a PWM input signal (PWM mode).
> This driver supports both modes.
>
> For device driver details, please refer to:
> - drivers/video/backlight/mp3309c_bl.c
>
> The datasheet is available at:
> - https://www.monolithicpower.com/en/mp3309c.html
>
> Signed-off-by: Flavio Suligoi
> ---
>
> v2:
> - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0,
>switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms,
>reset-on-length-ms)
> - add common.yaml#
> - remove already included properties (default-brightness, max-brightness)
> - substitute three boolean properties, used for the overvoltage-protection
>values, with a single enum property
> - remove some conditional definitions
> - remove the 2nd example
> v1:
> - first version
>
> .../bindings/leds/backlight/mps,mp3309c.yaml | 73 +++
> 1 file changed, 73 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> new file mode 100644
> index ..99ccdba2c08f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/mps,mp3309c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MPS MP3309C backlight
> +
> +maintainers:
> + - Flavio Suligoi
> +
> +description: |
> + The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a
> + programmable switching frequency to optimize efficiency.
> + It supports two different dimming modes:
> +
> + - analog mode, via I2C commands (default)
> + - PWM controlled mode.
> +
> + The datasheet is available at:
> + https://www.monolithicpower.com/en/mp3309c.html
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> +const: mps,mp3309c
> +
> + reg:
> +maxItems: 1
> +
> + pwms:
> +description: if present, the backlight is controlled in PWM mode.
> +maxItems: 1
> +
> + enable-gpios:
> +description: GPIO used to enable the backlight in "analog-i2c" dimming
> mode.
> +maxItems: 1
> +
> + mps,overvoltage-protection-microvolt:
> +description: Overvoltage protection (13.5V, 24V or 35.5V). If missing,
> the
> + hardware default of 35.5V is used.
> +enum: [ 1350, 2400, 3550 ]
You can add "default: 3550" and drop the free form default as text
in the description.
Cheers,
Conor.
> +
> + mps,no-sync-mode:
> +description: disable synchronous rectification mode
> +type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - max-brightness
> + - default-brightness
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> +i2c {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +/* Backlight with PWM control */
> +backlight_pwm: backlight@17 {
> +compatible = "mps,mp3309c-backlight";
As the bot pointed out, the compatible doesn't contain "backlight".
> +reg = <0x17>;
> +pwms = <&pwm1 0 333 0>; /* 300 Hz --> (1/f) * 1*10^9 */
> +max-brightness = <100>;
> +default-brightness = <80>;
> +overvoltage-protection-microvolt = <2400>;
> +};
> +};
> --
> 2.34.1
>
signature.asc
Description: PGP signature
Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
On Fri, 15 Sep 2023 16:05:15 +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM input signal (PWM mode). > This driver supports both modes. > > For device driver details, please refer to: > - drivers/video/backlight/mp3309c_bl.c > > The datasheet is available at: > - https://www.monolithicpower.com/en/mp3309c.html > > Signed-off-by: Flavio Suligoi > --- > > v2: > - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0, >switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms, >reset-on-length-ms) > - add common.yaml# > - remove already included properties (default-brightness, max-brightness) > - substitute three boolean properties, used for the overvoltage-protection >values, with a single enum property > - remove some conditional definitions > - remove the 2nd example > v1: > - first version > > .../bindings/leds/backlight/mps,mp3309c.yaml | 73 +++ > 1 file changed, 73 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.example.dtb: /example-0/i2c/backlight@17: failed to match any schema with compatible: ['mps,mp3309c-backlight'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230915140516.1294925-1-f.suli...@asem.it The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
