Re: [pull] radeon drm-next-3.11

2013-07-03 Thread Ruslan N. Marchenko

Am 01.07.2013 23:01, schrieb alexdeuc...@gmail.com:

From: Alex Deucheralexander.deuc...@amd.com

Hi Dave,

A few more patches for 3.11:
- add debugfs interface to check current DPM state
- Fix a bug that caused problems with DPM on BTC+ asics.

The following changes since commit f7d452f4fd5d86f764807a1234a407deb5b105ef:

   Merge branch 'drm-nouveau-next' of 
git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-07-01 
14:10:20 +1000)

are available in the git repository at:

   git://people.freedesktop.org/~agd5f/linux drm-next-3.11

Alex Deucher (12):
   drm/radeon: remove sumo dpm/uvd bringup leftovers
   drm/radeon/atom: fix endian bug in radeon_atom_init_mc_reg_table()
   drm/radeon: fix typo in radeon_atom_init_mc_reg_table()
   drm/radeon/dpm: re-enable state transitions for BTC
   drm/radeon/dpm: re-enable state transitions for Cayman
   drm/radeon/dpm: add infrastructure to support debugfs info
   drm/radeon/dpm: add debugfs support for rv6xx
   drm/radeon/dpm: add debugfs support for 7xx/evergreen/btc
   drm/radeon/dpm: add debugfs support for ON/LN
   drm/radeon/dpm: add debugfs support for TN
   drm/radeon/dpm: add debugfs support for cayman
   drm/radeon/dpm: add debugfs support for SI

  drivers/gpu/drm/radeon/btc_dpm.c |3 --
  drivers/gpu/drm/radeon/ni_dpm.c  |   25 +---
  drivers/gpu/drm/radeon/nid.h |4 ++
  drivers/gpu/drm/radeon/radeon.h  |2 +
  drivers/gpu/drm/radeon/radeon_asic.c |8 +
  drivers/gpu/drm/radeon/radeon_asic.h |   12 
  drivers/gpu/drm/radeon/radeon_atombios.c |3 +-
  drivers/gpu/drm/radeon/radeon_pm.c   |   40 ++
  drivers/gpu/drm/radeon/rv6xx_dpm.c   |   25 
  drivers/gpu/drm/radeon/rv770_dpm.c   |   30 
  drivers/gpu/drm/radeon/rv770d.h  |4 ++
  drivers/gpu/drm/radeon/si_dpm.c  |   19 
  drivers/gpu/drm/radeon/sid.h |4 ++
  drivers/gpu/drm/radeon/sumo_dpm.c|   45 ++---
  drivers/gpu/drm/radeon/trinity_dpm.c |   21 ++
  15 files changed, 206 insertions(+), 39 deletions(-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

This is really excellent and very wanted addition to the radeon, a huge 
thanks Alex for giving a second life to my old TimelineX with hybrid 
AMD/Intel graphics. Intel ironlake became a bit outdated already but 
with ATi HD 5650 I was able to drink tee all day long since it never 
came lower than 90 degrees Celsius.   Now it comfortably sits at 55-60 
so I can use it back again.


As I noticed it supports now either dynpm or profile method of clocking, 
however profiles themselves also have several (3) power states. Also 
during init phase it writes that it switching from boot to performance 
profile - so what exactly is the difference between dpm and profile 
method? Will dynpm react to ACPI events like lid closed or AC offline or 
I better to add calls to acpid event handlers to tweak the profiles/methods?


In any case it's just a new breath to my relict brick, especially now 
when its successor is at service repair :)


--
Looking forward to reading yours...
 Ruslan N. Marchenko

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [pull] radeon drm-next-3.11

2013-07-01 Thread Markus Trippelsdorf
On 2013.07.01 at 17:01 -0400, alexdeuc...@gmail.com wrote:
 From: Alex Deucher alexander.deuc...@amd.com
 
 Hi Dave,
 
 A few more patches for 3.11:
 - add debugfs interface to check current DPM state
 - Fix a bug that caused problems with DPM on BTC+ asics.
 
 The following changes since commit f7d452f4fd5d86f764807a1234a407deb5b105ef:
 
   Merge branch 'drm-nouveau-next' of 
 git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-07-01 
 14:10:20 +1000)
 
 are available in the git repository at:
 
   git://people.freedesktop.org/~agd5f/linux drm-next-3.11
 
 Alex Deucher (12):
   drm/radeon: remove sumo dpm/uvd bringup leftovers
   drm/radeon/atom: fix endian bug in radeon_atom_init_mc_reg_table()
   drm/radeon: fix typo in radeon_atom_init_mc_reg_table()
   drm/radeon/dpm: re-enable state transitions for BTC
   drm/radeon/dpm: re-enable state transitions for Cayman
   drm/radeon/dpm: add infrastructure to support debugfs info
   drm/radeon/dpm: add debugfs support for rv6xx
   drm/radeon/dpm: add debugfs support for 7xx/evergreen/btc

Looks like you forgot to add debugfs support for rs780:

diff --git a/drivers/gpu/drm/radeon/radeon_asic.c 
b/drivers/gpu/drm/radeon/radeon_asic.c
index a5b244d..ca4f928 100644
--- a/drivers/gpu/drm/radeon/radeon_asic.c
+++ b/drivers/gpu/drm/radeon/radeon_asic.c
@@ -1270,6 +1270,7 @@ static struct radeon_asic rs780_asic = {
.get_sclk = rs780_dpm_get_sclk,
.get_mclk = rs780_dpm_get_mclk,
.print_power_state = rs780_dpm_print_power_state,
+   .debugfs_print_current_performance_level = 
rv770_dpm_debugfs_print_current_performance_level,
},
.pflip = {
.pre_page_flip = rs600_pre_page_flip,

-- 
Markus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


RE: [pull] radeon drm-next-3.11

2013-07-01 Thread Deucher, Alexander
 -Original Message-
 From: Markus Trippelsdorf [mailto:mar...@trippelsdorf.de]
 Sent: Monday, July 01, 2013 5:58 PM
 To: alexdeuc...@gmail.com
 Cc: dri-devel@lists.freedesktop.org; airl...@gmail.com; Deucher, Alexander
 Subject: Re: [pull] radeon drm-next-3.11
 
 On 2013.07.01 at 17:01 -0400, alexdeuc...@gmail.com wrote:
  From: Alex Deucher alexander.deuc...@amd.com
 
  Hi Dave,
 
  A few more patches for 3.11:
  - add debugfs interface to check current DPM state
  - Fix a bug that caused problems with DPM on BTC+ asics.
 
  The following changes since commit
 f7d452f4fd5d86f764807a1234a407deb5b105ef:
 
Merge branch 'drm-nouveau-next' of
 git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-07-
 01 14:10:20 +1000)
 
  are available in the git repository at:
 
git://people.freedesktop.org/~agd5f/linux drm-next-3.11
 
  Alex Deucher (12):
drm/radeon: remove sumo dpm/uvd bringup leftovers
drm/radeon/atom: fix endian bug in radeon_atom_init_mc_reg_table()
drm/radeon: fix typo in radeon_atom_init_mc_reg_table()
drm/radeon/dpm: re-enable state transitions for BTC
drm/radeon/dpm: re-enable state transitions for Cayman
drm/radeon/dpm: add infrastructure to support debugfs info
drm/radeon/dpm: add debugfs support for rv6xx
drm/radeon/dpm: add debugfs support for 7xx/evergreen/btc
 
 Looks like you forgot to add debugfs support for rs780:
 
 diff --git a/drivers/gpu/drm/radeon/radeon_asic.c
 b/drivers/gpu/drm/radeon/radeon_asic.c
 index a5b244d..ca4f928 100644
 --- a/drivers/gpu/drm/radeon/radeon_asic.c
 +++ b/drivers/gpu/drm/radeon/radeon_asic.c
 @@ -1270,6 +1270,7 @@ static struct radeon_asic rs780_asic = {
   .get_sclk = rs780_dpm_get_sclk,
   .get_mclk = rs780_dpm_get_mclk,
   .print_power_state = rs780_dpm_print_power_state,
 + .debugfs_print_current_performance_level =
 rv770_dpm_debugfs_print_current_performance_level,
   },
   .pflip = {
   .pre_page_flip = rs600_pre_page_flip,
 

Rs780 doesn't have a convenient way to look up the current power state so it's 
not implemented yet.  The method used on the other asics does not work for 
rs780.

Alex


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel