Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload
On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> The bug is in the driver, so ...
>
> > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to:
> > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up
> > helpers.")
> > ... but the issue also seems to be due to a change in the generic drm code
>
> ... this one is the culprit and should be listed.
>
> > (reverting it separately fixes the issue):
> > 846c7dfc1193 ("drm/atomic: Try to preserve the crtc enabled state in
> > drm_atomic_remove_fb, v2.")
> > ... so I've included both in the commit. Is that the right thing to do?
>
> That only triggers the driver bug.
>
> I'll fix it up on commit,
> Gerd
Sorry if I misunderstood, but were you going to take the patch and fix
it up or would you like me to post a v2?
Cheers,
Sam.
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload
On Mon, Jun 17, 2019 at 11:20:34AM +1000, Sam Bobroff wrote:
> On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > The bug is in the driver, so ...
> >
> > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to:
> > > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up
> > > helpers.")
> > > ... but the issue also seems to be due to a change in the generic drm code
> >
> > ... this one is the culprit and should be listed.
> >
> > > (reverting it separately fixes the issue):
> > > 846c7dfc1193 ("drm/atomic: Try to preserve the crtc enabled state in
> > > drm_atomic_remove_fb, v2.")
> > > ... so I've included both in the commit. Is that the right thing to do?
> >
> > That only triggers the driver bug.
> >
> > I'll fix it up on commit,
> > Gerd
>
> Sorry if I misunderstood, but were you going to take the patch and fix
> it up or would you like me to post a v2?
Patch is in drm-misc-next, I fixed it on commit.
cheers,
Gerd
