Re: [PATCH] drm/exynos: remove unnecessary codes
2017년 01월 16일 18:37에 Andrzej Hajda 이(가) 쓴 글:
> On 16.01.2017 10:13, Inki Dae wrote:
>> This patch removes exynos_drm_crtc_cancel_page_flip call
>> when drm is closed because at that time, events will be released
>> by drm_events_release function.
>>
>> Change-Id: I156ea27a4c90aa87a27a50415515fa334148c912
>> Signed-off-by: Inki Dae
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 --
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> index 9d0df00..035d02e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> @@ -198,13 +198,7 @@ static int exynos_drm_open(struct drm_device *dev,
>> struct drm_file *file)
>> static void exynos_drm_preclose(struct drm_device *dev,
>> struct drm_file *file)
>> {
>> -struct drm_crtc *crtc;
>> -
>> exynos_drm_subdrv_close(dev, file);
>> -
>> -list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
>> -exynos_drm_crtc_cancel_page_flip(crtc, file);
>
> Since this is single user of exynos_drm_crtc_cancel_page_flip, this
> function can be removed as well.
Indeed. Will remove that function.
Thanks.
> Beside this:
> Reviewed-by: Andrzej Hajda
>
>
> Regards
> Andrzej
>
>> -
>> }
>>
>> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file
>> *file)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/exynos: remove unnecessary codes
Seen this quite often lately. It should be be 'code' and not 'codes'.
Code in the programming context is always a collection of instructions.
With best wishes,
Tobias
Inki Dae wrote:
> This patch removes exynos_drm_crtc_cancel_page_flip call
> when drm is closed because at that time, events will be released
> by drm_events_release function.
>
> Change-Id: I156ea27a4c90aa87a27a50415515fa334148c912
> Signed-off-by: Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 9d0df00..035d02e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -198,13 +198,7 @@ static int exynos_drm_open(struct drm_device *dev,
> struct drm_file *file)
> static void exynos_drm_preclose(struct drm_device *dev,
> struct drm_file *file)
> {
> - struct drm_crtc *crtc;
> -
> exynos_drm_subdrv_close(dev, file);
> -
> - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> - exynos_drm_crtc_cancel_page_flip(crtc, file);
> -
> }
>
> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file
> *file)
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/exynos: remove unnecessary codes
On 16.01.2017 10:13, Inki Dae wrote:
> This patch removes exynos_drm_crtc_cancel_page_flip call
> when drm is closed because at that time, events will be released
> by drm_events_release function.
>
> Change-Id: I156ea27a4c90aa87a27a50415515fa334148c912
> Signed-off-by: Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 9d0df00..035d02e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -198,13 +198,7 @@ static int exynos_drm_open(struct drm_device *dev,
> struct drm_file *file)
> static void exynos_drm_preclose(struct drm_device *dev,
> struct drm_file *file)
> {
> - struct drm_crtc *crtc;
> -
> exynos_drm_subdrv_close(dev, file);
> -
> - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> - exynos_drm_crtc_cancel_page_flip(crtc, file);
Since this is single user of exynos_drm_crtc_cancel_page_flip, this
function can be removed as well.
Beside this:
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> -
> }
>
> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file
> *file)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/exynos: remove unnecessary codes
2017년 01월 16일 18:13에 Inki Dae 이(가) 쓴 글:
> This patch removes exynos_drm_crtc_cancel_page_flip call
> when drm is closed because at that time, events will be released
> by drm_events_release function.
>
> Change-Id: I156ea27a4c90aa87a27a50415515fa334148c912
Oops, I forgot to remove above Changed-Id. Please ignore this line. I will
merge it without the line.
Thanks.
> Signed-off-by: Inki Dae
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 9d0df00..035d02e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -198,13 +198,7 @@ static int exynos_drm_open(struct drm_device *dev,
> struct drm_file *file)
> static void exynos_drm_preclose(struct drm_device *dev,
> struct drm_file *file)
> {
> - struct drm_crtc *crtc;
> -
> exynos_drm_subdrv_close(dev, file);
> -
> - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> - exynos_drm_crtc_cancel_page_flip(crtc, file);
> -
> }
>
> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file
> *file)
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
