Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Philipp Zabel
Hi Guido, Fabio,

On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
> 
> Good catch!
> 
> On Fri, Aug 2, 2019 at 7:55 AM Guido Günther  wrote:
> > 
> > Since
> > 
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one 
> > module")
> > 
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
> 
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
> 
> Apart from that:
> 
> Reviewed-by: Fabio Estevam 

Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:

drm/imx: Drop unused imx-ipuv3-crtc.o build

Since

commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one 
module")

the former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
there's no need to keep an extra entry with a non existing config value
(CONFIG_DRM_IMX_IPUV3).

Fixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one 
module")
Signed-off-by: Guido Günther 
Reviewed-by: Fabio Estevam 
Signed-off-by: Philipp Zabel 

no action necessary if you agree, otherwise just send a v2 and I'll
replace it.

regards
Philipp
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Fabio Estevam
Hi Guido,

Good catch!

On Fri, Aug 2, 2019 at 7:55 AM Guido Günther  wrote:
>
> Since
>
> commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one 
> module")
>
> imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an

Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
imx-ipuv3-crtc.o.

Apart from that:

Reviewed-by: Fabio Estevam 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel