Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
Hi, On 11/7/21 12:27, Yauhen Kharuzhy wrote: > On Sun, Nov 07, 2021 at 11:12:56AM +0100, Sam Ravnborg wrote: >> Hi Yauhen, >> On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote: >>> On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote: The Lenovo Yoga Book X91F/L uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. >>> >>> Tested on my Yoga Book, works. >> Great - and then it would be prudent that you acknowledge this with: >> Tested-by: Yauhen Kharuzhy >> >> A "Tested-by:" is in many cases better than an Acked-by: because you >> actually applied the patch, build it and verified that it works. >> Where an Acked-by: is just to say that you have looked at the patch and >> agrees with the patch. >> >> So a Tested-by: gives you the credit you deserve here. > > Yes, of course. I forgot about such option. > > Tested-by: Yauhen Kharuzhy Thank you, I've pushed this to drm-misc-next now. Regards, Hans
Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
On Sun, Nov 07, 2021 at 11:12:56AM +0100, Sam Ravnborg wrote: > Hi Yauhen, > On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote: > > On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote: > > > The Lenovo Yoga Book X91F/L uses a panel which has been mounted > > > 90 degrees rotated. Add a quirk for this. > > > > Tested on my Yoga Book, works. > Great - and then it would be prudent that you acknowledge this with: > Tested-by: Yauhen Kharuzhy > > A "Tested-by:" is in many cases better than an Acked-by: because you > actually applied the patch, build it and verified that it works. > Where an Acked-by: is just to say that you have looked at the patch and > agrees with the patch. > > So a Tested-by: gives you the credit you deserve here. Yes, of course. I forgot about such option. Tested-by: Yauhen Kharuzhy -- Yauhen Kharuzhy
Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
Hi Yauhen, On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote: > On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote: > > The Lenovo Yoga Book X91F/L uses a panel which has been mounted > > 90 degrees rotated. Add a quirk for this. > > Tested on my Yoga Book, works. Great - and then it would be prudent that you acknowledge this with: Tested-by: Yauhen Kharuzhy A "Tested-by:" is in many cases better than an Acked-by: because you actually applied the patch, build it and verified that it works. Where an Acked-by: is just to say that you have looked at the patch and agrees with the patch. So a Tested-by: gives you the credit you deserve here. Sam
Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
> The Lenovo Yoga Book X91F/L uses a panel which has been mounted
> 90 degrees rotated. Add a quirk for this.
Tested on my Yoga Book, works.
Acked-by: Yauhen Kharuzhy
> Cc: Yauhen Kharuzhy
> Signed-off-by: Hans de Goede
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d92b9408fe48..2cced702d225 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -262,6 +262,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad
> D330-10IGM"),
> },
> .driver_data = (void *)&lcd1200x1920_rightside_up,
> + }, {/* Lenovo Yoga Book X90F / X91F / X91L */
> + .matches = {
> + /* Non exact match to match all versions */
> + DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> + },
> + .driver_data = (void *)&lcd1200x1920_rightside_up,
> }, {/* OneGX1 Pro */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SYSTEM_MANUFACTURER"),
> --
> 2.31.1
>
--
Yauhen Kharuzhy
Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
Acked-by: Simon Ser
