Re: [PATCH 0/8] remove unsafe drm_for_each_connector()

2017-05-12 Thread Sean Paul 
On Thu, May 11, 2017 at 04:10:41PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan 
> 
> Hi all,
> 
> Something ligth in the middle of all my other tasks. I removed
> drm_for_each_connector() in favor of drm_for_each_connector_iter().
> 
> The i915 patch was tested, but I only *built-tested* the others!
> 
> Gustavo
> 
> ---

Hi Gustavo,
Aside from the rockchip splat, consider the rest of the series:

Reviewed-by: Sean Paul 

Once you have a v2 rockchip, I'll test and ack.

Sean

> Gustavo Padovan (8):
>   drm/exynos: use drm_for_each_connector_iter()
>   drm/rockchip: use drm_for_each_connector_iter()
>   drm/i915: use drm_for_each_connector_iter()
>   drm/mediatek: use drm_for_each_connector_iter()
>   drm/nouveau: use drm_for_each_connector_iter()
>   drm/vc4: use drm_for_each_connector_iter()
>   drm: remove unsafe drm_for_each_connector()
>   drm: todo: remove task about switch to drm_connector_list_iter
> 
>  Documentation/gpu/todo.rst  | 13 -
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 14 --
>  drivers/gpu/drm/i915/intel_display.c|  5 -
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c |  5 -
>  drivers/gpu/drm/nouveau/nv50_display.c  |  5 -
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 +-
>  drivers/gpu/drm/vc4/vc4_crtc.c  |  5 -
>  include/drm/drm_connector.h | 15 ---
>  8 files changed, 29 insertions(+), 43 deletions(-)
> 
> -- 
> 2.9.3
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Sean Paul, Software Engineer, Google / Chromium OS
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/8] remove unsafe drm_for_each_connector()

2017-05-12 Thread Daniel Vetter 
On Thu, May 11, 2017 at 04:10:41PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan 
> 
> Hi all,
> 
> Something ligth in the middle of all my other tasks. I removed
> drm_for_each_connector() in favor of drm_for_each_connector_iter().
> 
> The i915 patch was tested, but I only *built-tested* the others!

Thanks for doing this. Dropped a few comments just for more context,
spotted 1 bug in the vc4 patch, but otherwise looks all good.

I'd say respin the vc4 one, then wait 1-2 weeks for driver maintainer
acks/t-b, and then push it all through drm-misc.
-Daniel

> 
> Gustavo
> 
> ---
> Gustavo Padovan (8):
>   drm/exynos: use drm_for_each_connector_iter()
>   drm/rockchip: use drm_for_each_connector_iter()
>   drm/i915: use drm_for_each_connector_iter()
>   drm/mediatek: use drm_for_each_connector_iter()
>   drm/nouveau: use drm_for_each_connector_iter()
>   drm/vc4: use drm_for_each_connector_iter()
>   drm: remove unsafe drm_for_each_connector()
>   drm: todo: remove task about switch to drm_connector_list_iter
> 
>  Documentation/gpu/todo.rst  | 13 -
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 14 --
>  drivers/gpu/drm/i915/intel_display.c|  5 -
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c |  5 -
>  drivers/gpu/drm/nouveau/nv50_display.c  |  5 -
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 +-
>  drivers/gpu/drm/vc4/vc4_crtc.c  |  5 -
>  include/drm/drm_connector.h | 15 ---
>  8 files changed, 29 insertions(+), 43 deletions(-)
> 
> -- 
> 2.9.3
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel