Hi
Am 17.11.20 um 17:22 schrieb Ville Syrjälä:
> On Mon, Nov 16, 2020 at 09:04:28PM +0100, Thomas Zimmermann wrote:
>> If fbdev uses a shadow framebuffer, call the damage handler. Otherwise
>> the update might not make it to the screen.
>>
>> Signed-off-by: Thomas Zimmermann
>> Fixes: 222ec45f4c69 ("drm/fb_helper: Support framebuffers in I/O memory")
>> Cc: Thomas Zimmermann
>> Cc: Daniel Vetter
>> Cc: Sam Ravnborg
>> Cc: Maarten Lankhorst
>> Cc: Maxime Ripard
>> Cc: David Airlie
>> Cc: Daniel Vetter
>> Cc: Gerd Hoffmann
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: virtualizat...@lists.linux-foundation.org
>> ---
>> drivers/gpu/drm/drm_fb_helper.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_helper.c
>> b/drivers/gpu/drm/drm_fb_helper.c
>> index 25edf670867c..ee1a19e22df2 100644
>> --- a/drivers/gpu/drm/drm_fb_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -2189,6 +2189,9 @@ static ssize_t drm_fbdev_fb_write(struct fb_info
>> *info, const char __user *buf,
>> if (ret > 0)
>> *ppos += ret;
>>
>> +if (ret > 0)
>> +drm_fb_helper_dirty(info, 0, 0, info->var.xres, info->var.yres);
>
> Should that rather be 0->{x,y}res_virtual or {x,y}offset->{x,y}res?
That code snippet works in drm_fb_helper_sys_write().
However these are framebuffer-relative coordinates. I guess *res_virtual
would be more correct. I'll update the patch accordingly. Thanks for
pointing this out.
Best regards
Thomas
>
>> +
>> return ret ? ret : err;
>> }
>>
>> --
>> 2.29.2
>>
>> ___
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
