Re: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences

[Sam Ravnborg]

Hi Linus,

On Thu, Jun 15, 2023 at 10:21:37PM +0200, Linus Walleij wrote:
> The boe-tv101wum-nl6 is reinventing the mechanism to send command
> sequences that we usually nix during review, but I missed this one
> so fixing it up myself.
> 
> Also use the explicit function calls to mipi_dsi_dcs_exit_sleep_mode()
> and mipi_dsi_dcs_set_display_on() instead of reimplementing them
> with homegrown sequences.
It looks like the same sequence of calls are used in all init functions,
maybe move them out to the caller.

> 
> Signed-off-by: Linus Walleij 

I have browsed the patch, but it was impossible for me to review in
details due to the massive changes.
But the final result looks good!

With the static added as the robot noticed:
Reviewed-by: Sam Ravnborg 

Re: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences

[kernel test robot]

Hi Linus,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ac9a78681b921877518763ba0e89202254349d1b]

url:
https://github.com/intel-lab-lkp/linux/commits/Linus-Walleij/drm-panel-boe-tv101wum-nl6-Drop-macros-and-open-code-sequences/20230616-042312
base:   ac9a78681b921877518763ba0e89202254349d1b
patch link:
https://lore.kernel.org/r/20230615-fix-boe-tv101wum-nl6-v1-1-8ac378405fb7%40linaro.org
patch subject: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open 
code sequences
config: alpha-allyesconfig 
(https://download.01.org/0day-ci/archive/20230616/202306160538.b7hkwlko-...@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ac9a78681b921877518763ba0e89202254349d1b
b4 shazam 
https://lore.kernel.org/r/20230615-fix-boe-tv101wum-nl6-v1-1-8ac378405...@linaro.org
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=alpha olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/gpu/drm/panel/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot 
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202306160538.b7hkwlko-...@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c:776:5: warning: no previous 
>> prototype for 'boe_init' [-Wmissing-prototypes]
 776 | int boe_init(struct mipi_dsi_device *dsi)
 | ^~~~


vim +/boe_init +776 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c

   775  
 > 776  int boe_init(struct mipi_dsi_device *dsi)
   777  {
   778  msleep(24);
   779  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x05);
   780  mipi_dsi_dcs_write_seq(dsi, 0xB1, 0xE5);
   781  mipi_dsi_dcs_write_seq(dsi, 0xB3, 0x52);
   782  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x00);
   783  mipi_dsi_dcs_write_seq(dsi, 0xB3, 0x88);
   784  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x04);
   785  mipi_dsi_dcs_write_seq(dsi, 0xB8, 0x00);
   786  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x00);
   787  mipi_dsi_dcs_write_seq(dsi, 0xB6, 0x03);
   788  mipi_dsi_dcs_write_seq(dsi, 0xBA, 0x8B);
   789  mipi_dsi_dcs_write_seq(dsi, 0xBF, 0x1A);
   790  mipi_dsi_dcs_write_seq(dsi, 0xC0, 0x0F);
   791  mipi_dsi_dcs_write_seq(dsi, 0xC2, 0x0C);
   792  mipi_dsi_dcs_write_seq(dsi, 0xC3, 0x02);
   793  mipi_dsi_dcs_write_seq(dsi, 0xC4, 0x0C);
   794  mipi_dsi_dcs_write_seq(dsi, 0xC5, 0x02);
   795  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x01);
   796  mipi_dsi_dcs_write_seq(dsi, 0xE0, 0x26);
   797  mipi_dsi_dcs_write_seq(dsi, 0xE1, 0x26);
   798  mipi_dsi_dcs_write_seq(dsi, 0xDC, 0x00);
   799  mipi_dsi_dcs_write_seq(dsi, 0xDD, 0x00);
   800  mipi_dsi_dcs_write_seq(dsi, 0xCC, 0x26);
   801  mipi_dsi_dcs_write_seq(dsi, 0xCD, 0x26);
   802  mipi_dsi_dcs_write_seq(dsi, 0xC8, 0x00);
   803  mipi_dsi_dcs_write_seq(dsi, 0xC9, 0x00);
   804  mipi_dsi_dcs_write_seq(dsi, 0xD2, 0x03);
   805  mipi_dsi_dcs_write_seq(dsi, 0xD3, 0x03);
   806  mipi_dsi_dcs_write_seq(dsi, 0xE6, 0x04);
   807  mipi_dsi_dcs_write_seq(dsi, 0xE7, 0x04);
   808  mipi_dsi_dcs_write_seq(dsi, 0xC4, 0x09);
   809  mipi_dsi_dcs_write_seq(dsi, 0xC5, 0x09);
   810  mipi_dsi_dcs_write_seq(dsi, 0xD8, 0x0A);
   811  mipi_dsi_dcs_write_seq(dsi, 0xD9, 0x0A);
   812  mipi_dsi_dcs_write_seq(dsi, 0xC2, 0x0B);
   813  mipi_dsi_dcs_write_seq(dsi, 0xC3, 0x0B);
   814  mipi_dsi_dcs_write_seq(dsi, 0xD6, 0x0C);
   815  mipi_dsi_dcs_write_seq(dsi, 0xD7, 0x0C);
   816  mipi_dsi_dcs_write_seq(dsi, 0xC0, 0x05);
   817  mipi_dsi_dcs_write_seq(dsi, 0xC1, 0x05);
   818  mipi_dsi_dcs_write_seq(dsi, 0xD4, 0x06);
   819  mipi_dsi_dcs_write_seq(dsi, 0xD5, 0x06);
   820  mipi_dsi_dcs_write_seq(dsi, 0xCA, 0x07);
   821  mipi_dsi_dcs_write_seq(dsi, 0xCB, 0x07);
   822  mipi_dsi_dcs_write_seq(dsi, 0xDE, 0x08);
   823  mipi_dsi_dcs_write_seq(dsi, 0xDF, 0x08);
   824  mipi_dsi_dcs_write_seq(dsi, 0xB0, 0x02);
   825  mipi_dsi_dcs_write_seq(dsi, 0xC0, 0x00);
   826  mipi_dsi_dcs_write_seq(dsi, 0xC1, 0x0D);
   827  mipi_dsi_dcs_write_seq(dsi, 0xC2, 0x17);
   828  mipi_dsi_dcs_write_seq(dsi, 0xC3, 0x26);
   829  mipi_dsi_dcs_write_seq(dsi, 0xC4, 0x31);
   830  m