Re: [PATCH 1/5] pci: export pcie_get_speed_cap and pcie_get_width_cap
On Thu, Jun 28, 2018 at 10:19:41AM -0400, Alex Deucher wrote: > On Thu, Jun 28, 2018 at 9:42 AM, Bjorn Helgaas wrote: > > On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote: > >> So drivers can use them. This can be used to replace > >> duplicate code in the drm subsystem. > >> > >> Signed-off-by: Alex Deucher > > > > Acked-by: Bjorn Helgaas > > > > Thanks a lot for doing this! > > > > If you haven't applied these yet, please > > > > s/pci: export/PCI: Export/ > > > > in the subject. > > > Will fix. Any objections to taking this via the drm tree? Nope, I acked it because I assumed you would merge it along with the rest of the series via some non-PCI tree, so the drm tree would be great. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/5] pci: export pcie_get_speed_cap and pcie_get_width_cap
On Thu, Jun 28, 2018 at 9:42 AM, Bjorn Helgaas wrote:
> On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote:
>> So drivers can use them. This can be used to replace
>> duplicate code in the drm subsystem.
>>
>> Signed-off-by: Alex Deucher
>
> Acked-by: Bjorn Helgaas
>
> Thanks a lot for doing this!
>
> If you haven't applied these yet, please
>
> s/pci: export/PCI: Export/
>
> in the subject.
Will fix. Any objections to taking this via the drm tree?
Thanks,
Alex
>
>> ---
>> drivers/pci/pci.c | 2 ++
>> include/linux/pci.h | 3 +++
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>> index 97acba712e4e..22adaf35b136 100644
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -5222,6 +5222,7 @@ enum pci_bus_speed pcie_get_speed_cap(struct pci_dev
>> *dev)
>>
>> return PCI_SPEED_UNKNOWN;
>> }
>> +EXPORT_SYMBOL(pcie_get_speed_cap);
>>
>> /**
>> * pcie_get_width_cap - query for the PCI device's link width capability
>> @@ -5240,6 +5241,7 @@ enum pcie_link_width pcie_get_width_cap(struct pci_dev
>> *dev)
>>
>> return PCIE_LNK_WIDTH_UNKNOWN;
>> }
>> +EXPORT_SYMBOL(pcie_get_width_cap);
>>
>> /**
>> * pcie_bandwidth_capable - calculate a PCI device's link bandwidth
>> capability
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 340029b2fb38..6e0c0803b241 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -261,6 +261,9 @@ enum pci_bus_speed {
>> PCI_SPEED_UNKNOWN = 0xff,
>> };
>>
>> +enum pci_bus_speed pcie_get_speed_cap(struct pci_dev *dev);
>> +enum pcie_link_width pcie_get_width_cap(struct pci_dev *dev);
>> +
>> struct pci_cap_saved_data {
>> u16 cap_nr;
>> boolcap_extended;
>> --
>> 2.13.6
>>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/5] pci: export pcie_get_speed_cap and pcie_get_width_cap
On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote:
> So drivers can use them. This can be used to replace
> duplicate code in the drm subsystem.
>
> Signed-off-by: Alex Deucher
Acked-by: Bjorn Helgaas
Thanks a lot for doing this!
If you haven't applied these yet, please
s/pci: export/PCI: Export/
in the subject.
> ---
> drivers/pci/pci.c | 2 ++
> include/linux/pci.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 97acba712e4e..22adaf35b136 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -5222,6 +5222,7 @@ enum pci_bus_speed pcie_get_speed_cap(struct pci_dev
> *dev)
>
> return PCI_SPEED_UNKNOWN;
> }
> +EXPORT_SYMBOL(pcie_get_speed_cap);
>
> /**
> * pcie_get_width_cap - query for the PCI device's link width capability
> @@ -5240,6 +5241,7 @@ enum pcie_link_width pcie_get_width_cap(struct pci_dev
> *dev)
>
> return PCIE_LNK_WIDTH_UNKNOWN;
> }
> +EXPORT_SYMBOL(pcie_get_width_cap);
>
> /**
> * pcie_bandwidth_capable - calculate a PCI device's link bandwidth
> capability
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 340029b2fb38..6e0c0803b241 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -261,6 +261,9 @@ enum pci_bus_speed {
> PCI_SPEED_UNKNOWN = 0xff,
> };
>
> +enum pci_bus_speed pcie_get_speed_cap(struct pci_dev *dev);
> +enum pcie_link_width pcie_get_width_cap(struct pci_dev *dev);
> +
> struct pci_cap_saved_data {
> u16 cap_nr;
> boolcap_extended;
> --
> 2.13.6
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
