Re: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices

2013-08-14 Thread Rob Clark
On Wed, Aug 14, 2013 at 8:16 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
 On Tue, Aug 06, 2013 at 12:20:11AM +0200, Sebastian Hesselbarth wrote:
 From: Russell King rmk+ker...@arm.linux.org.uk

 TDA19988 devices need their RAM enabled in order to read EDID
 information.  Add support for this.

 Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
 Tested-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com

 There was some debate about whether this is needed or not.  It seems that
 if I don't run the NXP driver, it isn't needed, but if I have run the
 NXP driver, then yes it is.  As it seems to do no harm, I think it's fine
 to be submitted.

just fwiw, I had noticed before that (at least on the
beaglebone-black), nxp doesn't necessarily get reset when doing a warm
reboot.  So booting a kernel w/ NXP driver, and then rebooting w/
upstream kernel and tda998x should probably hit this same scenario.
Better to not assume too much about the state of the tda when the
driver is loaded, so I think this patch is a good idea.

Signed-off-by: Rob Clark robdcl...@gmail.com

BR,
-R
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices

2013-08-14 Thread Russell King - ARM Linux
On Tue, Aug 06, 2013 at 12:20:11AM +0200, Sebastian Hesselbarth wrote:
 From: Russell King rmk+ker...@arm.linux.org.uk
 
 TDA19988 devices need their RAM enabled in order to read EDID
 information.  Add support for this.
 
 Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
 Tested-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com

There was some debate about whether this is needed or not.  It seems that
if I don't run the NXP driver, it isn't needed, but if I have run the
NXP driver, then yes it is.  As it seems to do no harm, I think it's fine
to be submitted.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel