Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series

2024-06-24 Thread Rob Herring
On Mon, Jun 24, 2024 at 03:30:27AM +0200, Caleb Connolly wrote:
> Add bindings for the OnePlus 8, 8 Pro, and 8T devices.
> 
> Signed-off-by: Caleb Connolly 
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml 
> b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d839691a900c..a41eeb8c3fc5 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -986,8 +986,11 @@ properties:
>- enum:
>- qcom,qrb5165-rb5
>- qcom,sm8250-hdk
>- qcom,sm8250-mtp
> +  - oneplus,kebab
> +  - oneplus,instantnoodle
> +  - oneplus,instantnoodlep

Which one is which device in the commit msg? I can only guess that 'p' 
here corresponds to Pro. A comment after the compatibles would help.

>- sony,pdx203-generic
>- sony,pdx206-generic
>- xiaomi,elish
>- xiaomi,pipa
> 
> -- 
> 2.45.0
> 


Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series

2024-06-23 Thread Krzysztof Kozlowski
On 24/06/2024 03:30, Caleb Connolly wrote:
> Add bindings for the OnePlus 8, 8 Pro, and 8T devices.
> 
> Signed-off-by: Caleb Connolly 

Acked-by: Krzysztof Kozlowski 

Best regards,
Krzysztof