Re: [PATCH linux-next] drm/i915/request: Remove unused variables
On Sun, 21 Nov 2021, Christophe JAILLET wrote:
> Le 21/11/2021 à 11:13, cgel@gmail.com a écrit :
>> From: yong yiran
>>
>> The clang_analyzer complains as follows:
>> drivers/gpu/drm/i915/i915_request.c:2119:2 warning:
>> Value stored to 'x' is never read
>>
>> Reported-by: Zeal Robot
>> Signed-off-by: yong yiran
The sender's Signed-off-by is missing.
>> ---
>> drivers/gpu/drm/i915/i915_request.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_request.c
>> b/drivers/gpu/drm/i915/i915_request.c
>> index 820a1f38b271..5e4420f461e9 100644
>> --- a/drivers/gpu/drm/i915/i915_request.c
>> +++ b/drivers/gpu/drm/i915/i915_request.c
>> @@ -2047,7 +2047,6 @@ void i915_request_show(struct drm_printer *m,
>> {
>> const char *name = rq->fence.ops->get_timeline_name((struct dma_fence
>> *)&rq->fence);
>> char buf[80] = "";
>> -int x = 0;
>>
>> /*
>> * The prefix is used to show the queue status, for which we use
>> @@ -2079,8 +2078,6 @@ void i915_request_show(struct drm_printer *m,
>> * from the lists
>> */
>>
>> -x = print_sched_attr(&rq->sched.attr, buf, x, sizeof(buf));
>> -
>
> Seriously?
Basically I've started considering all of these patches as static
analyzer reports *only*. The "fixes" have often been completely wrong or
have missed the real issue and merely silenced the warning.
I really couldn't say anything about the "Zeal Robot" itself, but the
patches are giving it a bad reputation.
BR,
Jani.
>
> CJ
>
>
>> drm_printf(m, "%s%.*s%c %llx:%lld%s%s %s @ %dms: %s\n",
>> prefix, indent, "",
>> queue_status(rq),
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
Re: [PATCH linux-next] drm/i915/request: Remove unused variables
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-2028]
url:
https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441
base:5191249f880367a4cd675825cd721a8d78f26a45
config: x86_64-randconfig-c007-20211121 (attached as .config)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/117f34e1836e312bdea3b7c886d829e30f55a094
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441
git checkout 117f34e1836e312bdea3b7c886d829e30f55a094
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/i915_request.c:2032:12: error: unused function
>> 'print_sched_attr' [-Werror,-Wunused-function]
static int print_sched_attr(const struct i915_sched_attr *attr,
^
1 error generated.
vim +/print_sched_attr +2032 drivers/gpu/drm/i915/i915_request.c
7e2e69ed4678a4 Maarten Lankhorst 2021-10-21 2031
1f0e785a9cc09b Chris Wilson 2020-11-19 @2032 static int
print_sched_attr(const struct i915_sched_attr *attr,
1f0e785a9cc09b Chris Wilson 2020-11-19 2033
char *buf, int x, int len)
1f0e785a9cc09b Chris Wilson 2020-11-19 2034 {
1f0e785a9cc09b Chris Wilson 2020-11-19 2035 if (attr->priority ==
I915_PRIORITY_INVALID)
1f0e785a9cc09b Chris Wilson 2020-11-19 2036 return x;
1f0e785a9cc09b Chris Wilson 2020-11-19 2037
1f0e785a9cc09b Chris Wilson 2020-11-19 2038 x += snprintf(buf + x,
len - x,
1f0e785a9cc09b Chris Wilson 2020-11-19 2039 "
prio=%d", attr->priority);
1f0e785a9cc09b Chris Wilson 2020-11-19 2040
1f0e785a9cc09b Chris Wilson 2020-11-19 2041 return x;
1f0e785a9cc09b Chris Wilson 2020-11-19 2042 }
1f0e785a9cc09b Chris Wilson 2020-11-19 2043
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
Re: [PATCH linux-next] drm/i915/request: Remove unused variables
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-2028]
url:
https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441
base:5191249f880367a4cd675825cd721a8d78f26a45
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/117f34e1836e312bdea3b7c886d829e30f55a094
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441
git checkout 117f34e1836e312bdea3b7c886d829e30f55a094
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/i915_request.c:2032:12: error: 'print_sched_attr'
>> defined but not used [-Werror=unused-function]
2032 | static int print_sched_attr(const struct i915_sched_attr *attr,
|^~~~
cc1: all warnings being treated as errors
vim +/print_sched_attr +2032 drivers/gpu/drm/i915/i915_request.c
7e2e69ed4678a4 Maarten Lankhorst 2021-10-21 2031
1f0e785a9cc09b Chris Wilson 2020-11-19 @2032 static int
print_sched_attr(const struct i915_sched_attr *attr,
1f0e785a9cc09b Chris Wilson 2020-11-19 2033
char *buf, int x, int len)
1f0e785a9cc09b Chris Wilson 2020-11-19 2034 {
1f0e785a9cc09b Chris Wilson 2020-11-19 2035 if (attr->priority ==
I915_PRIORITY_INVALID)
1f0e785a9cc09b Chris Wilson 2020-11-19 2036 return x;
1f0e785a9cc09b Chris Wilson 2020-11-19 2037
1f0e785a9cc09b Chris Wilson 2020-11-19 2038 x += snprintf(buf + x,
len - x,
1f0e785a9cc09b Chris Wilson 2020-11-19 2039 "
prio=%d", attr->priority);
1f0e785a9cc09b Chris Wilson 2020-11-19 2040
1f0e785a9cc09b Chris Wilson 2020-11-19 2041 return x;
1f0e785a9cc09b Chris Wilson 2020-11-19 2042 }
1f0e785a9cc09b Chris Wilson 2020-11-19 2043
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
Re: [PATCH linux-next] drm/i915/request: Remove unused variables
Le 21/11/2021 à 11:13, cgel@gmail.com a écrit :
From: yong yiran
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/i915_request.c:2119:2 warning:
Value stored to 'x' is never read
Reported-by: Zeal Robot
Signed-off-by: yong yiran
---
drivers/gpu/drm/i915/i915_request.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c
b/drivers/gpu/drm/i915/i915_request.c
index 820a1f38b271..5e4420f461e9 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -2047,7 +2047,6 @@ void i915_request_show(struct drm_printer *m,
{
const char *name = rq->fence.ops->get_timeline_name((struct dma_fence
*)&rq->fence);
char buf[80] = "";
- int x = 0;
/*
* The prefix is used to show the queue status, for which we use
@@ -2079,8 +2078,6 @@ void i915_request_show(struct drm_printer *m,
* from the lists
*/
- x = print_sched_attr(&rq->sched.attr, buf, x, sizeof(buf));
-
Seriously?
CJ
drm_printf(m, "%s%.*s%c %llx:%lld%s%s %s @ %dms: %s\n",
prefix, indent, "",
queue_status(rq),
