Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-25 Thread Rob Herring 


On Wed, 13 Mar 2024 19:28:55 +0100, Krzysztof Kozlowski wrote:
> Convert Samsung Exynos5250/5420 SoC Display Port Controller bindings to
> DT schema with a change: add power-domains, already used in DTS.
> 
> This Display Port controller is actually variant of Analogix Display
> Port bridge, however new DT Schema does not reference analogix,dp.yaml,
> because of incompatibilities in the driver.  The analogix,dp.yaml
> expects two ports, input and output, but Linux Exynos DP DRM driver and
> DTS use only one port: output.
> 
> Signed-off-by: Krzysztof Kozlowski 
> 
> ---
> 
> Changes in v2:
> 1. Document deprecated samsung,hpd-gpios
> ---
>  .../bindings/display/exynos/exynos_dp.txt | 112 
>  .../display/samsung/samsung,exynos5-dp.yaml   | 163 ++
>  2 files changed, 163 insertions(+), 112 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>  create mode 100644 
> Documentation/devicetree/bindings/display/samsung/samsung,exynos5-dp.yaml
> 

Applied, thanks!

Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-21 Thread Rob Herring 
On Thu, Mar 21, 2024 at 08:37:15AM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2024 18:04, Conor Dooley wrote:
> > On Wed, Mar 13, 2024 at 07:28:55PM +0100, Krzysztof Kozlowski wrote:
> > 
> >> +  clock-names:
> >> +items:
> >> +  - const: dp
> > 
> >> +  phy-names:
> >> +items:
> >> +  - const: dp
> > 
> > The items lists here are redundant when you only have a single item, no?
> > Isnt it just
> > phy-names:
> >   const: dp
> 
> Somehow the convention for properties was to define the list. Unlike for
> compatible where we use shorter syntax like you propose. Shall we change
> the approach and use shorter syntax in general?

I guess the difference is -names is usually more than 1 whereas 
compatible is frequently only 1. Either way is fine I think.

Rob

Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-21 Thread Krzysztof Kozlowski 
On 20/03/2024 18:04, Conor Dooley wrote:
> On Wed, Mar 13, 2024 at 07:28:55PM +0100, Krzysztof Kozlowski wrote:
> 
>> +  clock-names:
>> +items:
>> +  - const: dp
> 
>> +  phy-names:
>> +items:
>> +  - const: dp
> 
> The items lists here are redundant when you only have a single item, no?
> Isnt it just
> phy-names:
>   const: dp

Somehow the convention for properties was to define the list. Unlike for
compatible where we use shorter syntax like you propose. Shall we change
the approach and use shorter syntax in general?

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-20 Thread Conor Dooley 
On Wed, Mar 13, 2024 at 07:28:55PM +0100, Krzysztof Kozlowski wrote:

> +  clock-names:
> +items:
> +  - const: dp

> +  phy-names:
> +items:
> +  - const: dp

The items lists here are redundant when you only have a single item, no?
Isnt it just
phy-names:
  const: dp
?

Otherwise,
Reviewed-by: Conor Dooley 

Thanks,
Conor.


signature.asc
Description: PGP signature