Re: [PATCH v4 12/15] drm/mediatek: add MT8365 SoC support

[Alexandre Mergnat]

On 21/06/2024 17:24, Chun-Kuang Hu wrote:

Hi, Alexandre:

  於 2024年5月23日 週四 下午8:49寫道：

From: Fabien Parent

Add DRM support for MT8365 SoC.

Signed-off-by: Fabien Parent
Reviewed-by: AngeloGioacchino Del Regno
Signed-off-by: Alexandre Mergnat
---
  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 
  1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c 
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index ce8f3cc6e853..e1c3281651ae 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -318,6 +318,10 @@ static const struct mtk_mmsys_driver_data 
mt8195_vdosys1_driver_data = {
 .mmsys_dev_num = 2,
  };

+static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {
+   .mmsys_dev_num = 1,

You do not describe the pipeline information here. I think display
function would not work.


Hi Chun-Kuang,

I don't describe the pipeline information here because I do it
in the DTS thanks to the OF graphs Angelo's serie [1].
I've tested DSI and DPI display, they work correctly ;)

[1] 
https://lore.kernel.org/all/20240618101726.110416-1-angelogioacchino.delre...@collabora.com/

--
Regards,
Alexandre

Re: [PATCH v4 12/15] drm/mediatek: add MT8365 SoC support

[Chun-Kuang Hu]

Hi, Alexandre:

 於 2024年5月23日 週四 下午8:49寫道：
>
> From: Fabien Parent 
>
> Add DRM support for MT8365 SoC.
>
> Signed-off-by: Fabien Parent 
> Reviewed-by: AngeloGioacchino Del Regno 
> 
> Signed-off-by: Alexandre Mergnat 
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c 
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index ce8f3cc6e853..e1c3281651ae 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -318,6 +318,10 @@ static const struct mtk_mmsys_driver_data 
> mt8195_vdosys1_driver_data = {
> .mmsys_dev_num = 2,
>  };
>
> +static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {
> +   .mmsys_dev_num = 1,

You do not describe the pipeline information here. I think display
function would not work.

Regards,
Chun-Kuang.

> +};
> +
>  static const struct of_device_id mtk_drm_of_ids[] = {
> { .compatible = "mediatek,mt2701-mmsys",
>   .data = _mmsys_driver_data},
> @@ -345,6 +349,8 @@ static const struct of_device_id mtk_drm_of_ids[] = {
>   .data = _vdosys0_driver_data},
> { .compatible = "mediatek,mt8195-vdosys1",
>   .data = _vdosys1_driver_data},
> +   { .compatible = "mediatek,mt8365-mmsys",
> + .data = _mmsys_driver_data},
> { }
>  };
>  MODULE_DEVICE_TABLE(of, mtk_drm_of_ids);
> @@ -732,6 +738,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
>   .data = (void *)MTK_DISP_MUTEX },
> { .compatible = "mediatek,mt8195-disp-mutex",
>   .data = (void *)MTK_DISP_MUTEX },
> +   { .compatible = "mediatek,mt8365-disp-mutex",
> + .data = (void *)MTK_DISP_MUTEX },
> { .compatible = "mediatek,mt8173-disp-od",
>   .data = (void *)MTK_DISP_OD },
> { .compatible = "mediatek,mt2701-disp-ovl",
>
> --
> 2.25.1
>