Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code
On Wed, 2022-06-01 at 12:02 +0100, Peter Robinson wrote:
> Runtime PM doesn't seem to work correctly on this driver. On top of
> that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static
> variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the
> driver's PM ops were not hooked-up.
>
> So, in order to support regular operation with V3D on BCM2711 (Raspberry
> Pi 4), get rid of the PM code. PM will be reinstated once we figure out
> the underlying issues.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Peter Robinson
> ---
Hi Florian, any thoughts on this?
Are brcm,7268-v3d and brcm,7278-v3d using runtime PM downstream?
Nicolas
Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code
On 6/1/22 13:02, Peter Robinson wrote:
> Runtime PM doesn't seem to work correctly on this driver. On top of
> that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static
> variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the
> driver's PM ops were not hooked-up.
>
> So, in order to support regular operation with V3D on BCM2711 (Raspberry
> Pi 4), get rid of the PM code. PM will be reinstated once we figure out
> the underlying issues.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Peter Robinson
> ---
This makes sense to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code
On Wed, Jun 1, 2022 at 4:03 AM Peter Robinson wrote:
> Runtime PM doesn't seem to work correctly on this driver. On top of
> that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static
> variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the
> driver's PM ops were not hooked-up.
>
> So, in order to support regular operation with V3D on BCM2711 (Raspberry
> Pi 4), get rid of the PM code. PM will be reinstated once we figure out
> the underlying issues.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Peter Robinson
>
If I remember right, I had runtime PM working on non-2711 hardware. I
never managed to get anyone to help with why 2711's power-on would fail,
and rpi just cranked the clock down as low as it would go as the power
management solution downstream.
I'm not sure what the right thing to do is, given all that. Just some
context.
