Re: [PATCH v9 00/15] Clean up "mediatek,larb"
On Mon, Dec 06, 2021 at 01:33:36PM +0100, Hans Verkuil wrote: > I think it might be easiest if it is all going through the media subsystem > (except for the dts patches, we don't handle those unless specifically > requested to do so). I need a resend for jpeg bindings txt to yaml > conversion series first, though. This time with the linux-media mailinglist > included :-) > > I would need your Ack for the iommu patches as well, of course. Okay, makes sense. IOMMU parts are Acked-by: Joerg Roedel
Re: [PATCH v9 00/15] Clean up "mediatek,larb"
On Mon, Dec 6, 2021 at 8:23 PM Hans Verkuil wrote: > > Hi Yong Wu, > > On 12/11/2021 11:54, Yong Wu wrote: > > MediaTek IOMMU block diagram always like below: > > > > M4U > > | > > smi-common > > | > > - > > | | ... > > | | > > larb1 larb2 > > | | > > vdec venc > > > > All the consumer connect with smi-larb, then connect with smi-common. > > > > When the consumer works, it should enable the smi-larb's power which also > > need enable the smi-common's power firstly. > > > > Thus, Firstly, use the device link connect the consumer and the > > smi-larbs. then add device link between the smi-larb and smi-common. > > > > After adding the device_link, then "mediatek,larb" property can be removed. > > the iommu consumer don't need call the mtk_smi_larb_get/put to enable > > the power and clock of smi-larb and smi-common. > > > > Base on a jpeg dt-bing patchset[1] that already got the necessary R-b. > > > > This patchset cross several tree, From [2], the media tree should be a good > > choice. > > > > [1] > > https://lore.kernel.org/linux-mediatek/20210702102304.3346429-1-hsi...@chromium.org/ > > Please resend this patch series converting the jpeg bindings to yaml, and > this time > CC the linux-media mailinglist. Because that was omitted, it never appeared > in the > media patchwork system, and so this was never merged. Since this patch series > depends on > this series, this needs to be merged first. Hi Hans, I've resent a v6 and cc linux-media: https://patchwork.linuxtv.org/project/linux-media/patch/20211206130425.184420-1-hsi...@chromium.org/ thanks > > Bindings for media drivers must be CC-ed to linux-media, since we maintain > those. > > Regards, > > Hans > > > [2] > > https://lore.kernel.org/linux-mediatek/e7269c80-5437-6ab9-c1db-df0b94eb9...@gmail.com/ > > > > Change notes: > > v9: 1) Add return -ENODEV when the dev is null. > > 2) Add more strict about the case that a iommu consume device use the > > ports in > > different larbs. Don't allow this case. > > 3) Remove two codec interface: mtk_vcodec_release_enc/dec_pm since it > > only has one > > line now. > > > > v8: > > https://lore.kernel.org/linux-mediatek/20210929013719.25120-1-yong...@mediatek.com/ > > 1) Rebase on v5.15-rc1. > > 2) Don't rebase the below mdp patchset that may still need more discuss. > > > > https://lore.kernel.org/linux-mediatek/20210709022324.1607884-1-ei...@chromium.org/ > > 3) Add Frank's Tested-by. Remove Dafna's Tested-by as he requested. > > > > v7: > > https://lore.kernel.org/linux-mediatek/20210730025238.22456-1-yong...@mediatek.com/ > > 1) Fix a arm32 boot fail issue. reported from Frank. > > 2) Add a return fail in the mtk drm. suggested by Dafna. > > > > v6: > > https://lore.kernel.org/linux-mediatek/20210714025626.5528-1-yong...@mediatek.com/ > > 1) rebase on v5.14-rc1. > > 2) Fix the issue commented in v5 from Dafna and Hsin-Yi. > > 3) Remove the patches about using pm_runtime_resume_and_get since they > > have > >already been merged by other patches. > > > > v5: > > https://lore.kernel.org/linux-mediatek/20210410091128.31823-1-yong...@mediatek.com/ > > 1) Base v5.12-rc2. > > 2) Remove changing the mtk-iommu to module_platform_driver patch, It > > have already been a > > independent patch. > > > > v4: > > https://lore.kernel.org/linux-mediatek/1590826218-23653-1-git-send-email-yong...@mediatek.com/ > > base on v5.7-rc1. > > 1) Move drm PM patch before smi patchs. > > 2) Change builtin_platform_driver to module_platform_driver since we may > > need > > build as module. > > 3) Rebase many patchset as above. > > > > v3: > > https://lore.kernel.org/linux-iommu/1567503456-24725-1-git-send-email-yong...@mediatek.com/ > > 1) rebase on v5.3-rc1 and the latest mt8183 patchset. > > 2) Use device_is_bound to check whether the driver is ready from > > Matthias. > > 3) Add DL_FLAG_STATELESS flag when calling device_link_add and explain > > the > >reason in the commit message[3/14]. > > 4) Add a display patch[12/14] into this series. otherwise it may affect > >display HW fastlogo even though it don't happen in mt8183. > > > > v2: > > https://lore.kernel.org/linux-iommu/1560171313-28299-1-git-send-email-yong...@mediatek.com/ > >1) rebase on v5.2-rc1. > >2) Move adding device_link between the consumer and smi-larb into > > iommu_add_device from Robin. > >3) add DL_FLAG_AUTOREMOVE_CONSUMER even though the smi is built-in from > > Evan. > >4) Remove the shutdown callback in iommu. > > > > v1: > > https://lore.kernel.org/linux-iommu/1546318276-18993-1-git-send-email-yong...@mediatek.com/ > > > > Yong Wu (14): > > dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW > > iommu/mediatek-v1: Free the existed fwspec if the master dev already > > has > > iommu/mediatek: Return
Re: [PATCH v9 00/15] Clean up "mediatek,larb"
On 06/12/2021 12:52, Joerg Roedel wrote: > On Fri, Nov 12, 2021 at 06:54:54PM +0800, Yong Wu wrote: >> Yong Wu (14): >> dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW >> iommu/mediatek-v1: Free the existed fwspec if the master dev already >> has >> iommu/mediatek: Return ENODEV if the device is NULL >> iommu/mediatek: Add probe_defer for smi-larb >> iommu/mediatek: Add device_link between the consumer and the larb >> devices >> media: mtk-jpeg: Get rid of mtk_smi_larb_get/put >> media: mtk-mdp: Get rid of mtk_smi_larb_get/put >> drm/mediatek: Get rid of mtk_smi_larb_get/put >> media: mtk-vcodec: Get rid of mtk_smi_larb_get/put >> media: mtk-vcodec: dec: Remove mtk_vcodec_release_dec_pm >> media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm >> memory: mtk-smi: Get rid of mtk_smi_larb_get/put >> arm: dts: mediatek: Get rid of mediatek, larb for MM nodes >> arm64: dts: mediatek: Get rid of mediatek, larb for MM nodes >> >> Yongqiang Niu (1): >> drm/mediatek: Add pm runtime support for ovl and rdma > > What is the plan for merging this? If Matthias has no objections I can > take the iommu-parts, or will this go through another tree? I think it might be easiest if it is all going through the media subsystem (except for the dts patches, we don't handle those unless specifically requested to do so). I need a resend for jpeg bindings txt to yaml conversion series first, though. This time with the linux-media mailinglist included :-) I would need your Ack for the iommu patches as well, of course. Regards, Hans
Re: [PATCH v9 00/15] Clean up "mediatek,larb"
Hi Yong Wu, On 12/11/2021 11:54, Yong Wu wrote: > MediaTek IOMMU block diagram always like below: > > M4U > | > smi-common > | > - > | | ... > | | > larb1 larb2 > | | > vdec venc > > All the consumer connect with smi-larb, then connect with smi-common. > > When the consumer works, it should enable the smi-larb's power which also > need enable the smi-common's power firstly. > > Thus, Firstly, use the device link connect the consumer and the > smi-larbs. then add device link between the smi-larb and smi-common. > > After adding the device_link, then "mediatek,larb" property can be removed. > the iommu consumer don't need call the mtk_smi_larb_get/put to enable > the power and clock of smi-larb and smi-common. > > Base on a jpeg dt-bing patchset[1] that already got the necessary R-b. > > This patchset cross several tree, From [2], the media tree should be a good > choice. > > [1] > https://lore.kernel.org/linux-mediatek/20210702102304.3346429-1-hsi...@chromium.org/ Please resend this patch series converting the jpeg bindings to yaml, and this time CC the linux-media mailinglist. Because that was omitted, it never appeared in the media patchwork system, and so this was never merged. Since this patch series depends on this series, this needs to be merged first. Bindings for media drivers must be CC-ed to linux-media, since we maintain those. Regards, Hans > [2] > https://lore.kernel.org/linux-mediatek/e7269c80-5437-6ab9-c1db-df0b94eb9...@gmail.com/ > > Change notes: > v9: 1) Add return -ENODEV when the dev is null. > 2) Add more strict about the case that a iommu consume device use the > ports in > different larbs. Don't allow this case. > 3) Remove two codec interface: mtk_vcodec_release_enc/dec_pm since it > only has one > line now. > > v8: > https://lore.kernel.org/linux-mediatek/20210929013719.25120-1-yong...@mediatek.com/ > 1) Rebase on v5.15-rc1. > 2) Don't rebase the below mdp patchset that may still need more discuss. > > https://lore.kernel.org/linux-mediatek/20210709022324.1607884-1-ei...@chromium.org/ > 3) Add Frank's Tested-by. Remove Dafna's Tested-by as he requested. > > v7: > https://lore.kernel.org/linux-mediatek/20210730025238.22456-1-yong...@mediatek.com/ > 1) Fix a arm32 boot fail issue. reported from Frank. > 2) Add a return fail in the mtk drm. suggested by Dafna. > > v6: > https://lore.kernel.org/linux-mediatek/20210714025626.5528-1-yong...@mediatek.com/ > 1) rebase on v5.14-rc1. > 2) Fix the issue commented in v5 from Dafna and Hsin-Yi. > 3) Remove the patches about using pm_runtime_resume_and_get since they > have >already been merged by other patches. > > v5: > https://lore.kernel.org/linux-mediatek/20210410091128.31823-1-yong...@mediatek.com/ > 1) Base v5.12-rc2. > 2) Remove changing the mtk-iommu to module_platform_driver patch, It have > already been a > independent patch. > > v4: > https://lore.kernel.org/linux-mediatek/1590826218-23653-1-git-send-email-yong...@mediatek.com/ > > base on v5.7-rc1. > 1) Move drm PM patch before smi patchs. > 2) Change builtin_platform_driver to module_platform_driver since we may > need > build as module. > 3) Rebase many patchset as above. > > v3: > https://lore.kernel.org/linux-iommu/1567503456-24725-1-git-send-email-yong...@mediatek.com/ > 1) rebase on v5.3-rc1 and the latest mt8183 patchset. > 2) Use device_is_bound to check whether the driver is ready from > Matthias. > 3) Add DL_FLAG_STATELESS flag when calling device_link_add and explain the >reason in the commit message[3/14]. > 4) Add a display patch[12/14] into this series. otherwise it may affect >display HW fastlogo even though it don't happen in mt8183. > > v2: > https://lore.kernel.org/linux-iommu/1560171313-28299-1-git-send-email-yong...@mediatek.com/ >1) rebase on v5.2-rc1. >2) Move adding device_link between the consumer and smi-larb into > iommu_add_device from Robin. >3) add DL_FLAG_AUTOREMOVE_CONSUMER even though the smi is built-in from > Evan. >4) Remove the shutdown callback in iommu. > > v1: > https://lore.kernel.org/linux-iommu/1546318276-18993-1-git-send-email-yong...@mediatek.com/ > > Yong Wu (14): > dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW > iommu/mediatek-v1: Free the existed fwspec if the master dev already > has > iommu/mediatek: Return ENODEV if the device is NULL > iommu/mediatek: Add probe_defer for smi-larb > iommu/mediatek: Add device_link between the consumer and the larb > devices > media: mtk-jpeg: Get rid of mtk_smi_larb_get/put > media: mtk-mdp: Get rid of mtk_smi_larb_get/put > drm/mediatek: Get rid of mtk_smi_larb_get/put > media: mtk-vcodec: Get rid of mtk_smi_larb_get/put > media: mtk-vcodec: dec: Remove mtk_vcodec_release_dec_pm
Re: [PATCH v9 00/15] Clean up "mediatek,larb"
On Fri, Nov 12, 2021 at 06:54:54PM +0800, Yong Wu wrote: > Yong Wu (14): > dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW > iommu/mediatek-v1: Free the existed fwspec if the master dev already > has > iommu/mediatek: Return ENODEV if the device is NULL > iommu/mediatek: Add probe_defer for smi-larb > iommu/mediatek: Add device_link between the consumer and the larb > devices > media: mtk-jpeg: Get rid of mtk_smi_larb_get/put > media: mtk-mdp: Get rid of mtk_smi_larb_get/put > drm/mediatek: Get rid of mtk_smi_larb_get/put > media: mtk-vcodec: Get rid of mtk_smi_larb_get/put > media: mtk-vcodec: dec: Remove mtk_vcodec_release_dec_pm > media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm > memory: mtk-smi: Get rid of mtk_smi_larb_get/put > arm: dts: mediatek: Get rid of mediatek, larb for MM nodes > arm64: dts: mediatek: Get rid of mediatek, larb for MM nodes > > Yongqiang Niu (1): > drm/mediatek: Add pm runtime support for ovl and rdma What is the plan for merging this? If Matthias has no objections I can take the iommu-parts, or will this go through another tree? Regards, Joerg
