Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Sebastian Reichel]

Hi,

On Thu, Feb 08, 2018 at 12:53:16PM +0200, Tomi Valkeinen wrote:
> On 08/02/18 11:41, Pavel Machek wrote:
> >> I've also picked patches 7-12.
> > 
> > It seems that part of the support made it to v4.16. Is it supposed to
> > be complete?
> > 
> > I still have these in my tree, and result works on Nokia N9. Is there
> > any way I can help with the merge?
> 
> I picked the patches that seemed safe to pick. I think we can do another
> review round if someone rebases and posts the patches. Although I see
> that they have conflicts with other patches that have been posted, so
> we'll see how it goes.
> 
> Btw, you seem to have something in your tree that was not in the series.
> Nothing in the series touches mipi_display.h.

I have a rebased series based on recent origin/master. It works
properly on Droid 4 (omap4), but has issues on omap3 even with
the fifo bug fix applied. I do not yet know the reason, but I
think we should proceed anyways. I originally planned to send
this based on rc1, but will do so now.

-- Sebastian


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tomi Valkeinen]

On 08/02/18 11:41, Pavel Machek wrote:
> Hi!
> 
>> I've also picked patches 7-12.
> 
> It seems that part of the support made it to v4.16. Is it supposed to
> be complete?
> 
> I still have these in my tree, and result works on Nokia N9. Is there
> any way I can help with the merge?

I picked the patches that seemed safe to pick. I think we can do another
review round if someone rebases and posts the patches. Although I see
that they have conflicts with other patches that have been posted, so
we'll see how it goes.

Btw, you seem to have something in your tree that was not in the series.
Nothing in the series touches mipi_display.h.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Pavel Machek]

Hi!

> I've also picked patches 7-12.

It seems that part of the support made it to v4.16. Is it supposed to
be complete?

I still have these in my tree, and result works on Nokia N9. Is there
any way I can help with the merge?

Best regards,

Pavel

diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c 
b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
index 15399a1..39b26cf 100644
--- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
+++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
@@ -33,8 +33,6 @@
 #define TCH 0
 
 #define DCS_READ_NUM_ERRORS0x05
-#define DCS_BRIGHTNESS 0x51
-#define DCS_CTRL_DISPLAY   0x53
 #define DCS_GET_ID10xda
 #define DCS_GET_ID20xdb
 #define DCS_GET_ID30xdc
@@ -385,7 +383,8 @@ static int dsicm_bl_update_status(struct backlight_device 
*dev)
 
r = dsicm_wake_up(ddata);
if (!r)
-   r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, level);
+   r = dsicm_dcs_write_1(ddata, 
MIPI_DCS_SET_DISPLAY_BRIGHTNESS,
+ level);
 
in->ops.dsi->bus_unlock(in);
}
@@ -667,11 +666,11 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
if (r)
goto err;
 
-   r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, 0xff);
+   r = dsicm_dcs_write_1(ddata, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, 0xff);
if (r)
goto err;
 
-   r = dsicm_dcs_write_1(ddata, DCS_CTRL_DISPLAY,
+   r = dsicm_dcs_write_1(ddata, MIPI_DCS_WRITE_CONTROL_DISPLAY,
(1<<2) | (1<<5));   /* BL | BCTRL */
if (r)
goto err;
@@ -685,6 +684,8 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
if (r)
goto err;
 
+   mdelay(1000);
+
r = _dsicm_enable_te(ddata, ddata->te_enabled);
if (r)
goto err;
@@ -1100,7 +1101,8 @@ static int dsicm_memory_read(struct omap_dss_device 
*dssdev,
goto err2;
 
while (buf_used < size) {
-   u8 dcs_cmd = first ? 0x2e : 0x3e;
+   u8 dcs_cmd = first ? MIPI_DCS_READ_MEMORY_START :
+   
MIPI_DCS_READ_MEMORY_CONTINUE;
first = 0;
 
r = in->ops.dsi->dcs_read(in, ddata->channel, dcs_cmd,
@@ -1378,6 +1380,7 @@ static int dsicm_probe(struct platform_device *pdev)
if (ddata->use_dsi_backlight) {
struct backlight_properties props = { 0 };
props.max_brightness = 255;
+   props.brightness = 128;
props.type = BACKLIGHT_RAW;
 
bldev = devm_backlight_device_register(dev, dev_name(dev),
@@ -1396,6 +1399,18 @@ static int dsicm_probe(struct platform_device *pdev)
goto err_bl;
}
 
+#if 0
+   mutex_lock(>lock);
+   ddata->in->ops.dsi->bus_lock(ddata->in);
+   r = dsicm_wake_up(ddata);
+   if (!r)
+   r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, 0xff);
+   r = dsicm_dcs_write_1(ddata, DCS_CTRL_DISPLAY,
+   (1<<2) | (1<<5));   /* BL | BCTRL */
+   r = dsicm_dcs_write_0(ddata, MIPI_DCS_SET_DISPLAY_ON);
+   ddata->in->ops.dsi->bus_unlock(ddata->in);
+   mutex_unlock(>lock);
+#endif
return 0;
 
 err_bl:
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c 
b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 4e8f68e..e63a783 100644
--- a/drivers/gpu/drm/omapdrm/dss/dispc.c
+++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
@@ -1489,6 +1489,18 @@ void dispc_ovl_compute_fifo_thresholds(enum 
omap_plane_id plane,
}
 }
 
+void dispc_ovl_set_manual_fifo_threshold(enum omap_plane_id plane)
+{
+   u32 fifo_low, fifo_high;
+   bool use_fifo_merge = false;
+   bool use_manual_update = true;
+
+   dispc_ovl_compute_fifo_thresholds(plane, _low, _high,
+ use_fifo_merge, use_manual_update);
+
+   dispc_ovl_set_fifo_threshold(plane, fifo_low, fifo_high);
+}
+
 static void dispc_ovl_set_mflag(enum omap_plane_id plane, bool enable)
 {
int bit;
@@ -2652,6 +2664,10 @@ static int dispc_ovl_setup(enum omap_plane_id plane,
oi->zorder, oi->pre_mult_alpha, oi->global_alpha,
oi->rotation_type, replication, vm, mem_to_mem);
 
+   /* manual mode needs other fifo thresholds */
+   if (mgr_fld_read(channel, DISPC_MGR_FLD_STALLMODE))
+   dispc_ovl_set_manual_fifo_threshold(plane);
+
return r;
 }
 
diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c 
b/drivers/gpu/drm/omapdrm/omap_connector.c
index a0d7b1d..a33b514 100644
--- a/drivers/gpu/drm/omapdrm/omap_connector.c
+++ b/drivers/gpu/drm/omapdrm/omap_connector.c
@@ -57,6 +57,14 @@ bool omap_connector_get_hdmi_mode(struct drm_connector 
*connector)

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Sebastian Reichel]

Hi Tomi,

On Fri, Dec 01, 2017 at 02:58:13PM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> On 24/07/17 20:32, Sebastian Reichel wrote:
> > Hi,
> > 
> > This adds support for command mode DSI panels to
> > omapdrm. I tested the patches on Nokia N950 (omap3)
> > and Motorola Droid 4 (omap4). This is basically
> > PATCHv3 of my series adding N950 display support,
> > but I started from scratch without reverting the
> > removal of manual display update support.
> > 
> > Tested:
> >  * Framebuffer Console
> >  * Display blanking
> >  * kmstest
> >  * Xorg with omap and modesetting driver
> >  * No updates send when nothing needs to be sent
> > 
> > Known issues:
> >  * Proper display rotation support
> >  * N950 (and N9) has first and last few lines
> >covered by plastic, so we should expose a
> >smaller screen
> > 
> > I plan to look into these issues once basic support
> > has been merged.
> > 
> > -- Sebastian
> > 
> > Sebastian Reichel (13):
> >   [A] drm/omap: remove unused function defines
> >   [A] drm/omap: drop incorrect comment
> >   [ ] drm/omap: plane: update fifo size on ovl setup
> >   [ ] drm/omap: add framedone interrupt support
> >   [ ] drm/omap: add manual update detection helper
> >   [ ] drm/omap: add support for manually updated displays
> >   [A] drm/omap: add support for physical size hints from display drivers
> >   [A] drm/omap: panel-dsi-cm: add regulator support
> >   [A] drm/omap: panel-dsi-cm: add physical size support
> >   [A] drm/omap: panel-dsi-cm: add external backlight support
> >   [A] drm/omap: panel-dsi-cm: switch to gpiod
> >   [A] ARM: dts: omap4-droid4: improve LCD description
> >   [ ] ARM: dts: n950: add display support
> > 
> > Tony Lindgren (1):
> >   drm/omap: panel-dsi-cm: fix driver
> 
> I've also picked patches 7-12.

Thanks. I just wanted to rebase the remaining patches on your
branch, but I don't see those patches in linux-next and your tree
does not seem to be updated properly either:

https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/

-- Sebastian


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tomi Valkeinen]

Hi,

On 24/07/17 20:32, Sebastian Reichel wrote:
> Hi,
> 
> This adds support for command mode DSI panels to
> omapdrm. I tested the patches on Nokia N950 (omap3)
> and Motorola Droid 4 (omap4). This is basically
> PATCHv3 of my series adding N950 display support,
> but I started from scratch without reverting the
> removal of manual display update support.
> 
> Tested:
>  * Framebuffer Console
>  * Display blanking
>  * kmstest
>  * Xorg with omap and modesetting driver
>  * No updates send when nothing needs to be sent
> 
> Known issues:
>  * Proper display rotation support
>  * N950 (and N9) has first and last few lines
>covered by plastic, so we should expose a
>smaller screen
> 
> I plan to look into these issues once basic support
> has been merged.
> 
> -- Sebastian
> 
> Sebastian Reichel (13):
>   drm/omap: remove unused function defines
>   drm/omap: drop incorrect comment
>   drm/omap: plane: update fifo size on ovl setup
>   drm/omap: add framedone interrupt support
>   drm/omap: add manual update detection helper
>   drm/omap: add support for manually updated displays
>   drm/omap: add support for physical size hints from display drivers
>   drm/omap: panel-dsi-cm: add regulator support
>   drm/omap: panel-dsi-cm: add physical size support
>   drm/omap: panel-dsi-cm: add external backlight support
>   drm/omap: panel-dsi-cm: switch to gpiod
>   ARM: dts: omap4-droid4: improve LCD description
>   ARM: dts: n950: add display support
> 
> Tony Lindgren (1):
>   drm/omap: panel-dsi-cm: fix driver

I've also picked patches 7-12.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Pavel Machek]

Hi!

> > P.S.: I got asked by different people about the status of this
> > patchset, which is required for display support on N9, N950 and
> > Droid 4. It's not just me and Tony, that are interested in this :)
> 
> Ok. If you agree to help with the DSI part in the future, I have no
> problems applying these (after review and testing, of course).
> 
> My worry is not only with complicating Laurent's work towards common DRM
> drivers, but also with the maintenance burden this brings. Keeping DSI
> working in the future may be challenging due to the lack of users and
> (easy to use) boards. I do have a N950 and OMAP4 Blaze Tablet, though,
> so I'm able to test both command and video modes. But getting those boot
> up is not always trivial, especially for the blaze tablet.

Well... Yes, they are challenging to boot, because without working
display, debugging them is hard/impossible. Very few people have
serial cables for those, but at least the N9 is pretty common.

PostmarketOS is interested in using it as a target. I'm interested in
keeping it going. With working display, I'm pretty sure I can prevent
regressions... and there could be even some improvements :-).

Best regards,
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Sebastian Reichel]

Hi,

On Thu, Oct 26, 2017 at 02:59:10PM +0300, Tomi Valkeinen wrote:
> On 24/10/17 01:01, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Fri, Oct 13, 2017 at 10:12:08AM -0700, Tony Lindgren wrote:
> >> * Tomi Valkeinen  [171012 01:46]:
> >>> On 29/09/17 16:26, Sebastian Reichel wrote:
>  Hi Tomi & Laurent,
> 
>  ping?
> >>>
> >>> I've been having quick glances at this every now and then, but I'm not
> >>> sure what to do with the series.
> >>>
> >>> We have one work item that more or less overrides everything but
> >>> critical fixes: moving to common DRM encoder/panel drivers. Anything
> >>> that makes that work more difficult should be postponed.
> >>>
> >>> Especially patch 6 in this series most likely falls into that category,
> >>> and might require a very different implementation with common DRM
> >>> drivers. Also everything in panel-dsi-cm needs to be ported to a common
> >>> DRM panel driver when can use them.
> >>>
> >>> So my gut feeling is that it's best to keep this out for now, and rework
> >>> it after Laurent gets the common DRM drivers working with omapdrm.
> >>
> >> Laurent, got any other comments?
> >>
> >> Maybe some of patches can be already applied to shrink down this
> >> set a bit?
> > 
> > I talked with Laurent at ELCE about this patchset and he is fine
> > with this series going in before his work assuming its fine
> > otherwise. He has not yet reviewed it, though and is busy the
> > next two weeks.
> > 
> > Regarding the panel-dsi-cm porting work: I will take care of this
> > once the driver uses common DRM drivers. I don't expect major
> > problems once omapdrm implements common drm's mipi_dsi_host. I
> > do use the standard DT properties already.
> > 
> > I do agree, that not applying this series makes Laurent's porting
> > work easier, since he can rip out all of DSI. It's not used by
> > anything except panel-dsi-cm, which is broken without this patchset.
> > I don't think that's a fair thing to do, though.
> > 
> > P.S.: I got asked by different people about the status of this
> > patchset, which is required for display support on N9, N950 and
> > Droid 4. It's not just me and Tony, that are interested in this :)
> 
> Ok. If you agree to help with the DSI part in the future, I have no
> problems applying these (after review and testing, of course).

Sure.

> My worry is not only with complicating Laurent's work towards common DRM
> drivers, but also with the maintenance burden this brings. Keeping DSI
> working in the future may be challenging due to the lack of users and
> (easy to use) boards. I do have a N950 and OMAP4 Blaze Tablet, though,
> so I'm able to test both command and video modes. But getting those boot
> up is not always trivial, especially for the blaze tablet.

I have N950, N9 and Droid 4 (omap4 based).
All of them have command mode panels.

> I've also spent many hours this year debugging obscure OMAP3 DSS HW
> issues, so my opinion about adding more OMAP3 DSS features may be a bit
> biased =).

This patchset is also for OMAP4 (Droid 4).

> I'll have a look at this series when I find a bit of spare time.

Thanks.

-- Sebastian


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tomi Valkeinen]

On 24/10/17 01:01, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Oct 13, 2017 at 10:12:08AM -0700, Tony Lindgren wrote:
>> * Tomi Valkeinen  [171012 01:46]:
>>> On 29/09/17 16:26, Sebastian Reichel wrote:
 Hi Tomi & Laurent,

 ping?
>>>
>>> I've been having quick glances at this every now and then, but I'm not
>>> sure what to do with the series.
>>>
>>> We have one work item that more or less overrides everything but
>>> critical fixes: moving to common DRM encoder/panel drivers. Anything
>>> that makes that work more difficult should be postponed.
>>>
>>> Especially patch 6 in this series most likely falls into that category,
>>> and might require a very different implementation with common DRM
>>> drivers. Also everything in panel-dsi-cm needs to be ported to a common
>>> DRM panel driver when can use them.
>>>
>>> So my gut feeling is that it's best to keep this out for now, and rework
>>> it after Laurent gets the common DRM drivers working with omapdrm.
>>
>> Laurent, got any other comments?
>>
>> Maybe some of patches can be already applied to shrink down this
>> set a bit?
> 
> I talked with Laurent at ELCE about this patchset and he is fine
> with this series going in before his work assuming its fine
> otherwise. He has not yet reviewed it, though and is busy the
> next two weeks.
> 
> Regarding the panel-dsi-cm porting work: I will take care of this
> once the driver uses common DRM drivers. I don't expect major
> problems once omapdrm implements common drm's mipi_dsi_host. I
> do use the standard DT properties already.
> 
> I do agree, that not applying this series makes Laurent's porting
> work easier, since he can rip out all of DSI. It's not used by
> anything except panel-dsi-cm, which is broken without this patchset.
> I don't think that's a fair thing to do, though.
> 
> P.S.: I got asked by different people about the status of this
> patchset, which is required for display support on N9, N950 and
> Droid 4. It's not just me and Tony, that are interested in this :)

Ok. If you agree to help with the DSI part in the future, I have no
problems applying these (after review and testing, of course).

My worry is not only with complicating Laurent's work towards common DRM
drivers, but also with the maintenance burden this brings. Keeping DSI
working in the future may be challenging due to the lack of users and
(easy to use) boards. I do have a N950 and OMAP4 Blaze Tablet, though,
so I'm able to test both command and video modes. But getting those boot
up is not always trivial, especially for the blaze tablet.

I've also spent many hours this year debugging obscure OMAP3 DSS HW
issues, so my opinion about adding more OMAP3 DSS features may be a bit
biased =).

I'll have a look at this series when I find a bit of spare time.

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Sebastian Reichel]

Hi,

On Fri, Oct 13, 2017 at 10:12:08AM -0700, Tony Lindgren wrote:
> * Tomi Valkeinen  [171012 01:46]:
> > On 29/09/17 16:26, Sebastian Reichel wrote:
> > > Hi Tomi & Laurent,
> > > 
> > > ping?
> > 
> > I've been having quick glances at this every now and then, but I'm not
> > sure what to do with the series.
> > 
> > We have one work item that more or less overrides everything but
> > critical fixes: moving to common DRM encoder/panel drivers. Anything
> > that makes that work more difficult should be postponed.
> > 
> > Especially patch 6 in this series most likely falls into that category,
> > and might require a very different implementation with common DRM
> > drivers. Also everything in panel-dsi-cm needs to be ported to a common
> > DRM panel driver when can use them.
> > 
> > So my gut feeling is that it's best to keep this out for now, and rework
> > it after Laurent gets the common DRM drivers working with omapdrm.
> 
> Laurent, got any other comments?
> 
> Maybe some of patches can be already applied to shrink down this
> set a bit?

I talked with Laurent at ELCE about this patchset and he is fine
with this series going in before his work assuming its fine
otherwise. He has not yet reviewed it, though and is busy the
next two weeks.

Regarding the panel-dsi-cm porting work: I will take care of this
once the driver uses common DRM drivers. I don't expect major
problems once omapdrm implements common drm's mipi_dsi_host. I
do use the standard DT properties already.

I do agree, that not applying this series makes Laurent's porting
work easier, since he can rip out all of DSI. It's not used by
anything except panel-dsi-cm, which is broken without this patchset.
I don't think that's a fair thing to do, though.

P.S.: I got asked by different people about the status of this
patchset, which is required for display support on N9, N950 and
Droid 4. It's not just me and Tony, that are interested in this :)

-- Sebastian


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tony Lindgren]

* Tomi Valkeinen  [171012 01:46]:
> On 29/09/17 16:26, Sebastian Reichel wrote:
> > Hi Tomi & Laurent,
> > 
> > ping?
> 
> I've been having quick glances at this every now and then, but I'm not
> sure what to do with the series.
> 
> We have one work item that more or less overrides everything but
> critical fixes: moving to common DRM encoder/panel drivers. Anything
> that makes that work more difficult should be postponed.
> 
> Especially patch 6 in this series most likely falls into that category,
> and might require a very different implementation with common DRM
> drivers. Also everything in panel-dsi-cm needs to be ported to a common
> DRM panel driver when can use them.
> 
> So my gut feeling is that it's best to keep this out for now, and rework
> it after Laurent gets the common DRM drivers working with omapdrm.

Laurent, got any other comments?

Maybe some of patches can be already applied to shrink down this
set a bit?

Regards,

Tony
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tomi Valkeinen]

Hi Sebastian,


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 29/09/17 16:26, Sebastian Reichel wrote:
> Hi Tomi & Laurent,
> 
> ping?

I've been having quick glances at this every now and then, but I'm not
sure what to do with the series.

We have one work item that more or less overrides everything but
critical fixes: moving to common DRM encoder/panel drivers. Anything
that makes that work more difficult should be postponed.

Especially patch 6 in this series most likely falls into that category,
and might require a very different implementation with common DRM
drivers. Also everything in panel-dsi-cm needs to be ported to a common
DRM panel driver when can use them.

So my gut feeling is that it's best to keep this out for now, and rework
it after Laurent gets the common DRM drivers working with omapdrm.

 Tomi

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Sebastian Reichel]

Hi Tomi & Laurent,

ping?

-- Sebastian

On Mon, Jul 24, 2017 at 07:32:57PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> This adds support for command mode DSI panels to
> omapdrm. I tested the patches on Nokia N950 (omap3)
> and Motorola Droid 4 (omap4). This is basically
> PATCHv3 of my series adding N950 display support,
> but I started from scratch without reverting the
> removal of manual display update support.
> 
> Tested:
>  * Framebuffer Console
>  * Display blanking
>  * kmstest
>  * Xorg with omap and modesetting driver
>  * No updates send when nothing needs to be sent
> 
> Known issues:
>  * Proper display rotation support
>  * N950 (and N9) has first and last few lines
>covered by plastic, so we should expose a
>smaller screen
> 
> I plan to look into these issues once basic support
> has been merged.
> 
> -- Sebastian
> 
> Sebastian Reichel (13):
>   drm/omap: remove unused function defines
>   drm/omap: drop incorrect comment
>   drm/omap: plane: update fifo size on ovl setup
>   drm/omap: add framedone interrupt support
>   drm/omap: add manual update detection helper
>   drm/omap: add support for manually updated displays
>   drm/omap: add support for physical size hints from display drivers
>   drm/omap: panel-dsi-cm: add regulator support
>   drm/omap: panel-dsi-cm: add physical size support
>   drm/omap: panel-dsi-cm: add external backlight support
>   drm/omap: panel-dsi-cm: switch to gpiod
>   ARM: dts: omap4-droid4: improve LCD description
>   ARM: dts: n950: add display support
> 
> Tony Lindgren (1):
>   drm/omap: panel-dsi-cm: fix driver
> 
>  arch/arm/boot/dts/omap3-n950.dts|  88 
>  arch/arm/boot/dts/omap4-droid4-xt894.dts|   6 +-
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 289 
> +---
>  drivers/gpu/drm/omapdrm/dss/dispc.c |  16 ++
>  drivers/gpu/drm/omapdrm/dss/omapdss.h   |   5 +-
>  drivers/gpu/drm/omapdrm/omap_connector.c|  14 ++
>  drivers/gpu/drm/omapdrm/omap_crtc.c | 158 -
>  drivers/gpu/drm/omapdrm/omap_drv.h  |   4 +
>  drivers/gpu/drm/omapdrm/omap_fb.c   |  20 ++
>  drivers/gpu/drm/omapdrm/omap_fbdev.c|   3 -
>  drivers/gpu/drm/omapdrm/omap_irq.c  |  24 ++
>  11 files changed, 529 insertions(+), 98 deletions(-)
> 
> -- 
> 2.13.2
> 


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv1 00/14] omapdrm: DSI command mode panel support

[Tony Lindgren]

* Sebastian Reichel  [170724 10:34]:
> Hi,
> 
> This adds support for command mode DSI panels to
> omapdrm. I tested the patches on Nokia N950 (omap3)
> and Motorola Droid 4 (omap4). This is basically
> PATCHv3 of my series adding N950 display support,
> but I started from scratch without reverting the
> removal of manual display update support.

Works for me:

Tested-by: Tony Lindgren 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel