Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-12-10 Thread Huacai Chen
Hi, Jaak,

On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
>
> On 06.11.23 04:15, Huacai Chen wrote:
> > Hi, Jaak and Evan,
> >
> > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
> >>
> >> On 05.11.23 14:40, Huacai Chen wrote:
> >>> Hi, Evan,
> >>>
> >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:
> 
>  Hi Huacai,
> 
>  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > Hi, Evan,
> >
> > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> >>
> >> Hi Huacai,
> >>
> >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> >>> Hi, Jaak,
> >>>
> >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> 
>  On 31.10.23 14:17, Huacai Chen wrote:
> > Hi, Jaak and Evan,
> >
> > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> > wrote:
> >>
> >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> >> wrote:
> >>>
> >>> On 26.10.23 03:58, Huacai Chen wrote:
>  Hi, Jaak,
> 
>  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
>  wrote:
> >
> > On 25.10.23 16:23, Huacai Chen wrote:
> >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> >>  wrote:
> >>>
> >>> Javier, Dave, Sima,
> >>>
> >>> On 23.10.23 00:54, Evan Preston wrote:
>  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > (Thorsten
> > Leemhuis)  wrote:
> >> On 09.10.23 10:54, Huacai Chen wrote:
> >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> >>>  wrote:
>  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
>  wrote:
> > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> >  wrote:
> >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> >> tracking (Thorsten
> >> Leemhuis)  wrote:
> >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> 
>  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
>  (Integrated Intel HD
>  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
>  results in a blank
>  screen after boot until the display manager 
>  starts... if it does start
>  at all. Using the nomodeset kernel parameter seems 
>  to be a workaround.
> 
>  I've bisected this to commit 
>  60aebc9559492cea6a9625f514a8041717e3a2e4
>  ("drivers/firmware: Move sysfb_init() from 
>  device_initcall to
>  subsys_initcall_sync").
> >>>
> > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > things work fine
> > again. So I guess the reason:
> >>
> >> Well, this to me still looks a lot (please correct me if 
> >> I'm wrong) like
> >> regression that should be fixed, as DRM_SIMPLEDRM was 
> >> enabled beforehand
> >> if I understood things correctly. Or is there a proper fix 
> >> for this
> >> already in the works and I just missed this? Or is there 
> >> some good
> >> reason why this won't/can't be fixed?
> >
> > DRM_SIMPLEDRM was enabled but it didn't work at all because 
> > there was
> > no corresponding platform device. Now DRM_SIMPLEDRM works 
> > but it has a
> > blank screen. Of course it is valuable to investigate 
> > further about
> > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > effort because
> > I don't have a same machine.
> >>>
> >>> Side note: Huacai, have you tried working with Jaak to get 
> >>> down to the
> >>> real problem? Evan, might you be able to help out here?
> >> No, Jaak has no response after he 'fixed' his problem by 
> >> disabling SIMPLEDRM.
> >>
> >
> > I'm sorry, what was it exactly you want me to do? Please be 
> > mindful that
> > I'm not familiar with the internals of the Linux kernel and 
> > DRI, and it
> > might sometimes take weeks before I have time to work and 
> > respond on this.

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-07 Thread Evan Preston
On 2023-11-06 Mon 09:39pm, Evan Preston wrote:
> Hi Huacai,
> 
> On 2023-11-07 Tue 09:49am, Huacai Chen wrote:
> > Hi, Evan,
> > 
> > On Tue, Nov 7, 2023 at 4:32 AM Evan Preston  wrote:
> > >
> > > Hi Huacai,
> > >
> > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote:
> > > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
> > > > >
> > > > > On 06.11.23 04:15, Huacai Chen wrote:
> > > > > > Hi, Jaak and Evan,
> > > > > >
> > > > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  
> > > > > > wrote:
> > > > > >>
> > > > > >> On 05.11.23 14:40, Huacai Chen wrote:
> > > > > >>> Hi, Evan,
> > > > > >>>
> > > > > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston 
> > > > > >>>  wrote:
> > > > > 
> > > > >  Hi Huacai,
> > > > > 
> > > > >  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > > > > Hi, Evan,
> > > > > >
> > > > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston 
> > > > > >  wrote:
> > > > > >>
> > > > > >> Hi Huacai,
> > > > > >>
> > > > > >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > > > >>> Hi, Jaak,
> > > > > >>>
> > > > > >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja 
> > > > > >>>  wrote:
> > > > > 
> > > > >  On 31.10.23 14:17, Huacai Chen wrote:
> > > > > > Hi, Jaak and Evan,
> > > > > >
> > > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > > > > >  wrote:
> > > > > >>
> > > > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja 
> > > > > >>  wrote:
> > > > > >>>
> > > > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > > > >  Hi, Jaak,
> > > > > 
> > > > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> > > > >   wrote:
> > > > > >
> > > > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > > > >>  wrote:
> > > > > >>>
> > > > > >>> Javier, Dave, Sima,
> > > > > >>>
> > > > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > > > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression 
> > > > > > tracking (Thorsten
> > > > > > Leemhuis)  wrote:
> > > > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > > > >>>  wrote:
> > > > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai 
> > > > >  Chen wrote:
> > > > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > > > >  wrote:
> > > > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux 
> > > > > >> regression tracking (Thorsten
> > > > > >> Leemhuis)  wrote:
> > > > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > > 
> > > > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad 
> > > > >  L570 (Integrated Intel HD
> > > > >  Graphics 620 (rev 02), Intel(R) Core(TM) 
> > > > >  i7-7500U) results in a blank
> > > > >  screen after boot until the display manager 
> > > > >  starts... if it does start
> > > > >  at all. Using the nomodeset kernel parameter 
> > > > >  seems to be a workaround.
> > > > > 
> > > > >  I've bisected this to commit 
> > > > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > > > >  ("drivers/firmware: Move sysfb_init() from 
> > > > >  device_initcall to
> > > > >  subsys_initcall_sync").
> > > > > >>>
> > > > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM 
> > > > > > makes things work fine
> > > > > > again. So I guess the reason:
> > > > > >>
> > > > > >> Well, this to me still looks a lot (please correct 
> > > > > >> me if I'm wrong) like
> > > > > >> regression that should be fixed, as DRM_SIMPLEDRM 
> > > > > >> was enabled beforehand
> > > > > >> if I understood things correctly. Or is there a 
> > > > > >> proper fix for this
> > > > > >> already in the works and I just missed this? Or is 
> > > > > >> there some good
> > > > > >> reason why this won't/can't be fixed?
> > > > > >
> > > > > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > > > >>

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-07 Thread Huacai Chen
Hi, Thorsten and Jaak,

On Tue, Nov 7, 2023 at 4:32 AM Evan Preston  wrote:
>
> Hi Huacai,
>
> On 2023-11-06 Mon 10:22pm, Huacai Chen wrote:
> > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
> > >
> > > On 06.11.23 04:15, Huacai Chen wrote:
> > > > Hi, Jaak and Evan,
> > > >
> > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
> > > >>
> > > >> On 05.11.23 14:40, Huacai Chen wrote:
> > > >>> Hi, Evan,
> > > >>>
> > > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  
> > > >>> wrote:
> > > 
> > >  Hi Huacai,
> > > 
> > >  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > > Hi, Evan,
> > > >
> > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  
> > > > wrote:
> > > >>
> > > >> Hi Huacai,
> > > >>
> > > >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > >>> Hi, Jaak,
> > > >>>
> > > >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  
> > > >>> wrote:
> > > 
> > >  On 31.10.23 14:17, Huacai Chen wrote:
> > > > Hi, Jaak and Evan,
> > > >
> > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > > >  wrote:
> > > >>
> > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja 
> > > >>  wrote:
> > > >>>
> > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > >  Hi, Jaak,
> > > 
> > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> > >   wrote:
> > > >
> > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > >>  wrote:
> > > >>>
> > > >>> Javier, Dave, Sima,
> > > >>>
> > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression 
> > > > tracking (Thorsten
> > > > Leemhuis)  wrote:
> > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > >>>  wrote:
> > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai 
> > >  Chen wrote:
> > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > >  wrote:
> > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > >> tracking (Thorsten
> > > >> Leemhuis)  wrote:
> > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > 
> > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > >  (Integrated Intel HD
> > >  Graphics 620 (rev 02), Intel(R) Core(TM) 
> > >  i7-7500U) results in a blank
> > >  screen after boot until the display manager 
> > >  starts... if it does start
> > >  at all. Using the nomodeset kernel parameter 
> > >  seems to be a workaround.
> > > 
> > >  I've bisected this to commit 
> > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > >  ("drivers/firmware: Move sysfb_init() from 
> > >  device_initcall to
> > >  subsys_initcall_sync").
> > > >>>
> > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > > things work fine
> > > > again. So I guess the reason:
> > > >>
> > > >> Well, this to me still looks a lot (please correct me 
> > > >> if I'm wrong) like
> > > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > > >> enabled beforehand
> > > >> if I understood things correctly. Or is there a proper 
> > > >> fix for this
> > > >> already in the works and I just missed this? Or is 
> > > >> there some good
> > > >> reason why this won't/can't be fixed?
> > > >
> > > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > > because there was
> > > > no corresponding platform device. Now DRM_SIMPLEDRM 
> > > > works but it has a
> > > > blank screen. Of course it is valuable to investigate 
> > > > further about
> > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > > > effort because
> > > > I don't have a same machine.
> > > >>>
> > > >>> Side note: Huacai, have you tried working wi

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Evan Preston
Hi Huacai,

On 2023-11-07 Tue 09:49am, Huacai Chen wrote:
> Hi, Evan,
> 
> On Tue, Nov 7, 2023 at 4:32 AM Evan Preston  wrote:
> >
> > Hi Huacai,
> >
> > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote:
> > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
> > > >
> > > > On 06.11.23 04:15, Huacai Chen wrote:
> > > > > Hi, Jaak and Evan,
> > > > >
> > > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  
> > > > > wrote:
> > > > >>
> > > > >> On 05.11.23 14:40, Huacai Chen wrote:
> > > > >>> Hi, Evan,
> > > > >>>
> > > > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  
> > > > >>> wrote:
> > > > 
> > > >  Hi Huacai,
> > > > 
> > > >  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > > > Hi, Evan,
> > > > >
> > > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  
> > > > > wrote:
> > > > >>
> > > > >> Hi Huacai,
> > > > >>
> > > > >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > > >>> Hi, Jaak,
> > > > >>>
> > > > >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  
> > > > >>> wrote:
> > > > 
> > > >  On 31.10.23 14:17, Huacai Chen wrote:
> > > > > Hi, Jaak and Evan,
> > > > >
> > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > > > >  wrote:
> > > > >>
> > > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja 
> > > > >>  wrote:
> > > > >>>
> > > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > > >  Hi, Jaak,
> > > > 
> > > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> > > >   wrote:
> > > > >
> > > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > > >>  wrote:
> > > > >>>
> > > > >>> Javier, Dave, Sima,
> > > > >>>
> > > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression 
> > > > > tracking (Thorsten
> > > > > Leemhuis)  wrote:
> > > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > > >>>  wrote:
> > > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai 
> > > >  Chen wrote:
> > > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > > >  wrote:
> > > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > > >> tracking (Thorsten
> > > > >> Leemhuis)  wrote:
> > > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > 
> > > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad 
> > > >  L570 (Integrated Intel HD
> > > >  Graphics 620 (rev 02), Intel(R) Core(TM) 
> > > >  i7-7500U) results in a blank
> > > >  screen after boot until the display manager 
> > > >  starts... if it does start
> > > >  at all. Using the nomodeset kernel parameter 
> > > >  seems to be a workaround.
> > > > 
> > > >  I've bisected this to commit 
> > > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > > >  ("drivers/firmware: Move sysfb_init() from 
> > > >  device_initcall to
> > > >  subsys_initcall_sync").
> > > > >>>
> > > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM 
> > > > > makes things work fine
> > > > > again. So I guess the reason:
> > > > >>
> > > > >> Well, this to me still looks a lot (please correct 
> > > > >> me if I'm wrong) like
> > > > >> regression that should be fixed, as DRM_SIMPLEDRM 
> > > > >> was enabled beforehand
> > > > >> if I understood things correctly. Or is there a 
> > > > >> proper fix for this
> > > > >> already in the works and I just missed this? Or is 
> > > > >> there some good
> > > > >> reason why this won't/can't be fixed?
> > > > >
> > > > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > > > because there was
> > > > > no corresponding platform device. Now DRM_SIMPLEDRM 
> > > > > works but it has a
> > > > > blank screen. Of course it is valuable to investigate 
> > > > > 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Huacai Chen
Hi, Evan,

On Tue, Nov 7, 2023 at 4:32 AM Evan Preston  wrote:
>
> Hi Huacai,
>
> On 2023-11-06 Mon 10:22pm, Huacai Chen wrote:
> > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
> > >
> > > On 06.11.23 04:15, Huacai Chen wrote:
> > > > Hi, Jaak and Evan,
> > > >
> > > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
> > > >>
> > > >> On 05.11.23 14:40, Huacai Chen wrote:
> > > >>> Hi, Evan,
> > > >>>
> > > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  
> > > >>> wrote:
> > > 
> > >  Hi Huacai,
> > > 
> > >  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > > Hi, Evan,
> > > >
> > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  
> > > > wrote:
> > > >>
> > > >> Hi Huacai,
> > > >>
> > > >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > >>> Hi, Jaak,
> > > >>>
> > > >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  
> > > >>> wrote:
> > > 
> > >  On 31.10.23 14:17, Huacai Chen wrote:
> > > > Hi, Jaak and Evan,
> > > >
> > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > > >  wrote:
> > > >>
> > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja 
> > > >>  wrote:
> > > >>>
> > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > >  Hi, Jaak,
> > > 
> > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> > >   wrote:
> > > >
> > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > >>  wrote:
> > > >>>
> > > >>> Javier, Dave, Sima,
> > > >>>
> > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression 
> > > > tracking (Thorsten
> > > > Leemhuis)  wrote:
> > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > >>>  wrote:
> > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai 
> > >  Chen wrote:
> > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > >  wrote:
> > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > >> tracking (Thorsten
> > > >> Leemhuis)  wrote:
> > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > 
> > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > >  (Integrated Intel HD
> > >  Graphics 620 (rev 02), Intel(R) Core(TM) 
> > >  i7-7500U) results in a blank
> > >  screen after boot until the display manager 
> > >  starts... if it does start
> > >  at all. Using the nomodeset kernel parameter 
> > >  seems to be a workaround.
> > > 
> > >  I've bisected this to commit 
> > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > >  ("drivers/firmware: Move sysfb_init() from 
> > >  device_initcall to
> > >  subsys_initcall_sync").
> > > >>>
> > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > > things work fine
> > > > again. So I guess the reason:
> > > >>
> > > >> Well, this to me still looks a lot (please correct me 
> > > >> if I'm wrong) like
> > > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > > >> enabled beforehand
> > > >> if I understood things correctly. Or is there a proper 
> > > >> fix for this
> > > >> already in the works and I just missed this? Or is 
> > > >> there some good
> > > >> reason why this won't/can't be fixed?
> > > >
> > > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > > because there was
> > > > no corresponding platform device. Now DRM_SIMPLEDRM 
> > > > works but it has a
> > > > blank screen. Of course it is valuable to investigate 
> > > > further about
> > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > > > effort because
> > > > I don't have a same machine.
> > > >>>
> > > >>> Side note: Huacai, have you tried working with Jaak to 
>

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Evan Preston
Hi Huacai,

On 2023-11-06 Mon 10:22pm, Huacai Chen wrote:
> On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
> >
> > On 06.11.23 04:15, Huacai Chen wrote:
> > > Hi, Jaak and Evan,
> > >
> > > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
> > >>
> > >> On 05.11.23 14:40, Huacai Chen wrote:
> > >>> Hi, Evan,
> > >>>
> > >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  
> > >>> wrote:
> > 
> >  Hi Huacai,
> > 
> >  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > Hi, Evan,
> > >
> > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  
> > > wrote:
> > >>
> > >> Hi Huacai,
> > >>
> > >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > >>> Hi, Jaak,
> > >>>
> > >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  
> > >>> wrote:
> > 
> >  On 31.10.23 14:17, Huacai Chen wrote:
> > > Hi, Jaak and Evan,
> > >
> > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > >  wrote:
> > >>
> > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> > >> wrote:
> > >>>
> > >>> On 26.10.23 03:58, Huacai Chen wrote:
> >  Hi, Jaak,
> > 
> >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> >   wrote:
> > >
> > > On 25.10.23 16:23, Huacai Chen wrote:
> > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > >>  wrote:
> > >>>
> > >>> Javier, Dave, Sima,
> > >>>
> > >>> On 23.10.23 00:54, Evan Preston wrote:
> >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > (Thorsten
> > > Leemhuis)  wrote:
> > >> On 09.10.23 10:54, Huacai Chen wrote:
> > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > >>>  wrote:
> >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
> >  wrote:
> > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > >  wrote:
> > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > >> tracking (Thorsten
> > >> Leemhuis)  wrote:
> > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > 
> >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> >  (Integrated Intel HD
> >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> >  results in a blank
> >  screen after boot until the display manager 
> >  starts... if it does start
> >  at all. Using the nomodeset kernel parameter seems 
> >  to be a workaround.
> > 
> >  I've bisected this to commit 
> >  60aebc9559492cea6a9625f514a8041717e3a2e4
> >  ("drivers/firmware: Move sysfb_init() from 
> >  device_initcall to
> >  subsys_initcall_sync").
> > >>>
> > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > things work fine
> > > again. So I guess the reason:
> > >>
> > >> Well, this to me still looks a lot (please correct me if 
> > >> I'm wrong) like
> > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > >> enabled beforehand
> > >> if I understood things correctly. Or is there a proper 
> > >> fix for this
> > >> already in the works and I just missed this? Or is there 
> > >> some good
> > >> reason why this won't/can't be fixed?
> > >
> > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > because there was
> > > no corresponding platform device. Now DRM_SIMPLEDRM works 
> > > but it has a
> > > blank screen. Of course it is valuable to investigate 
> > > further about
> > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > > effort because
> > > I don't have a same machine.
> > >>>
> > >>> Side note: Huacai, have you tried working with Jaak to get 
> > >>> down to the
> > >>> real problem? Evan, might you be able to help out here?
> > >> No, Jaak has no response after he 'fixed' his problem by 
> > >> disabling SIMPLEDRM.
> > >>
> > >
> > > I

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Huacai Chen
On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja  wrote:
>
> On 06.11.23 04:15, Huacai Chen wrote:
> > Hi, Jaak and Evan,
> >
> > On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
> >>
> >> On 05.11.23 14:40, Huacai Chen wrote:
> >>> Hi, Evan,
> >>>
> >>> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:
> 
>  Hi Huacai,
> 
>  On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > Hi, Evan,
> >
> > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> >>
> >> Hi Huacai,
> >>
> >> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> >>> Hi, Jaak,
> >>>
> >>> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> 
>  On 31.10.23 14:17, Huacai Chen wrote:
> > Hi, Jaak and Evan,
> >
> > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> > wrote:
> >>
> >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> >> wrote:
> >>>
> >>> On 26.10.23 03:58, Huacai Chen wrote:
>  Hi, Jaak,
> 
>  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
>  wrote:
> >
> > On 25.10.23 16:23, Huacai Chen wrote:
> >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> >>  wrote:
> >>>
> >>> Javier, Dave, Sima,
> >>>
> >>> On 23.10.23 00:54, Evan Preston wrote:
>  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > (Thorsten
> > Leemhuis)  wrote:
> >> On 09.10.23 10:54, Huacai Chen wrote:
> >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> >>>  wrote:
>  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
>  wrote:
> > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> >  wrote:
> >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> >> tracking (Thorsten
> >> Leemhuis)  wrote:
> >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> 
>  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
>  (Integrated Intel HD
>  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
>  results in a blank
>  screen after boot until the display manager 
>  starts... if it does start
>  at all. Using the nomodeset kernel parameter seems 
>  to be a workaround.
> 
>  I've bisected this to commit 
>  60aebc9559492cea6a9625f514a8041717e3a2e4
>  ("drivers/firmware: Move sysfb_init() from 
>  device_initcall to
>  subsys_initcall_sync").
> >>>
> > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > things work fine
> > again. So I guess the reason:
> >>
> >> Well, this to me still looks a lot (please correct me if 
> >> I'm wrong) like
> >> regression that should be fixed, as DRM_SIMPLEDRM was 
> >> enabled beforehand
> >> if I understood things correctly. Or is there a proper fix 
> >> for this
> >> already in the works and I just missed this? Or is there 
> >> some good
> >> reason why this won't/can't be fixed?
> >
> > DRM_SIMPLEDRM was enabled but it didn't work at all because 
> > there was
> > no corresponding platform device. Now DRM_SIMPLEDRM works 
> > but it has a
> > blank screen. Of course it is valuable to investigate 
> > further about
> > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > effort because
> > I don't have a same machine.
> >>>
> >>> Side note: Huacai, have you tried working with Jaak to get 
> >>> down to the
> >>> real problem? Evan, might you be able to help out here?
> >> No, Jaak has no response after he 'fixed' his problem by 
> >> disabling SIMPLEDRM.
> >>
> >
> > I'm sorry, what was it exactly you want me to do? Please be 
> > mindful that
> > I'm not familiar with the internals of the Linux kernel and 
> > DRI, and it
> > might sometimes take weeks before I have time to work and 
> > respond on this.
> >

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Jaak Ristioja

On 06.11.23 04:15, Huacai Chen wrote:

Hi, Jaak and Evan,

On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:


On 05.11.23 14:40, Huacai Chen wrote:

Hi, Evan,

On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:


Hi Huacai,

On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:

Hi, Evan,

On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:


Hi Huacai,

On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:

Hi, Jaak,

On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:


On 31.10.23 14:17, Huacai Chen wrote:

Hi, Jaak and Evan,

On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:


On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:


On 26.10.23 03:58, Huacai Chen wrote:

Hi, Jaak,

On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:


On 25.10.23 16:23, Huacai Chen wrote:

On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:


Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:

On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:

On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 09.10.23 10:54, Huacai Chen wrote:

On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:

On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 13.09.23 14:02, Jaak Ristioja wrote:


Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
screen after boot until the display manager starts... if it does start
at all. Using the nomodeset kernel parameter seems to be a workaround.

I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
("drivers/firmware: Move sysfb_init() from device_initcall to
subsys_initcall_sync").



As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:


Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?


DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.


Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.



I'm sorry, what was it exactly you want me to do? Please be mindful that
I'm not familiar with the internals of the Linux kernel and DRI, and it
might sometimes take weeks before I have time to work and respond on this.

It doesn't matter. I hope you can do some experiments to investigate
deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
whether there is also a blank screen. If no blank screen, that
probably means SIMPLEDRM has a bug, if still blank screen, that means
the firmware may pass wrong screen information.


Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.

CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
is that DRM_SIMPLEDRM has a bug. The next step is to enable
CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
some printk() in simpledrm_probe() and its sub-routines to see where
the driver fails. The output of these printk() can be seen by the
'dmesg' command after boot.

I need your help. I tried with my laptop (ThinkPad E490, Intel Core
i3-8145U, UHD Graphics 620) but I can't reproduce your problem. So
please patch your 6.5.x kernel with this temporary patch [1], then
build a "bad kernel" with SIMPLEDRM enabled. And after booting your
machine with this "bad kernel", please give me the dmesg output. Thank
you very much.

[1] http://ddns.miaomiaomiao.top:9000/download/kernel/patch-6.5.9


I'm unable to download it. Can you please send it by e-mail?

I'm sorry, please download from attachment.


When applying this patch the first hunk (drivers/firmware/sysfb.c) fails for
me with 6.5.9.  Attempting to load the 6.5.9 kernel without this patch
produces no dmesg output on my machine.

You copy-paste the patch? If you download it directly it can be
applied successfully, I think.


The patch downloaded from your URL applies successfully.  However, I still
see no dmesg output using the patched 6.5.9 kernel.  'journalctl -k -b all'
shows no dmesg output from any 6.5.x boots, only from 6.4.12 boots.

Thank yo

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Huacai Chen
Hi, Jaak and Evan,

On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja  wrote:
>
> On 05.11.23 14:40, Huacai Chen wrote:
> > Hi, Evan,
> >
> > On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:
> >>
> >> Hi Huacai,
> >>
> >> On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> >>> Hi, Evan,
> >>>
> >>> On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> 
>  Hi Huacai,
> 
>  On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > Hi, Jaak,
> >
> > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> >>
> >> On 31.10.23 14:17, Huacai Chen wrote:
> >>> Hi, Jaak and Evan,
> >>>
> >>> On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> >>> wrote:
> 
>  On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
>  wrote:
> >
> > On 26.10.23 03:58, Huacai Chen wrote:
> >> Hi, Jaak,
> >>
> >> On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
> >> wrote:
> >>>
> >>> On 25.10.23 16:23, Huacai Chen wrote:
>  On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
>   wrote:
> >
> > Javier, Dave, Sima,
> >
> > On 23.10.23 00:54, Evan Preston wrote:
> >> On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> >>> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> >>> (Thorsten
> >>> Leemhuis)  wrote:
>  On 09.10.23 10:54, Huacai Chen wrote:
> > On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> >  wrote:
> >> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
> >> wrote:
> >>> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> >>>  wrote:
>  On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
>  tracking (Thorsten
>  Leemhuis)  wrote:
> > On 13.09.23 14:02, Jaak Ristioja wrote:
> >>
> >> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> >> (Integrated Intel HD
> >> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> >> results in a blank
> >> screen after boot until the display manager starts... 
> >> if it does start
> >> at all. Using the nomodeset kernel parameter seems to 
> >> be a workaround.
> >>
> >> I've bisected this to commit 
> >> 60aebc9559492cea6a9625f514a8041717e3a2e4
> >> ("drivers/firmware: Move sysfb_init() from 
> >> device_initcall to
> >> subsys_initcall_sync").
> >
> >>> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> >>> things work fine
> >>> again. So I guess the reason:
> 
>  Well, this to me still looks a lot (please correct me if I'm 
>  wrong) like
>  regression that should be fixed, as DRM_SIMPLEDRM was 
>  enabled beforehand
>  if I understood things correctly. Or is there a proper fix 
>  for this
>  already in the works and I just missed this? Or is there 
>  some good
>  reason why this won't/can't be fixed?
> >>>
> >>> DRM_SIMPLEDRM was enabled but it didn't work at all because 
> >>> there was
> >>> no corresponding platform device. Now DRM_SIMPLEDRM works but 
> >>> it has a
> >>> blank screen. Of course it is valuable to investigate further 
> >>> about
> >>> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort 
> >>> because
> >>> I don't have a same machine.
> >
> > Side note: Huacai, have you tried working with Jaak to get down 
> > to the
> > real problem? Evan, might you be able to help out here?
>  No, Jaak has no response after he 'fixed' his problem by 
>  disabling SIMPLEDRM.
> 
> >>>
> >>> I'm sorry, what was it exactly you want me to do? Please be 
> >>> mindful that
> >>> I'm not familiar with the internals of the Linux kernel and DRI, 
> >>> and it
> >>> might sometimes take weeks before I have time to work and respond 
> >>> on this.
> >> It doesn't matter. I hope you can do some experiments to 
> >> investigate
> >> deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> >> CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to 
> >> see
> >> whether there is also a blank screen. If no blank scre

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Evan Preston
Hi Huacai,

On 2023-11-05 Sun 08:40pm, Huacai Chen wrote:
> Hi, Evan,
> 
> On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:
> >
> > Hi Huacai,
> >
> > On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > > Hi, Evan,
> > >
> > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> > > >
> > > > Hi Huacai,
> > > >
> > > > On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > > > Hi, Jaak,
> > > > >
> > > > > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> > > > > >
> > > > > > On 31.10.23 14:17, Huacai Chen wrote:
> > > > > > > Hi, Jaak and Evan,
> > > > > > >
> > > > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen 
> > > > > > >  wrote:
> > > > > > >>
> > > > > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> > > > > > >> wrote:
> > > > > > >>>
> > > > > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > > > > >  Hi, Jaak,
> > > > > > 
> > > > > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja 
> > > > > >   wrote:
> > > > > > >
> > > > > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > > > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > > > > >>  wrote:
> > > > > > >>>
> > > > > > >>> Javier, Dave, Sima,
> > > > > > >>>
> > > > > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > > > > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > > > > > (Thorsten
> > > > > > > Leemhuis)  wrote:
> > > > > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > > > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > > > > >>>  wrote:
> > > > > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
> > > > > >  wrote:
> > > > > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > > > > >  wrote:
> > > > > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > > > > >> tracking (Thorsten
> > > > > > >> Leemhuis)  wrote:
> > > > > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > > > 
> > > > > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > > > > >  (Integrated Intel HD
> > > > > >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> > > > > >  results in a blank
> > > > > >  screen after boot until the display manager 
> > > > > >  starts... if it does start
> > > > > >  at all. Using the nomodeset kernel parameter seems 
> > > > > >  to be a workaround.
> > > > > > 
> > > > > >  I've bisected this to commit 
> > > > > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > > > > >  ("drivers/firmware: Move sysfb_init() from 
> > > > > >  device_initcall to
> > > > > >  subsys_initcall_sync").
> > > > > > >>>
> > > > > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > > > > > things work fine
> > > > > > > again. So I guess the reason:
> > > > > > >>
> > > > > > >> Well, this to me still looks a lot (please correct me if 
> > > > > > >> I'm wrong) like
> > > > > > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > > > > > >> enabled beforehand
> > > > > > >> if I understood things correctly. Or is there a proper 
> > > > > > >> fix for this
> > > > > > >> already in the works and I just missed this? Or is there 
> > > > > > >> some good
> > > > > > >> reason why this won't/can't be fixed?
> > > > > > >
> > > > > > > DRM_SIMPLEDRM was enabled but it didn't work at all 
> > > > > > > because there was
> > > > > > > no corresponding platform device. Now DRM_SIMPLEDRM works 
> > > > > > > but it has a
> > > > > > > blank screen. Of course it is valuable to investigate 
> > > > > > > further about
> > > > > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > > > > > > effort because
> > > > > > > I don't have a same machine.
> > > > > > >>>
> > > > > > >>> Side note: Huacai, have you tried working with Jaak to get 
> > > > > > >>> down to the
> > > > > > >>> real problem? Evan, might you be able to help out here?
> > > > > > >> No, Jaak has no response after he 'fixed' his problem by 
> > > > > > >> disabling SIMPLEDRM.
> > > > > > >>
> > > > > > >
> > > > > > > I'm sorry, what was it exactly you want me to do? Please be 
> > > > > > > mindful that
> > > > > > > I'm not familiar with the internals of the Linux kernel and 
> > > > > > > DRI, and it
> > > > > > > might sometimes take weeks before I have time to work and 
> > > > > > > respond on this.
> > > > > >  It doesn't matter

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Jaak Ristioja

On 05.11.23 14:40, Huacai Chen wrote:

Hi, Evan,

On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:


Hi Huacai,

On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:

Hi, Evan,

On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:


Hi Huacai,

On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:

Hi, Jaak,

On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:


On 31.10.23 14:17, Huacai Chen wrote:

Hi, Jaak and Evan,

On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:


On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:


On 26.10.23 03:58, Huacai Chen wrote:

Hi, Jaak,

On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:


On 25.10.23 16:23, Huacai Chen wrote:

On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:


Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:

On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:

On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 09.10.23 10:54, Huacai Chen wrote:

On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:

On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 13.09.23 14:02, Jaak Ristioja wrote:


Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
screen after boot until the display manager starts... if it does start
at all. Using the nomodeset kernel parameter seems to be a workaround.

I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
("drivers/firmware: Move sysfb_init() from device_initcall to
subsys_initcall_sync").



As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:


Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?


DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.


Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.



I'm sorry, what was it exactly you want me to do? Please be mindful that
I'm not familiar with the internals of the Linux kernel and DRI, and it
might sometimes take weeks before I have time to work and respond on this.

It doesn't matter. I hope you can do some experiments to investigate
deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
whether there is also a blank screen. If no blank screen, that
probably means SIMPLEDRM has a bug, if still blank screen, that means
the firmware may pass wrong screen information.


Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.

CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
is that DRM_SIMPLEDRM has a bug. The next step is to enable
CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
some printk() in simpledrm_probe() and its sub-routines to see where
the driver fails. The output of these printk() can be seen by the
'dmesg' command after boot.

I need your help. I tried with my laptop (ThinkPad E490, Intel Core
i3-8145U, UHD Graphics 620) but I can't reproduce your problem. So
please patch your 6.5.x kernel with this temporary patch [1], then
build a "bad kernel" with SIMPLEDRM enabled. And after booting your
machine with this "bad kernel", please give me the dmesg output. Thank
you very much.

[1] http://ddns.miaomiaomiao.top:9000/download/kernel/patch-6.5.9


I'm unable to download it. Can you please send it by e-mail?

I'm sorry, please download from attachment.


When applying this patch the first hunk (drivers/firmware/sysfb.c) fails for
me with 6.5.9.  Attempting to load the 6.5.9 kernel without this patch
produces no dmesg output on my machine.

You copy-paste the patch? If you download it directly it can be
applied successfully, I think.


The patch downloaded from your URL applies successfully.  However, I still
see no dmesg output using the patched 6.5.9 kernel.  'journalctl -k -b all'
shows no dmesg output from any 6.5.x boots, only from 6.4.12 boots.

Thank you for your testing. Since you cannot boot to GUI successfully
as Jaak, you may have some troubles with getting the 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Huacai Chen
Hi, Evan,

On Sat, Nov 4, 2023 at 10:50 AM Evan Preston  wrote:
>
> Hi Huacai,
>
> On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> > Hi, Evan,
> >
> > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> > >
> > > Hi Huacai,
> > >
> > > On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > > Hi, Jaak,
> > > >
> > > > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> > > > >
> > > > > On 31.10.23 14:17, Huacai Chen wrote:
> > > > > > Hi, Jaak and Evan,
> > > > > >
> > > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> > > > > > wrote:
> > > > > >>
> > > > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> > > > > >> wrote:
> > > > > >>>
> > > > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > > > >  Hi, Jaak,
> > > > > 
> > > > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
> > > > >  wrote:
> > > > > >
> > > > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > > > >>  wrote:
> > > > > >>>
> > > > > >>> Javier, Dave, Sima,
> > > > > >>>
> > > > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > > > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > > > > (Thorsten
> > > > > > Leemhuis)  wrote:
> > > > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > > > >>>  wrote:
> > > > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
> > > > >  wrote:
> > > > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > > > >  wrote:
> > > > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > > > >> tracking (Thorsten
> > > > > >> Leemhuis)  wrote:
> > > > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > > 
> > > > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > > > >  (Integrated Intel HD
> > > > >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> > > > >  results in a blank
> > > > >  screen after boot until the display manager 
> > > > >  starts... if it does start
> > > > >  at all. Using the nomodeset kernel parameter seems 
> > > > >  to be a workaround.
> > > > > 
> > > > >  I've bisected this to commit 
> > > > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > > > >  ("drivers/firmware: Move sysfb_init() from 
> > > > >  device_initcall to
> > > > >  subsys_initcall_sync").
> > > > > >>>
> > > > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > > > > things work fine
> > > > > > again. So I guess the reason:
> > > > > >>
> > > > > >> Well, this to me still looks a lot (please correct me if 
> > > > > >> I'm wrong) like
> > > > > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > > > > >> enabled beforehand
> > > > > >> if I understood things correctly. Or is there a proper fix 
> > > > > >> for this
> > > > > >> already in the works and I just missed this? Or is there 
> > > > > >> some good
> > > > > >> reason why this won't/can't be fixed?
> > > > > >
> > > > > > DRM_SIMPLEDRM was enabled but it didn't work at all because 
> > > > > > there was
> > > > > > no corresponding platform device. Now DRM_SIMPLEDRM works 
> > > > > > but it has a
> > > > > > blank screen. Of course it is valuable to investigate 
> > > > > > further about
> > > > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's 
> > > > > > effort because
> > > > > > I don't have a same machine.
> > > > > >>>
> > > > > >>> Side note: Huacai, have you tried working with Jaak to get 
> > > > > >>> down to the
> > > > > >>> real problem? Evan, might you be able to help out here?
> > > > > >> No, Jaak has no response after he 'fixed' his problem by 
> > > > > >> disabling SIMPLEDRM.
> > > > > >>
> > > > > >
> > > > > > I'm sorry, what was it exactly you want me to do? Please be 
> > > > > > mindful that
> > > > > > I'm not familiar with the internals of the Linux kernel and 
> > > > > > DRI, and it
> > > > > > might sometimes take weeks before I have time to work and 
> > > > > > respond on this.
> > > > >  It doesn't matter. I hope you can do some experiments to 
> > > > >  investigate
> > > > >  deeper. The first experiment you can do is enabling SIMPLEFB 
> > > > >  (i.e.
> > > > >  CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to 
> > > > >  see
> > > > > 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-04 Thread Evan Preston
Hi Huacai,

On 2023-11-03 Fri 02:36pm, Huacai Chen wrote:
> Hi, Evan,
> 
> On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
> >
> > Hi Huacai,
> >
> > On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > > Hi, Jaak,
> > >
> > > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> > > >
> > > > On 31.10.23 14:17, Huacai Chen wrote:
> > > > > Hi, Jaak and Evan,
> > > > >
> > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> > > > > wrote:
> > > > >>
> > > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  
> > > > >> wrote:
> > > > >>>
> > > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > > >  Hi, Jaak,
> > > > 
> > > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
> > > >  wrote:
> > > > >
> > > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > > >>  wrote:
> > > > >>>
> > > > >>> Javier, Dave, Sima,
> > > > >>>
> > > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > > > (Thorsten
> > > > > Leemhuis)  wrote:
> > > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > > >>>  wrote:
> > > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen 
> > > >  wrote:
> > > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > > >  wrote:
> > > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression 
> > > > >> tracking (Thorsten
> > > > >> Leemhuis)  wrote:
> > > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > 
> > > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > > >  (Integrated Intel HD
> > > >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> > > >  results in a blank
> > > >  screen after boot until the display manager starts... 
> > > >  if it does start
> > > >  at all. Using the nomodeset kernel parameter seems to 
> > > >  be a workaround.
> > > > 
> > > >  I've bisected this to commit 
> > > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > > >  ("drivers/firmware: Move sysfb_init() from 
> > > >  device_initcall to
> > > >  subsys_initcall_sync").
> > > > >>>
> > > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes 
> > > > > things work fine
> > > > > again. So I guess the reason:
> > > > >>
> > > > >> Well, this to me still looks a lot (please correct me if I'm 
> > > > >> wrong) like
> > > > >> regression that should be fixed, as DRM_SIMPLEDRM was 
> > > > >> enabled beforehand
> > > > >> if I understood things correctly. Or is there a proper fix 
> > > > >> for this
> > > > >> already in the works and I just missed this? Or is there 
> > > > >> some good
> > > > >> reason why this won't/can't be fixed?
> > > > >
> > > > > DRM_SIMPLEDRM was enabled but it didn't work at all because 
> > > > > there was
> > > > > no corresponding platform device. Now DRM_SIMPLEDRM works but 
> > > > > it has a
> > > > > blank screen. Of course it is valuable to investigate further 
> > > > > about
> > > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort 
> > > > > because
> > > > > I don't have a same machine.
> > > > >>>
> > > > >>> Side note: Huacai, have you tried working with Jaak to get down 
> > > > >>> to the
> > > > >>> real problem? Evan, might you be able to help out here?
> > > > >> No, Jaak has no response after he 'fixed' his problem by 
> > > > >> disabling SIMPLEDRM.
> > > > >>
> > > > >
> > > > > I'm sorry, what was it exactly you want me to do? Please be 
> > > > > mindful that
> > > > > I'm not familiar with the internals of the Linux kernel and DRI, 
> > > > > and it
> > > > > might sometimes take weeks before I have time to work and respond 
> > > > > on this.
> > > >  It doesn't matter. I hope you can do some experiments to 
> > > >  investigate
> > > >  deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> > > >  CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to 
> > > >  see
> > > >  whether there is also a blank screen. If no blank screen, that
> > > >  probably means SIMPLEDRM has a bug, if still blank screen, that 
> > > >  means
> > > >  the firmware may pass wrong screen information.
> > > > >>>
> > > > >>> Testing with 6.5.9 I get a blank screen with CONFI

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-03 Thread Evan Preston
Hi Huacai,

On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> Hi, Jaak,
> 
> On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> >
> > On 31.10.23 14:17, Huacai Chen wrote:
> > > Hi, Jaak and Evan,
> > >
> > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:
> > >>
> > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:
> > >>>
> > >>> On 26.10.23 03:58, Huacai Chen wrote:
> >  Hi, Jaak,
> > 
> >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:
> > >
> > > On 25.10.23 16:23, Huacai Chen wrote:
> > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > >>  wrote:
> > >>>
> > >>> Javier, Dave, Sima,
> > >>>
> > >>> On 23.10.23 00:54, Evan Preston wrote:
> >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > (Thorsten
> > > Leemhuis)  wrote:
> > >> On 09.10.23 10:54, Huacai Chen wrote:
> > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > >>>  wrote:
> >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > >  wrote:
> > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking 
> > >> (Thorsten
> > >> Leemhuis)  wrote:
> > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > 
> >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> >  (Integrated Intel HD
> >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results 
> >  in a blank
> >  screen after boot until the display manager starts... if 
> >  it does start
> >  at all. Using the nomodeset kernel parameter seems to be a 
> >  workaround.
> > 
> >  I've bisected this to commit 
> >  60aebc9559492cea6a9625f514a8041717e3a2e4
> >  ("drivers/firmware: Move sysfb_init() from device_initcall 
> >  to
> >  subsys_initcall_sync").
> > >>>
> > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things 
> > > work fine
> > > again. So I guess the reason:
> > >>
> > >> Well, this to me still looks a lot (please correct me if I'm 
> > >> wrong) like
> > >> regression that should be fixed, as DRM_SIMPLEDRM was enabled 
> > >> beforehand
> > >> if I understood things correctly. Or is there a proper fix for 
> > >> this
> > >> already in the works and I just missed this? Or is there some 
> > >> good
> > >> reason why this won't/can't be fixed?
> > >
> > > DRM_SIMPLEDRM was enabled but it didn't work at all because there 
> > > was
> > > no corresponding platform device. Now DRM_SIMPLEDRM works but it 
> > > has a
> > > blank screen. Of course it is valuable to investigate further 
> > > about
> > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort 
> > > because
> > > I don't have a same machine.
> > >>>
> > >>> Side note: Huacai, have you tried working with Jaak to get down to 
> > >>> the
> > >>> real problem? Evan, might you be able to help out here?
> > >> No, Jaak has no response after he 'fixed' his problem by disabling 
> > >> SIMPLEDRM.
> > >>
> > >
> > > I'm sorry, what was it exactly you want me to do? Please be mindful 
> > > that
> > > I'm not familiar with the internals of the Linux kernel and DRI, and 
> > > it
> > > might sometimes take weeks before I have time to work and respond on 
> > > this.
> >  It doesn't matter. I hope you can do some experiments to investigate
> >  deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> >  CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
> >  whether there is also a blank screen. If no blank screen, that
> >  probably means SIMPLEDRM has a bug, if still blank screen, that means
> >  the firmware may pass wrong screen information.
> > >>>
> > >>> Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
> > >>> get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM 
> > >>> unset.
> > >> CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
> > >> by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
> > >> is that DRM_SIMPLEDRM has a bug. The next step is to enable
> > >> CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
> > >> some printk() in simpledrm_probe() and its sub-routines to see where
> > >> the driver fails. The output of these printk() can be seen by the
> > >> 'dmesg' command after boot.
> > > I need your help. I tried with 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-02 Thread Huacai Chen
Hi, Evan,

On Fri, Nov 3, 2023 at 1:54 PM Evan Preston  wrote:
>
> Hi Huacai,
>
> On 2023-11-02 Thu 08:38pm, Huacai Chen wrote:
> > Hi, Jaak,
> >
> > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
> > >
> > > On 31.10.23 14:17, Huacai Chen wrote:
> > > > Hi, Jaak and Evan,
> > > >
> > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  
> > > > wrote:
> > > >>
> > > >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:
> > > >>>
> > > >>> On 26.10.23 03:58, Huacai Chen wrote:
> > >  Hi, Jaak,
> > > 
> > >  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  
> > >  wrote:
> > > >
> > > > On 25.10.23 16:23, Huacai Chen wrote:
> > > >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > > >>  wrote:
> > > >>>
> > > >>> Javier, Dave, Sima,
> > > >>>
> > > >>> On 23.10.23 00:54, Evan Preston wrote:
> > >  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > > > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking 
> > > > (Thorsten
> > > > Leemhuis)  wrote:
> > > >> On 09.10.23 10:54, Huacai Chen wrote:
> > > >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> > > >>>  wrote:
> > >  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > > > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > > >  wrote:
> > > >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking 
> > > >> (Thorsten
> > > >> Leemhuis)  wrote:
> > > >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> > > 
> > >  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 
> > >  (Integrated Intel HD
> > >  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) 
> > >  results in a blank
> > >  screen after boot until the display manager starts... if 
> > >  it does start
> > >  at all. Using the nomodeset kernel parameter seems to be 
> > >  a workaround.
> > > 
> > >  I've bisected this to commit 
> > >  60aebc9559492cea6a9625f514a8041717e3a2e4
> > >  ("drivers/firmware: Move sysfb_init() from 
> > >  device_initcall to
> > >  subsys_initcall_sync").
> > > >>>
> > > > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things 
> > > > work fine
> > > > again. So I guess the reason:
> > > >>
> > > >> Well, this to me still looks a lot (please correct me if I'm 
> > > >> wrong) like
> > > >> regression that should be fixed, as DRM_SIMPLEDRM was enabled 
> > > >> beforehand
> > > >> if I understood things correctly. Or is there a proper fix for 
> > > >> this
> > > >> already in the works and I just missed this? Or is there some 
> > > >> good
> > > >> reason why this won't/can't be fixed?
> > > >
> > > > DRM_SIMPLEDRM was enabled but it didn't work at all because 
> > > > there was
> > > > no corresponding platform device. Now DRM_SIMPLEDRM works but 
> > > > it has a
> > > > blank screen. Of course it is valuable to investigate further 
> > > > about
> > > > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort 
> > > > because
> > > > I don't have a same machine.
> > > >>>
> > > >>> Side note: Huacai, have you tried working with Jaak to get down 
> > > >>> to the
> > > >>> real problem? Evan, might you be able to help out here?
> > > >> No, Jaak has no response after he 'fixed' his problem by disabling 
> > > >> SIMPLEDRM.
> > > >>
> > > >
> > > > I'm sorry, what was it exactly you want me to do? Please be mindful 
> > > > that
> > > > I'm not familiar with the internals of the Linux kernel and DRI, 
> > > > and it
> > > > might sometimes take weeks before I have time to work and respond 
> > > > on this.
> > >  It doesn't matter. I hope you can do some experiments to investigate
> > >  deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> > >  CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
> > >  whether there is also a blank screen. If no blank screen, that
> > >  probably means SIMPLEDRM has a bug, if still blank screen, that means
> > >  the firmware may pass wrong screen information.
> > > >>>
> > > >>> Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y 
> > > >>> and
> > > >>> get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM 
> > > >>> unset.
> > > >> CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
> > > >> by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
> > > >> is that DRM_SIMPLEDRM has a bug. The next step is 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-02 Thread Huacai Chen
Hi, Jaak,

On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja  wrote:
>
> On 31.10.23 14:17, Huacai Chen wrote:
> > Hi, Jaak and Evan,
> >
> > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:
> >>
> >> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:
> >>>
> >>> On 26.10.23 03:58, Huacai Chen wrote:
>  Hi, Jaak,
> 
>  On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:
> >
> > On 25.10.23 16:23, Huacai Chen wrote:
> >> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> >>  wrote:
> >>>
> >>> Javier, Dave, Sima,
> >>>
> >>> On 23.10.23 00:54, Evan Preston wrote:
>  On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
> > Leemhuis)  wrote:
> >> On 09.10.23 10:54, Huacai Chen wrote:
> >>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> >>>  wrote:
>  On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> >  wrote:
> >> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking 
> >> (Thorsten
> >> Leemhuis)  wrote:
> >>> On 13.09.23 14:02, Jaak Ristioja wrote:
> 
>  Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated 
>  Intel HD
>  Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results 
>  in a blank
>  screen after boot until the display manager starts... if it 
>  does start
>  at all. Using the nomodeset kernel parameter seems to be a 
>  workaround.
> 
>  I've bisected this to commit 
>  60aebc9559492cea6a9625f514a8041717e3a2e4
>  ("drivers/firmware: Move sysfb_init() from device_initcall to
>  subsys_initcall_sync").
> >>>
> > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work 
> > fine
> > again. So I guess the reason:
> >>
> >> Well, this to me still looks a lot (please correct me if I'm 
> >> wrong) like
> >> regression that should be fixed, as DRM_SIMPLEDRM was enabled 
> >> beforehand
> >> if I understood things correctly. Or is there a proper fix for this
> >> already in the works and I just missed this? Or is there some good
> >> reason why this won't/can't be fixed?
> >
> > DRM_SIMPLEDRM was enabled but it didn't work at all because there 
> > was
> > no corresponding platform device. Now DRM_SIMPLEDRM works but it 
> > has a
> > blank screen. Of course it is valuable to investigate further about
> > DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort 
> > because
> > I don't have a same machine.
> >>>
> >>> Side note: Huacai, have you tried working with Jaak to get down to the
> >>> real problem? Evan, might you be able to help out here?
> >> No, Jaak has no response after he 'fixed' his problem by disabling 
> >> SIMPLEDRM.
> >>
> >
> > I'm sorry, what was it exactly you want me to do? Please be mindful that
> > I'm not familiar with the internals of the Linux kernel and DRI, and it
> > might sometimes take weeks before I have time to work and respond on 
> > this.
>  It doesn't matter. I hope you can do some experiments to investigate
>  deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
>  CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
>  whether there is also a blank screen. If no blank screen, that
>  probably means SIMPLEDRM has a bug, if still blank screen, that means
>  the firmware may pass wrong screen information.
> >>>
> >>> Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
> >>> get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM 
> >>> unset.
> >> CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
> >> by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
> >> is that DRM_SIMPLEDRM has a bug. The next step is to enable
> >> CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
> >> some printk() in simpledrm_probe() and its sub-routines to see where
> >> the driver fails. The output of these printk() can be seen by the
> >> 'dmesg' command after boot.
> > I need your help. I tried with my laptop (ThinkPad E490, Intel Core
> > i3-8145U, UHD Graphics 620) but I can't reproduce your problem. So
> > please patch your 6.5.x kernel with this temporary patch [1], then
> > build a "bad kernel" with SIMPLEDRM enabled. And after booting your
> > machine with this "bad kernel", please give me the dmesg output. Thank
> > you very much.
> >
> > [1] http://ddns.miaomiao

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-01 Thread Jaak Ristioja

On 31.10.23 14:17, Huacai Chen wrote:

Hi, Jaak and Evan,

On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:


On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:


On 26.10.23 03:58, Huacai Chen wrote:

Hi, Jaak,

On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:


On 25.10.23 16:23, Huacai Chen wrote:

On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:


Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:

On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:

On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 09.10.23 10:54, Huacai Chen wrote:

On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:

On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 13.09.23 14:02, Jaak Ristioja wrote:


Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
screen after boot until the display manager starts... if it does start
at all. Using the nomodeset kernel parameter seems to be a workaround.

I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
("drivers/firmware: Move sysfb_init() from device_initcall to
subsys_initcall_sync").



As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:


Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?


DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.


Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.



I'm sorry, what was it exactly you want me to do? Please be mindful that
I'm not familiar with the internals of the Linux kernel and DRI, and it
might sometimes take weeks before I have time to work and respond on this.

It doesn't matter. I hope you can do some experiments to investigate
deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
whether there is also a blank screen. If no blank screen, that
probably means SIMPLEDRM has a bug, if still blank screen, that means
the firmware may pass wrong screen information.


Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.

CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
is that DRM_SIMPLEDRM has a bug. The next step is to enable
CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
some printk() in simpledrm_probe() and its sub-routines to see where
the driver fails. The output of these printk() can be seen by the
'dmesg' command after boot.

I need your help. I tried with my laptop (ThinkPad E490, Intel Core
i3-8145U, UHD Graphics 620) but I can't reproduce your problem. So
please patch your 6.5.x kernel with this temporary patch [1], then
build a "bad kernel" with SIMPLEDRM enabled. And after booting your
machine with this "bad kernel", please give me the dmesg output. Thank
you very much.

[1] http://ddns.miaomiaomiao.top:9000/download/kernel/patch-6.5.9


I'm unable to download it. Can you please send it by e-mail?

Jaak




Huacai



Huacai



Jaak



Huacai



Jaak



But I write this mail for a different reason:


I am having the same issue on a Lenovo Thinkpad P70 (Intel
Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
screen after boot and a rapidly flashing device-access-status
indicator.


This additional report makes me wonder if we should revert the culprit
(60aebc9559492c ("drivers/firmware: Move sysfb_init() from
device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
might lead to regressions for some users? But the patch description says
that this is not a common configuration, so can we maybe get away with that?

   From my point of view, this is not a regression, 60aebc9559492c
doesn't cause a problem, but exposes a problem. So we need to fix the
real problem (SIMPLEDRM has a blank screen on some conditions). This
needs Jaak or Evan's help.

Huacai


Ciao, Thorsten (wearing his 'the Linux kernel's regression 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-31 Thread Huacai Chen
Hi, Jaak and Evan,

On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen  wrote:
>
> On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:
> >
> > On 26.10.23 03:58, Huacai Chen wrote:
> > > Hi, Jaak,
> > >
> > > On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:
> > >>
> > >> On 25.10.23 16:23, Huacai Chen wrote:
> > >>> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> > >>>  wrote:
> > 
> >  Javier, Dave, Sima,
> > 
> >  On 23.10.23 00:54, Evan Preston wrote:
> > > On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> > >> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
> > >> Leemhuis)  wrote:
> > >>> On 09.10.23 10:54, Huacai Chen wrote:
> >  On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya 
> >   wrote:
> > > On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > >> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> > >>  wrote:
> > >>> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking 
> > >>> (Thorsten
> > >>> Leemhuis)  wrote:
> >  On 13.09.23 14:02, Jaak Ristioja wrote:
> > >
> > > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated 
> > > Intel HD
> > > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in 
> > > a blank
> > > screen after boot until the display manager starts... if it 
> > > does start
> > > at all. Using the nomodeset kernel parameter seems to be a 
> > > workaround.
> > >
> > > I've bisected this to commit 
> > > 60aebc9559492cea6a9625f514a8041717e3a2e4
> > > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > > subsys_initcall_sync").
> > 
> > >> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work 
> > >> fine
> > >> again. So I guess the reason:
> > >>>
> > >>> Well, this to me still looks a lot (please correct me if I'm wrong) 
> > >>> like
> > >>> regression that should be fixed, as DRM_SIMPLEDRM was enabled 
> > >>> beforehand
> > >>> if I understood things correctly. Or is there a proper fix for this
> > >>> already in the works and I just missed this? Or is there some good
> > >>> reason why this won't/can't be fixed?
> > >>
> > >> DRM_SIMPLEDRM was enabled but it didn't work at all because there was
> > >> no corresponding platform device. Now DRM_SIMPLEDRM works but it has 
> > >> a
> > >> blank screen. Of course it is valuable to investigate further about
> > >> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
> > >> I don't have a same machine.
> > 
> >  Side note: Huacai, have you tried working with Jaak to get down to the
> >  real problem? Evan, might you be able to help out here?
> > >>> No, Jaak has no response after he 'fixed' his problem by disabling 
> > >>> SIMPLEDRM.
> > >>>
> > >>
> > >> I'm sorry, what was it exactly you want me to do? Please be mindful that
> > >> I'm not familiar with the internals of the Linux kernel and DRI, and it
> > >> might sometimes take weeks before I have time to work and respond on 
> > >> this.
> > > It doesn't matter. I hope you can do some experiments to investigate
> > > deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> > > CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
> > > whether there is also a blank screen. If no blank screen, that
> > > probably means SIMPLEDRM has a bug, if still blank screen, that means
> > > the firmware may pass wrong screen information.
> >
> > Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
> > get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.
> CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
> by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
> is that DRM_SIMPLEDRM has a bug. The next step is to enable
> CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
> some printk() in simpledrm_probe() and its sub-routines to see where
> the driver fails. The output of these printk() can be seen by the
> 'dmesg' command after boot.
I need your help. I tried with my laptop (ThinkPad E490, Intel Core
i3-8145U, UHD Graphics 620) but I can't reproduce your problem. So
please patch your 6.5.x kernel with this temporary patch [1], then
build a "bad kernel" with SIMPLEDRM enabled. And after booting your
machine with this "bad kernel", please give me the dmesg output. Thank
you very much.

[1] http://ddns.miaomiaomiao.top:9000/download/kernel/patch-6.5.9


Huacai

>
> Huacai
>
> >
> > Jaak
> >
> > >
> > > Huacai
> > >
> > >>
> > >> Jaak
> > >>
> > 
> >  But I write this mail for a different reason:
> > 
> > > I am having the same issue on a Lenovo Thinkpad P70 (Intel
> > > Corpora

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-28 Thread Huacai Chen
On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja  wrote:
>
> On 26.10.23 03:58, Huacai Chen wrote:
> > Hi, Jaak,
> >
> > On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:
> >>
> >> On 25.10.23 16:23, Huacai Chen wrote:
> >>> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> >>>  wrote:
> 
>  Javier, Dave, Sima,
> 
>  On 23.10.23 00:54, Evan Preston wrote:
> > On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> >> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
> >> Leemhuis)  wrote:
> >>> On 09.10.23 10:54, Huacai Chen wrote:
>  On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  
>  wrote:
> > On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> >> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen 
> >>  wrote:
> >>> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking 
> >>> (Thorsten
> >>> Leemhuis)  wrote:
>  On 13.09.23 14:02, Jaak Ristioja wrote:
> >
> > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated 
> > Intel HD
> > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a 
> > blank
> > screen after boot until the display manager starts... if it 
> > does start
> > at all. Using the nomodeset kernel parameter seems to be a 
> > workaround.
> >
> > I've bisected this to commit 
> > 60aebc9559492cea6a9625f514a8041717e3a2e4
> > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > subsys_initcall_sync").
> 
> >> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work 
> >> fine
> >> again. So I guess the reason:
> >>>
> >>> Well, this to me still looks a lot (please correct me if I'm wrong) 
> >>> like
> >>> regression that should be fixed, as DRM_SIMPLEDRM was enabled 
> >>> beforehand
> >>> if I understood things correctly. Or is there a proper fix for this
> >>> already in the works and I just missed this? Or is there some good
> >>> reason why this won't/can't be fixed?
> >>
> >> DRM_SIMPLEDRM was enabled but it didn't work at all because there was
> >> no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
> >> blank screen. Of course it is valuable to investigate further about
> >> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
> >> I don't have a same machine.
> 
>  Side note: Huacai, have you tried working with Jaak to get down to the
>  real problem? Evan, might you be able to help out here?
> >>> No, Jaak has no response after he 'fixed' his problem by disabling 
> >>> SIMPLEDRM.
> >>>
> >>
> >> I'm sorry, what was it exactly you want me to do? Please be mindful that
> >> I'm not familiar with the internals of the Linux kernel and DRI, and it
> >> might sometimes take weeks before I have time to work and respond on this.
> > It doesn't matter. I hope you can do some experiments to investigate
> > deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
> > CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
> > whether there is also a blank screen. If no blank screen, that
> > probably means SIMPLEDRM has a bug, if still blank screen, that means
> > the firmware may pass wrong screen information.
>
> Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and
> get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.
CONFIG_FB_SIMPLE and  CONFIG_DRM_SIMPLEDRM use the same device created
by sysfb_init(). Since FB_SIMPLE works fine, I think the real problem
is that DRM_SIMPLEDRM has a bug. The next step is to enable
CONFIG_DRM_SIMPLEDRM and trace its initialization. In detail, adding
some printk() in simpledrm_probe() and its sub-routines to see where
the driver fails. The output of these printk() can be seen by the
'dmesg' command after boot.

Huacai

>
> Jaak
>
> >
> > Huacai
> >
> >>
> >> Jaak
> >>
> 
>  But I write this mail for a different reason:
> 
> > I am having the same issue on a Lenovo Thinkpad P70 (Intel
> > Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
> > Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
> > screen after boot and a rapidly flashing device-access-status
> > indicator.
> 
>  This additional report makes me wonder if we should revert the culprit
>  (60aebc9559492c ("drivers/firmware: Move sysfb_init() from
>  device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
>  might lead to regressions for some users? But the patch description says
>  that this is not a common configuration, so can we maybe get away with 
>  that?
> >>>   From my point of view, this is not a regression, 60aebc9559492c
> >>> doesn't cause a proble

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-28 Thread Jaak Ristioja

On 26.10.23 03:58, Huacai Chen wrote:

Hi, Jaak,

On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:


On 25.10.23 16:23, Huacai Chen wrote:

On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:


Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:

On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:

On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 09.10.23 10:54, Huacai Chen wrote:

On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:

On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 13.09.23 14:02, Jaak Ristioja wrote:


Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
screen after boot until the display manager starts... if it does start
at all. Using the nomodeset kernel parameter seems to be a workaround.

I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
("drivers/firmware: Move sysfb_init() from device_initcall to
subsys_initcall_sync").



As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:


Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?


DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.


Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.



I'm sorry, what was it exactly you want me to do? Please be mindful that
I'm not familiar with the internals of the Linux kernel and DRI, and it
might sometimes take weeks before I have time to work and respond on this.

It doesn't matter. I hope you can do some experiments to investigate
deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
whether there is also a blank screen. If no blank screen, that
probably means SIMPLEDRM has a bug, if still blank screen, that means
the firmware may pass wrong screen information.


Testing with 6.5.9 I get a blank screen with CONFIG_DRM_SIMPLEDRM=y and 
get no blank screen with CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM unset.


Jaak



Huacai



Jaak



But I write this mail for a different reason:


I am having the same issue on a Lenovo Thinkpad P70 (Intel
Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
screen after boot and a rapidly flashing device-access-status
indicator.


This additional report makes me wonder if we should revert the culprit
(60aebc9559492c ("drivers/firmware: Move sysfb_init() from
device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
might lead to regressions for some users? But the patch description says
that this is not a common configuration, so can we maybe get away with that?

  From my point of view, this is not a regression, 60aebc9559492c
doesn't cause a problem, but exposes a problem. So we need to fix the
real problem (SIMPLEDRM has a blank screen on some conditions). This
needs Jaak or Evan's help.

Huacai


Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
sysfb_init() from device_initcall to subsys_initcall_sync") there is
no platform device created for SIMPLEDRM at early stage, so it seems
also "no problem".

I don't understand above. You mean that after that commit the platform
device is also none, right?

No. The SIMPLEDRM driver needs a platform device to work, and that
commit makes the platform device created earlier. So, before that
commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
commit, SIMPLEDRM works, but the screen is blank.

Huacai


Confused...

--
An old man doll... just what I always wanted! - Clara












Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Huacai Chen
Hi, Jaak,

On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja  wrote:
>
> On 25.10.23 16:23, Huacai Chen wrote:
> > On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
> >  wrote:
> >>
> >> Javier, Dave, Sima,
> >>
> >> On 23.10.23 00:54, Evan Preston wrote:
> >>> On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
>  On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
>  Leemhuis)  wrote:
> > On 09.10.23 10:54, Huacai Chen wrote:
> >> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  
> >> wrote:
> >>> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
>  On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
>  wrote:
> > On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> > Leemhuis)  wrote:
> >> On 13.09.23 14:02, Jaak Ristioja wrote:
> >>>
> >>> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated 
> >>> Intel HD
> >>> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a 
> >>> blank
> >>> screen after boot until the display manager starts... if it does 
> >>> start
> >>> at all. Using the nomodeset kernel parameter seems to be a 
> >>> workaround.
> >>>
> >>> I've bisected this to commit 
> >>> 60aebc9559492cea6a9625f514a8041717e3a2e4
> >>> ("drivers/firmware: Move sysfb_init() from device_initcall to
> >>> subsys_initcall_sync").
> >>
>  As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
>  again. So I guess the reason:
> >
> > Well, this to me still looks a lot (please correct me if I'm wrong) like
> > regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
> > if I understood things correctly. Or is there a proper fix for this
> > already in the works and I just missed this? Or is there some good
> > reason why this won't/can't be fixed?
> 
>  DRM_SIMPLEDRM was enabled but it didn't work at all because there was
>  no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
>  blank screen. Of course it is valuable to investigate further about
>  DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
>  I don't have a same machine.
> >>
> >> Side note: Huacai, have you tried working with Jaak to get down to the
> >> real problem? Evan, might you be able to help out here?
> > No, Jaak has no response after he 'fixed' his problem by disabling 
> > SIMPLEDRM.
> >
>
> I'm sorry, what was it exactly you want me to do? Please be mindful that
> I'm not familiar with the internals of the Linux kernel and DRI, and it
> might sometimes take weeks before I have time to work and respond on this.
It doesn't matter. I hope you can do some experiments to investigate
deeper. The first experiment you can do is enabling SIMPLEFB (i.e.
CONFIG_FB_SIMPLE) instead of SIMPLEDRM (CONFIG_DRM_SIMPLEDRM) to see
whether there is also a blank screen. If no blank screen, that
probably means SIMPLEDRM has a bug, if still blank screen, that means
the firmware may pass wrong screen information.

Huacai

>
> Jaak
>
> >>
> >> But I write this mail for a different reason:
> >>
> >>> I am having the same issue on a Lenovo Thinkpad P70 (Intel
> >>> Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
> >>> Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
> >>> screen after boot and a rapidly flashing device-access-status
> >>> indicator.
> >>
> >> This additional report makes me wonder if we should revert the culprit
> >> (60aebc9559492c ("drivers/firmware: Move sysfb_init() from
> >> device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
> >> might lead to regressions for some users? But the patch description says
> >> that this is not a common configuration, so can we maybe get away with 
> >> that?
> >  From my point of view, this is not a regression, 60aebc9559492c
> > doesn't cause a problem, but exposes a problem. So we need to fix the
> > real problem (SIMPLEDRM has a blank screen on some conditions). This
> > needs Jaak or Evan's help.
> >
> > Huacai
> >>
> >> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> >> --
> >> Everything you wanna know about Linux kernel regression tracking:
> >> https://linux-regtracking.leemhuis.info/about/#tldr
> >> If I did something stupid, please tell me, as explained on that page.
> >>
>  When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
>  know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: 
>  Move
>  sysfb_init() from device_initcall to subsys_initcall_sync") there is
>  no platform device created for SIMPLEDRM at early stage, so it seems
>  also "no problem".
> >>> I don't understand above. You mean that after that commit the platform
> >>> device is also none, right?
> >> No. The 

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Jaak Ristioja

On 25.10.23 16:23, Huacai Chen wrote:

On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:


Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:

On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:

On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 09.10.23 10:54, Huacai Chen wrote:

On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:

On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:

On 13.09.23 14:02, Jaak Ristioja wrote:


Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
screen after boot until the display manager starts... if it does start
at all. Using the nomodeset kernel parameter seems to be a workaround.

I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
("drivers/firmware: Move sysfb_init() from device_initcall to
subsys_initcall_sync").



As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:


Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?


DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.


Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.



I'm sorry, what was it exactly you want me to do? Please be mindful that 
I'm not familiar with the internals of the Linux kernel and DRI, and it 
might sometimes take weeks before I have time to work and respond on this.


Jaak



But I write this mail for a different reason:


I am having the same issue on a Lenovo Thinkpad P70 (Intel
Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
screen after boot and a rapidly flashing device-access-status
indicator.


This additional report makes me wonder if we should revert the culprit
(60aebc9559492c ("drivers/firmware: Move sysfb_init() from
device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
might lead to regressions for some users? But the patch description says
that this is not a common configuration, so can we maybe get away with that?

 From my point of view, this is not a regression, 60aebc9559492c
doesn't cause a problem, but exposes a problem. So we need to fix the
real problem (SIMPLEDRM has a blank screen on some conditions). This
needs Jaak or Evan's help.

Huacai


Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
sysfb_init() from device_initcall to subsys_initcall_sync") there is
no platform device created for SIMPLEDRM at early stage, so it seems
also "no problem".

I don't understand above. You mean that after that commit the platform
device is also none, right?

No. The SIMPLEDRM driver needs a platform device to work, and that
commit makes the platform device created earlier. So, before that
commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
commit, SIMPLEDRM works, but the screen is blank.

Huacai


Confused...

--
An old man doll... just what I always wanted! - Clara










Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Linux regression tracking (Thorsten Leemhuis)
On 25.10.23 15:23, Huacai Chen wrote:
> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
>  wrote:
>>
>> Javier, Dave, Sima,
>>
>> On 23.10.23 00:54, Evan Preston wrote:
>>> On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
 On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
 Leemhuis)  wrote:
> On 09.10.23 10:54, Huacai Chen wrote:
>> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  
>> wrote:
>>> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
 On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
 wrote:
> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> Leemhuis)  wrote:
>> On 13.09.23 14:02, Jaak Ristioja wrote:
>>>
>>> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel 
>>> HD
>>> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a 
>>> blank
>>> screen after boot until the display manager starts... if it does 
>>> start
>>> at all. Using the nomodeset kernel parameter seems to be a 
>>> workaround.
>>>
>>> I've bisected this to commit 
>>> 60aebc9559492cea6a9625f514a8041717e3a2e4
>>> ("drivers/firmware: Move sysfb_init() from device_initcall to
>>> subsys_initcall_sync").
>>
 As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
 again. So I guess the reason:
>
> Well, this to me still looks a lot (please correct me if I'm wrong) like
> regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
> if I understood things correctly. Or is there a proper fix for this
> already in the works and I just missed this? Or is there some good
> reason why this won't/can't be fixed?

 DRM_SIMPLEDRM was enabled but it didn't work at all because there was
 no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
 blank screen. Of course it is valuable to investigate further about
 DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
 I don't have a same machine.
>>
>> Side note: Huacai, have you tried working with Jaak to get down to the
>> real problem? Evan, might you be able to help out here?
> No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.

Yeah, understood, already suspected something like that, thx for confirming.

>> But I write this mail for a different reason:
>>
>>> I am having the same issue on a Lenovo Thinkpad P70 (Intel
>>> Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
>>> Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
>>> screen after boot and a rapidly flashing device-access-status
>>> indicator.
>>
>> This additional report makes me wonder if we should revert the culprit
>> (60aebc9559492c ("drivers/firmware: Move sysfb_init() from
>> device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
>> might lead to regressions for some users? But the patch description says
>> that this is not a common configuration, so can we maybe get away with that?
>>From my point of view, this is not a regression, 60aebc9559492c
> doesn't cause a problem, but exposes a problem.

>From my understanding of Linus stance in cases like this I think that
aspect doesn't matter. To for example quote
https://lore.kernel.org/lkml/CAHk-=wiP4K8DRJWsCo=20hn_6054xbamgkf2kpguzpb5ama...@mail.gmail.com/

""
But it ended up exposing another problem, and as such caused a kernel
upgrade to fail for a user. So it got reverted.
"""

For other examples of his view see the bottom half of
https://docs.kernel.org/process/handling-regressions.html

We could bring Linus in to clarify if needed, but I for now didn't CC
him, as I hope we can solve this without him.

> So we need to fix the
> real problem (SIMPLEDRM has a blank screen on some conditions). This
> needs Jaak or Evan's help.

I'm all for solving the real problem, but if that is not possible within
a reasonable timeframe (which seems to be the case here) I assume Linus
in cases like this would want the culprit to be reverted. Unless of
cause that itself might cause a regression (which is possible, as the
commit made it into 6.5), then things become tricky.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

 When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
 know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
 sysfb_init() from device_initcall to subsys_initcall_sync") there is
 no platform device created for SIMPLEDRM at early stage, so it seems
 also "no problem".
>>> I don't understand above. You mean that after that commit the platform

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Javier Martinez Canillas
Huacai Chen  writes:

Hello,

> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
>  wrote:

[...]

>>
>> This additional report makes me wonder if we should revert the culprit
>> (60aebc9559492c ("drivers/firmware: Move sysfb_init() from
>> device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
>> might lead to regressions for some users? But the patch description says
>> that this is not a common configuration, so can we maybe get away with that?
> From my point of view, this is not a regression, 60aebc9559492c
> doesn't cause a problem, but exposes a problem. So we need to fix the
> real problem (SIMPLEDRM has a blank screen on some conditions). This
> needs Jaak or Evan's help.
>

I agree with this.

> Huacai

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Huacai Chen
On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis
 wrote:
>
> Javier, Dave, Sima,
>
> On 23.10.23 00:54, Evan Preston wrote:
> > On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> >> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
> >> Leemhuis)  wrote:
> >>> On 09.10.23 10:54, Huacai Chen wrote:
>  On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  
>  wrote:
> > On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> >> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
> >> wrote:
> >>> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> >>> Leemhuis)  wrote:
>  On 13.09.23 14:02, Jaak Ristioja wrote:
> >
> > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel 
> > HD
> > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a 
> > blank
> > screen after boot until the display manager starts... if it does 
> > start
> > at all. Using the nomodeset kernel parameter seems to be a 
> > workaround.
> >
> > I've bisected this to commit 
> > 60aebc9559492cea6a9625f514a8041717e3a2e4
> > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > subsys_initcall_sync").
> 
> >> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
> >> again. So I guess the reason:
> >>>
> >>> Well, this to me still looks a lot (please correct me if I'm wrong) like
> >>> regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
> >>> if I understood things correctly. Or is there a proper fix for this
> >>> already in the works and I just missed this? Or is there some good
> >>> reason why this won't/can't be fixed?
> >>
> >> DRM_SIMPLEDRM was enabled but it didn't work at all because there was
> >> no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
> >> blank screen. Of course it is valuable to investigate further about
> >> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
> >> I don't have a same machine.
>
> Side note: Huacai, have you tried working with Jaak to get down to the
> real problem? Evan, might you be able to help out here?
No, Jaak has no response after he 'fixed' his problem by disabling SIMPLEDRM.

>
> But I write this mail for a different reason:
>
> > I am having the same issue on a Lenovo Thinkpad P70 (Intel
> > Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
> > Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
> > screen after boot and a rapidly flashing device-access-status
> > indicator.
>
> This additional report makes me wonder if we should revert the culprit
> (60aebc9559492c ("drivers/firmware: Move sysfb_init() from
> device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
> might lead to regressions for some users? But the patch description says
> that this is not a common configuration, so can we maybe get away with that?
>From my point of view, this is not a regression, 60aebc9559492c
doesn't cause a problem, but exposes a problem. So we need to fix the
real problem (SIMPLEDRM has a blank screen on some conditions). This
needs Jaak or Evan's help.

Huacai
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> >> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
> >> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
> >> sysfb_init() from device_initcall to subsys_initcall_sync") there is
> >> no platform device created for SIMPLEDRM at early stage, so it seems
> >> also "no problem".
> > I don't understand above. You mean that after that commit the platform
> > device is also none, right?
>  No. The SIMPLEDRM driver needs a platform device to work, and that
>  commit makes the platform device created earlier. So, before that
>  commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
>  commit, SIMPLEDRM works, but the screen is blank.
> 
>  Huacai
> >
> > Confused...
> >
> > --
> > An old man doll... just what I always wanted! - Clara
> 
> 
> >
> >


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-25 Thread Thorsten Leemhuis
Javier, Dave, Sima,

On 23.10.23 00:54, Evan Preston wrote:
> On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
>> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
>> Leemhuis)  wrote:
>>> On 09.10.23 10:54, Huacai Chen wrote:
 On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:
> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
>> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
>> wrote:
>>> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
>>> Leemhuis)  wrote:
 On 13.09.23 14:02, Jaak Ristioja wrote:
>
> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> screen after boot until the display manager starts... if it does start
> at all. Using the nomodeset kernel parameter seems to be a workaround.
>
> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> ("drivers/firmware: Move sysfb_init() from device_initcall to
> subsys_initcall_sync").

>> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
>> again. So I guess the reason:
>>>
>>> Well, this to me still looks a lot (please correct me if I'm wrong) like
>>> regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
>>> if I understood things correctly. Or is there a proper fix for this
>>> already in the works and I just missed this? Or is there some good
>>> reason why this won't/can't be fixed?
>>
>> DRM_SIMPLEDRM was enabled but it didn't work at all because there was
>> no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
>> blank screen. Of course it is valuable to investigate further about
>> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
>> I don't have a same machine.

Side note: Huacai, have you tried working with Jaak to get down to the
real problem? Evan, might you be able to help out here?

But I write this mail for a different reason:

> I am having the same issue on a Lenovo Thinkpad P70 (Intel 
> Corporation HD Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).
> Upgrading from Linux 6.4.12 to 6.5 and later results in only a blank
> screen after boot and a rapidly flashing device-access-status
> indicator.

This additional report makes me wonder if we should revert the culprit
(60aebc9559492c ("drivers/firmware: Move sysfb_init() from
device_initcall to subsys_initcall_sync") [v6.5-rc1]). But I guess that
might lead to regressions for some users? But the patch description says
that this is not a common configuration, so can we maybe get away with that?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

>> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
>> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
>> sysfb_init() from device_initcall to subsys_initcall_sync") there is
>> no platform device created for SIMPLEDRM at early stage, so it seems
>> also "no problem".
> I don't understand above. You mean that after that commit the platform
> device is also none, right?
 No. The SIMPLEDRM driver needs a platform device to work, and that
 commit makes the platform device created earlier. So, before that
 commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
 commit, SIMPLEDRM works, but the screen is blank.

 Huacai
>
> Confused...
>
> --
> An old man doll... just what I always wanted! - Clara


> 
> 


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-23 Thread Evan Preston
On 2023-10-20 Fri 05:48pm, Huacai Chen wrote:
> On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
> Leemhuis)  wrote:
> >
> > On 09.10.23 10:54, Huacai Chen wrote:
> > > On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:
> > >> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > >>> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
> > >>> wrote:
> >  On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> >  Leemhuis)  wrote:
> > > On 13.09.23 14:02, Jaak Ristioja wrote:
> > >>
> > >> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> > >> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> > >> screen after boot until the display manager starts... if it does 
> > >> start
> > >> at all. Using the nomodeset kernel parameter seems to be a 
> > >> workaround.
> > >>
> > >> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> > >> ("drivers/firmware: Move sysfb_init() from device_initcall to
> > >> subsys_initcall_sync").
> > >
> > > Hmmm, no reaction since it was posted a while ago, unless I'm missing
> > > something.
> > >
> > > Huacai Chen, did you maybe miss this report? The problem is apparently
> > > caused by a commit of yours (that Javier applied), you hence should 
> > > look
> > > into this.
> >  I'm sorry but it looks very strange, could you please share your 
> >  config file?
> > >>> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
> > >>> again. So I guess the reason:
> > >>
> > >> Did Jaak reply privately? It should have been disclosed in public
> > >> ML here instead.
> > > Yes, he replied privately, and disabling DRM_SIMPLEDRM was suggested by 
> > > me.
> >
> > Well, this to me still looks a lot (please correct me if I'm wrong) like
> > regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
> > if I understood things correctly. Or is there a proper fix for this
> > already in the works and I just missed this? Or is there some good
> > reason why this won't/can't be fixed?
> DRM_SIMPLEDRM was enabled but it didn't work at all because there was
> no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
> blank screen. Of course it is valuable to investigate further about
> DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
> I don't have a same machine.
> 
> Huacai

I am having the same issue on a Lenovo Thinkpad P70 (Intel Corporation HD 
Graphics 530 (rev 06), Intel(R) Core(TM) i7-6700HQ).  Upgrading from Linux 
6.4.12 to 6.5 and later results in only a blank screen after boot and a rapidly 
flashing device-access-status indicator.

> >
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > --
> > Everything you wanna know about Linux kernel regression tracking:
> > https://linux-regtracking.leemhuis.info/about/#tldr
> > If I did something stupid, please tell me, as explained on that page.
> >
> > #regzbot poke
> >
> > >>> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
> > >>> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
> > >>> sysfb_init() from device_initcall to subsys_initcall_sync") there is
> > >>> no platform device created for SIMPLEDRM at early stage, so it seems
> > >>> also "no problem".
> > >>
> > >> I don't understand above. You mean that after that commit the platform
> > >> device is also none, right?
> > > No. The SIMPLEDRM driver needs a platform device to work, and that
> > > commit makes the platform device created earlier. So, before that
> > > commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
> > > commit, SIMPLEDRM works, but the screen is blank.
> > >
> > > Huacai
> > >>
> > >> Confused...
> > >>
> > >> --
> > >> An old man doll... just what I always wanted! - Clara
> > >
> > >


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-20 Thread Huacai Chen
On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:
>
> On 09.10.23 10:54, Huacai Chen wrote:
> > On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:
> >> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> >>> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  
> >>> wrote:
>  On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
>  Leemhuis)  wrote:
> > On 13.09.23 14:02, Jaak Ristioja wrote:
> >>
> >> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> >> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> >> screen after boot until the display manager starts... if it does start
> >> at all. Using the nomodeset kernel parameter seems to be a workaround.
> >>
> >> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> >> ("drivers/firmware: Move sysfb_init() from device_initcall to
> >> subsys_initcall_sync").
> >
> > Hmmm, no reaction since it was posted a while ago, unless I'm missing
> > something.
> >
> > Huacai Chen, did you maybe miss this report? The problem is apparently
> > caused by a commit of yours (that Javier applied), you hence should look
> > into this.
>  I'm sorry but it looks very strange, could you please share your config 
>  file?
> >>> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
> >>> again. So I guess the reason:
> >>
> >> Did Jaak reply privately? It should have been disclosed in public
> >> ML here instead.
> > Yes, he replied privately, and disabling DRM_SIMPLEDRM was suggested by me.
>
> Well, this to me still looks a lot (please correct me if I'm wrong) like
> regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
> if I understood things correctly. Or is there a proper fix for this
> already in the works and I just missed this? Or is there some good
> reason why this won't/can't be fixed?
DRM_SIMPLEDRM was enabled but it didn't work at all because there was
no corresponding platform device. Now DRM_SIMPLEDRM works but it has a
blank screen. Of course it is valuable to investigate further about
DRM_SIMPLEDRM on Jaak's machine, but that needs Jaak's effort because
I don't have a same machine.

Huacai
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
> >>> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
> >>> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
> >>> sysfb_init() from device_initcall to subsys_initcall_sync") there is
> >>> no platform device created for SIMPLEDRM at early stage, so it seems
> >>> also "no problem".
> >>
> >> I don't understand above. You mean that after that commit the platform
> >> device is also none, right?
> > No. The SIMPLEDRM driver needs a platform device to work, and that
> > commit makes the platform device created earlier. So, before that
> > commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
> > commit, SIMPLEDRM works, but the screen is blank.
> >
> > Huacai
> >>
> >> Confused...
> >>
> >> --
> >> An old man doll... just what I always wanted! - Clara
> >
> >


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-20 Thread Linux regression tracking (Thorsten Leemhuis)
On 09.10.23 10:54, Huacai Chen wrote:
> On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:
>> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
>>> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:
 On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
 Leemhuis)  wrote:
> On 13.09.23 14:02, Jaak Ristioja wrote:
>>
>> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
>> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
>> screen after boot until the display manager starts... if it does start
>> at all. Using the nomodeset kernel parameter seems to be a workaround.
>>
>> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
>> ("drivers/firmware: Move sysfb_init() from device_initcall to
>> subsys_initcall_sync").
>
> Hmmm, no reaction since it was posted a while ago, unless I'm missing
> something.
>
> Huacai Chen, did you maybe miss this report? The problem is apparently
> caused by a commit of yours (that Javier applied), you hence should look
> into this.
 I'm sorry but it looks very strange, could you please share your config 
 file?
>>> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
>>> again. So I guess the reason:
>>
>> Did Jaak reply privately? It should have been disclosed in public
>> ML here instead.
> Yes, he replied privately, and disabling DRM_SIMPLEDRM was suggested by me.

Well, this to me still looks a lot (please correct me if I'm wrong) like
regression that should be fixed, as DRM_SIMPLEDRM was enabled beforehand
if I understood things correctly. Or is there a proper fix for this
already in the works and I just missed this? Or is there some good
reason why this won't/can't be fixed?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

>>> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
>>> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
>>> sysfb_init() from device_initcall to subsys_initcall_sync") there is
>>> no platform device created for SIMPLEDRM at early stage, so it seems
>>> also "no problem".
>>
>> I don't understand above. You mean that after that commit the platform
>> device is also none, right?
> No. The SIMPLEDRM driver needs a platform device to work, and that
> commit makes the platform device created earlier. So, before that
> commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
> commit, SIMPLEDRM works, but the screen is blank.
> 
> Huacai
>>
>> Confused...
>>
>> --
>> An old man doll... just what I always wanted! - Clara
> 
> 


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-09 Thread Huacai Chen
On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya  wrote:
>
> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> > Hi, all,
> >
> > On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:
> > >
> > > Hi, all,
> > >
> > > On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> > > Leemhuis)  wrote:
> > > >
> > > > [CCing the regression list, as it should be in the loop for regressions:
> > > > https://docs.kernel.org/admin-guide/reporting-regressions.html]
> > > >
> > > > Hi, Thorsten here, the Linux kernel's regression tracker.
> > > >
> > > > On 13.09.23 14:02, Jaak Ristioja wrote:
> > > > >
> > > > > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> > > > > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> > > > > screen after boot until the display manager starts... if it does start
> > > > > at all. Using the nomodeset kernel parameter seems to be a workaround.
> > > > >
> > > > > I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> > > > > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > > > > subsys_initcall_sync").
> > > >
> > > > Hmmm, no reaction since it was posted a while ago, unless I'm missing
> > > > something.
> > > >
> > > > Huacai Chen, did you maybe miss this report? The problem is apparently
> > > > caused by a commit of yours (that Javier applied), you hence should look
> > > > into this.
> > > I'm sorry but it looks very strange, could you please share your config 
> > > file?
> > As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
> > again. So I guess the reason:
>
> Did Jaak reply privately? It should have been disclosed in public
> ML here instead.
Yes, he replied privately, and disabling DRM_SIMPLEDRM was suggested by me.

>
> >
> > When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
> > know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
> > sysfb_init() from device_initcall to subsys_initcall_sync") there is
> > no platform device created for SIMPLEDRM at early stage, so it seems
> > also "no problem".
>
> I don't understand above. You mean that after that commit the platform
> device is also none, right?
No. The SIMPLEDRM driver needs a platform device to work, and that
commit makes the platform device created earlier. So, before that
commit, SIMPLEDRM doesn't work, but the screen isn't blank; after that
commit, SIMPLEDRM works, but the screen is blank.

Huacai
>
> Confused...
>
> --
> An old man doll... just what I always wanted! - Clara


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-09 Thread Bagas Sanjaya
On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Chen wrote:
> Hi, all,
> 
> On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:
> >
> > Hi, all,
> >
> > On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> > Leemhuis)  wrote:
> > >
> > > [CCing the regression list, as it should be in the loop for regressions:
> > > https://docs.kernel.org/admin-guide/reporting-regressions.html]
> > >
> > > Hi, Thorsten here, the Linux kernel's regression tracker.
> > >
> > > On 13.09.23 14:02, Jaak Ristioja wrote:
> > > >
> > > > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> > > > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> > > > screen after boot until the display manager starts... if it does start
> > > > at all. Using the nomodeset kernel parameter seems to be a workaround.
> > > >
> > > > I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> > > > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > > > subsys_initcall_sync").
> > >
> > > Hmmm, no reaction since it was posted a while ago, unless I'm missing
> > > something.
> > >
> > > Huacai Chen, did you maybe miss this report? The problem is apparently
> > > caused by a commit of yours (that Javier applied), you hence should look
> > > into this.
> > I'm sorry but it looks very strange, could you please share your config 
> > file?
> As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
> again. So I guess the reason:

Did Jaak reply privately? It should have been disclosed in public
ML here instead.

> 
> When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
> know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
> sysfb_init() from device_initcall to subsys_initcall_sync") there is
> no platform device created for SIMPLEDRM at early stage, so it seems
> also "no problem".

I don't understand above. You mean that after that commit the platform
device is also none, right?

Confused...

-- 
An old man doll... just what I always wanted! - Clara


signature.asc
Description: PGP signature


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-08 Thread Huacai Chen
Hi, all,

On Tue, Sep 26, 2023 at 10:31 PM Huacai Chen  wrote:
>
> Hi, all,
>
> On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
> Leemhuis)  wrote:
> >
> > [CCing the regression list, as it should be in the loop for regressions:
> > https://docs.kernel.org/admin-guide/reporting-regressions.html]
> >
> > Hi, Thorsten here, the Linux kernel's regression tracker.
> >
> > On 13.09.23 14:02, Jaak Ristioja wrote:
> > >
> > > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> > > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> > > screen after boot until the display manager starts... if it does start
> > > at all. Using the nomodeset kernel parameter seems to be a workaround.
> > >
> > > I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> > > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > > subsys_initcall_sync").
> >
> > Hmmm, no reaction since it was posted a while ago, unless I'm missing
> > something.
> >
> > Huacai Chen, did you maybe miss this report? The problem is apparently
> > caused by a commit of yours (that Javier applied), you hence should look
> > into this.
> I'm sorry but it looks very strange, could you please share your config file?
As confirmed by Jaak, disabling DRM_SIMPLEDRM makes things work fine
again. So I guess the reason:

When SIMPLEDRM takes over the framebuffer, the screen is blank (don't
know why). And before 60aebc9559492cea6a9625f ("drivers/firmware: Move
sysfb_init() from device_initcall to subsys_initcall_sync") there is
no platform device created for SIMPLEDRM at early stage, so it seems
also "no problem".

Huacai


>
> Huacai
>
> >
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > --
> > Everything you wanna know about Linux kernel regression tracking:
> > https://linux-regtracking.leemhuis.info/about/#tldr
> > If I did something stupid, please tell me, as explained on that page.
> >
> > > git bisect start
> > > # status: waiting for both good and bad commits
> > > # good: [6995e2de6891c724bfeb2db33d7b87775f913ad1] Linux 6.4
> > > git bisect good 6995e2de6891c724bfeb2db33d7b87775f913ad1
> > > # status: waiting for bad commit, 1 good commit known
> > > # bad: [2dde18cd1d8fac735875f2e4987f11817cc0bc2c] Linux 6.5
> > > git bisect bad 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> > > # bad: [b775d6c5859affe00527cbe74263de05cfe6b9f9] Merge tag 'mips_6.5'
> > > of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
> > > git bisect bad b775d6c5859affe00527cbe74263de05cfe6b9f9
> > > # good: [3a8a670eeeaa40d87bd38a587438952741980c18] Merge tag
> > > 'net-next-6.5' of
> > > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
> > > git bisect good 3a8a670eeeaa40d87bd38a587438952741980c18
> > > # bad: [188d3f80fc6d8451ab5e570becd6a7b2d3033023] drm/amdgpu: vcn_4_0
> > > set instance 0 init sched score to 1
> > > git bisect bad 188d3f80fc6d8451ab5e570becd6a7b2d3033023
> > > # good: [12fb1ad70d65edc3405884792d044fa79df7244f] drm/amdkfd: update
> > > process interrupt handling for debug events
> > > git bisect good 12fb1ad70d65edc3405884792d044fa79df7244f
> > > # bad: [9cc31938d4586f72eb8e0235ad9d9eb22496fcee] i915/perf: Drop the
> > > aging_tail logic in perf OA
> > > git bisect bad 9cc31938d4586f72eb8e0235ad9d9eb22496fcee
> > > # bad: [51d86ee5e07ccef85af04ee9850b0baa107999b6] drm/msm: Switch to
> > > fdinfo helper
> > > git bisect bad 51d86ee5e07ccef85af04ee9850b0baa107999b6
> > > # good: [bfdede3a58ea970333d77a05144a7bcec13cf515] drm/rockchip: cdn-dp:
> > > call drm_connector_update_edid_property() unconditionally
> > > git bisect good bfdede3a58ea970333d77a05144a7bcec13cf515
> > > # good: [123ee07ba5b7123e0ce0e0f9d64938026c16a2ce] drm: sun4i_tcon: use
> > > devm_clk_get_enabled in `sun4i_tcon_init_clocks`
> > > git bisect good 123ee07ba5b7123e0ce0e0f9d64938026c16a2ce
> > > # bad: [20d54e48d9c705091a025afff5839da2ea606f6b] fbdev: Rename
> > > fb_mem*() helpers
> > > git bisect bad 20d54e48d9c705091a025afff5839da2ea606f6b
> > > # bad: [728cb3f061e2b3a002fd76d91c2449b1497b6640] gpu: drm: bridge: No
> > > need to set device_driver owner
> > > git bisect bad 728cb3f061e2b3a002fd76d91c2449b1497b6640
> > > # bad: [0f1cb4d777281ca3360dbc8959befc488e0c327e] drm/ssd130x: Fix
> > > include guard name
> > > git bisect bad 0f1cb4d777281ca3360dbc8959befc488e0c327e
> > > # good: [0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630] dt-bindings: display:
> > > simple: Add BOE EV121WXM-N10-1850 panel
> > > git bisect good 0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630
> > > # bad: [60aebc9559492cea6a9625f514a8041717e3a2e4] drivers/firmware: Move
> > > sysfb_init() from device_initcall to subsys_initcall_sync
> > > git bisect bad 60aebc9559492cea6a9625f514a8041717e3a2e4
> > > # good: [8bb7c7bca5b70f3cd22d95b4d36029295c4274f6] drm/panel:
> > > panel-simple: Add BOE EV121WXM-N10-1850 panel support
> > > git bisect good 8bb7c7bca5b70f3cd22d95b4d36029295c4274f6
> > > # first bad c

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-09-26 Thread Huacai Chen
Hi, all,

On Tue, Sep 26, 2023 at 7:15 PM Linux regression tracking (Thorsten
Leemhuis)  wrote:
>
> [CCing the regression list, as it should be in the loop for regressions:
> https://docs.kernel.org/admin-guide/reporting-regressions.html]
>
> Hi, Thorsten here, the Linux kernel's regression tracker.
>
> On 13.09.23 14:02, Jaak Ristioja wrote:
> >
> > Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> > Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> > screen after boot until the display manager starts... if it does start
> > at all. Using the nomodeset kernel parameter seems to be a workaround.
> >
> > I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> > ("drivers/firmware: Move sysfb_init() from device_initcall to
> > subsys_initcall_sync").
>
> Hmmm, no reaction since it was posted a while ago, unless I'm missing
> something.
>
> Huacai Chen, did you maybe miss this report? The problem is apparently
> caused by a commit of yours (that Javier applied), you hence should look
> into this.
I'm sorry but it looks very strange, could you please share your config file?

Huacai

>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> > git bisect start
> > # status: waiting for both good and bad commits
> > # good: [6995e2de6891c724bfeb2db33d7b87775f913ad1] Linux 6.4
> > git bisect good 6995e2de6891c724bfeb2db33d7b87775f913ad1
> > # status: waiting for bad commit, 1 good commit known
> > # bad: [2dde18cd1d8fac735875f2e4987f11817cc0bc2c] Linux 6.5
> > git bisect bad 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> > # bad: [b775d6c5859affe00527cbe74263de05cfe6b9f9] Merge tag 'mips_6.5'
> > of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
> > git bisect bad b775d6c5859affe00527cbe74263de05cfe6b9f9
> > # good: [3a8a670eeeaa40d87bd38a587438952741980c18] Merge tag
> > 'net-next-6.5' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
> > git bisect good 3a8a670eeeaa40d87bd38a587438952741980c18
> > # bad: [188d3f80fc6d8451ab5e570becd6a7b2d3033023] drm/amdgpu: vcn_4_0
> > set instance 0 init sched score to 1
> > git bisect bad 188d3f80fc6d8451ab5e570becd6a7b2d3033023
> > # good: [12fb1ad70d65edc3405884792d044fa79df7244f] drm/amdkfd: update
> > process interrupt handling for debug events
> > git bisect good 12fb1ad70d65edc3405884792d044fa79df7244f
> > # bad: [9cc31938d4586f72eb8e0235ad9d9eb22496fcee] i915/perf: Drop the
> > aging_tail logic in perf OA
> > git bisect bad 9cc31938d4586f72eb8e0235ad9d9eb22496fcee
> > # bad: [51d86ee5e07ccef85af04ee9850b0baa107999b6] drm/msm: Switch to
> > fdinfo helper
> > git bisect bad 51d86ee5e07ccef85af04ee9850b0baa107999b6
> > # good: [bfdede3a58ea970333d77a05144a7bcec13cf515] drm/rockchip: cdn-dp:
> > call drm_connector_update_edid_property() unconditionally
> > git bisect good bfdede3a58ea970333d77a05144a7bcec13cf515
> > # good: [123ee07ba5b7123e0ce0e0f9d64938026c16a2ce] drm: sun4i_tcon: use
> > devm_clk_get_enabled in `sun4i_tcon_init_clocks`
> > git bisect good 123ee07ba5b7123e0ce0e0f9d64938026c16a2ce
> > # bad: [20d54e48d9c705091a025afff5839da2ea606f6b] fbdev: Rename
> > fb_mem*() helpers
> > git bisect bad 20d54e48d9c705091a025afff5839da2ea606f6b
> > # bad: [728cb3f061e2b3a002fd76d91c2449b1497b6640] gpu: drm: bridge: No
> > need to set device_driver owner
> > git bisect bad 728cb3f061e2b3a002fd76d91c2449b1497b6640
> > # bad: [0f1cb4d777281ca3360dbc8959befc488e0c327e] drm/ssd130x: Fix
> > include guard name
> > git bisect bad 0f1cb4d777281ca3360dbc8959befc488e0c327e
> > # good: [0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630] dt-bindings: display:
> > simple: Add BOE EV121WXM-N10-1850 panel
> > git bisect good 0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630
> > # bad: [60aebc9559492cea6a9625f514a8041717e3a2e4] drivers/firmware: Move
> > sysfb_init() from device_initcall to subsys_initcall_sync
> > git bisect bad 60aebc9559492cea6a9625f514a8041717e3a2e4
> > # good: [8bb7c7bca5b70f3cd22d95b4d36029295c4274f6] drm/panel:
> > panel-simple: Add BOE EV121WXM-N10-1850 panel support
> > git bisect good 8bb7c7bca5b70f3cd22d95b4d36029295c4274f6
> > # first bad commit: [60aebc9559492cea6a9625f514a8041717e3a2e4]
> > drivers/firmware: Move sysfb_init() from device_initcall to
> > subsys_initcall_sync


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-09-26 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the regression list, as it should be in the loop for regressions:
https://docs.kernel.org/admin-guide/reporting-regressions.html]

Hi, Thorsten here, the Linux kernel's regression tracker.

On 13.09.23 14:02, Jaak Ristioja wrote:
> 
> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank
> screen after boot until the display manager starts... if it does start
> at all. Using the nomodeset kernel parameter seems to be a workaround.
> 
> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> ("drivers/firmware: Move sysfb_init() from device_initcall to
> subsys_initcall_sync").

Hmmm, no reaction since it was posted a while ago, unless I'm missing
something.

Huacai Chen, did you maybe miss this report? The problem is apparently
caused by a commit of yours (that Javier applied), you hence should look
into this.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

> git bisect start
> # status: waiting for both good and bad commits
> # good: [6995e2de6891c724bfeb2db33d7b87775f913ad1] Linux 6.4
> git bisect good 6995e2de6891c724bfeb2db33d7b87775f913ad1
> # status: waiting for bad commit, 1 good commit known
> # bad: [2dde18cd1d8fac735875f2e4987f11817cc0bc2c] Linux 6.5
> git bisect bad 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> # bad: [b775d6c5859affe00527cbe74263de05cfe6b9f9] Merge tag 'mips_6.5'
> of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
> git bisect bad b775d6c5859affe00527cbe74263de05cfe6b9f9
> # good: [3a8a670eeeaa40d87bd38a587438952741980c18] Merge tag
> 'net-next-6.5' of
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
> git bisect good 3a8a670eeeaa40d87bd38a587438952741980c18
> # bad: [188d3f80fc6d8451ab5e570becd6a7b2d3033023] drm/amdgpu: vcn_4_0
> set instance 0 init sched score to 1
> git bisect bad 188d3f80fc6d8451ab5e570becd6a7b2d3033023
> # good: [12fb1ad70d65edc3405884792d044fa79df7244f] drm/amdkfd: update
> process interrupt handling for debug events
> git bisect good 12fb1ad70d65edc3405884792d044fa79df7244f
> # bad: [9cc31938d4586f72eb8e0235ad9d9eb22496fcee] i915/perf: Drop the
> aging_tail logic in perf OA
> git bisect bad 9cc31938d4586f72eb8e0235ad9d9eb22496fcee
> # bad: [51d86ee5e07ccef85af04ee9850b0baa107999b6] drm/msm: Switch to
> fdinfo helper
> git bisect bad 51d86ee5e07ccef85af04ee9850b0baa107999b6
> # good: [bfdede3a58ea970333d77a05144a7bcec13cf515] drm/rockchip: cdn-dp:
> call drm_connector_update_edid_property() unconditionally
> git bisect good bfdede3a58ea970333d77a05144a7bcec13cf515
> # good: [123ee07ba5b7123e0ce0e0f9d64938026c16a2ce] drm: sun4i_tcon: use
> devm_clk_get_enabled in `sun4i_tcon_init_clocks`
> git bisect good 123ee07ba5b7123e0ce0e0f9d64938026c16a2ce
> # bad: [20d54e48d9c705091a025afff5839da2ea606f6b] fbdev: Rename
> fb_mem*() helpers
> git bisect bad 20d54e48d9c705091a025afff5839da2ea606f6b
> # bad: [728cb3f061e2b3a002fd76d91c2449b1497b6640] gpu: drm: bridge: No
> need to set device_driver owner
> git bisect bad 728cb3f061e2b3a002fd76d91c2449b1497b6640
> # bad: [0f1cb4d777281ca3360dbc8959befc488e0c327e] drm/ssd130x: Fix
> include guard name
> git bisect bad 0f1cb4d777281ca3360dbc8959befc488e0c327e
> # good: [0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630] dt-bindings: display:
> simple: Add BOE EV121WXM-N10-1850 panel
> git bisect good 0bd5bd65cd2e4d1335ea6c17cd2c8664decbc630
> # bad: [60aebc9559492cea6a9625f514a8041717e3a2e4] drivers/firmware: Move
> sysfb_init() from device_initcall to subsys_initcall_sync
> git bisect bad 60aebc9559492cea6a9625f514a8041717e3a2e4
> # good: [8bb7c7bca5b70f3cd22d95b4d36029295c4274f6] drm/panel:
> panel-simple: Add BOE EV121WXM-N10-1850 panel support
> git bisect good 8bb7c7bca5b70f3cd22d95b4d36029295c4274f6
> # first bad commit: [60aebc9559492cea6a9625f514a8041717e3a2e4]
> drivers/firmware: Move sysfb_init() from device_initcall to
> subsys_initcall_sync


Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-09-18 Thread Bagas Sanjaya
On Wed, Sep 13, 2023 at 03:02:26PM +0300, Jaak Ristioja wrote:
> Hello,
> 
> Upgrading to Linux 6.5 on a Lenovo ThinkPad L570 (Integrated Intel HD
> Graphics 620 (rev 02), Intel(R) Core(TM) i7-7500U) results in a blank screen
> after boot until the display manager starts... if it does start at all.
> Using the nomodeset kernel parameter seems to be a workaround.
> 
> I've bisected this to commit 60aebc9559492cea6a9625f514a8041717e3a2e4
> ("drivers/firmware: Move sysfb_init() from device_initcall to
> subsys_initcall_sync").
> 

Thanks for the regression report. I'm adding it to regzbot:

#regzbot ^introduced: 60aebc9559492c

-- 
An old man doll... just what I always wanted! - Clara


signature.asc
Description: PGP signature