i915: pipe state still does not match

2013-11-30 Thread Chris Wilson
On Sat, Nov 30, 2013 at 05:31:34PM +0100, Jan Engelhardt wrote:
> 
> On Friday 2013-11-29 11:48, Chris Wilson wrote:
> >> What I could collect so far:
> >
> >Thanks, I broke the handling of cropped XvImages along the fast paths.
> >It should be fixed by:
> >
> >commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8
> >Author: Chris Wilson 
> >Date:   Thu Nov 28 21:13:33 2013 +
> >
> >sna/video: Correct handling of cropped images along packed fast path
> 
> I didn't manage to crash X within an hour, so that's commit is looking 
> good.
> 
> The kernel error message for i915 pipe state however still appears -
> namely, whenever the X server is terminating, including "reasonably
> proper" terminations induced with sending SIGTERM to the X process.
> Could it be that the i915 module does not handle sudden shutdowns
> (which however can occur at any time) of the /dev/dri/cardN file
> descriptor well enough?

I'd say it was just the KMS transition from the X mode to the fbcon mode
that triggers the inconsistent state warning. The warning is just that
the hardware state after the mode change does not match our expectations
- often this is a result of a buggy state readback, but sometimes it
does indicate a more severe bug in our mode programming.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


i915: pipe state still does not match

2013-11-30 Thread Jan Engelhardt

On Friday 2013-11-29 11:48, Chris Wilson wrote:
>> What I could collect so far:
>
>Thanks, I broke the handling of cropped XvImages along the fast paths.
>It should be fixed by:
>
>commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8
>Author: Chris Wilson 
>Date:   Thu Nov 28 21:13:33 2013 +
>
>sna/video: Correct handling of cropped images along packed fast path

I didn't manage to crash X within an hour, so that's commit is looking 
good.

The kernel error message for i915 pipe state however still appears -
namely, whenever the X server is terminating, including "reasonably
proper" terminations induced with sending SIGTERM to the X process.
Could it be that the i915 module does not handle sudden shutdowns
(which however can occur at any time) of the /dev/dri/cardN file
descriptor well enough?


i915: pipe state still does not match

2013-11-29 Thread Chris Wilson
On Thu, Nov 28, 2013 at 09:08:45PM +0100, Jan Engelhardt wrote:
> On Wednesday 2013-11-27 12:08, Chris Wilson wrote:
> >On Wed, Nov 27, 2013 at 11:59:56AM +0100, Jan Engelhardt wrote:
> >> 
> >> Despite the i915/drm fixes added in v3.11.8, the X server still 
> >> terminates due to some pipe state bug in 3.11.9.
> >
> >X terminating is entirely unconnected with that *ERROR*.
> 
> Are you sure? Whenever X crashed, that inteldrv kernel message
> was showing up in dmesg.
> Affected versions:
>   xorg-x11-server-1.14.3.901
>   xf86-video-intel-2.99.906-4.1.x86_64
> Working versions:
>   xorg-x11-server-1.13.2
>   xf86-video-intel-2.20.19
> 
> >Can you please attach your Xorg.0.log with the crash information?
> 
> What I could collect so far:

Thanks, I broke the handling of cropped XvImages along the fast paths.
It should be fixed by:

commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8
Author: Chris Wilson 
Date:   Thu Nov 28 21:13:33 2013 +

sna/video: Correct handling of cropped images along packed fast path

In particular, it was offseting the read from the source image, but not
correcting the length to read - causing a read from beyond the end of
the source and a segfault.

Reported-by: Jan Engelhardt 
Signed-off-by: Chris Wilson 
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


i915: pipe state still does not match

2013-11-29 Thread Daniel Vetter
On Thu, Nov 28, 2013 at 09:08:45PM +0100, Jan Engelhardt wrote:
> On Wednesday 2013-11-27 12:08, Chris Wilson wrote:
> >On Wed, Nov 27, 2013 at 11:59:56AM +0100, Jan Engelhardt wrote:
> >> 
> >> Despite the i915/drm fixes added in v3.11.8, the X server still 
> >> terminates due to some pipe state bug in 3.11.9.
> >
> >X terminating is entirely unconnected with that *ERROR*.
> 
> Are you sure? Whenever X crashed, that inteldrv kernel message
> was showing up in dmesg.
> Affected versions:
>   xorg-x11-server-1.14.3.901
>   xf86-video-intel-2.99.906-4.1.x86_64
> Working versions:
>   xorg-x11-server-1.13.2
>   xf86-video-intel-2.20.19

For the ERROR the kernel is the important part. I can be that it's
triggered by userspace doing something funny (and likely, sinc there's a
good chance you're hitting a less well tested path when crashing). But
it's a kernel issue.

To track the kernel issue down can you please boot with drm.debug=0xe
added to your bootline, reproduce the issue and then attach the complete
dmesg?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


i915: pipe state still does not match

2013-11-28 Thread Jan Engelhardt
On Wednesday 2013-11-27 12:08, Chris Wilson wrote:
>On Wed, Nov 27, 2013 at 11:59:56AM +0100, Jan Engelhardt wrote:
>> 
>> Despite the i915/drm fixes added in v3.11.8, the X server still 
>> terminates due to some pipe state bug in 3.11.9.
>
>X terminating is entirely unconnected with that *ERROR*.

Are you sure? Whenever X crashed, that inteldrv kernel message
was showing up in dmesg.
Affected versions:
xorg-x11-server-1.14.3.901
xf86-video-intel-2.99.906-4.1.x86_64
Working versions:
xorg-x11-server-1.13.2
xf86-video-intel-2.20.19

>Can you please attach your Xorg.0.log with the crash information?

What I could collect so far:


[47.331] 
This is a pre-release version of the X server from The X.Org Foundation.
It is not supported in any way.
Bugs may be filed in the bugzilla at http://bugs.freedesktop.org/.
Select the "xorg" product for bugs you find in this release.
Before reporting bugs in pre-release versions please check the
latest version in the X.Org Foundation git repository.
See http://wiki.x.org/wiki/GitPage for git access instructions.
[47.331] 
X.Org X Server 1.14.3.901 (1.14.4 RC 1)
Release Date: 2013-10-26
[47.331] X Protocol Version 11, Revision 0
[47.331] Build Operating System: openSUSE SUSE LINUX
[47.331] Current Operating System: Linux nakamura.inai.de 
3.11.9-jng20-desktop #1 SMP PREEMPT Wed Nov 27 09:56:23 UTC 2013 (a089a7e) 
x86_64
[47.331] Kernel command line: root=/dev/disk/by-label/nakamura-root 
splash=silent showopts video=640x480
[47.332] Build Date: 06 November 2013  10:07:38AM
[47.332]  
[47.332] Current version of pixman: 0.30.2
[47.332]Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
[47.332] Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
[47.333] (==) Log file: "/var/log/Xorg.0.log", Time: Thu Nov 28 20:15:00 
2013
[47.335] (==) Using config directory: "/etc/X11/xorg.conf.d"
[47.335] (==) Using system config directory "/usr/share/X11/xorg.conf.d"
[47.378] (==) No Layout section.  Using the first Screen section.
[47.379] (==) No screen section available. Using defaults.
[47.379] (**) |-->Screen "Default Screen Section" (0)
[47.379] (**) |   |-->Monitor ""
[47.395] (==) No monitor specified for screen "Default Screen Section".
Using a default monitor configuration.
[47.395] (==) Automatically adding devices
[47.395] (==) Automatically enabling devices
[47.395] (==) Automatically adding GPU devices
[47.396] (WW) The directory "/usr/share/fonts/misc/sgi" does not exist.
[47.396]Entry deleted from font path.
[47.396] (==) FontPath set to:
/usr/share/fonts/misc:unscaled,
/usr/share/fonts/Type1/,
/usr/share/fonts/100dpi:unscaled,
/usr/share/fonts/75dpi:unscaled,
/usr/share/fonts/ghostscript/,
/usr/share/fonts/cyrillic:unscaled,
/usr/share/fonts/truetype/,
built-ins
[47.396] (==) ModulePath set to 
"/usr/lib64/xorg/modules/updates,/usr/lib64/xorg/modules"
[47.396] (II) The server relies on udev to provide the list of input 
devices.
If no devices become available, reconfigure udev or disable 
AutoAddDevices.
[47.411] (II) Loader magic: 0x803c20
[47.411] (II) Module ABI versions:
[47.411]X.Org ANSI C Emulation: 0.4
[47.411]X.Org Video Driver: 14.1
[47.411]X.Org XInput driver : 19.1
[47.411]X.Org Server Extension : 7.0
[47.412] (II) xfree86: Adding drm device (/dev/dri/card0)
[47.416] (--) PCI:*(0:0:2:0) 8086:a011:104d:9075 rev 0, Mem @ 
0xfea8/524288, 0xe000/268435456, 0xfe80/1048576, I/O @ 0xf0f0/8
[47.417] (--) PCI: (0:0:2:1) 8086:a012:104d:9075 rev 0, Mem @ 
0xfea0/524288
[47.418] Initializing built-in extension Generic Event Extension
[47.419] Initializing built-in extension SHAPE
[47.419] Initializing built-in extension MIT-SHM
[47.419] Initializing built-in extension XInputExtension
[47.419] Initializing built-in extension XTEST
[47.419] Initializing built-in extension BIG-REQUESTS
[47.419] Initializing built-in extension SYNC
[47.419] Initializing built-in extension XKEYBOARD
[47.419] Initializing built-in extension XC-MISC
[47.419] Initializing built-in extension SECURITY
[47.419] Initializing built-in extension XINERAMA
[47.419] Initializing built-in extension XFIXES
[47.420] Initializing built-in extension RENDER
[47.420] Initializing built-in extension RANDR
[47.420] Initializing built-in extension COMPOSITE
[47.420] Initializing built-in extension DAMAGE
[47.420] Initializing built-in extension MIT-SCREEN-SAVER
[47.420] Initializing built-in extension DOUBLE-BUFFER
[47.420] Initializing built-i

i915: pipe state still does not match

2013-11-27 Thread Jan Engelhardt
Greetings.


Despite the i915/drm fixes added in v3.11.8, the X server still 
terminates due to some pipe state bug in 3.11.9.

I have a fb setup to span two crtcs in below's configuration,
and the kernel problem is easily triggerable for me by moving
an Xv window (such as by using mplayer) forth and back
between the two crtc.
The problem did not exist in 3.9.9.

> xrandr
Screen 0: minimum 320 x 200, current 1280 x 1624, maximum 32767 x 32767
LVDS1 connected primary 1024x600+0+1024 (normal left inverted right x axis y 
axis) 220mm x 129mm
   1024x600   60.0*+
   800x60060.3 56.2  
   640x48059.9  
VGA1 connected 1280x1024+0+0 (normal left inverted right x axis y axis) 376mm x 
301mm
   1280x1024  60.0*+   75.0 72.0  
   1152x864   75.0  
   1024x768   75.1 70.1 60.0  
   832x62474.6  
   800x60072.2 75.0 60.3  
   640x48075.0 72.8 66.7 60.0  
   720x40070.1  
   640x35070.1  
VIRTUAL1 disconnected (normal left inverted right x axis y axis)



[drm:intel_pipe_config_compare] *ERROR* mismatch in adjusted_mode.flags 
(expected 4, found 0)
[ cut here ]
WARNING: CPU: 1 PID: 714 at 
/home/abuild/rpmbuild/BUILD/kernel-desktop-3.11.9~jng20/linux-3.11/drivers/gpu/drm/i915/intel_display.c:8329
 check_crtc_state+0x637/0x6a5 [i915]()
pipe state doesn't match!
Modules linked in: ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_filter 
ip6_tables ipt_REJECT xt_tcpudp xt_owner xt_multiport xt_conntrack 
iptable_filter af_packet ipt_MASQUERADE iptable_nat nf_conntrack_ipv4 
cpufreq_conservative nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack xt_mark 
iptable_mangle ip_tables x_tables snd_hda_codec_realtek uvcvideo videobuf2_core 
snd_hda_intel snd_hda_codec snd_hwdep videodev snd_pcm_oss snd_pcm 
videobuf2_vmalloc iTCO_wdt jme gpio_ich coretemp snd_seq snd_timer pcspkr 
jmb38x_ms videobuf2_memops iTCO_vendor_support sdhci_pci lpc_ich memstick 
i2c_i801 snd_seq_device mii sdhci joydev mfd_core snd_mixer_oss led_class 
mmc_core serio_raw ata_generic acpi_cpufreq battery snd mperf ac shpchp 
soundcore snd_page_alloc sg tcp_veno sony_laptop rfkill autofs4
 btrfs raid6_pq zlib_deflate xor libcrc32c sha256_generic cbc hid_generic 
usbhid hid uhci_hcd ata_piix i915 drm_kms_helper ehci_pci ehci_hcd drm usbcore 
usb_common i2c_algo_bit i2c_core video intel_agp intel_gtt agpgart button 
processor thermal_sys hwmon scsi_dh_emc scsi_dh_alua scsi_dh_rdac scsi_dh_hp_sw 
scsi_dh dm_snapshot dm_mirror dm_region_hash dm_log dm_crypt dm_mod xts 
gf128mul aes_x86_64
CPU: 1 PID: 714 Comm: X Tainted: GW3.11.9-jng20-desktop #1
Hardware name: Sony Corporation VPCM11M1E/VAIO, BIOS R0090Z4 01/23/2010
  8141925d 88003b5d1788 8103ba85
 a01a689b 880037462000 88003b5d17d8 88003b5d1800
 8800374626d0 8103bae1 a01e97bb 0018
Call Trace:
 [] dump_trace+0x8c/0x296
 [] show_stack_log_lvl+0x13e/0x14d
 [] show_stack+0x2f/0x31
 [] dump_stack+0x50/0x89
 [] warn_slowpath_common+0x74/0x89
 [] warn_slowpath_fmt+0x47/0x49
 [] check_crtc_state+0x637/0x6a5 [i915]
 [] intel_modeset_check_state+0x37e/0x604 [i915]
 [] intel_set_mode+0x1b/0x22 [i915]
 [] intel_crtc_set_config+0x612/0x789 [i915]
 [] drm_mode_set_config_internal+0x44/0xac [drm]
 [] drm_fb_helper_set_par+0x55/0x98 [drm_kms_helper]
 [] fb_set_var+0x250/0x33b
 [] fbcon_blank+0x75/0x1c0
 [] do_unblank_screen+0xca/0x136
 [] vt_ioctl+0x4d5/0xf28
 [] tty_ioctl+0x910/0x976
 [] vfs_ioctl+0x1b/0x28
 [] do_vfs_ioctl+0x32d/0x3e8
 [] SyS_ioctl+0x4e/0x7e
 [] system_call_fastpath+0x1a/0x1f
 [<7fe31322a1e7>] 0x7fe31322a1e6
---[ end trace 36d598c7e5fa5f63 ]---


i915: pipe state still does not match

2013-11-27 Thread Chris Wilson
On Wed, Nov 27, 2013 at 11:59:56AM +0100, Jan Engelhardt wrote:
> Greetings.
> 
> 
> Despite the i915/drm fixes added in v3.11.8, the X server still 
> terminates due to some pipe state bug in 3.11.9.
> 
> I have a fb setup to span two crtcs in below's configuration,
> and the kernel problem is easily triggerable for me by moving
> an Xv window (such as by using mplayer) forth and back
> between the two crtc.
> The problem did not exist in 3.9.9.
> 
> > xrandr
> Screen 0: minimum 320 x 200, current 1280 x 1624, maximum 32767 x 32767
> LVDS1 connected primary 1024x600+0+1024 (normal left inverted right x axis y 
> axis) 220mm x 129mm
>1024x600   60.0*+
>800x60060.3 56.2  
>640x48059.9  
> VGA1 connected 1280x1024+0+0 (normal left inverted right x axis y axis) 376mm 
> x 301mm
>1280x1024  60.0*+   75.0 72.0  
>1152x864   75.0  
>1024x768   75.1 70.1 60.0  
>832x62474.6  
>800x60072.2 75.0 60.3  
>640x48075.0 72.8 66.7 60.0  
>720x40070.1  
>640x35070.1  
> VIRTUAL1 disconnected (normal left inverted right x axis y axis)

X terminating is entirely unconnected with that *ERROR*. Can you please
attach your Xorg.0.log with the crash information?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre