linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
89b03aeaef16 ("drm/vkms: fix 32bit compilation error by replacing macros")
Fixes tag
Fixes: a19c2ac9858 ("drm: vkms: Add support to the RGB565 format")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 396369d67549 ("drm: vkms: Add support to the RGB565 format")
--
Cheers,
Stephen Rothwell
pgpwfyAVi2oDt.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
d8e4fb9112e8 ("drm/amdgpu/display: Protect some functions with
CONFIG_DRM_AMD_DC_DCN")
Fixes tag
Fixes: 9b0e0d433f74 ("drm/amd/display: Add dependant changes for DCN32/321")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant:
Fixes: d3dfceb58de5 ("drm/amd/display: Add dependant changes for DCN32/321")
--
Cheers,
Stephen Rothwell
pgpOCe6XKiPeY.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the drm tree
On Fri, Jun 3, 2022 at 5:38 PM Stephen Rothwell wrote: > > Hi Rob, > > On Fri, 3 Jun 2022 07:58:14 -0700 Rob Clark wrote: > > > > will the truncated subject confuse the scripts that look for patches > > to backport to stable, ie. do we *really* have to rewrite history to > > fix this? > > I don't know what scripts are being used and what they expect, but our > documentation says (Documentation/process/submitting-patches.rst): > > If your patch fixes a bug in a specific commit, e.g. you found an issue > using > ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of > the SHA-1 ID, and the one line summary. Do not split the tag across > multiple > lines, tags are exempt from the "wrap at 75 columns" rule in order to > simplify > parsing scripts. > > But, that being said, doing the rewrite is up to the maintainer. You > could just look at this as a learning experience and do better in the > future. Ok, I'll leave it up to airlied If you don't mind sharing, what is the script you use? We could perhaps add it to our WIP CI.. a script is much less likely to miss a check than a human, so I'm a fan of automating these sorts of checks whenever possible ;-) BR, -R > BTW, my script reacted to the missing closing quotes and parentheses, > which is more like to confuse any scripts that the actual truncation. > -- > Cheers, > Stephen Rothwell
Re: linux-next: Fixes tag needs some work in the drm tree
Hi Rob, On Fri, 3 Jun 2022 07:58:14 -0700 Rob Clark wrote: > > will the truncated subject confuse the scripts that look for patches > to backport to stable, ie. do we *really* have to rewrite history to > fix this? I don't know what scripts are being used and what they expect, but our documentation says (Documentation/process/submitting-patches.rst): If your patch fixes a bug in a specific commit, e.g. you found an issue using ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of the SHA-1 ID, and the one line summary. Do not split the tag across multiple lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify parsing scripts. But, that being said, doing the rewrite is up to the maintainer. You could just look at this as a learning experience and do better in the future. BTW, my script reacted to the missing closing quotes and parentheses, which is more like to confuse any scripts that the actual truncation. -- Cheers, Stephen Rothwell pgpX48RmMq16y.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the drm tree
On Thu, Jun 2, 2022 at 10:16 PM Stephen Rothwell wrote:
>
> Hi all,
>
> In commit
>
> 8caad14e7224 ("drm/msm/dpu: Fix pointer dereferenced before checking")
>
> Fixes tag
>
> Fixes: d7d0e73f7de33 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Fixes tags should not be truncated or split across more than 1 line. So:
>
> Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
> writeback")
Hmm, checkpatch seems to not catch this (unless it was a recent
addition that landed after what msm-fixes is based on.
will the truncated subject confuse the scripts that look for patches
to backport to stable, ie. do we *really* have to rewrite history to
fix this?
BR,
-R
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
8caad14e7224 ("drm/msm/dpu: Fix pointer dereferenced before checking")
Fixes tag
Fixes: d7d0e73f7de33 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Fixes tags should not be truncated or split across more than 1 line. So:
Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
writeback")
--
Cheers,
Stephen Rothwell
pgpkY8ZfxxDX3.pgp
Description: OpenPGP digital signature
RE: linux-next: Fixes tag needs some work in the drm tree
Yes, that's what it meant.
Regards,
Shirish S
-Original Message-
From: Stephen Rothwell
Sent: Monday, October 28, 2019 1:53 AM
To: Dave Airlie ; DRI
Cc: Linux Next Mailing List ; Linux Kernel Mailing
List ; S, Shirish ; Deucher,
Alexander
Subject: linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")
Fixes tag
Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling
policy")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling
policy")
--
Cheers,
Stephen Rothwell
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
8c9f69bc5cc4 ("drm/amdgpu: fix build error without CONFIG_HSA_AMD")
Fixes tag
Fixes: 1abb680ad371 ("drm/amdgpu: disable gfxoff while use no H/W scheduling
policy")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
Fixes: aa978594cf7f ("drm/amdgpu: disable gfxoff while use no H/W scheduling
policy")
--
Cheers,
Stephen Rothwell
pgpP6mp4fRCM1.pgp
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
b7019ac550eb ("drm/nouveau: fix bogus GPL-2 license header")
Fixes tag
Fixes: b24413180f5 (License cleanup: add SPDX GPL-2.0 license identifier to
files with no license)
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpd0o_5UF6B3.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
289aabbf7bc8 ("drm/amd/display: Use vrr friendly pageflip throttling in DC.")
Fixes tag
Fixes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR
has these problem(s):
- Please don't split Fixes tags over more than one line
--
Cheers,
Stephen Rothwell
pgpdDElguoALU.pgp
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
linux-next: Fixes tag needs some work in the drm tree
Hi all,
In commit
4b5105036afb ("drm/amd/display: Don't leak memory when updating streams")
Fixes tags
Fixes: c00e0cc0fdc0 ("drm/amd/display: Call into DC once per multiplane flip")
Fixes: ea39594e0855 ("drm/amd/display: Perform plane updates only when
needed")
have this problem:
- Target SHA1s do not exist
--
Cheers,
Stephen Rothwell
pgpR5vf0aiaLI.pgp
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
