[PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Helge Bahmann
Fix deadlock in drm_setmaster_ioctl

diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index 096e2a3..7c8b15b 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -168,7 +168,7 @@ int drm_setmaster_ioctl(struct drm_device *dev, void *data,
file_priv-minor-master != file_priv-master) {
mutex_lock(dev-struct_mutex);
file_priv-minor-master = drm_master_get(file_priv-master);
-   mutex_lock(dev-struct_mutex);
+   mutex_unlock(dev-struct_mutex);
}
 
return 0;

-- 
Dipl. Math.
Helge Bahmann
Berater
Geschäftsbereich Hochsicherheit
secunet Security Networks AG
Ammonstraße 74
01067 Dresden, Germany
Fon: +49 201 54 54-3586
Fax: +49 201 54 54-1323
Email: helge.bahm...@secunet.com

Sitz: Kronprinzenstraße 30, 45128 Essen
Amtsgericht Essen HRB 13615
Vorstand: Dr. Rainer Baumgart, Thomas Koelzer, Thomas Pleines
Aufsichtsratsvorsitzender: Dr. Karsten Ottenberg

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Jiri Kosina
On Wed, 4 Mar 2009, Helge Bahmann wrote:

 Fix deadlock in drm_setmaster_ioctl
 
 diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
 index 096e2a3..7c8b15b 100644
 --- a/drivers/gpu/drm/drm_stub.c
 +++ b/drivers/gpu/drm/drm_stub.c
 @@ -168,7 +168,7 @@ int drm_setmaster_ioctl(struct drm_device *dev, void 
 *data,
   file_priv-minor-master != file_priv-master) {
   mutex_lock(dev-struct_mutex);
   file_priv-minor-master = drm_master_get(file_priv-master);
 - mutex_lock(dev-struct_mutex);
 + mutex_unlock(dev-struct_mutex);
   }
  
   return 0;
 

This is not a kind of patch that should be taken through trivial tree. 
CCing David.

-- 
Jiri Kosina
SUSE Labs

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [Intel-gfx] [PATCH] drm/i915: TV mode_set sync up with 2D driver

2009-03-04 Thread Robert Lowery
 Fix TV control save register for untouched bits, and color
 knobs different definition for 945 and 965 chips.

 Signed-off-by: Zhenyu Wang zhenyu.z.w...@intel.com
 ---
  drivers/gpu/drm/i915/i915_reg.h |2 +-
  drivers/gpu/drm/i915/intel_tv.c |   11 ---
  2 files changed, 9 insertions(+), 4 deletions(-)

 diff --git a/drivers/gpu/drm/i915/i915_reg.h
 b/drivers/gpu/drm/i915/i915_reg.h
 index 9d6539a..0ae0274 100644
 --- a/drivers/gpu/drm/i915/i915_reg.h
 +++ b/drivers/gpu/drm/i915/i915_reg.h
 @@ -855,7 +855,7 @@
   */
  # define TV_ENC_C0_FIX   (1  10)
  /** Bits that must be preserved by software */
 -# define TV_CTL_SAVE ((3  8) | (3  6))
 +# define TV_CTL_SAVE ((1  11) | (3  9) | (7  6) | 0xf)
  # define TV_FUSE_STATE_MASK  (3  4)
  /** Read-only state that reports all features enabled */
  # define TV_FUSE_STATE_ENABLED   (0  4)
 diff --git a/drivers/gpu/drm/i915/intel_tv.c
 b/drivers/gpu/drm/i915/intel_tv.c
 index 21cddea..5c406a1 100644
 --- a/drivers/gpu/drm/i915/intel_tv.c
 +++ b/drivers/gpu/drm/i915/intel_tv.c
 @@ -1135,7 +1135,8 @@ intel_tv_mode_set(struct drm_encoder *encoder,
 struct drm_display_mode *mode,
   if (!tv_mode)
   return; /* can't happen (mode_prepare prevents this) */

 - tv_ctl = 0;
 + tv_ctl = I915_READ(TV_CTL);
 + tv_ctl = TV_CTL_SAVE;

   switch (tv_priv-type) {
   default:
 @@ -1215,7 +1216,6 @@ intel_tv_mode_set(struct drm_encoder *encoder,
 struct drm_display_mode *mode,
   /* dda1 implies valid video levels */
   if (tv_mode-dda1_inc) {
   scctl1 |= TV_SC_DDA1_EN;
 - scctl1 |= video_levels-burst  TV_BURST_LEVEL_SHIFT;
   }

   if (tv_mode-dda2_inc)
 @@ -1225,6 +1225,7 @@ intel_tv_mode_set(struct drm_encoder *encoder,
 struct drm_display_mode *mode,
   scctl1 |= TV_SC_DDA3_EN;

   scctl1 |= tv_mode-sc_reset;
 + scctl1 |= video_levels-burst  TV_BURST_LEVEL_SHIFT;
   scctl1 |= tv_mode-dda1_inc  TV_SCDDA1_INC_SHIFT;

   scctl2 = tv_mode-dda2_size  TV_SCDDA2_SIZE_SHIFT |
 @@ -1266,7 +1267,11 @@ intel_tv_mode_set(struct drm_encoder *encoder,
 struct drm_display_mode *mode,
  color_conversion-av);
   }

 - I915_WRITE(TV_CLR_KNOBS, 0x00606000);
 + if (IS_I965G(dev))
 + I915_WRITE(TV_CLR_KNOBS, 0x00404000);
 + else
 + I915_WRITE(TV_CLR_KNOBS, 0x00606000);
 +
   if (video_levels)
   I915_WRITE(TV_CLR_LEVEL,
  ((video_levels-black  TV_BLACK_LEVEL_SHIFT) |

This is out of sync now that the following is committed
http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=42e34e90e2e4048b38481cab61cef46f932eada7


 --
 1.5.6.5

 ___
 Intel-gfx mailing list
 intel-...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx




--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Zoltan Boszormenyi
Jiri Kosina írta:
 On Wed, 4 Mar 2009, Helge Bahmann wrote:

   
 Fix deadlock in drm_setmaster_ioctl

 diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
 index 096e2a3..7c8b15b 100644
 --- a/drivers/gpu/drm/drm_stub.c
 +++ b/drivers/gpu/drm/drm_stub.c
 @@ -168,7 +168,7 @@ int drm_setmaster_ioctl(struct drm_device *dev, void 
 *data,
  file_priv-minor-master != file_priv-master) {
  mutex_lock(dev-struct_mutex);
  file_priv-minor-master = drm_master_get(file_priv-master);
 -mutex_lock(dev-struct_mutex);
 +mutex_unlock(dev-struct_mutex);
  }
  
  return 0;

 

 This is not a kind of patch that should be taken through trivial tree. 
   

You must mean this is exactly that kind of a patch...
Notice the double mutex_lock() on the same mutex in the same scope.

 CCing David.

   


--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Helge Bahmann
Am Wednesday 04 March 2009 11:00:00 schrieb Jiri Kosina:
 On Wed, 4 Mar 2009, Zoltan Boszormenyi wrote:
   diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
   index 096e2a3..7c8b15b 100644
   --- a/drivers/gpu/drm/drm_stub.c
   +++ b/drivers/gpu/drm/drm_stub.c
   @@ -168,7 +168,7 @@ int drm_setmaster_ioctl(struct drm_device *dev,
   void *data, file_priv-minor-master != file_priv-master) {
mutex_lock(dev-struct_mutex);
file_priv-minor-master = 
   drm_master_get(file_priv-master);
   -mutex_lock(dev-struct_mutex);
   +mutex_unlock(dev-struct_mutex);
}
  
return 0;
  
   This is not a kind of patch that should be taken through trivial tree.
 
  You must mean this is exactly that kind of a patch...
  Notice the double mutex_lock() on the same mutex in the same scope.

 I try not to take urgent stuff through trivial tree, in order not to
 bother Linus more than once per merge window with trivial stuff.

 I can of course take it, if DRM maintainers prefer it that way ...

well it *looked* trivial to me :) it would of course be nice to have it in 
2.6.29 as it currently 
prevents drm[Set|Drop]Master from working, which is required for multiple X 
instances nowadays -- 
if it helps, I tested this exact scenario and the above appears to be the only 
showstopper

Best regards
-- 
Dipl. Math.
Helge Bahmann
Berater
Geschäftsbereich Hochsicherheit
secunet Security Networks AG
Ammonstraße 74
01067 Dresden, Germany
Fon: +49 201 54 54-3586
Fax: +49 201 54 54-1323
Email: helge.bahm...@secunet.com

Sitz: Kronprinzenstraße 30, 45128 Essen
Amtsgericht Essen HRB 13615
Vorstand: Dr. Rainer Baumgart, Thomas Koelzer, Thomas Pleines
Aufsichtsratsvorsitzender: Dr. Karsten Ottenberg

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Dave Airlie

 Fix deadlock in drm_setmaster_ioctl

Wow, I have this right in my rawhide tree, I must have retyped this when
I ported it back.

thanks I'll send it to Linus now.

Dave.
 
 diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
 index 096e2a3..7c8b15b 100644
 --- a/drivers/gpu/drm/drm_stub.c
 +++ b/drivers/gpu/drm/drm_stub.c
 @@ -168,7 +168,7 @@ int drm_setmaster_ioctl(struct drm_device *dev, void 
 *data,
   file_priv-minor-master != file_priv-master) {
   mutex_lock(dev-struct_mutex);
   file_priv-minor-master = drm_master_get(file_priv-master);
 - mutex_lock(dev-struct_mutex);
 + mutex_unlock(dev-struct_mutex);
   }
  
   return 0;
 
 

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20456] New: DRI won't work due to unkown chip id.

2009-03-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20456

   Summary: DRI won't work due to unkown chip id.
   Product: Mesa
   Version: CVS
  Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/DRI/r300
AssignedTo: dri-devel@lists.sourceforge.net
ReportedBy: dreamandf...@gmail.com


I think I've found a solution.
In file Mesa-7.3/src/mesa/drivers/dri/r300/radeon_chipset.h, line 190:
#define PCI_CHIP_RV515_718A   718A
   should be:
#define PCI_CHIP_RV515_718A   718a
   I've tested, this fixed the problem and I have direct rendering working.

My system is Gentoo 2008.0, with ATI Mobility Radeon X2300. Xorg 7.4,
xf86-video-ati open source driver.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 4696] segfault in server-side glXMakeCurrent path with indirect rendering

2009-03-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=4696





--- Comment #11 from Steven Houston ste...@shouston.net  2009-03-04 08:55:18 
PST ---
Created an attachment (id=23514)
 -- (http://bugs.freedesktop.org/attachment.cgi?id=23514)
Reproduce code

This code reproduces the crash on mesa 6.5.1. It re-uses the same OpenGL
context on 2 different windows.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 4696] segfault in server-side glXMakeCurrent path with indirect rendering

2009-03-04 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=4696


Steven Houston ste...@shouston.net changed:

   What|Removed |Added

 CC||ste...@shouston.net




--- Comment #12 from Steven Houston ste...@shouston.net  2009-03-04 09:03:30 
PST ---
I was able to reliably reproduce this crash on CentOS 5.2. No drivers from HW
vendors were installed on the system. glxinfo produces:

OpenGL vendor string: Mesa project: www.mesa3d.org
OpenGL renderer string: Mesa GLX Indirect
OpenGL version string: 1.2 (1.5 Mesa 6.5.1)

I get the crash on the same line of code in context.c as the original bug
reporter: 
if (!newCtx-DrawBuffer || newCtx-DrawBuffer-Name == 0) {

The reproduce case is to create a window, create a GLX rendering context, make
some GL calls, destroy the window but keep the rendering context. Then create a
new window and make the existing rendering context current on the new window,
the crash occurs in this glxMakeCurrent call.

I tried the reproduce case on ubuntu 8.10 with no vendor drivers, this uses
mesa 7.2. I wasn't able to reproduce on this system so the problem may be
fixed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 12419] possible circular locking dependency on i915 dma

2009-03-04 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=12419





--- Comment #9 from r...@sisk.pl  2009-03-04 11:44 ---
On Wednesday 04 March 2009, Wang Chen wrote:
 Rafael J. Wysocki said the following on 2009-3-4 3:25:
  This message has been generated automatically as a part of a report
  of recent regressions.
  
  The following bug entry is on the current list of known regressions
  from 2.6.28.  Please verify if it still should be listed and let me know
  (either way).
  
  
  Bug-Entry   : http://bugzilla.kernel.org/show_bug.cgi?id=12419
  Subject : possible circular locking dependency on i915 dma
  Submitter   : Wang Chen wangc...@cn.fujitsu.com
  Date: 2009-01-08 14:11 (55 days old)
  First-Bad-Commit: 
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=546b0974c39657017407c86fe79811100b60700d
  References  : http://marc.info/?l=linux-kernelm=123142399720125w=4
  
 
 yet not fixed.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 12771] Oops in i915_gem_flush

2009-03-04 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=12771





--- Comment #1 from ka...@colleduc.ee  2009-03-04 12:00 ---
The oops still occurs with 2.6.29-rc7. An additional thing to note is that it
only happens with EXA turned on, but not with UXA.


I compiled my kernel with CONFIG_DEBUG_INFO and examined vmlinux with gdb:

(gdb) list *i915_gem_flush+0x131
0xc02be421 is in i915_gem_flush (drivers/gpu/drm/i915/i915_gem.c:1203).
1198
1199#if WATCH_EXEC
1200DRM_INFO(%s: queue flush %08x to ring\n, __func__,
cmd);
1201#endif
1202BEGIN_LP_RING(2);
1203OUT_RING(cmd);
1204OUT_RING(0); /* noop */
1205ADVANCE_LP_RING();
1206}
1207}


And the oops itself with WATCH_EXEC defined in i915_drv.h:

[drm:i915_mem_init_heap] *ERROR* heap already initialized?6[drm] buffers_ptr
136692264 buffer_count 1 len 01d8
[drm] i915_gem_execbuffer: invalidate_domains 0008 flush_domains 0001
[drm] i915_gem_flush: invalidate 0008 flush 0001
[drm] i915_gem_flush: queue flush 0204 to ring
BUG: unable to handle kernel paging request at 34c8
IP: [c02be421] i915_gem_flush+0x131/0x170
*pde = 
Oops: 0002 [#1] PREEMPT
last sysfs file: /sys/devices/pci:00/:00:1e.0/:02:08.0/resource
Modules linked in: ipv6 snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq
snd_seq_device snd_pcm_oss snd_mixer_oss snd_intel8x0 irtty_sir snd_ac97_codec
ac97_bus sir_dev snd_pcm irda ipw2200 snd_timer snd libipw thinkpad_acpi
soundcore yenta_socket e100 rfkill sr_mod rsrc_nonstatic snd_page_alloc
ehci_hcd 8250_pnp 8250_pci lib80211 mii video crc_ccitt led_class uhci_hcd
pcmcia_core sg cdrom 8250 serial_core output

Pid: 2733, comm: X Not tainted (2.6.29-rc7 #2) 2887AVG
EIP: 0060:[c02be421] EFLAGS: 00213212 CPU: 0
EIP is at i915_gem_flush+0x131/0x170
EAX: 34c8 EBX: 0001 ECX: 34cc EDX: 34d0
ESI: 0204 EDI: f7134400 EBP: f5e07dfc ESP: f5e07dd8
DS: 007b ES: 007b FS:  GS: 0033 SS: 0068
Process X (pid: 2733, ti=f5e06000 task=f5efb840 task.ti=f5e06000)
Stack:
c043f548 c03d113d 0204 0001 f703b000 0204 0009 0008
0001 f5e07eb8 c02c15b2 c043ffd0 c03d1237 0008 0001 b7999000
c178c600  c0152640  f5e07e6c f5d10ec0 f68aedc0 f7134400
Call Trace:
[c02c15b2] ? i915_gem_execbuffer+0xda2/0xdd0
[c0152640] ? filemap_fault+0x0/0x4c0
[c0113f26] ? do_page_fault+0x2d6/0x750
[c02aabc2] ? drm_gem_object_lookup+0x32/0x70
[c02a9290] ? drm_ioctl+0xe0/0x2f0
[c017a121] ? do_sync_write+0xd1/0x110
[c02c0810] ? i915_gem_execbuffer+0x0/0xdd0
[c01874a1] ? vfs_ioctl+0x81/0x90
[c0187632] ? do_vfs_ioctl+0x72/0x5c0
[c0125d97] ? _local_bh_enable+0x27/0xa0
[c017ab10] ? vfs_write+0x100/0x140
[c017a050] ? do_sync_write+0x0/0x110
[c0187bb9] ? sys_ioctl+0x39/0x70
[c0103431] ? sysenter_do_call+0x12/0x25
[c03a] ? unix_stream_connect+0x3a0/0x490
Code: 04 e8 39 db 0e 00 8b 75 ec 83 7e 20 07 7e 42 8b 45 ec 8b 75 f0 8b 50 1c
8b 48 14 8b 58 0c 8d 04 11 83 c2 04 21 da 01 d1 83 c2 04 8930 21 da c7 01 00
00 00 00 8b 45 ec 83 68 20 08 89 50 1c 8b
EIP: [c02be421] i915_gem_flush+0x131/0x170 SS:ESP 0068:f5e07dd8
---[ end trace 832e8b45814ff199 ]---


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Kristian Høgsberg
On Wed, Mar 4, 2009 at 6:50 AM, Dave Airlie airl...@linux.ie wrote:

 Fix deadlock in drm_setmaster_ioctl

 Wow, I have this right in my rawhide tree, I must have retyped this when
 I ported it back.

We need to bump the dri version for this so we don't deadlock on older
kernels when the 2d drivers start using this.  A second non-kms X
server would just fail to initialize DRI before, when we add
drmSetMaster() support they will deadlock if we don't make it
conditional on whether or not the kernel has this fix.

cheers,
Kristian

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] Fix deadlock in drm_setmaster_ioctl

2009-03-04 Thread Dave Airlie

  I ported it back.
 
 We need to bump the dri version for this so we don't deadlock on older
 kernels when the 2d drivers start using this.  A second non-kms X
 server would just fail to initialize DRI before, when we add
 drmSetMaster() support they will deadlock if we don't make it
 conditional on whether or not the kernel has this fix.

This has never been in a released kernel so no need.

Dave.

--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [Intel-gfx] [PATCH] drm/i915: TV mode_set sync up with 2D driver

2009-03-04 Thread Wang, Zhenyu Z
On 2009.03.04 15:54:15 +0800, Robert Lowery wrote:
  Fix TV control save register for untouched bits, and color
  knobs different definition for 945 and 965 chips.
 
...
 
 This is out of sync now that the following is committed
 http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=42e34e90e2e4048b38481cab61cef46f932eada7
 

That will be sync up later, we have to hook on output properties
first.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


signature.asc
Description: Digital signature
--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel