Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Dave Airlie
On Thu, Mar 19, 2009 at 2:08 PM, Greg KH g...@kroah.com wrote:
 Hi,

 Here's 5 patches that add the Intel Poulsbo/Morrestown DRM driver to the
 kernel tree.

 There are 4 patches that make changes to the DRM core, and one patch
 that adds the DRM driver itself.  The driver is added to the
 drivers/staging/ directory because it is not the final driver that
 Intel wishes to support over time.  The userspace api is going to
 change, and work is currently underway to hook up properly with the
 memory management system.


 However this work is going to take a while, and in the meantime, users
 want to run Linux on this kind of hardware.  I'd really like to add the
 driver to the staging tree, but it needs these core DRM changes in order
 to get it to work properly.

 Originally I had a patch that basically duplicated the existing DRM
 core, and embedded it with these changes and the PSB driver together
 into one big mess of a kernel module.  But Richard convinced me that
 this wasn't the nicest thing to do, and he did work on the PSB code
 and dug out these older DRM patches.

 The only thing that looks a bit odd to me is the unlocked ioctl patch,
 Thomas, is that thing really correct?

 David, I'd be glad to take the DRM changes through the staging tree, but
 only if you ack them.

First off, the non-staging patches need more complete changelog entries,
a bit of meaning goes a long way. I'll ack them if they are documented and
make sense. The unlocked ioctl hook makes sense to me at least!

Now the non-core DRM driver comes with some caveats no one mentioned,
only the userspace 2D is open, no userspace 3D is available and I've no idea if
one is forthcoming. Now I don't know enough about the Poulsbo to say this
drm implementation is secure and can't DMA over my password file.

There is no upstream X.org driver available for this yet, Ubuntu
shipped something
but really we should be at least seeing X.org and Mesa commitments from Intel
to supporting this code in the future before we go shipping it all in
the kernel.

Staging something with a very broken userspace API is going to be an nightmare,
its fine if my audio doesn't work, but when X fails to start people
are left in a lot worse
place, personally I would never stage any driver that can break the
users userspace
this badly when we finally do get a version we want to upstream
properly. GPU drivers
are not just a kernel bit, they are not like a network card or sound
driver, where the
userspace API is mostly defined or a filesystem where we have POSIX.

So really I'm NAKing this from ever entering the mainline in its
current form, without
a supporting roadmap and plans for the userspace bits.

Dave.


 thanks,

 greg k-h
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm: reorder struct drm_ioctl_desc to save space on 64 bit builds

2009-03-19 Thread Richard Kennedy
drm: reorder struct drm_ioctl_desc to save space on 64 bit builds

shrinks drm_ioctl_desc from 24 bytes to 16 bytes by reordering members
to remove padding.

updates DRM_IOCTL_DEF macro to initialise structure members by name to
handle the structure reorder.

The applied patch reduces data used in drm.ko from 10440 to 9032

Signed-off-by: Richard Kennedy rich...@rsk.demon.co.uk
---

This patch is against v2.6.29-rc8, it compiles but hasn't had any other
testing as I don't have any of this hardware.

size reports
drm.ko
textdatabss
106297  10440   144 116881  1c891
106297  9032144 115473  1c311 +patch

I also built these 2 drivers
sis.ko
text data bss
381721160   5933172d
381719320   57491675 +patch

radeon.ko
text data bss
94744   988016400   121024
94744   965616400   120800 +patch

regards
Richard


diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index e5f4ae9..62c2ef3 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -281,16 +281,16 @@ typedef int drm_ioctl_compat_t(struct file *filp, 
unsigned int cmd,
 
 struct drm_ioctl_desc {
unsigned int cmd;
-   drm_ioctl_t *func;
int flags;
+   drm_ioctl_t *func;
 };
 
 /**
  * Creates a driver or general drm_ioctl_desc array entry for the given
  * ioctl, for use by drm_ioctl().
  */
-#define DRM_IOCTL_DEF(ioctl, func, flags) \
-   [DRM_IOCTL_NR(ioctl)] = {ioctl, func, flags}
+#define DRM_IOCTL_DEF(ioctl, _func, _flags) \
+   [DRM_IOCTL_NR(ioctl)] = {.cmd = ioctl, .func = _func, .flags = _flags}
 
 struct drm_magic_entry {
struct list_head head;



--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[patch 4/5] drm: Add unlocked IOCTL functionality from the drm repo.

2009-03-19 Thread Greg KH
Signed-off-by: Thomas Hellstrom thellst...@vmware.com
Signed-off-by: Richard Purdie rpur...@linux.intel.com
Signed-off-by: Greg Kroah-Hartman gre...@suse.de

---
 drivers/gpu/drm/drm_drv.c |9 +++--
 include/drm/drmP.h|2 ++
 2 files changed, 9 insertions(+), 2 deletions(-)

--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -455,6 +455,12 @@ static int drm_version(struct drm_device
 int drm_ioctl(struct inode *inode, struct file *filp,
  unsigned int cmd, unsigned long arg)
 {
+   return drm_unlocked_ioctl(filp, cmd, arg);
+}
+EXPORT_SYMBOL(drm_ioctl);
+
+long drm_unlocked_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
+{
struct drm_file *file_priv = filp-private_data;
struct drm_device *dev = file_priv-minor-dev;
struct drm_ioctl_desc *ioctl;
@@ -530,8 +536,7 @@ int drm_ioctl(struct inode *inode, struc
DRM_DEBUG(ret = %x\n, retcode);
return retcode;
 }
-
-EXPORT_SYMBOL(drm_ioctl);
+EXPORT_SYMBOL(drm_unlocked_ioctl);
 
 drm_local_map_t *drm_getsarea(struct drm_device *dev)
 {
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1016,6 +1016,8 @@ extern int drm_init(struct drm_driver *d
 extern void drm_exit(struct drm_driver *driver);
 extern int drm_ioctl(struct inode *inode, struct file *filp,
 unsigned int cmd, unsigned long arg);
+extern long drm_unlocked_ioctl(struct file *filp,
+  unsigned int cmd, unsigned long arg);
 extern long drm_compat_ioctl(struct file *filp,
 unsigned int cmd, unsigned long arg);
 extern int drm_lastclose(struct drm_device *dev);


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Greg KH
Hi,

Here's 5 patches that add the Intel Poulsbo/Morrestown DRM driver to the
kernel tree.

There are 4 patches that make changes to the DRM core, and one patch
that adds the DRM driver itself.  The driver is added to the
drivers/staging/ directory because it is not the final driver that
Intel wishes to support over time.  The userspace api is going to
change, and work is currently underway to hook up properly with the
memory management system.

However this work is going to take a while, and in the meantime, users
want to run Linux on this kind of hardware.  I'd really like to add the
driver to the staging tree, but it needs these core DRM changes in order
to get it to work properly.

Originally I had a patch that basically duplicated the existing DRM
core, and embedded it with these changes and the PSB driver together
into one big mess of a kernel module.  But Richard convinced me that
this wasn't the nicest thing to do, and he did work on the PSB code
and dug out these older DRM patches.

The only thing that looks a bit odd to me is the unlocked ioctl patch,
Thomas, is that thing really correct?

David, I'd be glad to take the DRM changes through the staging tree, but
only if you ack them.

thanks,

greg k-h

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[patch 2/5] drm: Add a tracker for global objects.

2009-03-19 Thread Greg KH
[coding style issues fixed by gregkh]

Signed-off-by: Thomas Hellstrom thellst...@vmware.com
Signed-off-by: Richard Purdie rpur...@linux.intel.com
Signed-off-by: Greg Kroah-Hartman gre...@suse.de

---
 drivers/gpu/drm/Makefile |3 -
 drivers/gpu/drm/drm_drv.c|3 +
 drivers/gpu/drm/drm_global.c |  105 +++
 include/drm/drmP.h   |   20 
 4 files changed, 130 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -386,6 +386,8 @@ static int __init drm_core_init(void)
 
DRM_INFO(Initialized %s %d.%d.%d %s\n,
 CORE_NAME, CORE_MAJOR, CORE_MINOR, CORE_PATCHLEVEL, CORE_DATE);
+   drm_global_init();
+
return 0;
 err_p3:
drm_sysfs_destroy();
@@ -399,6 +401,7 @@ err_p1:
 
 static void __exit drm_core_exit(void)
 {
+   drm_global_release();
remove_proc_entry(dri, NULL);
drm_sysfs_destroy();
 
--- /dev/null
+++ b/drivers/gpu/drm/drm_global.c
@@ -0,0 +1,105 @@
+/**
+ *
+ * Copyright 2008-2009 VMware, Inc., Palo Alto, CA., USA
+ * All Rights Reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the
+ * Software), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sub license, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the
+ * next paragraph) shall be included in all copies or substantial portions
+ * of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
+ * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+ * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+ * USE OR OTHER DEALINGS IN THE SOFTWARE.
+ *
+ **/
+#include drmP.h
+struct drm_global_item {
+   struct mutex mutex;
+   void *object;
+   int refcount;
+};
+
+static struct drm_global_item glob[DRM_GLOBAL_NUM];
+
+void drm_global_init(void)
+{
+   int i;
+
+   for (i = 0; i  DRM_GLOBAL_NUM; ++i) {
+   struct drm_global_item *item = glob[i];
+   mutex_init(item-mutex);
+   item-object = NULL;
+   item-refcount = 0;
+   }
+}
+
+void drm_global_release(void)
+{
+   int i;
+   for (i = 0; i  DRM_GLOBAL_NUM; ++i) {
+   struct drm_global_item *item = glob[i];
+   BUG_ON(item-object != NULL);
+   BUG_ON(item-refcount != 0);
+   }
+}
+
+int drm_global_item_ref(struct drm_global_reference *ref)
+{
+   int ret;
+   struct drm_global_item *item = glob[ref-global_type];
+   void *object;
+
+   mutex_lock(item-mutex);
+   if (item-refcount == 0) {
+   item-object = kmalloc(ref-size, GFP_KERNEL);
+   if (unlikely(item-object == NULL)) {
+   ret = -ENOMEM;
+   goto out_err;
+   }
+
+   ref-object = item-object;
+   ret = ref-init(ref);
+   if (unlikely(ret != 0))
+   goto out_err;
+
+   ++item-refcount;
+   }
+   ref-object = item-object;
+   object = item-object;
+   mutex_unlock(item-mutex);
+   return 0;
+out_err:
+   kfree(item-object);
+   mutex_unlock(item-mutex);
+   item-object = NULL;
+   return ret;
+}
+EXPORT_SYMBOL(drm_global_item_ref);
+
+void drm_global_item_unref(struct drm_global_reference *ref)
+{
+   struct drm_global_item *item = glob[ref-global_type];
+
+   mutex_lock(item-mutex);
+   BUG_ON(item-refcount == 0);
+   BUG_ON(ref-object != item-object);
+   if (--item-refcount == 0) {
+   ref-release(ref);
+   kfree(item-object);
+   item-object = NULL;
+   }
+   mutex_unlock(item-mutex);
+}
+EXPORT_SYMBOL(drm_global_item_unref);
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -10,7 +10,8 @@ drm-y   :=drm_auth.o drm_bufs.o drm
drm_lock.o drm_memory.o drm_proc.o drm_stub.o drm_vm.o \
drm_agpsupport.o drm_scatter.o ati_pcigart.o drm_pci.o \
drm_sysfs.o drm_hashtab.o drm_sman.o drm_mm.o \
-   drm_crtc.o drm_crtc_helper.o drm_modes.o drm_edid.o
+   drm_crtc.o drm_crtc_helper.o drm_modes.o 

[patch 3/5] drm: Export hash table functionality.

2009-03-19 Thread Greg KH
These drm functions are needed for the psb module.

Signed-off-by: Thomas Hellstrom thellst...@vmware.com
Signed-off-by: Richard Purdie rpur...@linux.intel.com
Signed-off-by: Greg Kroah-Hartman gre...@suse.de

---
 drivers/gpu/drm/drm_hashtab.c |4 
 1 file changed, 4 insertions(+)

--- a/drivers/gpu/drm/drm_hashtab.c
+++ b/drivers/gpu/drm/drm_hashtab.c
@@ -62,6 +62,7 @@ int drm_ht_create(struct drm_open_hash *
}
return 0;
 }
+EXPORT_SYMBOL(drm_ht_create);
 
 void drm_ht_verbose_list(struct drm_open_hash *ht, unsigned long key)
 {
@@ -156,6 +157,7 @@ int drm_ht_just_insert_please(struct drm
}
return 0;
 }
+EXPORT_SYMBOL(drm_ht_just_insert_please);
 
 int drm_ht_find_item(struct drm_open_hash *ht, unsigned long key,
 struct drm_hash_item **item)
@@ -169,6 +171,7 @@ int drm_ht_find_item(struct drm_open_has
*item = hlist_entry(list, struct drm_hash_item, head);
return 0;
 }
+EXPORT_SYMBOL(drm_ht_find_item);
 
 int drm_ht_remove_key(struct drm_open_hash *ht, unsigned long key)
 {
@@ -202,3 +205,4 @@ void drm_ht_remove(struct drm_open_hash 
ht-table = NULL;
}
 }
+EXPORT_SYMBOL(drm_ht_remove);


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[patch 1/5] drm: Split out the mm declarations in a separate header. Add atomic operations.

2009-03-19 Thread Greg KH
[coding style issues fixed by gregkh]

Signed-off-by: Thomas Hellstrom thellst...@vmware.com
Signed-off-by: Richard Purdie rpur...@linux.intel.com
Signed-off-by: Greg Kroah-Hartman gre...@suse.de

---
 drivers/gpu/drm/drm_mm.c |  165 +++
 include/drm/drmP.h   |   37 --
 include/drm/drm_mm.h |   90 +
 3 files changed, 228 insertions(+), 64 deletions(-)

--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -42,8 +42,11 @@
  */
 
 #include drmP.h
+#include drm_mm.h
 #include linux/slab.h
 
+#define MM_UNUSED_TARGET 4
+
 unsigned long drm_mm_tail_space(struct drm_mm *mm)
 {
struct list_head *tail_node;
@@ -74,16 +77,62 @@ int drm_mm_remove_space_from_tail(struct
return 0;
 }
 
+static struct drm_mm_node *drm_mm_kmalloc(struct drm_mm *mm, int atomic)
+{
+   struct drm_mm_node *child;
+
+   if (atomic)
+   child = kmalloc(sizeof(*child), GFP_ATOMIC);
+   else
+   child = kmalloc(sizeof(*child), GFP_KERNEL);
+
+   if (unlikely(child == NULL)) {
+   spin_lock(mm-unused_lock);
+   if (list_empty(mm-unused_nodes))
+   child = NULL;
+   else {
+   child =
+   list_entry(mm-unused_nodes.next,
+  struct drm_mm_node, fl_entry);
+   list_del(child-fl_entry);
+   --mm-num_unused;
+   }
+   spin_unlock(mm-unused_lock);
+   }
+   return child;
+}
+
+int drm_mm_pre_get(struct drm_mm *mm)
+{
+   struct drm_mm_node *node;
+
+   spin_lock(mm-unused_lock);
+   while (mm-num_unused  MM_UNUSED_TARGET) {
+   spin_unlock(mm-unused_lock);
+   node = kmalloc(sizeof(*node), GFP_KERNEL);
+   spin_lock(mm-unused_lock);
+
+   if (unlikely(node == NULL)) {
+   int ret = (mm-num_unused  2) ? -ENOMEM : 0;
+   spin_unlock(mm-unused_lock);
+   return ret;
+   }
+   ++mm-num_unused;
+   list_add_tail(node-fl_entry, mm-unused_nodes);
+   }
+   spin_unlock(mm-unused_lock);
+   return 0;
+}
+EXPORT_SYMBOL(drm_mm_pre_get);
 
 static int drm_mm_create_tail_node(struct drm_mm *mm,
-   unsigned long start,
-   unsigned long size)
+  unsigned long start,
+  unsigned long size, int atomic)
 {
struct drm_mm_node *child;
 
-   child = (struct drm_mm_node *)
-   drm_alloc(sizeof(*child), DRM_MEM_MM);
-   if (!child)
+   child = drm_mm_kmalloc(mm, atomic);
+   if (unlikely(child == NULL))
return -ENOMEM;
 
child-free = 1;
@@ -97,8 +146,7 @@ static int drm_mm_create_tail_node(struc
return 0;
 }
 
-
-int drm_mm_add_space_to_tail(struct drm_mm *mm, unsigned long size)
+int drm_mm_add_space_to_tail(struct drm_mm *mm, unsigned long size, int atomic)
 {
struct list_head *tail_node;
struct drm_mm_node *entry;
@@ -106,20 +154,21 @@ int drm_mm_add_space_to_tail(struct drm_
tail_node = mm-ml_entry.prev;
entry = list_entry(tail_node, struct drm_mm_node, ml_entry);
if (!entry-free) {
-   return drm_mm_create_tail_node(mm, entry-start + entry-size, 
size);
+   return drm_mm_create_tail_node(mm, entry-start + entry-size,
+  size, atomic);
}
entry-size += size;
return 0;
 }
 
 static struct drm_mm_node *drm_mm_split_at_start(struct drm_mm_node *parent,
-   unsigned long size)
+unsigned long size,
+int atomic)
 {
struct drm_mm_node *child;
 
-   child = (struct drm_mm_node *)
-   drm_alloc(sizeof(*child), DRM_MEM_MM);
-   if (!child)
+   child = drm_mm_kmalloc(parent-mm, atomic);
+   if (unlikely(child == NULL))
return NULL;
 
INIT_LIST_HEAD(child-fl_entry);
@@ -151,8 +200,9 @@ struct drm_mm_node *drm_mm_get_block(str
tmp = parent-start % alignment;
 
if (tmp) {
-   align_splitoff = drm_mm_split_at_start(parent, alignment - tmp);
-   if (!align_splitoff)
+   align_splitoff =
+   drm_mm_split_at_start(parent, alignment - tmp, 0);
+   if (unlikely(align_splitoff == NULL))
return NULL;
}
 
@@ -161,7 +211,7 @@ struct drm_mm_node *drm_mm_get_block(str
parent-free = 0;
return parent;
} else {
-   child = drm_mm_split_at_start(parent, size);
+   child = drm_mm_split_at_start(parent, 

[Bug 20539] Segmentation Fault with Radeon (maybe with pixmap command)

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20539


Michel Dänzer mic...@daenzer.net changed:

   What|Removed |Added

 AssignedTo|xorg-driver-...@lists.x.org |dri-
   ||de...@lists.sourceforge.net
  Component|Driver/Radeon   |Drivers/DRI/r300
Product|xorg|Mesa
  QAContact|xorg-t...@lists.x.org   |
Version|7.4 |unspecified




--- Comment #16 from Michel Dänzer mic...@daenzer.net  2009-03-19 01:40:11 
PST ---
The valgrind error below looks like the most likely culprit at this point.
Apparently the Mesa r300 driver is accessing texture object memory after it's
been freed. I'm not sure if it's the responsibility of the driver or the Mesa
core to prevent this, assuming the driver for now.

==27872== Invalid read of size 4
==27872==at 0x7A7F4BB: r300UpdateTexture (r300_texstate.c:576)
==27872==by 0x7A7F5A8: r300UpdateTextureState (r300_texstate.c:648)
==27872==by 0x7A782B9: r300UpdateShaderStates (r300_state.c:2685)
==27872==by 0x7A7B6D2: r300RunRender (r300_render.c:314)
==27872==by 0x7B135F3: _tnl_run_pipeline (t_pipeline.c:158)
==27872==by 0x7B13B64: _tnl_draw_prims (t_draw.c:402)
==27872==by 0x7B0C823: vbo_exec_vtx_flush (vbo_exec_draw.c:251)
==27872==by 0x7B07F27: vbo_exec_FlushVertices (vbo_exec_api.c:751)
==27872==by 0x7B98460: _mesa_PopAttrib (attrib.c:862)
==27872==by 0x5922AD0: __glXDisp_PopAttrib (indirect_dispatch.c:1445)
==27872==by 0x594C77E: __glXDisp_Render (glxcmds.c:1783)
==27872==by 0x5951079: __glXDispatch (glxext.c:523)
==27872==  Address 0x4ec6e00 is 24 bytes inside a block of size 1,572 free'd
==27872==at 0x4024E3A: free (vg_replace_malloc.c:323)
==27872==by 0x7AD01AC: _mesa_free (imports.c:85)
==27872==by 0x7A60767: driDestroyTextureObject (texmem.c:353)
==27872==by 0x7A7E26D: r300DeleteTexture (r300_tex.c:1000)
==27872==by 0x7AF2F00: _mesa_reference_texobj (texobj.c:317)
==27872==by 0x7AF45A0: _mesa_DeleteTextures (texobj.c:852)
==27872==by 0x5926692: __glXDisp_DeleteTextures (indirect_dispatch.c:2848)
==27872==by 0x5951079: __glXDispatch (glxext.c:523)
==27872==by 0x808C51E: Dispatch (dispatch.c:437)
==27872==by 0x80716F4: main (main.c:397)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Thomas Hellström
Dave and Greg,

Some quick comments below.

Dave Airlie wrote:
 On Thu, Mar 19, 2009 at 2:08 PM, Greg KH g...@kroah.com wrote:
   
 Hi,

 Here's 5 patches that add the Intel Poulsbo/Morrestown DRM driver to the
 kernel tree.

 There are 4 patches that make changes to the DRM core, and one patch
 that adds the DRM driver itself.  The driver is added to the
 drivers/staging/ directory because it is not the final driver that
 Intel wishes to support over time.  The userspace api is going to
 change, and work is currently underway to hook up properly with the
 memory management system.
 

   
 However this work is going to take a while, and in the meantime, users
 want to run Linux on this kind of hardware.  I'd really like to add the
 driver to the staging tree, but it needs these core DRM changes in order
 to get it to work properly.

 Originally I had a patch that basically duplicated the existing DRM
 core, and embedded it with these changes and the PSB driver together
 into one big mess of a kernel module.  But Richard convinced me that
 this wasn't the nicest thing to do, and he did work on the PSB code
 and dug out these older DRM patches.

 The only thing that looks a bit odd to me is the unlocked ioctl patch,
 Thomas, is that thing really correct?

 David, I'd be glad to take the DRM changes through the staging tree, but
 only if you ack them.
 

 First off, the non-staging patches need more complete changelog entries,
 a bit of meaning goes a long way. I'll ack them if they are documented and
 make sense. The unlocked ioctl hook makes sense to me at least!
   

For the non-staging patches, (which also sit in the modesetting-newttm 
tree),
I can add some more elaborate comments. However I think all of them are 
targeted to support functionality for TTM, so unless the TTM code goes 
into staging or mainstream, there is little point in merging them to 
core drm before other drivers find them useful.

Although I see the patch adding TTM is including some backwards 
compatibility defines
(In particular the PAT compat stuff) that needs to be stripped.


 Now the non-core DRM driver comes with some caveats no one mentioned,
 only the userspace 2D is open, no userspace 3D is available and I've no idea 
 if
 one is forthcoming. Now I don't know enough about the Poulsbo to say this
 drm implementation is secure and can't DMA over my password file.

   

The GPU in Poulsbo / Morestown can only access memory through a 
multi-context 4GB two-level page-table, and the implementation of that 
is open in psb_mmu.c.
The VDC is accessing memory through a traditional Intel GTT: psb_gtt.c
The registers used to set up the page table are blocked from user-space 
access. Any registers used to fire GPU assembly code with privileges to 
change those registers are also blocked.

So security-wise there is nothing worse with this device than with other 
devices without full open documentation. And AFAICT it's more secure 
than some drivers _with_ full open documentation.
The non-existence of an open-source 3D implementation doesn't really 
alter that situation.

However, if there's a policy issue about adding Linux kernel support for 
closed-source user-space drivers, I think it helps to be explicit about 
that.


 There is no upstream X.org driver available for this yet, Ubuntu
 shipped something
 but really we should be at least seeing X.org and Mesa commitments from Intel
 to supporting this code in the future before we go shipping it all in
 the kernel.

   

...

 Staging something with a very broken userspace API is going to be an 
 nightmare,
 its fine if my audio doesn't work, but when X fails to start people
 are left in a lot worse
 place, personally I would never stage any driver that can break the
 users userspace
 this badly when we finally do get a version we want to upstream
 properly. GPU drivers
 are not just a kernel bit, they are not like a network card or sound
 driver, where the
 userspace API is mostly defined or a filesystem where we have POSIX.

   

I can't really comment on this since I have no knowledge about the
upcoming interface changes.

Thanks,
Thomas

 So really I'm NAKing this from ever entering the mainline in its
 current form, without
 a supporting roadmap and plans for the userspace bits.

 Dave.

   
 thanks,

 greg k-h
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/

 

 --
 Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
 powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
 easily build your RIAs with Flex Builder, the Eclipse(TM)based development
 software that enables intelligent coding and step-through debugging.
 Download the free 60 day trial. 

Moorestown non-staging patches.

2009-03-19 Thread Thomas Hellström
Greg / Richard:

Comments to the non-staging patches:

patch 1/5] drm: Split out the mm declarations in a separateheader. 
Add atomic operations:

The range manager operations are usually quite fast, and the range 
manager really only needs
to be protected by a spinlock. Add atomic operations and means to 
pre-allocate memory needed
within the atomic sections, similar to the idr implementation.
Also create a separate header file for the API so users don't need to 
include the full drmP.h header.

[patch 2/5] drm: Add a tracker for global objects.

Some DRM data shouldn't really be per device. This includes 
memory-accounting and perhaps
also object handle lookup. A system with one or more gpus would ideally 
want to share handle
space and memory accounting between the GPU drivers.
Add a tracker for such global objects. These objects live as long any 
DRM driver reference them.

[patch 3/5] drm: Export hash table functionality.

Make the drm hash table implementation usable from within drm device 
drivers.

[patch 4/5] drm: Add unlocked IOCTL functionality from the drm repo.

Make the drm ioctl handle callable as an unlocked IOCTL.
This is really only providing an alternative interface, since the 
calling sequence for the
unlocked ioctl is somewhat different.
Taken from the drm develpment repo.
NOTE: This should not be used yet for core drm ioctls, as some are not 
thread-safe.




--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Richard Purdie
Hi,

On Thu, 2009-03-19 at 16:48 +1000, Dave Airlie wrote:
 First off, the non-staging patches need more complete changelog entries,
 a bit of meaning goes a long way. I'll ack them if they are documented and
 make sense. The unlocked ioctl hook makes sense to me at least!

 Now the non-core DRM driver comes with some caveats no one mentioned,
 only the userspace 2D is open, no userspace 3D is available and I've no idea 
 if
 one is forthcoming. Now I don't know enough about the Poulsbo to say this
 drm implementation is secure and can't DMA over my password file.

I think Thomas has covered these things and between us, we can improve
the patch series.

 There is no upstream X.org driver available for this yet, Ubuntu
 shipped something
 but really we should be at least seeing X.org and Mesa commitments from Intel
 to supporting this code in the future before we go shipping it all in
 the kernel.

An older version of the X.org driver has been available (with various
urls) at http://git.moblin.org/cgit.cgi/deprecated/xf86-video-psb/ for a
while. I'm working on getting this updated and that should happen soon.

I'm also working on getting the binary bits for 3D support publicly
available somewhere but these are not open source and unlikely to be any
time soon. We know this sucks, we're working on it but thats all I can
really say.

As Greg said, we don't envisage this driver being the final solution.
There is hardware out there, running Linux which needs any driver rather
than no driver now. Having a standard implementation that everyone uses
has to be preferable to everyone rolling their own modified version of
it. For 2D, the driver is open and people can chose to use the 3D
binaries or not. This would seem to fit the staging tree's mandate where
this driver could live until things get sorted properly.

Does this ease some of your concerns? I don't claim this is an ideal
situation but we're all trying to make the best of what we've got...

Cheers,

Richard




--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 10303] glFogCoordPointer broken in DRI Radeon R300 driver

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=10303


Maciej Cencora m.cenc...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #7 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 05:09:19 
PST ---
Support for EXT_fog_coord in r300 has been commited to mesa master branch and
should be part of upcoming 7.5 release.
Please reopen if the bug still exists.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 11980] GL_EXT_stencil_two_side breaks shadows in warzone2100 since 6.5 .3

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=11980





--- Comment #2 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 05:14:58 
PST ---
Can you reproduce the bug with current mesa? Some EXT_stencil_two_side related
patches has been committed about a month ago.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 19002] RS690 break with multi-texture fragment programs

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=19002





--- Comment #1 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 05:44:15 
PST ---
I can't reproduce it with my RS690 on mesa 7.2 neither on current master.
What mplayer version do you have?
Mine is MPlayer 1.0rc2-4.3.2


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


RE: [Intel-gfx] [PATCH] Read EDID extensions from monitor

2009-03-19 Thread Ma, Ling
Any comments ?

Thanks
Ma Ling 

-Original Message-
From: intel-gfx-boun...@lists.freedesktop.org 
[mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Ma Ling
Sent: Wednesday, March 18, 2009 6:38 PM
To: dri-devel@lists.sourceforge.net
Cc: intel-...@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] Read EDID extensions from monitor

Usually drm read basic EDID, that is enough for us, but because digital display 
is introduced
i.e. HDMI monitor, sometime we need to interact with monitor by EDID extension 
information,
including audio/video data block, speaker allocation and vendor specific data 
block...
This patch intends to reading EDID extensions(max 4) from digital monitor for 
user.
Any comments are welcome.

Thanks
Ma Ling

Signed-off-by: Ma Ling ling...@intel.com
---
 drivers/gpu/drm/drm_edid.c |  118 +--
 include/drm/drm_crtc.h |3 +-
 2 files changed, 92 insertions(+), 29 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a839a28..d83432a 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -550,11 +550,20 @@ static int add_detailed_info(struct drm_connector 
*connector,
 }
 
 #define DDC_ADDR 0x50
-
-unsigned char *drm_do_probe_ddc_edid(struct i2c_adapter *adapter)
+/**
+ * Get EDID information via I2C.
+ *
+ * \param adapter : i2c device adaptor
+ * \param buf : EDID data buffer to be filled
+ * \param len : EDID data buffer length
+ * \return 0 on success or -1 on failure.
+ *
+ * Try to fetch EDID information by calling i2c driver function.
+ */
+int drm_do_probe_ddc_edid(struct i2c_adapter *adapter,
+ unsigned char *buf, int len)
 {
unsigned char start = 0x0;
-   unsigned char *buf = kmalloc(EDID_LENGTH, GFP_KERNEL);
struct i2c_msg msgs[] = {
{
.addr   = DDC_ADDR,
@@ -564,31 +573,36 @@ unsigned char *drm_do_probe_ddc_edid(struct i2c_adapter 
*adapter)
}, {
.addr   = DDC_ADDR,
.flags  = I2C_M_RD,
-   .len= EDID_LENGTH,
+   .len= len,
.buf= buf,
}
};
 
-   if (!buf) {
-   dev_warn(adapter-dev, unable to allocate memory for EDID 
-block.\n);
-   return NULL;
-   }
-
if (i2c_transfer(adapter, msgs, 2) == 2)
-   return buf;
+   return 0;
 
dev_info(adapter-dev, unable to read EDID block.\n);
-   kfree(buf);
-   return NULL;
+   return -1;
 }
 EXPORT_SYMBOL(drm_do_probe_ddc_edid);
 
-static unsigned char *drm_ddc_read(struct i2c_adapter *adapter)
+/**
+ * Get EDID information.
+ *
+ * \param adapter : i2c device adaptor.
+ * \param buf : EDID data buffer to be filled
+ * \param len : EDID data buffer length
+ * \return 0 on success or -1 on failure.
+ *
+ * Initialize DDC, then fetch EDID information
+ * by calling drm_do_probe_ddc_edid function.
+ */
+static int drm_ddc_read(struct i2c_adapter *adapter,
+   unsigned char *buf, int len)
 {
struct i2c_algo_bit_data *algo_data = adapter-algo_data;
-   unsigned char *edid = NULL;
int i, j;
+   int ret = -1;
 
algo_data-setscl(algo_data-data, 1);
 
@@ -616,7 +630,7 @@ static unsigned char *drm_ddc_read(struct i2c_adapter 
*adapter)
msleep(15);
 
/* Do the real work */
-   edid = drm_do_probe_ddc_edid(adapter);
+   ret = drm_do_probe_ddc_edid(adapter, buf, len);
algo_data-setsda(algo_data-data, 0);
algo_data-setscl(algo_data-data, 0);
msleep(15);
@@ -632,7 +646,7 @@ static unsigned char *drm_ddc_read(struct i2c_adapter 
*adapter)
msleep(15);
algo_data-setscl(algo_data-data, 0);
algo_data-setsda(algo_data-data, 0);
-   if (edid)
+   if (ret == 0)
break;
}
/* Release the DDC lines when done or the Apple Cinema HD display
@@ -641,9 +655,31 @@ static unsigned char *drm_ddc_read(struct i2c_adapter 
*adapter)
algo_data-setsda(algo_data-data, 1);
algo_data-setscl(algo_data-data, 1);
 
-   return edid;
+   return ret;
+}
+
+static int drm_ddc_read_edid(struct drm_connector *connector,
+struct i2c_adapter *adapter,
+char *buf, int len)
+{
+   int ret;
+
+   ret = drm_ddc_read(adapter, buf, len);
+   if (ret != 0) {
+   dev_info(connector-dev-pdev-dev, %s: no EDID data\n,
+drm_get_connector_name(connector));
+   goto end;
+   }
+   if (!edid_is_valid((struct edid *)buf)) {
+   dev_warn(connector-dev-pdev-dev, %s: EDID invalid.\n,
+

[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #2 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 05:48:09 
PST ---
Could you post you Xorg log and dmesg output?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 6979] r300_vertexprog.c, unknown output 3

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=6979


Maciej Cencora m.cenc...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #4 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 05:06:48 
PST ---
Support for EXT_fog_coord in r300 has been commited to mesa master branch and
should be part of upcoming 7.5 release.
Please reopen if the bug still exists.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Alan Cox
 The non-existence of an open-source 3D implementation doesn't really 
 alter that situation.

I think it does to an extent
 
 However, if there's a policy issue about adding Linux kernel support for 
 closed-source user-space drivers, I think it helps to be explicit about 
 that.

Actually its a lawyer question not just policy. If the two parts being put
together are tightly dependant on each other and in fact form a single
work which it seems could reasonably be the case in this situation then
if one half is GPL the other must also be so.

There is also policy on this, I refer you back to the Intel wireless and
binary management daemon discussions. I likewise refer you to some of the
input device discussions related to USB HID and devices where vendors
wanted us to exclude their device in favour of proprietary libusb drivers.

Alan

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 14076] GL_OUT_OF_MEMORY crash with R300 driver and Lineage II under Wine

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=14076





--- Comment #2 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 06:04:15 
PST ---
This looks like wine bug http://bugs.winehq.org/show_bug.cgi?id=13335
How much system RAM do you have?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 12765] i915 VT switch with AIGLX causes X lock up

2009-03-19 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=12765





--- Comment #3 from r...@sisk.pl  2009-03-19 06:03 ---
On Monday 16 March 2009, Sitsofe Wheeler wrote:
 On Sat, Mar 14, 2009 at 08:05:32PM +0100, Rafael J. Wysocki wrote:
  
  The following bug entry is on the current list of known regressions
  from 2.6.28.  Please verify if it still should be listed and let me know
  (either way).
  
  
  Bug-Entry   : http://bugzilla.kernel.org/show_bug.cgi?id=12765
  Subject : i915 VT switch with AIGLX causes X lock up
  Submitter   : Sitsofe Wheeler sits...@yahoo.com
  Date: 2009-02-21 15:38 (22 days old)

 Still here in 2.6.29-rc8.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #3 from Mukund Sivaraman m...@banu.com  2009-03-19 06:29:31 PST 
---
Maciej: Do you mean the logs after a bootup without running the GtkGlExt
application?

On running the app, the machine locks hard and this is the only machine I have
here, so I won't be able to get a dmesg output then.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #4 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 06:39:43 
PST ---
(In reply to comment #3)
 Maciej: Do you mean the logs after a bootup without running the GtkGlExt
 application?

Yes


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #5 from Mukund Sivaraman m...@banu.com  2009-03-19 07:02:12 PST 
---
Created an attachment (id=24046)
 -- (http://bugs.freedesktop.org/attachment.cgi?id=24046)
dmesg output


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #6 from Mukund Sivaraman m...@banu.com  2009-03-19 07:03:04 PST 
---
Created an attachment (id=24047)
 -- (http://bugs.freedesktop.org/attachment.cgi?id=24047)
X log


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20608] gtkglext example program locks up system with Mobility X1400 chipset

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20608





--- Comment #7 from Mukund Sivaraman m...@banu.com  2009-03-19 07:04:20 PST 
---
Also kernel modesetting is turned off with the nomodeset option in the kernel
cmdline.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20751] New: 2D acceleration on R6xx freezes my computer

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20751

   Summary: 2D acceleration on R6xx freezes my computer
   Product: DRI
   Version: XOrg CVS
  Platform: x86-64 (AMD64)
OS/Version: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: DRM/Radeon
AssignedTo: dri-devel@lists.sourceforge.net
ReportedBy: n...@chdir.org


Hello


I'm trying to enable EXA acceleration on my FireGL v5600 by following the
directives written on the wiki
(http://wiki.x.org/wiki/radeon%3Ar6xx_r7xx_branch).
Alas, it's freezing my system: I can only use my sysrecue key to reboot.

My lspci:
60:00.0 VGA compatible controller: ATI Technologies Inc RV630GL [FireGL
v5600]

uname -a :
Linux brew 2.6.29-rc8 #1 SMP Wed Mar 18 08:34:15 CET 2009 x86_64 GNU/Linux

Current DRM git HEAD :
commit 3085912035f3c37cfcf3df91af9e2c44ad29438e
Date:   Mon Mar 16 15:48:07 2009 -0400

xf86-video-ati git HEAD :
commit 68e83f10adb23fc359c1da881f5d666cd08b4067
Date:   Wed Mar 18 20:58:19 2009 -0400

My kernel log is filled with :

kernel: [drm] Initialized drm 1.1.0 20060810
kernel: radeon :60:00.0: PCI INT A - GSI 28 (level, low) - IRQ 28
kernel: radeon :60:00.0: setting latency timer to 64
kernel: [drm] Initialized radeon 1.29.0 20080613 on minor 0
kernel: mtrr: type mismatch for d000,1000 old: write-back new:
write-combining
last message repeated 4 times
kernel: [drm] Setting GART location based on new memory map
kernel: [drm] Loading RV630 CP Microcode
kernel: [drm] Loading RV630 PFP Microcode
kernel: DMAR:[DMA Write] Request device [60:00.0] fault addr ffefe000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] Resetting GPU
kernel: DMAR:[DMA Write] Request device [60:00.0] fault addr ffefe000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] writeback test failed 0 deadbeef
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003
kernel: DMAR:[DMA Read] Request device [60:00.0] fault addr f000 
kernel: DMAR:[fault reason 01] Present bit in root entry is clear
kernel: [drm] wait idle failed status : 0xA0003030 0x0003

The complete kern.log and Xorg.0.log are available at:
   http://chdir.org/~nbareil/r600_accel_bug/

Thank you!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--

[Bug 20751] 2D acceleration on R6xx freezes my computer

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20751





--- Comment #1 from Alex Deucher ag...@yahoo.com  2009-03-19 08:34:12 PST ---
Any chance you could try the drm-next branch of Dave's drm tree?
http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=summary
The version in fdo git may be missing some 2.6.29 compatibility.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20751] 2D acceleration on R6xx freezes my computer

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20751





--- Comment #2 from Nicolas Bareil n...@chdir.org  2009-03-19 09:12:55 PST ---
(In reply to comment #1)
 Any chance you could try the drm-next branch of Dave's drm tree?
 http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=summary
 The version in fdo git may be missing some 2.6.29 compatibility.
 

Using origin/drm-next (commit 41f13fe81dd1b08723ab9f3fc3c7f29cfa81f1a5 from
you), 
I have the same result, sorry :(


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Sindhudweep Sarkar
This might be the opinion of a completely non educated end user but it
seems that an intel specific drm and other bits (xorg, mesa) would be
somewhat of a maintenance waste.

TI-OMAP 3xxx and a couple of other arm processors use similar SGX-5xx
graphics cores. IIRC arm is often little endian so perhaps a unified
driver would be easier in the long term.

On Thu, Mar 19, 2009 at 12:08 AM, Greg KH g...@kroah.com wrote:
 Hi,

 Here's 5 patches that add the Intel Poulsbo/Morrestown DRM driver to the
 kernel tree.

 There are 4 patches that make changes to the DRM core, and one patch
 that adds the DRM driver itself.  The driver is added to the
 drivers/staging/ directory because it is not the final driver that
 Intel wishes to support over time.  The userspace api is going to
 change, and work is currently underway to hook up properly with the
 memory management system.

 However this work is going to take a while, and in the meantime, users
 want to run Linux on this kind of hardware.  I'd really like to add the
 driver to the staging tree, but it needs these core DRM changes in order
 to get it to work properly.

 Originally I had a patch that basically duplicated the existing DRM
 core, and embedded it with these changes and the PSB driver together
 into one big mess of a kernel module.  But Richard convinced me that
 this wasn't the nicest thing to do, and he did work on the PSB code
 and dug out these older DRM patches.

 The only thing that looks a bit odd to me is the unlocked ioctl patch,
 Thomas, is that thing really correct?

 David, I'd be glad to take the DRM changes through the staging tree, but
 only if you ack them.

 thanks,

 greg k-h
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


DG41TY not supported by i915 driver

2009-03-19 Thread Simeon Walker
Hi,

Back in November Zhenyu Wang posted a patch adding 2 PCI ID's for the
G41 chipset to the i915 driver. 

http://marc.info/?l=dri-develm=122690362516074w=4

As far as I can see only one of those ID's (0x2E22) was committed, he
other (0x2E32) was not. I can't find any further reference to this PCI
ID. Am I missing something?

Simeon



-- 
Gall y neges e-bost hon, ac unrhyw atodiadau a anfonwyd gyda hi,
gynnwys deunydd cyfrinachol ac wedi eu bwriadu i'w defnyddio'n unig
gan y sawl y cawsant eu cyfeirio ato (atynt). Os ydych wedi derbyn y
neges e-bost hon trwy gamgymeriad, rhowch wybod i'r anfonwr ar
unwaith a dilëwch y neges. Os na fwriadwyd anfon y neges atoch chi,
rhaid i chi beidio â defnyddio, cadw neu ddatgelu unrhyw wybodaeth a
gynhwysir ynddi. Mae unrhyw farn neu safbwynt yn eiddo i'r sawl a'i
hanfonodd yn unig  ac nid yw o anghenraid yn cynrychioli barn
Prifysgol Bangor. Nid yw Prifysgol Bangor yn gwarantu
bod y neges e-bost hon neu unrhyw atodiadau yn rhydd rhag firysau neu
100% yn ddiogel. Oni bai fod hyn wedi ei ddatgan yn uniongyrchol yn
nhestun yr e-bost, nid bwriad y neges e-bost hon yw ffurfio contract
rhwymol - mae rhestr o lofnodwyr awdurdodedig ar gael o Swyddfa
Cyllid Prifysgol Bangor.  www.bangor.ac.uk

This email and any attachments may contain confidential material and
is solely for the use of the intended recipient(s).  If you have
received this email in error, please notify the sender immediately
and delete this email.  If you are not the intended recipient(s), you
must not use, retain or disclose any information contained in this
email.  Any views or opinions are solely those of the sender and do
not necessarily represent those of the Bangor University.
Bangor University does not guarantee that this email or
any attachments are free from viruses or 100% secure.  Unless
expressly stated in the body of the text of the email, this email is
not intended to form a binding contract - a list of authorised
signatories is available from the Bangor University Finance
Office.  www.bangor.ac.uk


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Greg KH
On Thu, Mar 19, 2009 at 12:03:09PM -0400, Sindhudweep Sarkar wrote:
 This might be the opinion of a completely non educated end user but it
 seems that an intel specific drm and other bits (xorg, mesa) would be
 somewhat of a maintenance waste.

What do you mean by this?

 TI-OMAP 3xxx and a couple of other arm processors use similar SGX-5xx
 graphics cores. IIRC arm is often little endian so perhaps a unified
 driver would be easier in the long term.

Long term lots of things are good.

But how do I get my laptop that I currently have right now up and
running properly with linux in a better-than-800x600-framebuffer mode?

That's why I need/want this driver now, there are hundreds of thousands
of these types of laptops in the pipeline to users and I want them to
run Linux, not be forced to run some other operating system...

thanks,

greg k-h

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 11980] GL_EXT_stencil_two_side breaks shadows in warzone2100 since 6.5 .3

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=11980


Maciej Cencora m.cenc...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #3 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 10:29:02 
PST ---
 7.3 from experimental doesn't work, but is older than a month. With
 MesaLib-7.5-devel-20090313.tar.gz the shadows work.

 To reproduce you will probably need version 2.2.x or smaller of Warzone
 (trunk segfaults in the driver here due to some VBO stuff, on a X800 GTO).

 Best regards,
 Christian Ohm

Closing as fixed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Richard Purdie

On Thu, 2009-03-19 at 12:03 -0400, Sindhudweep Sarkar wrote:
 This might be the opinion of a completely non educated end user but it
 seems that an intel specific drm and other bits (xorg, mesa) would be
 somewhat of a maintenance waste.
 
 TI-OMAP 3xxx and a couple of other arm processors use similar SGX-5xx
 graphics cores. IIRC arm is often little endian so perhaps a unified
 driver would be easier in the long term.

Long term a unified driver would be very nice to have and nobody
disagrees with that. Things don't happen overnight and you have to take
smaller steps to get there. This proposal is one step on a road that may
lead to a driver for the TI part too. It will need someone in the ARM
community to step up and write the ARM specific bits.

Cheers,

Richard


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Sindhudweep Sarkar
Of course real support for poulsbo is really important and desirable
since netbooks make such a huge percentage of computer sales these
days. I'm guessing, however, that the number of
embedded/mobile/appliance devices that use or will use the SGX5xx is
much larger than even the plethora of netbooks being pumped out. If
more hardware support can be gained for a little extra burden why not
go for it? I would argue that a unified driver stack would actually
have less maintenance cost since common bugs could be killed. Even
ignoring all the arm devices that will use that graphics core, what
about intel's own use of the SGX 535 elsewhere? Does this poulsbo
driver support the intel CE3100 processors?


I think i'm really apprehensive about device specific one-offs. Of
course a mainline driver upstream is an important step to prevent that
but without a roadmap it only seems marginally better.

Best,
Sindhudweep

On Thu, Mar 19, 2009 at 12:27 PM, Greg KH g...@kroah.com wrote:
 On Thu, Mar 19, 2009 at 12:03:09PM -0400, Sindhudweep Sarkar wrote:
 This might be the opinion of a completely non educated end user but it
 seems that an intel specific drm and other bits (xorg, mesa) would be
 somewhat of a maintenance waste.

 What do you mean by this?

 TI-OMAP 3xxx and a couple of other arm processors use similar SGX-5xx
 graphics cores. IIRC arm is often little endian so perhaps a unified
 driver would be easier in the long term.

 Long term lots of things are good.

 But how do I get my laptop that I currently have right now up and
 running properly with linux in a better-than-800x600-framebuffer mode?

 That's why I need/want this driver now, there are hundreds of thousands
 of these types of laptops in the pipeline to users and I want them to
 run Linux, not be forced to run some other operating system...

 thanks,

 greg k-h


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Greg KH
On Thu, Mar 19, 2009 at 07:05:30PM +, Matthew Garrett wrote:
 On Thu, Mar 19, 2009 at 12:02:54PM -0700, Greg KH wrote:
  On Thu, Mar 19, 2009 at 06:53:38PM +, Matthew Garrett wrote:
   On Thu, Mar 19, 2009 at 09:27:19AM -0700, Greg KH wrote:
   
But how do I get my laptop that I currently have right now up and
running properly with linux in a better-than-800x600-framebuffer mode?
   
   You don't, because there's no working X driver.
  
  Um, no, I have one right here, seems to work ok.  Richard pointed out
  the public git tree for it.
 
 With current X? If that's been fixed up recently then it's a definite 
 improvement, but last I checked it only built against old X servers.

It currently only builds with new X servers, which turned out to be a
problem trying to get it to work on an openSUSE 11.1 machine, which uses
an older xserver, but that's a distro issue, not an upstream issue...

thanks,

greg k-h

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Greg KH
On Thu, Mar 19, 2009 at 06:53:38PM +, Matthew Garrett wrote:
 On Thu, Mar 19, 2009 at 09:27:19AM -0700, Greg KH wrote:
 
  But how do I get my laptop that I currently have right now up and
  running properly with linux in a better-than-800x600-framebuffer mode?
 
 You don't, because there's no working X driver.

Um, no, I have one right here, seems to work ok.  Richard pointed out
the public git tree for it.

Yes, there's no excellerated 3d without the binary xorg blob, but I
really don't need that right now.

thanks,

greg k-h

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Corbin Simpson
Richard Purdie wrote:
 On Thu, 2009-03-19 at 12:03 -0400, Sindhudweep Sarkar wrote:
 This might be the opinion of a completely non educated end user but it
 seems that an intel specific drm and other bits (xorg, mesa) would be
 somewhat of a maintenance waste.

 TI-OMAP 3xxx and a couple of other arm processors use similar SGX-5xx
 graphics cores. IIRC arm is often little endian so perhaps a unified
 driver would be easier in the long term.
 
 Long term a unified driver would be very nice to have and nobody
 disagrees with that. Things don't happen overnight and you have to take
 smaller steps to get there. This proposal is one step on a road that may
 lead to a driver for the TI part too. It will need someone in the ARM
 community to step up and write the ARM specific bits.

Nokia's written and open-sourced some related code for DRM.

My university is paying me to work on an ARM-based SoC handheld with an
SGX core, and I might be more into this later. (Y'know, once the device
is actually out the door.)

~ C.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [patch 0/5] Intel Poulsbo/Morrestown DRM driver and DRM core changes

2009-03-19 Thread Thomas Hellström
Greg KH wrote:
 On Thu, Mar 19, 2009 at 11:14:35AM +0100, Thomas Hellström wrote:
   
 First off, the non-staging patches need more complete changelog entries,
 a bit of meaning goes a long way. I'll ack them if they are documented and
 make sense. The unlocked ioctl hook makes sense to me at least!
   
   
 For the non-staging patches, (which also sit in the modesetting-newttm 
 tree), I can add some more elaborate comments. However I think all of
 them are targeted to support functionality for TTM, so unless the TTM
 code goes into staging or mainstream, there is little point in merging
 them to core drm before other drivers find them useful.

 Although I see the patch adding TTM is including some backwards
 compatibility defines (In particular the PAT compat stuff) that needs
 to be stripped.
 

 Great, care to respin it and send it to me?

 thanks,

 greg k-h
   
Greg,
A clean TTM patch was sent to Intel with the other patches.
I'm not sure why it got lost along the way?

/Thomas





--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20697] xorg 1.6 caught a signal 11 when dri is enabled

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20697





--- Comment #4 from Jimmy Jazz jimmy.j...@gmx.net  2009-03-19 13:53:53 PST ---
(In reply to comment #3)
 Do you have old fglrx libs still lying around?  Make sure to fully uninstall 
 it
 before using the open source drivers.
 
No, I really checked twice before reporting. I'm more open source friendly.
Also I tried for a while to get the closed source working but without success.
:)

I have just found a non existent link to
//usr/lib32/opengl/ati/extensions/libdri.so 
and
strings /usr/lib64/xorg/modules/extensions/libdri.so | grep -i fglrx
DRIScreenInit for fglrx driver

but that's all.

I will check it again.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20537] piglit failures on ATI Mobility M6

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20537





--- Comment #1 from Maciej Cencora m.cenc...@gmail.com  2009-03-19 14:20:47 
PST ---
All the 'Assertion `exec-ctx-Driver.NeedFlush  0x2`' errors are fixed in
current git. Could you also run piglit against mesa/radeon-rewrite branch?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20697] xorg 1.6 caught a signal 11 when dri is enabled

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20697





--- Comment #5 from Jimmy Jazz jimmy.j...@gmx.net  2009-03-19 15:05:27 PST ---
(In reply to comment #3)

This time the culprit wasn't the closed source ati libs... 

In gentoo, /usr/lib64/xorg/modules/extensions/libdri.so is a link to
/usr/lib64/opengl/xorg-x11/extensions/libdri.so. That ease the switching
between the closed and the open sources with the eselect tool. 
Also when I upgraded xorg-server to 1.6.0 or to the git sources with emerge
tool  the real libdri.so file was never deleted and replaced with the new
library. 

The lesson is, always perform a ls -l and take time to check the creation date
and the type of the object.

Reinstalling the server after removing
/usr/lib64/xorg/modules/extensions/libdri.so as well as
/usr/lib64/opengl/xorg-x11/extensions/libdri.so has done it.

Little report,
glgears reports 400FPS, EXA is smooth enough during scrolling but compiz 8.2
gives me a stupid white screen.
Also AIGLX still complains about a missing /usr/lib64/dri/r600_dri.so file.
Probably due to the fact that it is not r6xx or r7xx ready right now.

Thanks for the hint 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20697] xorg 1.6 caught a signal 11 when dri is enabled

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20697





--- Comment #6 from Jimmy Jazz jimmy.j...@gmx.net  2009-03-19 15:06:44 PST ---
Created an attachment (id=24053)
 -- (http://bugs.freedesktop.org/attachment.cgi?id=24053)
Xorg log with better results


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20697] xorg 1.6 caught a signal 11 when dri is enabled

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20697


Jimmy Jazz jimmy.j...@gmx.net changed:

   What|Removed |Added

  Attachment #23927|0   |1
is obsolete||




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 20697] xorg 1.6 caught a signal 11 when dri is enabled

2009-03-19 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=20697


Alex Deucher ag...@yahoo.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||NOTABUG




--- Comment #7 from Alex Deucher ag...@yahoo.com  2009-03-19 15:48:51 PST ---
(In reply to comment #5)
 
 Little report,
 glgears reports 400FPS, EXA is smooth enough during scrolling but compiz 8.2
 gives me a stupid white screen.
 Also AIGLX still complains about a missing /usr/lib64/dri/r600_dri.so file.
 Probably due to the fact that it is not r6xx or r7xx ready right now.
 

GL will not be accelerated and compiz won't work yet since there is no 3D
driver yet for r6xx/r7xx chips.  We just have Xv and EXA support right now.

 Thanks for the hint 
 

No problem.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] radeon: add some new pci ids

2009-03-19 Thread Alex Deucher
http://www.botchco.com/alex/xorg/0001-radeon-add-some-new-pci-ids.patch

for drm-next

From 4e91d985755227efcdd6f3ddab90286c3a8ed492 Mon Sep 17 00:00:00 2001
From: Alex Deucher alexdeuc...@gmail.com
Date: Thu, 19 Mar 2009 20:38:04 -0400
Subject: [PATCH] radeon: add some new pci ids

Signed-off-by: Alex Deucher alexdeuc...@gmail.com
---
 include/drm/drm_pciids.h |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/drm/drm_pciids.h b/include/drm/drm_pciids.h
index c2fd3c5..ecb9761 100644
--- a/include/drm/drm_pciids.h
+++ b/include/drm/drm_pciids.h
@@ -354,6 +354,8 @@
{0x1002, 0x9612, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
{0x1002, 0x9613, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
{0x1002, 0x9614, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
+   {0x1002, 0x9615, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
+   {0x1002, 0x9616, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
{0, 0, 0}

 #define r128_PCI_IDS \
-- 
1.5.6.3

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: udpated KMS speed improvement patch

2009-03-19 Thread Jesse Barnes
Correcting mailing list, should be dri-devel, not drm-devel.  Comments
below.

On Tue, 17 Mar 2009 20:52:21 -0700
Arjan van de Ven ar...@infradead.org wrote:

 Latest version below; this is a consolidation of the EDID speed
 improvement and using the async infrastructure...
 ... comments welcome
 
 With this, the KMS time goes from 1.2 seconds to 0.14 seconds on my
 laptop.
 
 
 diff --git a/drivers/gpu/drm/drm_crtc_helper.c
 b/drivers/gpu/drm/drm_crtc_helper.c index 1c3a8c5..5950d1a 100644
 --- a/drivers/gpu/drm/drm_crtc_helper.c
 +++ b/drivers/gpu/drm/drm_crtc_helper.c
 @@ -29,6 +29,8 @@
   *  Jesse Barnes jesse.bar...@intel.com
   */
  
 +#include linux/async.h
 +
  #include drmP.h
  #include drm_crtc.h
  #include drm_crtc_helper.h
 @@ -137,6 +139,26 @@ int drm_helper_probe_connector_modes(struct
 drm_device *dev, uint32_t maxX, }
  EXPORT_SYMBOL(drm_helper_probe_connector_modes);
  
 +int drm_helper_probe_connector_modes_fast(struct drm_device *dev,
 uint32_t maxX,
 +   uint32_t maxY)
 +{
 + struct drm_connector *connector;
 + int count = 0;
 +
 + list_for_each_entry(connector,
 dev-mode_config.connector_list, head) {
 + count +=
 drm_helper_probe_single_connector_modes(connector,
 +
 maxX, maxY);
 + /*
 +  * If we found a 'good' connector, we stop probing
 futher.
 +  */
 + if (count  0)
 + break;
 + }
 +
 + return count;
 +}
 +EXPORT_SYMBOL(drm_helper_probe_connector_modes_fast);

Ok, this seems fine, though I might call it probe_one_connector or
similar, since we return after finding the first connector with mode.

  /**
   * drm_initial_config - setup a sane initial connector configuration
   * @dev: DRM device
 @@ -902,7 +942,7 @@ bool drm_helper_initial_config(struct drm_device
 *dev, bool can_grow) struct drm_connector *connector;
   int count = 0;
  
 - count = drm_helper_probe_connector_modes(dev,
 + count = drm_helper_probe_connector_modes_fast(dev,
dev-mode_config.max_width,
dev-mode_config.max_height);

This changes behavior a bit though; the idea behind the initial config
is to put the kernel console on as many displays as possible at boot
time, that way people won't miss important messages.  You might argue
that the primary display should be chosen by the low level driver
though; if so we could use that head as the one for kernel messages,
and still get the speedup.

 diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
 index a839a28..069b189 100644
 --- a/drivers/gpu/drm/drm_edid.c
 +++ b/drivers/gpu/drm/drm_edid.c
 @@ -588,20 +588,22 @@ static unsigned char *drm_ddc_read(struct
 i2c_adapter *adapter) {
   struct i2c_algo_bit_data *algo_data = adapter-algo_data;
   unsigned char *edid = NULL;
 + int divider = 5;
   int i, j;

Not sure about the DDC changes; we already have problems with not
getting data back on several displays, but I think that problem is
buried in the actual i2c code, not the delays in this routine.

 diff --git a/drivers/gpu/drm/i915/intel_display.c
 b/drivers/gpu/drm/i915/intel_display.c index a283427..4b88341 100644
 --- a/drivers/gpu/drm/i915/intel_display.c
 +++ b/drivers/gpu/drm/i915/intel_display.c
 @@ -319,7 +319,7 @@ void
  intel_wait_for_vblank(struct drm_device *dev)
  {
   /* Wait for 20ms, i.e. one cycle at 50hz. */
 - udelay(2);
 + mdelay(20);
  }

We could probably do this independently.  We'll generally be holding the
struct mutex here, but that should be ok.

  
  static int
 diff --git a/drivers/gpu/drm/i915/intel_drv.h
 b/drivers/gpu/drm/i915/intel_drv.h index 957daef..22a74bd 100644
 --- a/drivers/gpu/drm/i915/intel_drv.h
 +++ b/drivers/gpu/drm/i915/intel_drv.h
 @@ -81,6 +81,7 @@ struct intel_output {
   int type;
   struct intel_i2c_chan *i2c_bus; /* for control functions */
   struct intel_i2c_chan *ddc_bus; /* for DDC only stuff */
 + struct edid *edid;
   bool load_detect_temp;
   bool needs_tv_clock;
   void *dev_priv;
 diff --git a/drivers/gpu/drm/i915/intel_lvds.c
 b/drivers/gpu/drm/i915/intel_lvds.c index 0d211af..dc4fecc 100644
 --- a/drivers/gpu/drm/i915/intel_lvds.c
 +++ b/drivers/gpu/drm/i915/intel_lvds.c
 @@ -336,6 +336,7 @@ static void intel_lvds_destroy(struct
 drm_connector *connector) intel_i2c_destroy(intel_output-ddc_bus);
   drm_sysfs_connector_remove(connector);
   drm_connector_cleanup(connector);
 + kfree(intel_output-edid);
   kfree(connector);
  }
  
 @@ -516,5 +517,6 @@ failed:
   if (intel_output-ddc_bus)
   intel_i2c_destroy(intel_output-ddc_bus);
   drm_connector_cleanup(connector);
 + kfree(intel_output-edid);
   kfree(connector);
  }
 diff --git a/drivers/gpu/drm/i915/intel_modes.c
 b/drivers/gpu/drm/i915/intel_modes.c index e42019e..8c0d5f6 100644
 --- 

[Bug 11888] the screen remains black after resume

2009-03-19 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=11888


rui.zh...@intel.com changed:

   What|Removed |Added

  Component|Video(DRI)  |Bluetooth




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 11888] the screen remains black after resume

2009-03-19 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=11888


rui.zh...@intel.com changed:

   What|Removed |Added

  Component|Bluetooth   |Video(Other)




-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm: Use a little stash on the stack to avoid kmalloc in most DRM ioctls.

2009-03-19 Thread Eric Anholt
The kmalloc was taking up about 1.5% of the CPU on an ioctl-heavy workload
(x11perf -aa10text on 965).  Initial results look like they have a
corresponding improvement in performance for aa10text, but more numbers might
not hurt.

Thanks to ajax for pointing out this performance regression I'd introduced
back in 2007.
---
 drivers/gpu/drm/drm_drv.c |   15 ++-
 1 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 14c7a23..822d092 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -458,6 +458,7 @@ int drm_ioctl(struct inode *inode, struct file *filp,
drm_ioctl_t *func;
unsigned int nr = DRM_IOCTL_NR(cmd);
int retcode = -EINVAL;
+   char stack_kdata[128];
char *kdata = NULL;
 
atomic_inc(dev-ioctl_count);
@@ -496,10 +497,14 @@ int drm_ioctl(struct inode *inode, struct file *filp,
retcode = -EACCES;
} else {
if (cmd  (IOC_IN | IOC_OUT)) {
-   kdata = kmalloc(_IOC_SIZE(cmd), GFP_KERNEL);
-   if (!kdata) {
-   retcode = -ENOMEM;
-   goto err_i1;
+   if (_IOC_SIZE(cmd) = sizeof(stack_kdata)) {
+   kdata = stack_kdata;
+   } else {
+   kdata = kmalloc(_IOC_SIZE(cmd), GFP_KERNEL);
+   if (!kdata) {
+   retcode = -ENOMEM;
+   goto err_i1;
+   }
}
}
 
@@ -520,7 +525,7 @@ int drm_ioctl(struct inode *inode, struct file *filp,
}
 
   err_i1:
-   if (kdata)
+   if (kdata != stack_kdata)
kfree(kdata);
atomic_dec(dev-ioctl_count);
if (retcode)
-- 
1.6.2.1


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel