[PATCH] i915: Skip wrong TV outputs on HP laptop
A new HP laptop with GM45 seems detecting wrongly TV outputs
occasionally. Most of time it detects the TV output as disconnected,
but spontaneously it detects NTSC 480i although the laptop has no TV
output at all.
A simple (but ad hoc) fix is to add a DMI check as below.
Signed-off-by: Takashi Iwai ti...@suse.de
---
drivers/gpu/drm/i915/intel_tv.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 552ec11..e848a28 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -37,6 +37,7 @@
#include intel_drv.h
#include i915_drm.h
#include i915_drv.h
+#include linux/dmi.h
enum tv_margin {
TV_MARGIN_LEFT, TV_MARGIN_TOP,
@@ -1735,6 +1736,18 @@ static int tv_is_present_in_vbt(struct drm_device *dev)
return ret;
}
+static struct dmi_system_id intel_bad_tv[] = {
+ {
+ .ident = HP Compaq 420,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, Hewlett-Packard),
+ DMI_MATCH(DMI_PRODUCT_NAME, HP 420),
+ },
+ },
+
+ { } /* terminating entry */
+};
+
void
intel_tv_init(struct drm_device *dev)
{
@@ -1757,6 +1770,10 @@ intel_tv_init(struct drm_device *dev)
if (!dev_priv-int_tv_support)
return;
+ /* wrongly detected TV outputs */
+ if (dmi_check_system(intel_bad_tv))
+ return;
+
/*
* Sanity check the TV output by checking to see if the
* DAC register holds a value
--
1.7.0.4
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On 05:15 Tue 20 Apr , Rafael J. Wysocki wrote: If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. Please list these two similar regressions from 2.6.33 in the r600 DRM: * r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer: https://bugs.freedesktop.org/show_bug.cgi?id=27571 * r600 CS checker rejects narrow FBO renderbuffers: https://bugs.freedesktop.org/show_bug.cgi?id=27609 Thanks. -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] i915: Skip wrong TV outputs on HP laptop
At Tue, 20 Apr 2010 10:13:20 -0700, Eric Anholt wrote: On Tue, 20 Apr 2010 14:50:54 +0200, Takashi Iwai ti...@suse.de wrote: A new HP laptop with GM45 seems detecting wrongly TV outputs occasionally. Most of time it detects the TV output as disconnected, but spontaneously it detects NTSC 480i although the laptop has no TV output at all. A simple (but ad hoc) fix is to add a DMI check as below. Signed-off-by: Takashi Iwai ti...@suse.de Does this laptop have no TV connector on the laptop or the dock for it? No, it has neither TV connector nor docking-station. If any patch that can fix the wrong detection is available, I'll happily test it. thanks, Takashi -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] i915: Skip wrong TV outputs on HP laptop
On Wed, 2010-04-21 at 01:58 +0800, Takashi Iwai wrote: At Tue, 20 Apr 2010 10:13:20 -0700, Eric Anholt wrote: On Tue, 20 Apr 2010 14:50:54 +0200, Takashi Iwai ti...@suse.de wrote: A new HP laptop with GM45 seems detecting wrongly TV outputs occasionally. Most of time it detects the TV output as disconnected, but spontaneously it detects NTSC 480i although the laptop has no TV output at all. A simple (but ad hoc) fix is to add a DMI check as below. Signed-off-by: Takashi Iwai ti...@suse.de Does this laptop have no TV connector on the laptop or the dock for it? No, it has neither TV connector nor docking-station. If any patch that can fix the wrong detection is available, I'll happily test it. Oh. This laptop is also based on gm45. Maybe it has the similar issue wit the laptop on https://bugzilla.kernel.org/show_bug.cgi?id=14792. Will you please try the patch in hhttps://bugzilla.kernel.org/show_bug.cgi?id=14792#C24 and see whether the issue can be fixed? Thanks. Yakui thanks, Takashi -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On Wednesday 21 April 2010, Ben Gamari wrote: On Tue, 20 Apr 2010 05:15:57 +0200 (CEST), Rafael J. Wysocki r...@sisk.pl wrote: This message contains a list of some regressions from 2.6.33, for which there are no fixes in the mainline known to the tracking team. If any of them have been fixed already, please let us know. If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. I have recently reported this suspend regression on my Dell laptop hardware. References: http://lkml.org/lkml/2010/4/18/20 Bug-report: https://bugzilla.kernel.org/show_bug.cgi?id=15820 This has been added to the list now. Please check my comment in the Bugzilla entry. Rafael -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On Tuesday 20 April 2010, Nick Bowler wrote: On 05:15 Tue 20 Apr , Rafael J. Wysocki wrote: If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. Please list these two similar regressions from 2.6.33 in the r600 DRM: * r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer: https://bugs.freedesktop.org/show_bug.cgi?id=27571 * r600 CS checker rejects narrow FBO renderbuffers: https://bugs.freedesktop.org/show_bug.cgi?id=27609 Do you want to me to add them as one entry or as two separate bugs? Rafael -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
