Re: [PATCH] i915: Skip wrong TV outputs on HP laptop
At Wed, 21 Apr 2010 08:46:16 +0800, ykzhao wrote: On Wed, 2010-04-21 at 01:58 +0800, Takashi Iwai wrote: At Tue, 20 Apr 2010 10:13:20 -0700, Eric Anholt wrote: On Tue, 20 Apr 2010 14:50:54 +0200, Takashi Iwai ti...@suse.de wrote: A new HP laptop with GM45 seems detecting wrongly TV outputs occasionally. Most of time it detects the TV output as disconnected, but spontaneously it detects NTSC 480i although the laptop has no TV output at all. A simple (but ad hoc) fix is to add a DMI check as below. Signed-off-by: Takashi Iwai ti...@suse.de Does this laptop have no TV connector on the laptop or the dock for it? No, it has neither TV connector nor docking-station. If any patch that can fix the wrong detection is available, I'll happily test it. Oh. This laptop is also based on gm45. Maybe it has the similar issue wit the laptop on https://bugzilla.kernel.org/show_bug.cgi?id=14792. Yeah, it sounds pretty similar. Will you please try the patch in hhttps://bugzilla.kernel.org/show_bug.cgi?id=14792#C24 and see whether the issue can be fixed? OK, I'll give it a try later. Thanks! Takashi -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On Tue, 20 Apr 2010 05:15:57 +0200 (CEST), Rafael J. Wysocki r...@sisk.pl wrote: This message contains a list of some regressions from 2.6.33, for which there are no fixes in the mainline known to the tracking team. If any of them have been fixed already, please let us know. If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. I have recently reported this suspend regression on my Dell laptop hardware. References: http://lkml.org/lkml/2010/4/18/20 Bug-report: https://bugzilla.kernel.org/show_bug.cgi?id=15820 Thanks, - Ben -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] i915: Skip wrong TV outputs on HP laptop
On 2010.04.20 10:13:20 -0700, Eric Anholt wrote:
On Tue, 20 Apr 2010 14:50:54 +0200, Takashi Iwai ti...@suse.de wrote:
A new HP laptop with GM45 seems detecting wrongly TV outputs
occasionally. Most of time it detects the TV output as disconnected,
but spontaneously it detects NTSC 480i although the laptop has no TV
output at all.
A simple (but ad hoc) fix is to add a DMI check as below.
Signed-off-by: Takashi Iwai ti...@suse.de
Does this laptop have no TV connector on the laptop or the dock for it?
Maybe old TV quirks in UMS driver will also be helpful in case that
current BIOS check still fail.
This is from old UMS driver, but use pci subsys ids instead of dmi info
at that time.
From 60bc20124faee4db406b856e139959f8c082830d Mon Sep 17 00:00:00 2001
From: Zhenyu Wang zhen...@linux.intel.com
Date: Wed, 21 Apr 2010 15:53:51 +0800
Subject: [PATCH] drm/i915: TV quirks for laptop with no TV connector
This picks up TV connector quirks in original UMS driver,
to disable TV encoder on laptop with no physical TV port.
Signed-off-by: Zhenyu Wang zhen...@linux.intel.com
---
drivers/gpu/drm/i915/intel_tv.c | 69 +++
1 files changed, 69 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 081cb90..a96a14f 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1612,6 +1612,71 @@ static int tv_is_present_in_vbt(struct drm_device *dev)
return ret;
}
+struct intel_tv_quirk {
+ int pci_device;
+ int subsys_vendor;
+ int subsys_device;
+};
+
+struct intel_tv_quirk intel_tv_quirk_list[] = {
+ /* Clevo M720R has no tv output */
+ { 0x2a02, 0x1558, 0x0721 },
+ /* Dell Latitude X1 */
+ { 0x2592, 0x1028, 0x01a3 },
+ /* Dell Latitude X1 / D630 (LP: #197740) */
+ { 0x2592, 0x1028, 0x01f9 },
+ /* Dell XPS 1330 */
+ { 0x2a02, 0x1028, 0x0209 },
+ /* Dell Inspiron 1535 */
+ { 0x2a02, 0x1028, 0x0254 },
+ /* Dell Inspiron 1735 */
+ { 0x2a02, 0x1028, 0x0256 },
+ /* Dell Inspiron 1318 */
+ { 0x2a02, 0x1028, 0x0286 },
+ /* Dell Vostro A840 (LP: #235155) */
+ { 0x2a02, 0x1028, 0x0298 },
+ /* Lenovo 3000 v200 */
+ { 0x2a02, 0x17aa, 0x3c18 },
+ /* Panasonic Toughbook CF-Y4 has no TV output */
+ { 0x2592, 0x10f7, 0x8338 },
+ /* Panasonic Toughbook CF-Y7 has no TV output */
+ { 0x2a02, 0x10f7, 0x8338 },
+ /* Toshiba Satellite U300 has no TV output */
+ { 0x2a02, 0x1179, 0xff50 },
+ /* Samsung Q35 has no TV output */
+ { 0x27a2, 0x144d, 0xc504 },
+ /* Samsung Q45 has no TV output */
+ { 0x2a02, 0x144d, 0xc510 },
+ /* HP Compaq nx6110 has no TV output */
+ { 0x2592, 0x103c, 0x099c },
+ /* HP Compaq nx6310 has no TV output */
+ { 0x27a2, 0x103c, 0x30aa },
+ /* HP Compaq 6730s has no TV output */
+ { 0x2a42, 0x103c, 0x30e8 },
+ /* Ordi Enduro UW31 (See LP: #152416) */
+ { 0x27a2, 0x1584, 0x9900 },
+ /* Littlebit Sepia X35 (rebranded Asus Z37E) (See LP: #201257) */
+ { 0x2a02, 0x1043, 0x8265 },
+ /* end mark */
+ { 0, 0, 0 }
+};
+
+static bool
+intel_tv_check(struct drm_device *dev)
+{
+ struct pci_dev *pdev = dev-pdev;
+ struct intel_tv_quirk *q = intel_tv_quirk_list;
+
+ while (q q-pci_device) {
+ if (q-pci_device == dev-pci_device
+ q-subsys_vendor == pdev-subsystem_vendor
+ q-subsys_device == pdev-subsystem_device)
+ return true;
+ ++q;
+ }
+ return false;
+}
+
void
intel_tv_init(struct drm_device *dev)
{
@@ -1635,6 +1700,10 @@ intel_tv_init(struct drm_device *dev)
if (!dev_priv-int_tv_support)
return;
+ /* No real TV output quirks */
+ if (intel_tv_check(dev))
+ return;
+
/*
* Sanity check the TV output by checking to see if the
* DAC register holds a value
--
1.6.3.3
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signature.asc
Description: Digital signature
--
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On Wed, Apr 21, 2010 at 07:15:38AM +0200, Rafael J. Wysocki wrote: On Tuesday 20 April 2010, Nick Bowler wrote: On 05:15 Tue 20 Apr , Rafael J. Wysocki wrote: If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. Please list these two similar regressions from 2.6.33 in the r600 DRM: * r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer: https://bugs.freedesktop.org/show_bug.cgi?id=27571 * r600 CS checker rejects narrow FBO renderbuffers: https://bugs.freedesktop.org/show_bug.cgi?id=27609 Do you want to me to add them as one entry or as two separate bugs? Rafael First one is userspace bug, i need to look into the second one. ie we were lucky the hw didn't lockup without depth buffer and depth test enabled. Cheers, Jerome -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 15469] [Intel Graphics HD] Kernel panic on boot with certain BIOS options
https://bugzilla.kernel.org/show_bug.cgi?id=15469 Artem S. Tashkinov t.ar...@mailcity.com changed: What|Removed |Added CC||a...@linux-foundation.org --- Comment #3 from Artem S. Tashkinov t.ar...@mailcity.com 2010-04-21 09:59:42 --- Who else I should subscribe this bug to, so that it was noticed by kernel developers? I'm now manually transcribing those screenshots: EIP: 0060:[f845ff1b] EFLAGS: 00010206 CPU: 1 EIP us at drm_mm_search_free+0x6b/0x90 [drm] EAX: 2000 EBX: f6798de0 ECX: EDX: 1000 ESI: f76a86c0 EDI: f6d93300 EBP: f6739cec ESP: f6739cc4 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 ... Call Trace: [f87519ab] ? i915_gem_object_bind_to_gtt+0x6b/0x1e0 [i915] [f8751ba4] ? i915_gem_object_pin+0x84/0x90 [i915] [f8751c00] ? i915_gem_init_ringbuffer+0x50/0x460 [i915] [f845fe0e] ? drm_mm_create_tail_node+0x1e/0x70 [drm] ... Kernel 2.6.34-rc5 is also affected. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching someone on the CC list of the bug. -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] i915: Skip wrong TV outputs on HP laptop
At Wed, 21 Apr 2010 08:46:16 +0800, ykzhao wrote: On Wed, 2010-04-21 at 01:58 +0800, Takashi Iwai wrote: At Tue, 20 Apr 2010 10:13:20 -0700, Eric Anholt wrote: On Tue, 20 Apr 2010 14:50:54 +0200, Takashi Iwai ti...@suse.de wrote: A new HP laptop with GM45 seems detecting wrongly TV outputs occasionally. Most of time it detects the TV output as disconnected, but spontaneously it detects NTSC 480i although the laptop has no TV output at all. A simple (but ad hoc) fix is to add a DMI check as below. Signed-off-by: Takashi Iwai ti...@suse.de Does this laptop have no TV connector on the laptop or the dock for it? No, it has neither TV connector nor docking-station. If any patch that can fix the wrong detection is available, I'll happily test it. Oh. This laptop is also based on gm45. Maybe it has the similar issue wit the laptop on https://bugzilla.kernel.org/show_bug.cgi?id=14792. Will you please try the patch in hhttps://bugzilla.kernel.org/show_bug.cgi?id=14792#C24 and see whether the issue can be fixed? Looks positive. Rebooted many times, and no longer wrong detection. It'd be nice if this is merged to upstream, and also for stable kernel. Tested-by: Takashi Iwai ti...@suse.de Thanks! Takashi -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.34-rc5: Reported regressions from 2.6.33
On Wed, Apr 21, 2010 at 07:15:38AM +0200, Rafael J. Wysocki wrote: On Tuesday 20 April 2010, Nick Bowler wrote: Please list these two similar regressions from 2.6.33 in the r600 DRM: * r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer: https://bugs.freedesktop.org/show_bug.cgi?id=27571 * r600 CS checker rejects narrow FBO renderbuffers: https://bugs.freedesktop.org/show_bug.cgi?id=27609 Do you want to me to add them as one entry or as two separate bugs? As upstream doesn't consider the first to be a kernel issue, I guess you should just list the second. On 10:57 Wed 21 Apr , Jerome Glisse wrote: First one is userspace bug, i need to look into the second one. ie we were lucky the hw didn't lockup without depth buffer and depth test enabled. OK, if the failure is due to userspace is doing Very Bad Things(tm), catching that seems reasonable. Nevertheless, even if it happened by luck, the result was (ostensibly) working programs that suddenly break once one upgrades to the latest kernel. If userspace can't be fixed before 2.6.34 is released, perhaps a less cryptic log message would be appropriate? -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
