Re: [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode
On 11/20/2009 10:01 PM, James Simmons wrote: Paulius Zaleckas wrote: On drivers using drm_fb_helper's in fb_ops it is not possible to change video mode, because of different var-pixclock evaluation: ... patch: http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg44369.html Those patches will enable fbdev apps to run properly. More patches are needed if you want to support mode switching using the fbdev emulation layer. I noticed my patches and yours where lost. Who do you send patches too that can merge them ? y:/usr/src/git26 perl scripts/get_maintainer.pl -f drivers/gpu/drm/drm_fb_helper.c David Airlieairl...@linux.ie Dave Airlieairl...@redhat.com Jesse Barnesjbar...@virtuousgeek.org Mikael Petterssonmi...@it.uu.se dri-devel@lists.sourceforge.net linux-ker...@vger.kernel.org That's accurate enough. Generally, if nothing has happened in a week, the chances that it's lost are very high. Resend. If you like, cc me and I'll maintain the patches and resend them for you. You can add Tested-by: Paulius Zaleckaspaulius.zalec...@gmail.com for http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg44369.html as this was preventing DirectFB from running on my Asus Eee PC 701. I tested it as well with the both my 3Dfx driver that I wrote with KMS and the nouveau driver. We just need to make sure that the patches end up in the drm-next tree or these patches will be lost when drm-next gets merged to linus tree. IMHO this patch should end up in current (2.6.32) kernel and we should send it to stable ML. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Linux-fbdev-devel] drm_fb_helper: Impossible to change video mode
On 11/20/2009 09:05 PM, Andrew Morton wrote: On Fri, 20 Nov 2009 18:53:37 + (GMT) James Simmonsjsimm...@infradead.org wrote: Paulius Zaleckas wrote: On drivers using drm_fb_helper's in fb_ops it is not possible to change video mode, because of different var-pixclock evaluation: ... patch: http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg44369.html Those patches will enable fbdev apps to run properly. More patches are needed if you want to support mode switching using the fbdev emulation layer. I noticed my patches and yours where lost. Who do you send patches too that can merge them ? y:/usr/src/git26 perl scripts/get_maintainer.pl -f drivers/gpu/drm/drm_fb_helper.c David Airlieairl...@linux.ie Dave Airlieairl...@redhat.com Jesse Barnesjbar...@virtuousgeek.org Mikael Petterssonmi...@it.uu.se dri-devel@lists.sourceforge.net linux-ker...@vger.kernel.org That's accurate enough. Generally, if nothing has happened in a week, the chances that it's lost are very high. Resend. If you like, cc me and I'll maintain the patches and resend them for you. You can add Tested-by: Paulius Zaleckas paulius.zalec...@gmail.com for http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg44369.html as this was preventing DirectFB from running on my Asus Eee PC 701. While at this patch maybe you should fix that spelling issue as well. cheers, lkml resendbot. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
drm_fb_helper: Impossible to change video mode
Hi,
On drivers using drm_fb_helper's in fb_ops it is not possible to change
video mode, because of different var-pixclock evaluation:
int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
struct fb_info *info)
{
[...]
if (var-pixclock == -1 || !var-pixclock)
return -EINVAL;
[...]
int drm_fb_helper_set_par(struct fb_info *info)
{
[...]
if (var-pixclock != -1) {
DRM_ERROR(PIXEL CLCOK SET\n);
return -EINVAL;
}
[...]
One of these evaluations will fail regardless of pixclock value.
P.S. check CLCOK spelling :)
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
