Re: [Intel-gfx] [PATCH 08/17] drm/i915: add per-output hotplug callback

[Keith Packard]

On Fri, 2009-06-05 at 13:15 +, Eric Anholt wrote:

> s-o-b?  also, a weird cherry-pick message here.

operator error.

> Seems like #10 was "Import DisplayPort" code and this is something
else?

Yeah, I've gone ahead and just merged all of the 'add display port' into
one giant patch.

> No // comments in kernel code.

Removed.

> gratuitous move of code in this commit?

Un-moved.

> The commmit doesn't seem to match the commit message here.

Actually, it does, in that the patch doesn't actually work, and that a
'real' fix would involve re-setting the current mode instead of
attempting to save/restore simple register contents. I've just removed
this patch from the series; it doesn't work, and it isn't even moving in
the right direction.

> Looks like this should be squashed into #14 that uses it?

Squashed.

(new patch series coming shortly)

-- 
keith.pack...@intel.com


signature.asc
Description: This is a digitally signed message part
--
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 08/17] drm/i915: add per-output hotplug callback

[Eric Anholt]

On Sat, 2009-05-30 at 20:42 -0700, Keith Packard wrote:
> This allows each output to deal with plug/unplug events as needed
> (cherry picked from commit 08d57f21d1042153ebc26465be85d7e166008a14)

s-o-b?  also, a weird cherry-pick message here.

> ---
>  drivers/gpu/drm/i915/i915_irq.c  |8 
>  drivers/gpu/drm/i915/intel_drv.h |1 +
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 98bb4c8..43745ff 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -191,7 +191,15 @@ static void i915_hotplug_work_func(struct work_struct 
> *work)
>   drm_i915_private_t *dev_priv = container_of(work, drm_i915_private_t,
>   hotplug_work);
>   struct drm_device *dev = dev_priv->dev;
> + struct drm_mode_config *mode_config = &dev->mode_config;
> + struct drm_connector *connector;
>  
> + list_for_each_entry(connector, &mode_config->connector_list, head) {
> + struct intel_output *intel_output = to_intel_output(connector);
> +
> + if (intel_output->hot_plug)
> + (*intel_output->hot_plug) (intel_output);
> + }
>   /* Just fire off a uevent and let userspace tell us what to do */
>   drm_sysfs_hotplug_event(dev);
>  }
> diff --git a/drivers/gpu/drm/i915/intel_drv.h 
> b/drivers/gpu/drm/i915/intel_drv.h
> index d89a2fe..c585879 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -83,6 +83,7 @@ struct intel_output {
>   bool load_detect_temp;
>   bool needs_tv_clock;
>   void *dev_priv;
> + void (*hot_plug)(struct intel_output *);
>  };
>  
>  struct intel_crtc {
-- 
Eric Anholt
e...@anholt.net eric.anh...@intel.com




signature.asc
Description: This is a digitally signed message part
--
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel